| *** prometheanfire is now known as Guest844 | 05:52 | |
| *** Guest844 is now known as prometheanfire | 05:56 | |
| gibi | bauzas: I agree not to mentione anything about placement in the higlights | 08:04 |
|---|---|---|
| gibi | gmann: thanks for https://review.opendev.org/c/openstack/nova/+/831244 ! bauzas I let you +W it as we are close to RC time | 08:06 |
| bauzas | gibi: done | 08:14 |
| gibi | bauzas: thanks | 08:14 |
| gibi | I'm also +1 on the cycle higlights | 08:14 |
| bauzas | thanks | 08:48 |
| opendevreview | Merged openstack/nova master: Fix unit test for oslo.context 4.1.0 https://review.opendev.org/c/openstack/nova/+/831244 | 08:54 |
| bauzas | sean-k-mooney: gibi: are we happy with releasing os-vif, osc-placement and python-novaclient ? there is still https://review.opendev.org/c/openstack/osc-placement/+/828545 open | 10:03 |
| bauzas | I'm on this client change btw. | 10:03 |
| gibi | bauzas: I'm OK, not to include the 1.39 osc-placement support in Yoga. | 10:03 |
| bauzas | as you wish | 10:03 |
| gibi | the API is moslty ment for machine consumptioon | 10:03 |
| bauzas | you'll probably have one +2 in 1 hour | 10:03 |
| gibi | so we can take that easy | 10:03 |
| *** mgoddard- is now known as mgoddard | 10:04 | |
| * bauzas looks at the open changes for the libs | 10:04 | |
| gibi | I have nothing for os-vif or the novaclient either | 10:04 |
| bauzas | yeah | 10:07 |
| gibi | bauzas: btw, if there is any patch that needs attention just link it to me | 10:09 |
| bauzas | gibi: I'm just wrapping the yoga paperwork | 10:09 |
| gibi | I know the feeling :) | 10:09 |
| bauzas | I'm just afraid of having missed some stuff | 10:11 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: mention the cycle highlights in the ptl guide https://review.opendev.org/c/openstack/nova/+/831353 | 10:11 |
| bauzas | gibi: sean-k-mooney: easy peasy ^ | 10:11 |
| gibi | on it | 10:12 |
| opendevreview | Pierre Libeau proposed openstack/nova master: Move file system freeze after end of mirroring https://review.opendev.org/c/openstack/nova/+/803713 | 10:25 |
| sean-k-mooney | bauzas: we likely dont need an os-vif release | 11:01 |
| sean-k-mooney | ill chekc but i dont think we merged anything since the last one | 11:01 |
| sean-k-mooney | bauzas: ya there is nothing https://github.com/openstack/os-vif/compare/2.7.1...master | 11:02 |
| sean-k-mooney | bauzas: the latest version of the release highlights looks good to me | 11:05 |
| sean-k-mooney | bauzas: for osc and nova client https://review.opendev.org/c/openstack/releases/+/830249 https://review.opendev.org/c/openstack/releases/+/830227 the final release where approved and released allready | 11:07 |
| sean-k-mooney | the client lib freeze happens at m3 | 11:07 |
| sean-k-mooney | well freeze and release | 11:07 |
| *** bhagyashris is now known as bhagyashris|ruck | 11:30 | |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 11:42 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 11:42 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 11:42 |
| sean-k-mooney | gibi: care to re review https://review.opendev.org/c/openstack/nova/+/803713 | 12:25 |
| sean-k-mooney | they added a comment regarding the freeze | 12:25 |
| gibi | yepp on my list for today | 12:26 |
| sean-k-mooney | im not sure if it had the detail you wanted but at least it now exitss | 12:26 |
| sean-k-mooney | cool | 12:26 |
| opendevreview | Merged openstack/nova master: mention the cycle highlights in the ptl guide https://review.opendev.org/c/openstack/nova/+/831353 | 12:33 |
| opendevreview | Fabian Wiesel proposed openstack/nova master: Transport context to all threads https://review.opendev.org/c/openstack/nova/+/827467 | 12:53 |
| bauzas | hmpf, got a network glitch | 13:42 |
| bauzas | cores, we have a couple of follow-ups from 3 merged blueprints | 14:29 |
| bauzas | we need a second +2/+W for https://review.opendev.org/c/openstack/nova/+/830817 and https://review.opendev.org/c/openstack/nova/+/828372 | 14:30 |
| bauzas | gibi: sean-k-mooney: gmann: melwitt: ^ | 14:30 |
| bauzas | also, | 14:30 |
| * gibi is on a call but after that will look at the follow ups | 14:31 | |
| bauzas | melwitt: we have unified limits still having 2 open patches | 14:31 |
| sean-k-mooney | bauzas: im ah lightos driver and zuul job for emulation | 14:31 |
| sean-k-mooney | ya those are on my radar | 14:31 |
| bauzas | ++ | 14:31 |
| bauzas | sean-k-mooney: can I +W https://review.opendev.org/c/openstack/nova/+/789963/31 ? | 14:32 |
| opendevreview | Fabian Wiesel proposed openstack/nova master: Transport context to all threads https://review.opendev.org/c/openstack/nova/+/827467 | 14:41 |
| bauzas | reminder: nova meeting in 45 mins here at #openstack-nova | 15:16 |
| bauzas | will be juicy about the release :) | 15:17 |
| gibi | I've approved https://review.opendev.org/c/openstack/nova/+/830817 and https://review.opendev.org/c/openstack/nova/+/828372 | 15:28 |
| gibi | I'm super happy that we have a green nova-emulation tempest job | 15:28 |
| sean-k-mooney | yep me too | 15:29 |
| gibi | sean-k-mooney: I've also approve the fs freeze bugfix | 15:30 |
| sean-k-mooney | ack | 15:31 |
| gibi | I think we have a pretty nice yoga release :) | 15:31 |
| sean-k-mooney | unifed limits, emulation, dpu support, all nice to have feautres | 15:32 |
| elodilles | bauzas: are you updating the nova meeting page right now? | 15:39 |
| bauzas | elodilles: nope, I'm done | 15:46 |
| bauzas | elodilles: oh I forgot to modify the dates | 15:46 |
| elodilles | bauzas: if you are done then I'll update stable section | 15:48 |
| elodilles | (i saw that you updated the dates, so i've updated stable section o:)) | 15:53 |
| bauzas | elodilles: yup | 15:55 |
| bauzas | do it | 15:55 |
| bauzas | reminder : nova meeting in 5 mins | 15:55 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Mar 1 16:00:01 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| bauzas | hello everyone | 16:00 |
| yuval | hey | 16:00 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:00 |
| elodilles | o/ | 16:00 |
| gmann | o/ | 16:00 |
| gibi | \o | 16:01 |
| bauzas | ok let's start, people will join | 16:01 |
| bauzas | #topic Bugs (stuck/critical) | 16:01 |
| bauzas | #info No Critical bug | 16:01 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 28 new untriaged bugs (+1 since the last meeting) | 16:02 |
| bauzas | #help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage | 16:02 |
| bauzas | #link https://storyboard.openstack.org/#!/project/openstack/placement 26 open stories (-1 since the last meeting) in Storyboard for Placement | 16:02 |
| bauzas | we're entering the RC period, which is always a good time for looking at open bugs :) | 16:02 |
| * bauzas will do this week | 16:02 | |
| bauzas | any bug people want to discuss ? | 16:02 |
| bauzas | (I'll explain the difference between RC1 and other RCs later in the meeting) | 16:03 |
| bauzas | looks not | 16:03 |
| bauzas | I take your silence as a no :) | 16:03 |
| bauzas | #topic Gate status | 16:03 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:04 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status | 16:04 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:04 |
| bauzas | nothing to mention here, we don't have new failure bugs AFAICS | 16:04 |
| bauzas | again, any gate issue people want to discuss ? | 16:05 |
| gibi | - | 16:05 |
| sean-k-mooney | nope | 16:06 |
| bauzas | k | 16:06 |
| *** hemna8 is now known as hemna | 16:07 | |
| bauzas | next huge topic | 16:07 |
| bauzas | #topic Release Planning | 16:07 |
| bauzas | #link https://releases.openstack.org/yoga/schedule.html#y-ff FeatureFreeze happened last Thursday Feb 24th | 16:07 |
| bauzas | #link https://etherpad.opendev.org/p/nova-yoga-blueprint-status Etherpad for blueprints tracking | 16:07 |
| bauzas | I updated it | 16:07 |
| bauzas | we have a few follow-ups for impemented blueprints | 16:07 |
| bauzas | but they will be merged in the next days | 16:07 |
| bauzas | none of the changes are about providing a feature, they are just nits or CI changes | 16:08 |
| bauzas | that's why I said "Implemented" to all the merged blueprints | 16:08 |
| bauzas | #link https://blueprints.launchpad.net/nova/yoga | 16:08 |
| bauzas | #info 12 Nova blueprints and 1 Placement story successfully merged on Yoga, 12 were deferred to Zed | 16:08 |
| bauzas | I'll remove the series goal for the 12 deferred ones | 16:09 |
| bauzas | but at RC1 | 16:09 |
| gmann | 12 +1 is good number I think | 16:10 |
| bauzas | thanks btw. for folks that helped to review | 16:10 |
| bauzas | gmann: indeed, about 50% of the accepted blueprints | 16:10 |
| bauzas | and 50% of the deferred ones were because nobody was working on them | 16:10 |
| bauzas | again, thanks folks | 16:11 |
| bauzas | and also, thanks contributors that continued to discuss with us and provided new revisions when it was needed :) | 16:11 |
| gibi | ++ | 16:12 |
| bauzas | I take it as a good cycle | 16:12 |
| gibi | it was a good one | 16:12 |
| bauzas | hopefully the better we are, the larger contributors we'll have :) | 16:12 |
| bauzas | anyway, now, yoga-3 is released | 16:13 |
| bauzas | now, it's time to work on RC1 | 16:13 |
| bauzas | #link https://releases.openstack.org/yoga/schedule.html#y-rc1 RC1 is now due on March 10th | 16:13 |
| bauzas | which is in less than 2 weeks | 16:13 |
| bauzas | for tracking, I created the usual etherpad | 16:14 |
| bauzas | #link https://etherpad.opendev.org/p/nova-yoga-rc-potential Etherpad for RC tracking | 16:14 |
| bauzas | please open it | 16:14 |
| bauzas | you'll see that we already merged the RPC and the API version changes | 16:15 |
| bauzas | now, we need someone to work on the reno prelude | 16:15 |
| bauzas | who wants to contribute for it ? ^ | 16:15 |
| bauzas | fwiw, this prelude should be quite the cycle highlights https://review.opendev.org/c/openstack/releases/+/831241 | 16:16 |
| bauzas | if nobody wants to do it, I can work on it | 16:16 |
| bauzas | that's not like I did it for most of the older cycles: p | 16:16 |
| bauzas | ok, I take it as "yes, please do" :p | 16:17 |
| sean-k-mooney | bauzas: do we have the standard bug tag created yet for rc potential | 16:17 |
| bauzas | sean-k-mooney: indeed, that was the next iteam | 16:17 |
| bauzas | item* | 16:17 |
| sean-k-mooney | ack | 16:17 |
| bauzas | we now have in the etherpad https://bugs.launchpad.net/nova/+bugs?field.tag=yoga-rc-potential | 16:17 |
| bauzas | #info please mark any important bug as a RC potential one by adding yoga-rc-potential tag to your bug report | 16:18 |
| bauzas | for the moment, we have none of them | 16:18 |
| bauzas | for RC1, any bug can be accepted | 16:19 |
| opendevreview | Merged openstack/nova master: Lightos driver release note https://review.opendev.org/c/openstack/nova/+/830817 | 16:19 |
| bauzas | after RC1, we'll only accept bugs that fix a regression | 16:19 |
| sean-k-mooney | i have one we may want to consider | 16:19 |
| bauzas | sean-k-mooney: sure | 16:19 |
| sean-k-mooney | we can talk about it in open discuss if you prefer | 16:19 |
| sean-k-mooney | or now https://review.opendev.org/c/openstack/nova/+/830966 bacially we disable eventlet monkey patching of dns | 16:20 |
| sean-k-mooney | because back on python 2.6/centos 6 it broke ipv6 | 16:21 |
| bauzas | we can discuss this now | 16:21 |
| sean-k-mooney | but apparently that can cause the api to hang since its a blocking call | 16:21 |
| sean-k-mooney | so im wondering do we want to revert the workaround | 16:21 |
| bauzas | OK, please mark the bug report as RC potential then | 16:22 |
| sean-k-mooney | if so i can file an upstream bug and refrence the downstream one | 16:22 |
| bauzas | yes, please | 16:22 |
| sean-k-mooney | ok ill do it after the meeting and we can decied later if we want to make that change now or next cycle and backport | 16:22 |
| bauzas | RC1 is always a good time for discussing about the bugs we know but we never have time to look at | 16:22 |
| gibi | how risky it is? | 16:23 |
| sean-k-mooney | ya https://bugs.launchpad.net/nova/+bug/1164822 is what the orginal patch was trying to fix | 16:23 |
| bauzas | (I'd personnally be in favor of a larger period in time for caring about bugs, but I also understand how quick it is to merge blueprints by 2.5 months) | 16:23 |
| sean-k-mooney | gibi: well you can get the same effect by exporting a env var | 16:23 |
| sean-k-mooney | so not really imo | 16:23 |
| gibi | then I'm OK | 16:23 |
| sean-k-mooney | sicne installer coudl always get the same behavior | 16:24 |
| gibi | with this bug being merged before RC1 | 16:24 |
| bauzas | let's mark it for now, and we'll revisit it off-topic during the week | 16:24 |
| gibi | ack | 16:24 |
| sean-k-mooney | ack | 16:24 |
| bauzas | I'll ping people on IRC that mark bugs as potential | 16:24 |
| bauzas | to see how important this is | 16:24 |
| bauzas | please stay close to your IRC client :) | 16:24 |
| bauzas | ok, I guess we're done with this topic | 16:25 |
| bauzas | I haven't mentioned the clients release but the patch is going | 16:26 |
| sean-k-mooney | the client shoudl already be done | 16:26 |
| sean-k-mooney | the final release of osc-placment and nova client is already done | 16:26 |
| bauzas | this is there https://review.opendev.org/c/openstack/releases/+/831293 | 16:27 |
| sean-k-mooney | that not doign a release | 16:28 |
| bauzas | we have a osc-placement patch for supporting the latest API microversion for any-traits, but gibi agreed on it not being needed for Yoga | 16:28 |
| sean-k-mooney | it just creating the branches | 16:28 |
| gibi | bauzas: yepp | 16:28 |
| elodilles | as sean-k-mooney says :] | 16:28 |
| bauzas | oh yeah | 16:28 |
| bauzas | correct | 16:28 |
| sean-k-mooney | but ya we shoudl also do that :) | 16:28 |
| sean-k-mooney | i.e. create the branches | 16:28 |
| bauzas | but we're branching on already delivered versions, right? | 16:28 |
| sean-k-mooney | yes | 16:29 |
| elodilles | releases were out last week | 16:29 |
| elodilles | yes | 16:29 |
| sean-k-mooney | which we released a few days ago | 16:29 |
| sean-k-mooney | on friday | 16:29 |
| bauzas | so we're good | 16:29 |
| sean-k-mooney | yes | 16:29 |
| bauzas | we're just branching, but releéases are already gone | 16:29 |
| elodilles | yepp :) | 16:29 |
| sean-k-mooney | yep elodilles pingged me and you on friday and i approved them a release leasion | 16:30 |
| sean-k-mooney | sicne you were busy | 16:30 |
| bauzas | great thanks then | 16:30 |
| bauzas | anyway, I guess we can move on then | 16:30 |
| bauzas | sean-k-mooney: appreciated, the beauty of delegating :) | 16:30 |
| gibi | :) | 16:31 |
| bauzas | ok, moving on, time flies | 16:31 |
| bauzas | #topic Review priorities | 16:31 |
| bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B1 | 16:31 |
| bauzas | I only marked the osc-placement patch | 16:31 |
| bauzas | I'd hold my vote until we branch | 16:31 |
| bauzas | but given nobody +2d/+Wd we're safe | 16:32 |
| bauzas | anything to add ? | 16:33 |
| gibi | - | 16:34 |
| bauzas | #topic Stable Branches | 16:34 |
| bauzas | elodilles: floor is yours | 16:34 |
| elodilles | #info queens and pike branches are blocked | 16:34 |
| elodilles | #info WA patch for stable/wallaby gate stability needs 2nd +2: https://review.opendev.org/830656 | 16:34 |
| elodilles | maybe this can have a prio ^^^ o:) | 16:34 |
| elodilles | because wallaby patches cannot really merge due to high failure rate | 16:35 |
| elodilles | #info stable/queens gate fix waiting for 2nd +2: https://review.opendev.org/830327 (needs to be backported to pike as well) | 16:35 |
| elodilles | we haven't done stable releases for a long time, release patches now proposed: https://review.opendev.org/q/project:openstack/releases+intopic:nova+is:open | 16:35 |
| bauzas | I've seen them | 16:35 |
| bauzas | I added them in the RC etherpad for making sure we don't forget them | 16:36 |
| elodilles | maybe this is a good time to release them, but let me know if we need to wait | 16:36 |
| elodilles | bauzas: ++ | 16:36 |
| bauzas | I don't see any reason to hold a stable release but I could be wrong, I need to look at the open patchs | 16:36 |
| bauzas | patches* even | 16:36 |
| bauzas | but yeah, we need other cores for the stable branches fixes :) | 16:37 |
| bauzas | just sayin' | 16:37 |
| * gibi still not have the power over stable :) | 16:37 | |
| opendevreview | Dan Smith proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 16:37 |
| opendevreview | Dan Smith proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 16:37 |
| opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 16:37 |
| dansmith | whoami-rajat: ^ | 16:37 |
| elodilles | if bug fixes are landing during FF and final RC and we backport some of them then we can do another round of stable release | 16:38 |
| elodilles | i think ^^^ | 16:38 |
| bauzas | dansmith: dude, we're in meeting, shhhttttt :p | 16:38 |
| bauzas | gibi: oh, that. | 16:38 |
| bauzas | gibi: could be fixable | 16:38 |
| gibi | ;) | 16:38 |
| elodilles | :) | 16:39 |
| * bauzas should write a new thread then | 16:39 | |
| dansmith | bauzas: apologies | 16:39 |
| bauzas | dansmith: heh no worries you're not the first and you won't be the last | 16:39 |
| bauzas | that's the drawback of in-channel meetings per se | 16:39 |
| bauzas | anyway | 16:39 |
| bauzas | nothing on stable, folks ? | 16:39 |
| bauzas | guess not | 16:40 |
| bauzas | #topic Open discussion | 16:40 |
| bauzas | this topic has nothing on the agenda | 16:40 |
| bauzas | any stuff someone wants to raise ? | 16:40 |
| bauzas | or shall I close it ? | 16:41 |
| sean-k-mooney | i have one thing for us to reflect on. os-vif is pretty stable at this point i wonder if it makes sense to move to release independet | 16:41 |
| bauzas | sean-k-mooney: interesting thoughts but I wonder if that would be more suitable at a PTG timing | 16:41 |
| bauzas | I'd be interested in hearing thoughts from the neutron team | 16:41 |
| sean-k-mooney | we dont need to make any decission now ya we can discuss at ptg | 16:41 |
| bauzas | tbc, release-independent doesn't prevent you to release at milestones | 16:42 |
| sean-k-mooney | correct | 16:42 |
| bauzas | it's just, you're free to do as you want | 16:42 |
| sean-k-mooney | it just remove the requiremetn to have at least one release a cycle | 16:42 |
| bauzas | sec | 16:42 |
| bauzas | verifying the requirements | 16:42 |
| sean-k-mooney | we tend to have enough to do 1 release a cycle but typically dont have a need to do more hten one | 16:43 |
| sean-k-mooney | which we can do with the current model too | 16:43 |
| elodilles | https://releases.openstack.org/reference/release_models.html#independent | 16:43 |
| *** bhagyashris_ is now known as bhagyashris|ruck | 16:43 | |
| elodilles | the definition ^^^ | 16:43 |
| * bauzas reads https://releases.openstack.org/reference/release_models.html | 16:43 | |
| bauzas | damn, burned | 16:43 |
| elodilles | :] | 16:43 |
| sean-k-mooney | we currently use cycle-with-intermediary which works fine | 16:43 |
| bauzas | well, then let's discuss this at the PTG | 16:44 |
| sean-k-mooney | but most of the changes tend to be paper work | 16:44 |
| sean-k-mooney | ack | 16:44 |
| bauzas | enforcing a release per cycle is something a bit loud, but this could be necessary | 16:44 |
| bauzas | releasing the enforcement doesn't sound bad at a first glance, but I wonder the implications | 16:45 |
| elodilles | one significant thing is that os-vif won't have stable branches, | 16:45 |
| elodilles | but i think not so much backports arrives there | 16:45 |
| sean-k-mooney | elodilles: ya but we dont really do backports often | 16:45 |
| elodilles | sean-k-mooney: ++ | 16:45 |
| sean-k-mooney | we do bug i can proably count them on two hands for the last 2-3 releases | 16:45 |
| bauzas | but then we loose the possibility of doing them :) | 16:45 |
| sean-k-mooney | yep | 16:46 |
| sean-k-mooney | lets talk about it later | 16:46 |
| bauzas | yup | 16:46 |
| sean-k-mooney | just wanted people to think about it | 16:46 |
| bauzas | thanks | 16:46 |
| bauzas | any other topic ? | 16:46 |
| bauzas | sean-k-mooney: please put it somewhere in your brain until the ptg etherpad is created, I don't want to miss this conversation at the PTG | 16:46 |
| bauzas | that said, if nobody has any items... | 16:47 |
| bauzas | thanks all | 16:47 |
| bauzas | #endmeeting | 16:47 |
| opendevmeet | Meeting ended Tue Mar 1 16:47:42 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:47 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-03-01-16.00.html | 16:47 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-03-01-16.00.txt | 16:47 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-03-01-16.00.log.html | 16:47 |
| elodilles | thanks bauzas o/ | 16:47 |
| chateaulav | \o | 16:47 |
| gibi | \o | 16:48 |
| chateaulav | gibi: thanks as well, i appreciate all the help again! | 16:48 |
| chateaulav | sean-k-mooney: you as well | 16:48 |
| gibi | chateaulav: thanks for the work! | 16:50 |
| sean-k-mooney | chateaulav: no worries. | 17:11 |
| opendevreview | Dan Smith proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 17:16 |
| opendevreview | Dan Smith proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 17:16 |
| opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 17:16 |
| dansmith | whoami-rajat: looks like there were more unit fails on the base patch.. I had only been going after the one that failed in the top patch | 18:00 |
| dansmith | probably more of the same needed further down | 18:00 |
| whoami-rajat | dansmith, those were the tests i was referring to, they should be fixed with a single line in the test conductor code | 18:04 |
| whoami-rajat | https://review.opendev.org/c/openstack/nova/+/831219/10/nova/tests/unit/conductor/test_conductor.py | 18:05 |
| whoami-rajat | L#389 | 18:05 |
| dansmith | whoami-rajat: ah okay so you're on top of it? | 18:05 |
| whoami-rajat | dansmith, i was skeptical about fixing conductor tests in the compute patch initially | 18:06 |
| whoami-rajat | i can do that update if it sounds right | 18:06 |
| dansmith | yeah, conductor calls compute rpc, so if compute rpc client changes, then those tests have to change to match | 18:06 |
| whoami-rajat | dansmith, but we're fixing these tests because we added the conductor parameter (hack) which shouldn't have been there in the first place in the compute patch, also they're easier to fix since all rebuild args are placed at one place but we're fixing 18 tests because of a code change that shouldn't exist in this patch | 18:09 |
| whoami-rajat | that's why i was skeptical about it ^ | 18:10 |
| dansmith | I don't see it that way at all :) | 18:10 |
| dansmith | the reason to break these things apart is to make sure each step works, because in reality, not all the services get upgraded at the same time in a real deployment, | 18:10 |
| dansmith | so doing the steps like this help ensure that we're not just shifting the state of the world atomically, which is how we discovered that the behavior of rebuild had changed, when we separated the api patch from the implementation | 18:11 |
| dansmith | it's not a "hack" to add a parameter that is the equivalent of what we have today as we step through those changes, it's just keeping things compatible | 18:12 |
| whoami-rajat | I understand why we are doing it like this but we already have rpc versions to check and maintain that compatibility (although this provides more assurance) | 18:13 |
| whoami-rajat | but again, in a real deployment as well, if the compute is new and conductor is old, we will see the same failure in the logs as these tests | 18:14 |
| dansmith | but we had versions in the initial unified patch, which weren't properly honoring the old behavior :) | 18:14 |
| dansmith | whoami-rajat: just FYI, conductor always has to be upgraded before compute, it's in our upgrade process | 18:14 |
| dansmith | api and conductor together, compute after | 18:15 |
| whoami-rajat | we weren't passing the reimage_boot_volume parameter down to the compute in the initial patch so there weren't the RPC bumps but i get what you're saying, we wouldn't have discovered the issue if it wasn't for the split | 18:18 |
| whoami-rajat | maybe it's just new for me to split the different services code apart | 18:18 |
| whoami-rajat | sorry for all the fuzz created :) | 18:18 |
| dansmith | s'ok, let's just get it right :) | 18:18 |
| whoami-rajat | ack, on it | 18:19 |
| opendevreview | Merged openstack/nova master: Move file system freeze after end of mirroring https://review.opendev.org/c/openstack/nova/+/803713 | 18:19 |
| chateaulav | gibi: im guessing for https://review.opendev.org/c/openstack/nova/+/828372 the -2 V is just an occasional hiccup with gate jobs | 18:40 |
| elodilles | dansmith: when you have some time, can you please use your stable core power on this one-liner patch? :) https://review.opendev.org/c/openstack/nova/+/830656/ | 18:41 |
| gibi | chateaulav: yepp, feel free to recheck | 18:41 |
| chateaulav | cool | 18:42 |
| dansmith | elodilles: done | 18:45 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 18:47 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 18:47 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 18:47 |
| whoami-rajat | dansmith, instead of one, it was 3 line change but tests are passing now ^ | 18:48 |
| dansmith | cool | 18:48 |
| elodilles | dansmith: thanks! \o/ | 18:58 |
| *** jparker__ is now known as jparker | 19:06 | |
| opendevreview | Merged openstack/nova stable/wallaby: skip test_tagged_attachment in nova-next https://review.opendev.org/c/openstack/nova/+/830656 | 20:28 |
| opendevreview | Merged openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 22:05 |
| *** dasm|rover is now known as dasm|off | 22:39 | |
| *** clarkb is now known as Guest985 | 23:32 | |
| *** Guest985 is now known as clarkb | 23:41 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!