opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 03:27 |
---|---|---|
opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | 03:27 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | 04:35 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 04:35 |
*** elodilles_pto is now known as elodilles | 06:46 | |
gibi | bauzas, sean-k-mooney: can we get a second opinion on https://review.opendev.org/c/openstack/nova/+/831507/comment/b9fbbb2c_8e65c98e/ about the possible refactor? | 07:44 |
gibi | Uggla: I don't want to be a heavy handed core but I really don't like the 14 conditionals in the unshelve code | 07:47 |
Uggla | gibi, hi | 08:01 |
gibi | o/ | 08:02 |
Uggla | gibi, ok i'm gonna change in that way. | 08:06 |
gibi | Uggla: don't rush, I just asked bauzas and sean-k-mooney oppinion about it above | 08:06 |
Uggla | gibi, I agree that usually having so many conditions is not great. | 08:07 |
gibi | cores: easy win for a +A (doc patch) https://review.opendev.org/c/openstack/placement/+/845730 | 08:18 |
gibi | cores: also an easy +A (unit test stabilization) https://review.opendev.org/c/openstack/nova/+/845922 | 08:22 |
bauzas | gibi: sorry was afk due to some appointment | 08:35 |
bauzas | Uggla: will try to do the review today | 08:35 |
Uggla | bauzas, ok | 08:40 |
bauzas | finishing up my GPU patch | 08:40 |
bauzas | gibi: do you think we could workaround https://bugs.launchpad.net/nova/+bug/1874664 with some flavor extraspec ? | 08:47 |
bauzas | it's a placement issue | 08:48 |
bauzas | if you look at the issue, we try to use the same RP https://paste.opendev.org/show/b9A9TdUl1dzTJaNtbrCd/ | 08:48 |
bauzas | for both allocations | 08:49 |
gibi | bauzas: I will check in a minute | 09:01 |
gibi | bauzas: have you checked that multicreate without vgpu can boot two instance on the same host? (I'm wondering if we do that) | 09:05 |
bauzas | gibi: good question, I dunno | 09:08 |
bauzas | gibi: so, my fix I created was using this bug number but I'll then create a separate other | 09:09 |
gibi | bauzas: I see the limitation | 09:20 |
gibi | bauzas: it is not placement | 09:20 |
gibi | bauzas: in that test placement returns 2 allocation candidate | 09:20 |
gibi | one for each pGPU | 09:20 |
gibi | but nova only able to consume the first allocation candidate per host | 09:21 |
gibi | bauzas: https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/scheduler/manager.py#L382-L388 | 09:21 |
gibi | nova only tries to first a_c, for both instance | 09:22 |
gibi | *tries to claim the first | 09:22 |
gibi | it succeeds for the first instance but obviously fails for the second | 09:22 |
gibi | the TODO from jaypipes is valid | 09:22 |
gibi | if you resolve that TODO then the test_multiple_instance_create_filling_up_capacity test case will be able to boot both instances on the same host | 09:23 |
bauzas | gibi: looking | 09:24 |
bauzas | gibi: thanks for finding the RCA | 09:33 |
gibi | I think we can implement that TODO | 09:33 |
gibi | without adding to much complexity with sorting | 09:33 |
gibi | it would not be optimal but would be better than what we have today | 09:33 |
gibi | I'm affraid the gate is broken on master | 09:39 |
gibi | https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute-centos-9-stream&skip=0 | 09:39 |
gibi | libvirt.libvirtError: internal error: unable to execute QEMU command 'netdev_add': File descriptor named '(null)' has not been found | 09:40 |
bauzas | gibi: what a Friday | 09:49 |
bauzas | Centos 9 Stream /o\ | 09:49 |
gibi | bauzas: reported a bug https://bugs.launchpad.net/nova/+bug/1979047 please triage it and set it critical I will drop a mail to the ML | 09:49 |
bauzas | gibi: we need to make this job non-voting | 09:50 |
gibi | are we give up on this job? :) | 09:51 |
bauzas | gibi: the priority is to unblock the gate | 09:51 |
bauzas | want me to write it ? | 09:52 |
gibi | I sent a mail to the ML | 09:53 |
bauzas | I'll propose the patch at least | 09:54 |
bauzas | we're on a Friday | 09:54 |
gibi | bauzas: my philosophy: sure unblock the gate in 2-3 days if nobody found a quick solution. but keep the pain a bit around to motivate people to try and find a solution first :) | 09:55 |
bauzas | gibi: my philosophy: remove support from something which breaks and you'll suddently find people who care | 09:55 |
bauzas | either way, patch is being forged, we need two cores for approving it, so there is no direct impact *yet* | 09:56 |
gibi | OK, lets go with yours this time :) | 09:56 |
gibi | I will +2 the non-voting patch | 09:56 |
opendevreview | Sylvain Bauza proposed openstack/nova master: zuul: Temporarly put Centos9 Stream job non-voting https://review.opendev.org/c/openstack/nova/+/846292 | 10:03 |
bauzas | gibi: feel free to add a reply to your email with this patch number | 10:03 |
opendevreview | Sylvain Bauza proposed openstack/nova master: zuul: Temporarly put Centos9 Stream job non-voting https://review.opendev.org/c/openstack/nova/+/846292 | 10:04 |
gibi | bauzas: thanks +2. done the ML update | 10:07 |
gibi | bauzas: the grenade job on master also look baaaad https://zuul.opendev.org/t/openstack/builds?job_name=nova-grenade-multinode&project=openstack%2Fnova&branch=master&skip=0 | 10:17 |
gibi | that seem to be a different error | 10:18 |
gibi | Details: {'type': 'SecurityGroupInUse', 'message': 'Security Group 40f249d7-9c4e-432c-91d7-d68ef7ac05b0 in use.', 'detail': ''} | 10:18 |
bauzas | yup, saw | 10:18 |
bauzas | damn | 10:19 |
sean-k-mooney | i can take a look at it too i guess | 10:23 |
opendevreview | Merged openstack/placement master: Add WA about resource_providers.can_host removal https://review.opendev.org/c/openstack/placement/+/845730 | 10:23 |
sean-k-mooney | so i guessl libvirt need to be udated for a new qemu release? | 10:24 |
sean-k-mooney | to fix interface attach | 10:24 |
sean-k-mooney | or they broke there api compat and we need to adress that | 10:24 |
gibi | sean-k-mooney: I added the libvirt and qemu versions to the bugreport I don't know if any of those are fresh | 10:25 |
tkajinam | gibi, the bug title reminds me this https://bugzilla.redhat.com/show_bug.cgi?id=2092856 | 10:26 |
gibi | tkajinam: good find. That very much like it | 10:27 |
tkajinam | we pinned libvirt to workaround this in tripleo | 10:27 |
sean-k-mooney | ya i was about to ping danpb and ask about that bug | 10:28 |
gibi | bauzas: I'm going to open a bug on tempest about the security group issue | 10:29 |
bauzas | gibi: cool | 10:29 |
gibi | https://bugs.launchpad.net/tempest/+bug/1979052 | 10:33 |
bauzas | I need to go off | 10:35 |
bauzas | (fortunately, wasn't doing gym today) | 10:36 |
bauzas | but I have my kid with me so I need to cook :) | 10:36 |
gibi | let me know what did you cook when you are back | 10:36 |
gibi | I need inspiration | 10:36 |
sean-k-mooney | im considerign firing up my new(ish) BBQ this evening and cookig somethign or at least doing that at the weekend | 10:45 |
gibi | sounds nice :) | 10:45 |
sean-k-mooney | since i invested in a "kamado joe big joe 3" i might as well make use of it. i had left over chicken form tha tlast time in the freezer which i had last night. it was pretty tasty | 10:47 |
sean-k-mooney | i did a prime rib roast on it before and it was amazing, also did really nice potatos corn and fish | 10:48 |
sean-k-mooney | its been 50:50 for bread sofar. the first loaf was nice the second i didnt have the dome heat soaked enouch so it went way to high then too low so the bread did not cook to the center but im pretty happy all in all | 10:50 |
gibi | I need ribs :) | 10:51 |
*** whoami-rajat__ is now known as whoami-rajat | 11:33 | |
bauzas | sean-k-mooney: hah, I'm a BBQ lover | 12:35 |
bauzas | kamados <3 | 12:36 |
bauzas | I have a Weber Genesis 2 (gas) at home with a plancha, so usually, I cook both vegetables and potatoes while the meat is grilling | 12:37 |
bauzas | in general, sausages as it's French thing | 12:37 |
bauzas | https://www.bestfranceforever.com/you-cant-have-a-french-barbecue-without-these-10-ingredients/ | 12:39 |
bauzas | (sorry for the URL name... :) | 12:39 |
* bauzas is amazed how the cultures are different between countries when it comes to BBQingf | 12:41 | |
sean-k-mooney | yep | 12:47 |
sean-k-mooney | there is a lot of variation | 12:47 |
opendevreview | Sylvain Bauza proposed openstack/nova master: Add a functest for verifying multiple VGPU allocations https://review.opendev.org/c/openstack/nova/+/845747 | 13:27 |
opendevreview | Sylvain Bauza proposed openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | 13:27 |
Uggla | bauzas, looking at your BBQ damned it is connected ! | 13:50 |
bauzas | well, yes and no | 13:50 |
bauzas | my BBQ *can* be connected | 13:51 |
bauzas | and indeed I use a grill temperature sensor that's connected for my meat cooking | 13:52 |
bauzas | but not a weber | 13:52 |
Uggla | bauzas, meat cooking pro ! | 13:52 |
bauzas | Uggla: unfortunately, my middle name isn't Rafa :) | 13:57 |
bauzas | only French people looking at YT can understand :) | 13:58 |
Uggla | bauzas, I don't have the ref... | 14:01 |
bauzas | Uggla: https://www.youtube.com/c/LeBarbecueDeRafa | 14:01 |
sean-k-mooney | i went with a ceramic grill basically because i wanted the charcol taste but didnt want to have to worry about tending a fire or unstable temperatures | 14:02 |
bauzas | sean-k-mooney: I have charcoil tasting with my Weber flavorizers tho | 14:03 |
sean-k-mooney | that and it can be used for low an slow smokes or you can use it as a pizza oven | 14:03 |
bauzas | sean-k-mooney: and eventually after 15 years of grilling, I gave up playing with charcoil | 14:04 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843947 | 14:42 |
*** whoami-rajat__ is now known as whoami-rajat | 14:43 | |
bauzas | gibi: there for a question about https://github.com/openstack/nova/blob/93a65f06df67ce39d65827692150c78013c7f6d5/nova/scheduler/manager.py#L382-L388 ? | 14:54 |
bauzas | should hopefully be quick, I want to be on weekend :) | 14:55 |
gibi | sure, hit me | 14:55 |
bauzas | gibi: so I tested with my functest | 14:55 |
bauzas | we return the allocations | 14:55 |
sean-k-mooney | do we where? | 14:56 |
bauzas | gibi: so, I guess we should loop over all the allocations until claim_resources() returns True, right? | 14:56 |
gibi | right | 14:56 |
bauzas | ok, looks to me simple then | 14:57 |
gibi | at some point we might want to be smarter than linear looping but the loop is still better than what we have today | 14:57 |
gibi | bauzas: probably it worth adding extra multicreate tests around this case when you add the loop | 14:58 |
sean-k-mooney | well for the pci in placment stuff we have introduced a way to filter the list of allocations per hosts | 14:58 |
gibi | sean-k-mooney: yeah that is one smartness | 14:58 |
sean-k-mooney | so hopefully its short today and it will be refined in the future | 14:58 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843947 | 14:58 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843948 | 14:58 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843949 | 14:58 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844598 | 14:58 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844599 | 14:58 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843950 | 15:25 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: functional: Use tempdir for CONF.instances_path https://review.opendev.org/c/openstack/nova/+/846204 | 15:25 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843951 | 15:25 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843952 | 15:25 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844606 | 15:25 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844607 | 15:25 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fake: Ensure need_legacy_block_device_info returns False https://review.opendev.org/c/openstack/nova/+/843958 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: tests: work around malformed serial XML https://review.opendev.org/c/openstack/nova/+/844743 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: functional: Use tempdir for CONF.instances_path https://review.opendev.org/c/openstack/nova/+/844750 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | 17:18 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | 17:18 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | 17:46 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | 17:46 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | 17:46 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | 17:46 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | 18:26 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | 18:26 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844594 | 18:26 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844595 | 18:26 |
artom | gdi I'll the hashes right one day | 18:26 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843948 | 18:57 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843949 | 18:57 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844598 | 18:57 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844599 | 18:57 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843951 | 19:03 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843952 | 19:03 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844606 | 19:03 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844607 | 19:03 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | 19:11 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | 19:11 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | 19:11 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | 19:11 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | 19:11 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843679 | 19:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843680 | 19:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844594 | 19:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844595 | 19:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843948 | 21:15 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843949 | 21:15 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844598 | 21:15 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844599 | 21:15 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843951 | 21:19 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843952 | 21:19 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844606 | 21:19 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844607 | 21:19 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Add a regression test for bug 1939545 https://review.opendev.org/c/openstack/nova/+/843959 | 21:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: compute: Ensure updates to bdms during pre_live_migration are saved https://review.opendev.org/c/openstack/nova/+/843960 | 21:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Make connection_info returned by CinderFixture unique per attachment https://review.opendev.org/c/openstack/nova/+/844744 | 21:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: func: Add live migration rollback volume attachment tests https://review.opendev.org/c/openstack/nova/+/844745 | 21:23 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/train: fup: Assert state of connection_info during LM rollback in func tests https://review.opendev.org/c/openstack/nova/+/844746 | 21:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!