| *** mfo is now known as Guest4296 | 00:27 | |
| *** mfo_ is now known as mfo | 00:27 | |
| opendevreview | OpenStack Proposal Bot proposed openstack/python-novaclient master: Imported Translations from Zanata https://review.opendev.org/c/openstack/python-novaclient/+/848804 | 03:56 |
|---|---|---|
| gibi | good morning | 06:30 |
| bauzas | good morning | 07:23 |
| bauzas | gibi: yeah, scrolled above, indeed I was thinking about abandoning the Yoga specs after Zed spec approval freeze | 07:53 |
| gibi | ack | 08:10 |
| sean-k-mooney | dansmith: bauzas can you confrim the logic asserted in the commit https://review.opendev.org/c/openstack/nova/+/845335 i belive they are correct but i dont know if we had those returns for a reason | 12:50 |
| bauzas | oh that | 12:50 |
| bauzas | yeah, simple and trivial fix I discussed with ratailor__ | 12:51 |
| sean-k-mooney | ya rajesh is correct casts shoudl not return anything | 12:51 |
| bauzas | sean-k-mooney: I think it was just a copy/paste problem | 12:51 |
| bauzas | when people created those calls | 12:51 |
| sean-k-mooney | and techinaly beofre and after this call if you assinged the result to avar the content would be None | 12:51 |
| sean-k-mooney | ya ok that what i assumed too | 12:51 |
| bauzas | cctxt.cast() retunrs None anyone | 12:51 |
| bauzas | anyway* | 12:51 |
| sean-k-mooney | yep and the default result fo a fucntion that does not return is None | 12:52 |
| sean-k-mooney | if you assign it to a var | 12:52 |
| sean-k-mooney | so i dont think this changes the interface in any way | 12:52 |
| sean-k-mooney | just being extra carful since its in the rpc api | 12:52 |
| bauzas | sean-k-mooney: proof of evidence https://github.com/openstack/oslo.messaging/blob/f1b47b6ba8ee4888f6cba1efac0fbf747c5406e6/oslo_messaging/rpc/client.py#L476 | 12:56 |
| bauzas | sorry, took me a while, my laptop is burning CPU | 12:56 |
| sean-k-mooney | hehe ya i know it does not have a return | 12:58 |
| sean-k-mooney | the other reason i was +1 and not +2 is the lack of a bug | 12:58 |
| sean-k-mooney | bauzas: so without adding that we cant backport | 12:58 |
| bauzas | sean-k-mooney: mmmm, I'm maybe wrong, but we don't need to file a bug report for backporting to stable branches | 12:59 |
| bauzas | I can verify the stable policy tho | 12:59 |
| sean-k-mooney | i tought that was a requirement but if not i guess its fine | 13:00 |
| sean-k-mooney | this does not really fix anything | 13:00 |
| sean-k-mooney | so its not really something i would backport | 13:00 |
| sean-k-mooney | unless it help with a differnt issue | 13:00 |
| sean-k-mooney | if it did then we would just backport it as part of that other bug fix | 13:00 |
| bauzas | "It’s nevertheless allowed to backport fixes for other bugs if their safety can be easily proved. For example, documentation fixes, debug log message typo corrections, test only changes, patches that enhance test coverage, configuration file content fixes can apply to all supported branches. For those types of backports, stable maintainers will decide on case by case basis." | 13:00 |
| bauzas | https://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes | 13:01 |
| sean-k-mooney | ack | 13:01 |
| sean-k-mooney | ok if your happy with the patch as is i can upgrade to +2 | 13:02 |
| bauzas | sean-k-mooney: I added the github link to oslo.messaging cast() to prove the absence of change | 13:02 |
| bauzas | so you're free to vote | 13:03 |
| bauzas | I'm just adding the stable policy clarification | 13:04 |
| sean-k-mooney | ya i dont think stable policy should be an issue | 13:04 |
| sean-k-mooney | im not expecting use to backport this | 13:04 |
| sean-k-mooney | since it will have no viable impact | 13:05 |
| bauzas | I left a comment for backport reviewers | 13:05 |
| bauzas | the policy says it's up to the stable cores to decide whether this is useful or not | 13:05 |
| bauzas | but nothing prevents it to be proposed | 13:05 |
| sean-k-mooney | sure but i dont think its useful | 13:06 |
| sean-k-mooney | if we want to backport it for a backport of a diffeent patch to avoid a merge conflict | 13:06 |
| sean-k-mooney | then im fine with it | 13:06 |
| sean-k-mooney | but otherwise i would just leave it on master | 13:06 |
| *** dasm|off is now known as dasm | 13:39 | |
| opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | 18:22 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | 21:09 |
| opendevreview | Merged openstack/nova stable/yoga: Fix typos in help messages https://review.opendev.org/c/openstack/nova/+/846260 | 21:20 |
| *** dasm is now known as dasm|off | 21:36 | |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Ignore LibvirtConfigObject kwargs https://review.opendev.org/c/openstack/nova/+/830644 | 23:29 |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Remove unnecessary TODO https://review.opendev.org/c/openstack/nova/+/830645 | 23:29 |
| opendevreview | Rico Lin proposed openstack/nova master: add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | 23:29 |
| opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | 23:29 |
| opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | 23:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!