| opendevreview | wangkuntian proposed openstack/nova stable/yoga: Modify the command of getting serial console https://review.opendev.org/c/openstack/nova/+/850723 | 07:11 |
|---|---|---|
| bauzas | morning | 07:18 |
| gibi | good morning | 07:24 |
| Uggla | bauzas, hi, I pushed an update version of unshelve to host. If you can have a look. | 08:09 |
| bauzas | Uggla: I'll try but I'm overloaded by the vgpu regression | 08:10 |
| opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host (Compute API part) https://review.opendev.org/c/openstack/nova/+/831507 | 08:23 |
| opendevreview | ribaudr proposed openstack/nova master: Allow unshelve to a specific host (REST API part) https://review.opendev.org/c/openstack/nova/+/845897 | 08:23 |
| opendevreview | wangkuntian proposed openstack/nova master: Modify the command of getting serial console https://review.opendev.org/c/openstack/nova/+/850729 | 08:23 |
| opendevreview | wangkuntian proposed openstack/nova master: Modify the command of getting serial console https://review.opendev.org/c/openstack/nova/+/850734 | 08:48 |
| opendevreview | wangkuntian proposed openstack/nova master: Modify the command of getting serial console https://review.opendev.org/c/openstack/nova/+/850729 | 09:01 |
| gibi | bauzas: now I managed to get back to your keypair patch and left feedback https://review.opendev.org/c/openstack/nova/+/849133 | 09:07 |
| bauzas | gibi: ack, will look | 09:19 |
| bauzas | gibi: thanks for the review, will update it this afternoon | 09:53 |
| auniyal | O/, please have a review this - https://review.opendev.org/c/openstack/nova/+/848886 | 10:24 |
| sean-k-mooney | over all it looks ok there are proably some spelling nits that i cant see | 10:31 |
| sean-k-mooney | we dont need the other section in the release note but i have leaft that feedback on the review | 10:31 |
| gibi | I left feedback too | 11:01 |
| sean-k-mooney | auniyal: it would be helpful if you could also mark some fo the coments as resolved | 11:01 |
| sean-k-mooney | im currently in the middle of something downstream so cant really spend much time on the review currently but in general when you push a new revision ist good if you can look at the old commens in gerrit, confirm its adressed and mark them done. | 11:03 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | 11:08 |
| gibi | fyi: if somebody has an idea to handle the fallout of ^^ (and the parent bug) then I'm all ears as I can only solve this back hacking either instance.save() or the rollback_live_migration_at_destination driver call | 11:09 |
| gibi | s/back/by/ | 11:10 |
| sean-k-mooney | gibi: sorry cant load context now but remind me on monday and ill think about it | 11:15 |
| gibi | sean-k-mooney: sure, I know you are knee deep in a DB dump | 11:15 |
| sean-k-mooney | also didnto know that Instance.mutated_migration_context() was a thing | 11:15 |
| gibi | it is a beautiful if you use it in a small scope, but applying to a big scope is dangerous like hell | 11:16 |
| gibi | anyhow it is not super urgent | 11:16 |
| sean-k-mooney | im glad you were able to find the cause of that issue one way or another | 11:18 |
| gibi | it was a tricky one as we have two RPC to the dest during migration rollback, the first is a cast the second is a call. The second one saves the proper instance data but the first one saves the wrong data. However as the first one is cast it can happen _after_ the second call. | 11:20 |
| sean-k-mooney | ah | 11:20 |
| sean-k-mooney | so this is also why its not determinitic | 11:20 |
| sean-k-mooney | also cast_as_call-- | 11:20 |
| gibi | it was deterministic for James but it wasn't in a func env | 11:20 |
| sean-k-mooney | well likely because of the cast as call fixutre | 11:21 |
| gibi | yepp | 11:21 |
| sean-k-mooney | that will make it so the cast alwasy happens first | 11:21 |
| gibi | that was the first thing to hide the issue, but then I still had to slow down the execution of the cast to let the call finish first | 11:21 |
| gibi | in real env during the cast we do disk IO (delete disk) | 11:22 |
| gibi | so that could take time and nova switch to the next RPC which is the call | 11:22 |
| sean-k-mooney | well we can do what we did in other case | 11:22 |
| sean-k-mooney | add a lock to the mocked op | 11:22 |
| sean-k-mooney | so that it will block then to the call then unlock to let the cast continue | 11:23 |
| gibi | while locking would force a better serialization of the events it will still create a time window where the db has the wrong instance data | 11:23 |
| gibi | we would save the wrong data first | 11:23 |
| sean-k-mooney | oh i just mean in the func test | 11:23 |
| gibi | ahh | 11:23 |
| gibi | in the func test I used threading.Condition to serialize the thing | 11:24 |
| sean-k-mooney | ack ya same idea | 11:24 |
| gibi | yepp | 11:24 |
| gibi | that is basically a lock | 11:24 |
| gibi | I actually needed two as I had to prevent instance.delete to happen before the cast too :D | 11:24 |
| sean-k-mooney | :) fun | 11:24 |
| gibi | it was indeed :) | 11:25 |
| sean-k-mooney | i have stared and set rp +1 form me on both | 11:25 |
| sean-k-mooney | so ill get back to them monday | 11:25 |
| gibi | ack, thanks | 11:26 |
| sean-k-mooney | gibi: if you respin care to pull https://review.opendev.org/c/openstack/nova/+/850672/1/nova/tests/functional/integrated_helpers.py into its own change first | 11:37 |
| sean-k-mooney | just thinking that might be good to be able to backport seperatly | 11:37 |
| sean-k-mooney | although not required | 11:37 |
| gibi | sean-k-mooney: sure I can, but I guess we will backport the reproducer and the eventual fix anyhow | 11:58 |
| sean-k-mooney | yep its not that important | 11:59 |
| sean-k-mooney | just one of the reaosn i have used the freestanding approch in the past is to not include cast_as_call | 11:59 |
| sean-k-mooney | i.e. if you just use the mixins that is not added unless you do it yourslef in teh func test | 12:00 |
| gibi | sean-k-mooney: true | 12:00 |
| gibi | I'm not sure how easy it would be to move the libvirt functional tests away from the _IntegratedBase | 12:00 |
| sean-k-mooney | i would move it to https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/integrated_helpers.py#L23= first | 12:01 |
| sean-k-mooney | but as stephen notes https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L1231-L1233= | 12:02 |
| sean-k-mooney | but if we were to remove one or the ohter i would remove _IntegratedTestBase | 12:02 |
| sean-k-mooney | crap meeting | 12:03 |
| gibi | I think this shows that even if we want light test case bases we eventually end up with heavy bases | 13:07 |
| gibi | so I would not fight much against the heavy bases | 13:08 |
| *** hemna7 is now known as hemna | 13:09 | |
| opendevreview | Sylvain Bauza proposed openstack/nova master: api: Drop generating a keypair and add special chars to naming https://review.opendev.org/c/openstack/nova/+/849133 | 13:58 |
| bauzas | gibi: sean-k-mooney: updated my 2.92 patch based on gibi's comments | 13:59 |
| bauzas | just a few cleanups | 13:59 |
| *** dasm|off is now known as dasm | 14:12 | |
| gibi | bauzas: +2 | 14:57 |
| bauzas | ta | 14:57 |
| bauzas | I'm reviewing Uggla's API change ;) | 14:57 |
| gibi | I feel we will land two API change in a short while :) | 14:58 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: [trivial] Simplify dict get call by removing unused default https://review.opendev.org/c/openstack/nova/+/850450 | 15:18 |
| *** yoctozepto_ is now known as yoctozepto | 15:27 | |
| *** efried1 is now known as efried | 15:27 | |
| *** rpioso_ is now known as rpioso | 15:27 | |
| *** johnsom_ is now known as johnsom | 15:27 | |
| Uggla | bauzas, thx, I hope you will like it. | 15:29 |
| *** akekane_ is now known as abhishekk | 15:31 | |
| bauzas | gibi: looks like we have a problem with test_live_migration_with_trunk | 15:41 |
| bauzas | in tempest.api.compute.admin.test_live_migration.LiveMigrationTest | 15:41 |
| bauzas | Uggla: +Wd so happy weekend :) | 15:50 |
| Uggla | bauzas, I wish you a happy (probably hot) WE as well. | 15:53 |
| bauzas | it's my daughter's birthday today so yes :) | 15:53 |
| bauzas | 12yo | 15:53 |
| bauzas | f***, I'm getting old | 15:54 |
| bauzas | likewise OpenStack | 15:54 |
| bauzas | both were born on mid-July 2010 | 15:54 |
| bauzas | anyway, done for the week, see you all on Monday | 15:55 |
| *** dasm is now known as dasm|off | 22:11 | |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 22:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!