opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 03:00 |
---|---|---|
opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | 03:00 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 03:00 |
opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | 03:00 |
opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | 03:00 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | 03:00 |
opendevreview | Amit Uniyal proposed openstack/nova master: Updated Suspend definition in server concepts doc https://review.opendev.org/c/openstack/nova/+/851511 | 04:19 |
opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | 04:31 |
opendevreview | Tony Breeds proposed openstack/placement master: disable traits count check to allow os-traits 2.8.0 https://review.opendev.org/c/openstack/placement/+/851792 | 05:07 |
opendevreview | Tony Breeds proposed openstack/placement master: Update placement for os-traits 2.8.0 release https://review.opendev.org/c/openstack/placement/+/851793 | 05:07 |
tonyb | Can someone take a look at: https://review.opendev.org/c/openstack/requirements/+/849986 The patch is trying to use the latest openstacksdk but it fails "nova.tests.unit.scheduler.client.test_report.SafeConnectedTestCase.test_missing_endpoint" I suspect that's because openstacksdk reworked the proxy/cache code [ https://review.opendev.org/c/openstack/openstacksdk/+/837802 ] and I'm guessing that it caches 404 (or similar) | 05:27 |
tonyb | so the second all returns directly from the cache. | 05:27 |
* tonyb kinda looks sidelong at stephenfin | 05:28 | |
gibi | good morning | 07:29 |
Uggla | gibi, good morning | 07:30 |
bauzas | good morning | 07:44 |
* bauzas fights with OSC change | 07:44 | |
opendevreview | Tony Breeds proposed openstack/placement master: disable traits count check to allow os-traits 2.8.0 https://review.opendev.org/c/openstack/placement/+/851792 | 07:53 |
opendevreview | Tony Breeds proposed openstack/placement master: Update placement for os-traits 2.8.0 release https://review.opendev.org/c/openstack/placement/+/851793 | 07:53 |
opendevreview | Radosław Piliszek proposed openstack/nova master: [docs] Fix mention of custom scheduling after Wallaby https://review.opendev.org/c/openstack/nova/+/851807 | 08:15 |
bauzas | gibi: around ? | 08:29 |
gibi | bauzas: yes | 08:29 |
bauzas | gibi: I wanted to discuss your excellent point on https://review.opendev.org/c/openstack/nova/+/838976/3/nova/virt/libvirt/utils.py#597 | 08:29 |
bauzas | fixing it isn't trivial as it either needs to change the callers or to longer use this method | 08:30 |
bauzas | but I checked which callers are using this method, and this is only for the reshape method and for the recreating method (when you reboot) | 08:31 |
bauzas | [sbauza@sbauza nova]$ git grep '\.mdev_uuid2name(' | 08:33 |
bauzas | nova/tests/functional/libvirt/test_reshape.py: utils.mdev_uuid2name(mdev_uuid)) | 08:33 |
bauzas | nova/tests/functional/libvirt/test_vgpu.py: mdev_name = libvirt_utils.mdev_uuid2name(uuid) | 08:33 |
bauzas | nova/tests/functional/libvirt/test_vgpu.py: mdev_name = libvirt_utils.mdev_uuid2name(mdev) | 08:33 |
bauzas | nova/tests/functional/libvirt/test_vgpu.py: libvirt_utils.mdev_uuid2name(mdevs[0])) | 08:33 |
bauzas | nova/tests/functional/regressions/test_bug_1951656.py: mdev_name = libvirt_utils.mdev_uuid2name(uuid) | 08:33 |
bauzas | nova/virt/libvirt/driver.py: dev_name = libvirt_utils.mdev_uuid2name(mdev_uuid) | 08:33 |
bauzas | nova/virt/libvirt/driver.py: dev_name = libvirt_utils.mdev_uuid2name(mdev_uuid) | 08:33 |
bauzas | so FWIW, I think we could provide a follow-up patch for it, instead of trying to modify all of the above in the same change | 08:35 |
gibi | I'm not sure what you imply. Is this not a bug right now to use non suffixed mdev_name with libvirt 7.7+? | 08:36 |
bauzas | gibi: we already have a bug for recreate() | 08:40 |
bauzas | so this won't change | 08:41 |
gibi | OK, so you say, that we use the wrong mdev_name in two cases 1) reshape, but there we only use it internally to nova so libvirt wont see it 2) in recreate but recreate is broken for other reasons as well | 08:41 |
gibi | Do I understand it correctly? | 08:42 |
bauzas | 1) for reshapes, we no longer do them | 08:42 |
gibi | except FFU | 08:42 |
bauzas | unless someone wants to reshape from Queens to Rocky | 08:42 |
gibi | ack | 08:42 |
bauzas | for 2), you got it | 08:43 |
bauzas | actually, we could fix https://bugs.launchpad.net/nova/+bug/1900800 once we provide the FUP | 08:44 |
gibi | so 1) can be an issue if someone FFUs from Queens to Train | 08:44 |
bauzas | 1) only if they run Train with libvirt 7.7 | 08:44 |
gibi | yepp | 08:44 |
gibi | I agree this is low probabability | 08:45 |
bauzas | and I'm not saying we shouldn't modify uuid2name | 08:45 |
bauzas | just saying this couldn't be in the same change | 08:45 |
bauzas | but by a FUP | 08:45 |
gibi | OK, lets have a fup | 08:45 |
sean-k-mooney | bauzas your on pto for the next two weeks yes? from tomorrow? | 08:51 |
bauzas | sean-k-mooney: from tonight until Aug 29 | 08:51 |
sean-k-mooney | bauzas: did you start trying to port the mdev lib to work around the other issues we have with libvirt | 08:52 |
sean-k-mooney | if not that is ok | 08:52 |
bauzas | sean-k-mooney: you mean about using sysfs instead of libvirt for getting the mdevs ? | 08:53 |
bauzas | no if so | 08:53 |
sean-k-mooney | ya | 08:53 |
sean-k-mooney | ok | 08:53 |
opendevreview | Sylvain Bauza proposed openstack/nova master: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/838976 | 08:59 |
bauzas | gibi: sean-k-mooney: update the mdev rename change without modifying the mdev_uuid2name method as we agreed ^ | 09:00 |
bauzas | will work now on a FUP to fix the recreate method | 09:00 |
sean-k-mooney | ack | 09:04 |
gibi | dansmith_: when you are up. I have an ovo question. Is there a way to run code before a remotable method is called on the remote end? Like instance.save() is remoteable but I need to run code during instance.save() on the caller side _before_ the rpc call is made to the remote and to call save() there | 09:21 |
gibi | dansmith_: context is https://review.opendev.org/c/openstack/nova/+/850746 | 09:21 |
gibi | dansmith_: the instance.mutated_migration_context() is not a remotable obviously, but save() is and I would need state to travell between the mutated_migration_context call and a later save() call | 09:22 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for bug 1982497 https://review.opendev.org/c/openstack/nova/+/850672 | 09:35 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | 09:35 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid saving instance under mutated migration context https://review.opendev.org/c/openstack/nova/+/851832 | 09:35 |
gibi | dansmith_: or alternatively where to stash data in the instance ovo that travels from local to remote but not persisted | 09:39 |
sean-k-mooney | gibi: you could decorate the remotable method | 10:10 |
gibi | the mutated_migration_context does not need to be remotable | 10:10 |
gibi | hm, | 10:10 |
gibi | we can create two save() methods | 10:11 |
sean-k-mooney | right but you were askign could we run somthing ofn the remote before it runs right | 10:11 |
gibi | one non remoteable and one remoteable | 10:11 |
sean-k-mooney | im not sure about that | 10:11 |
gibi | with different names of course | 10:11 |
gibi | and the the non remoteable can call the remoteable | 10:11 |
gibi | sean-k-mooney: you are a genius, thanks | 10:11 |
sean-k-mooney | normally we would do that the other way around | 10:12 |
sean-k-mooney | what exactuly are you tryign to do by the way | 10:12 |
gibi | I need to prevent instance.save to persist things if the instance is under mutated migration context | 10:12 |
gibi | so I need a flag on the instance object | 10:12 |
gibi | but the mutation happens on the local instance | 10:12 |
gibi | while save runs on the remote instance | 10:13 |
sean-k-mooney | you can add filed to the instance object directly | 10:13 |
sean-k-mooney | they wont be saved or sent over the wire | 10:13 |
gibi | the second is the problem | 10:13 |
sean-k-mooney | as in "instnace.my_flag=True" | 10:13 |
gibi | the save runs on the remote | 10:13 |
gibi | so I need to send the flag on the wire (or check the flag on the local side during save, hence the question) | 10:13 |
sean-k-mooney | if you want it to be a noop do you | 10:14 |
sean-k-mooney | you dont want it to save | 10:14 |
gibi | context in here https://review.opendev.org/c/openstack/nova/+/851832 | 10:14 |
sean-k-mooney | so add a decorator that checks if its set on teh souce | 10:14 |
sean-k-mooney | and just dont forward if the flag is set | 10:14 |
gibi | hm | 10:14 |
gibi | that also possible | 10:14 |
gibi | if I decorate before the remoteable decorator | 10:14 |
gibi | then I can inject thing to the local side | 10:15 |
sean-k-mooney | yep it need to be the other decorator | 10:15 |
sean-k-mooney | yes | 10:15 |
sean-k-mooney | and avoid the rpc entirly | 10:15 |
gibi | ack, thanks | 10:15 |
gibi | you answered my question | 10:15 |
sean-k-mooney | :) | 10:15 |
sean-k-mooney | i think we already do this on the instance object by the way. we cachce some things in the object in memory via filed that are never sent on the wire | 10:16 |
gibi | I will go with a normal function instead of a wrapper applied by a decorator, as the actual logic is highly save + migration context specific | 10:20 |
gibi | I will do save() -> remoted_save() indirection | 10:20 |
sean-k-mooney | hum the issue witht that is you are moving the remoteable decorator to remote_save | 10:21 |
sean-k-mooney | isnt that a problem | 10:21 |
gibi | the decorator would do the same technically as the function returned from the decorator would be different | 10:22 |
gibi | I believe it will not be a problem, but we will see | 10:22 |
sean-k-mooney | i think it might cause issue for grenade | 10:22 |
sean-k-mooney | it woudl technically be an rpc change i think | 10:23 |
sean-k-mooney | the decorator would not alter the name of the remote rpc endpoint for the function | 10:23 |
sean-k-mooney | it would still be save not remote_save() | 10:23 |
*** tosky_ is now known as tosky | 10:24 | |
gibi | ahh | 10:24 |
gibi | why we are too clever with these namings | 10:24 |
gibi | ?! | 10:24 |
gibi | but you are right | 10:25 |
gibi | the incoming save might fail | 10:25 |
gibi | hm | 10:25 |
sean-k-mooney | you can add a try_save() | 10:25 |
gibi | actually the incoming save RPC will call Instance.save that will do the checks again | 10:25 |
sean-k-mooney | function that delegate to save | 10:25 |
sean-k-mooney | try_save can check if it should save and then call save | 10:25 |
gibi | try_save is bad as I don't want to replace all the instance.save calls with instance.try_save | 10:26 |
gibi | but I need the check at every instance.save call | 10:26 |
sean-k-mooney | ya that was what i was about to say you would have to do that | 10:26 |
sean-k-mooney | so the only ohte way to do this if you dont use a decorator | 10:26 |
sean-k-mooney | is to have the context manage replace instance.save within it | 10:27 |
sean-k-mooney | which is kind of messy | 10:27 |
gibi | as the decorator is applied both on the local and on the remote side with the decorator we also call the extra check twice. I think the effect is the same either if I use the decorator or a save -> remote_save indirection | 10:28 |
gibi | but I will try it out after lunch | 10:28 |
gibi | thanks again | 10:28 |
sean-k-mooney | cool let me knwo how it goes, enjoy lunch | 10:29 |
gibi | thanks | 10:29 |
*** dasm|off is now known as dasm | 11:06 | |
opendevreview | Elod Illes proposed openstack/nova stable/rocky: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/804654 | 11:07 |
opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | 11:22 |
opendevreview | Elod Illes proposed openstack/nova stable/wallaby: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/829434 | 11:36 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid saving instance under mutated migration context https://review.opendev.org/c/openstack/nova/+/851832 | 11:54 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | 11:54 |
gibi | sean-k-mooney[m]: locally this works ^^ lets see if it passes tempest and grenade | 11:54 |
gibi | dansmith_: meanwhile with sean-k-mooney[m] we figured a solution for my question ^^ | 11:55 |
artom | gibi, I have a concern on https://review.opendev.org/c/openstack/nova/+/851832 - does it sound legit to you? I'm not too sure myself... | 12:07 |
*** priteau_ is now known as priteau | 12:38 | |
opendevreview | Merged openstack/nova master: [docs] Fix mention of custom scheduling after Wallaby https://review.opendev.org/c/openstack/nova/+/851807 | 12:55 |
opendevreview | Guillaume Espanel proposed openstack/nova master: Skip useless qemu-img convert when snapshotting https://review.opendev.org/c/openstack/nova/+/851854 | 12:55 |
gibi | artom: you and sean-k-mooney[m] both raised this, I'm waiting for grenade to prove that it is a real problem or not. If it is then the only way to keep this work is to decorate save() to modify it so the name is kept. | 13:00 |
gibi | I'm not sure how the names of the RPC is mapped | 13:00 |
gibi | in you example you need an old conductor | 13:01 |
gibi | but I think we say, upgrade your control service first | 13:01 |
sean-k-mooney | gibi: dansmith_ might be able to help you figure that out but i can point to where that is done of the top of my head | 13:01 |
gibi | so in theory the conductor will have both save and _remote_save | 13:01 |
gibi | during a rolling upgrade | 13:01 |
gibi | old computes will call save over RPC and that exists | 13:01 |
gibi | new computes probably will call _remote_save and that also exists in a new conductor | 13:02 |
gibi | sean-k-mooney: ack | 13:02 |
artom | gibi, for a major version upgrade, yeah, control tier first, so it's not a problem | 13:23 |
artom | It's only a problem if we backport | 13:23 |
sean-k-mooney[m] | my laptop over heated again | 13:23 |
sean-k-mooney[m] | ill be upstream only for a bit while it cools down and i get the vpn set up elsewhere | 13:24 |
artom | Pour mineral oil in your bathtub and dunk your laptop in there? | 13:25 |
gibi | artom: hm, if we backport then both the old and the new side will have both save and _remote_save so I don't see the problem about the backport either | 13:28 |
opendevreview | Radosław Piliszek proposed openstack/nova stable/yoga: [docs] Fix mention of custom scheduling after Wallaby https://review.opendev.org/c/openstack/nova/+/851870 | 13:29 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | 13:32 |
opendevreview | Balazs Gibizer proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/c/openstack/nova/+/708768 | 13:32 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Remove the PowerVM driver https://review.opendev.org/c/openstack/nova/+/850346 | 13:32 |
kashyap | gibi: Thx for cleaning up the PowerVM! | 13:33 |
gibi | that wasn't me | 13:34 |
gibi | I just rebased | 13:34 |
kashyap | Err, stephenfin++ :) | 13:34 |
kashyap | What a diffstat: +10 -9350 | 13:34 |
dansmith_ | artom: gibi sean-k-mooney[m]: I'm really -2 on that approach in general, but -1 for politeness | 13:45 |
opendevreview | Elod Illes proposed openstack/nova stable/train: DNM: test preinstall of python3-yaml https://review.opendev.org/c/openstack/nova/+/851861 | 13:46 |
dansmith_ | gibi: to answer your question, the methods are mapped automatically, which means it's a problem for minor and major upgrades as artom noted, and why you can't find the method mapping | 13:46 |
*** dansmith_ is now known as dansmith | 13:46 | |
gibi | dansmith: thanks for the feedback | 13:46 |
gibi | dansmith: so during minor upgrade we allow new compute code to run before the conductor is upgraded? | 13:48 |
dansmith | yes, any service in any order | 13:48 |
gibi | that is news for me | 13:49 |
gibi | anyhowe | 13:49 |
dansmith | but as I said on the review, this is really an impedance mismatch between compute and manager, it sounds like, and some refactoring there needs to happen instead of doubling down on the original thing, IMHO | 13:49 |
dansmith | gibi: okay, that's why artom specifically called out minor updates | 13:49 |
dansmith | basically, we expect anyone should be able to "yum upgrade" on any node at any time | 13:49 |
gibi | ack, I learned something new today | 13:50 |
gibi | going back to the original problem | 13:50 |
gibi | I don't know what will break if we remove the mutated migration context from the rollback_live_migration_at_destination call | 13:51 |
gibi | It was added there on purpose as far as I see | 13:51 |
artom | Yeah, it was so that we roll back the stuff claimed on the destination | 13:51 |
dansmith | it's something in driver.destroy() that looks to see if there's a migration context, and does more/less stuff during destroy as a result right? | 13:51 |
artom | Actually, maybe not, ignore me until I look at the code again | 13:52 |
dansmith | as noted, I think that was probably the first bad move | 13:52 |
dansmith | the "temporarily mutate instance so I don't have to change code elsewhere" | 13:53 |
dansmith | ended up having a side-effect that we didn't expect, so more flags to prevent side effects is just compounding the problem :) | 13:53 |
gibi | dansmith: I agree with general idea not to add more flags. So lets see if we can figure out how to untangle what we have | 13:55 |
dansmith | ++ | 13:55 |
gibi | dansmith: if we are already at the problem the follow up patch https://review.opendev.org/c/openstack/nova/+/850746/3 show another occurence of the save under mutated migration context codepath. | 13:58 |
gibi | we call driver.rebuild https://review.opendev.org/c/openstack/nova/+/850746/3 under a mutated context | 13:58 |
kashyap | gibi: Hey, is there some "openstack server show" command to see the machine type configured on the compute node? Or 'grep'ing the nova.conf / `sudo virsh dumpxml $instance` the only way? | 13:58 |
dansmith | gibi: I have to jump on a call, might have a few minutes after before the next one at the top of the next hour | 13:58 |
gibi | and ironic virt driver saves the instance https://review.opendev.org/c/openstack/nova/+/850746/3 | 13:59 |
bauzas | kashyap: you would need to be an admin at least if so | 13:59 |
gibi | dansmith: ack | 13:59 |
gibi | dansmith: no worries | 13:59 |
kashyap | bauzas: Right, let's say admin. Is there an admin Nova command? | 13:59 |
bauzas | this is a conf opt | 13:59 |
bauzas | so this shouldn't be an API extension | 13:59 |
bauzas | in general, we don't want to provide an API for knowing about some config option | 14:00 |
kashyap | bauzas: Right; fair enough | 14:00 |
kashyap | bauzas: Note, this is also a metadata and extra_spec property as well | 14:01 |
kashyap | "this" == guest machine type | 14:01 |
kashyap | bauzas: So if a user configures a Glance image with that image meta property, they should be able to see | 14:03 |
kashyap | bauzas: So, `openstack image show` should show it if a user sets it | 14:05 |
gibi | dansmith: so if you have a minute at some point I summarized my second question here https://review.opendev.org/c/openstack/nova/+/850746/3/nova/compute/manager.py#3797 | 14:06 |
opendevreview | Elod Illes proposed openstack/nova stable/train: DNM: test preinstall of python3-yaml https://review.opendev.org/c/openstack/nova/+/851861 | 14:06 |
gibi | kashyap: while I understand the need to see what machine type an instance uses, I don't think we have a single place we persist it for the insance. I guess we rely on the fact that we can always regenerate the machine type from the flavor + image + compute config. | 14:08 |
kashyap | gibi: Great answer; that's exactly what I'm writing for a (downstream) docs question | 14:09 |
kashyap | It is set via 3 places as you indicate - per-compute host config; flavor extra spec; or an image metada prop | 14:09 |
kashyap | s/metada/metadata/ | 14:09 |
kashyap | gibi: Oh, wait - do we actually support this hw:machine_type" via flavor extra_spec? | 14:16 |
* kashyap looks up | 14:16 | |
gibi | kashyap: I dont see machine_type in https://docs.openstack.org/nova/latest/configuration/extra-specs.html | 14:21 |
kashyap | gibi: Yeah, me neither: so only two ways - compute config; or image meta | 14:21 |
kashyap | gibi: For image, a tenant user should be able to see it via `openstack image show`, right? | 14:22 |
gibi | I think so | 14:23 |
gibi | kashyap: one thing i see is that nova stores the image meta in instance.system_metadata['image_hw_machine_type'] so that even if the image is changed later the instance has its machine type persisted | 14:25 |
kashyap | Yeah, we do store it in system_metadata (Lee did that work) | 14:25 |
gibi | also if an admin want to query the machine_type of an instance then it can be done via nova-manage | 14:26 |
kashyap | https://docs.openstack.org/nova/latest/admin/hw-machine-type.html | 14:26 |
gibi | ack, that is the one | 14:26 |
kashyap | gibi: What about the tenant user? (Perhaps via `openstack image show`? | 14:26 |
gibi | openstack image show only valid the the image properties are not changed after the instance is booted (I'm not sure the image meta could change) | 14:27 |
bauzas | oh the q35 saga | 14:27 |
bauzas | forgot about it | 14:27 |
bauzas | hence the nova-manage command | 14:27 |
* bauzas does 3 different things at the same time :( | 14:27 | |
bauzas | actually, 4 given I reply | 14:27 |
kashyap | gibi: Oh, right: "nova-manage image_property show $instance_uuid $property" | 14:28 |
kashyap | --^ The above is for tenant too, right? | 14:28 |
kashyap | So, it'd be: `nova-manage image_property show $instance_uuid hw_machine_type` | 14:29 |
gibi | the tenant does not have access to nova-manage | 14:31 |
gibi | that is an admin tool | 14:31 |
gibi | afaik | 14:31 |
kashyap | Yes, you're right | 14:31 |
opendevreview | Stanislav Dmitriev proposed openstack/nova master: Add support for sync writes with block migration https://review.opendev.org/c/openstack/nova/+/851892 | 14:39 |
opendevreview | Merged openstack/placement master: doc: Comment out language option https://review.opendev.org/c/openstack/placement/+/844855 | 14:43 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination https://review.opendev.org/c/openstack/nova/+/851832 | 15:00 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | 15:00 |
gibi | artom, dansmith: when the other direction ^^. I don't find anything that breaks when I remove the mutation from rollback_live_migration_at_destination so I did so | 15:01 |
gibi | s/when/went/ | 15:01 |
elodilles | bauzas: are you updating the meeting page right now, or is it OK if i edit it? | 15:12 |
bauzas | elodilles: I'm piling a lot of stuff, please do it by now and then I'll do it | 15:13 |
elodilles | bauzas: ack, one sec | 15:13 |
elodilles | bauzas: done (i tried to be quick :)) | 15:15 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | 15:25 |
bauzas | reminder : nova meeting in 25 mins here | 15:35 |
gibi | stephenfin: if you have time, this makes py310 happy with unittest.mock https://review.opendev.org/c/openstack/nova/+/851445/ | 15:37 |
opendevreview | Merged openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | 15:47 |
Uggla | gibi, maybe dumb question but how do you properly set in instance in "failure" ? | 15:54 |
Uggla | instance.vm_state = vm_states.ERROR and instance.save() ? | 15:57 |
gibi | it depends on where and when the ERROR condition happened | 15:59 |
Uggla | I especially wonder about the error msg. | 15:59 |
gibi | you might need to report error on an instance event | 15:59 |
bauzas | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Aug 2 16:00:04 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
bauzas | hi folks | 16:00 |
Uggla | o/ | 16:00 |
gibi | o/ | 16:00 |
bauzas | ok, let's start so people will join | 16:01 |
ratailor | o/ | 16:01 |
elodilles | o/ | 16:01 |
bauzas | #topic Bugs (stuck/critical) | 16:02 |
bauzas | #info No Critical bug | 16:02 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 11 new untriaged bugs (+1 since the last meeting) | 16:02 |
bauzas | #link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement | 16:02 |
bauzas | I had a small time for looking at the bugs | 16:02 |
bauzas | but I provided an etherpad https://etherpad.opendev.org/p/nova-bug-triage-20220726 | 16:02 |
bauzas | I only triaged two, as at least 3 other bugs need to be looked more | 16:03 |
bauzas | that's it | 16:03 |
opendevreview | Merged openstack/python-novaclient master: Add support for 2.92 : keypair import mandatory https://review.opendev.org/c/openstack/python-novaclient/+/851231 | 16:03 |
bauzas | any bug to discuss ? | 16:03 |
bauzas | btw. I had fun with https://bugs.launchpad.net/nova/+bug/1983263 | 16:04 |
bauzas | looks we only accept Ussuri computes for Ussuri :p | 16:05 |
bauzas | could be a FFU issue :) | 16:05 |
bauzas | just sayin' :) | 16:06 |
bauzas | anyway, moving on | 16:06 |
bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:07 |
bauzas | elodilles: do you want to get the bug baton for this week ? :) | 16:07 |
elodilles | bauzas: yes please! \o/ | 16:08 |
elodilles | :) | 16:08 |
bauzas | suuuuure | 16:08 |
bauzas | #info Next bug baton is passed to elodilles | 16:08 |
bauzas | that's it for bugds | 16:08 |
bauzas | #topic Gate status | 16:08 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:08 |
bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status | 16:08 |
bauzas | #link https://zuul.openstack.org/builds?job_name=tempest-integrated-compute-centos-9-stream&project=openstack%2Fnova&pipeline=periodic-weekly&skip=0 Centos 9 Stream periodic job status | 16:08 |
bauzas | #link https://zuul.opendev.org/t/openstack/builds?job_name=nova-emulation&pipeline=periodic-weekly&skip=0 Emulation periodic job runs | 16:09 |
bauzas | I've look at all of above ^ | 16:09 |
bauzas | looked | 16:09 |
bauzas | no issues I found | 16:09 |
bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:09 |
bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:09 |
bauzas | really, please stop saying 'recheck' | 16:09 |
bauzas | last time, we found 50% nova rechecks that were blind | 16:10 |
bauzas | I mean, 50% of all the nova rechecks | 16:10 |
bauzas | moving on ? | 16:11 |
* bauzas wonders whether people are already on PTO :) | 16:12 | |
gibi | nope | 16:12 |
bauzas | #topic Release Planning | 16:12 |
bauzas | #link https://releases.openstack.org/zed/schedule.html | 16:12 |
bauzas | #info Zed-3 is in 4 weeks | 16:12 |
bauzas | now, hopefully you've seen my email from yesterday | 16:12 |
bauzas | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029789.html | 16:13 |
bauzas | I propose now to look at the etherpad I created | 16:13 |
bauzas | #link https://etherpad.opendev.org/p/nova-zed-microversions-plan | 16:14 |
bauzas | we have 3 open changes asking for a microversion | 16:14 |
bauzas | so I'd like to ask you folks how we could organize and triage those 3 between them for a microversion | 16:15 |
gibi | for me it depends on how close they are to land | 16:16 |
bauzas | two of them were already modified to use 2.92 | 16:17 |
bauzas | so it looks to me both can be priorital | 16:17 |
bauzas | one is touching the /servers API | 16:17 |
bauzas | but only by a single rebuild action | 16:18 |
bauzas | the other one is technically a WIP and adding a new API resource /os-server-shares | 16:18 |
gibi | if the second one is a WIP then I guess the first one has priority: ) | 16:19 |
bauzas | any concerns about this ? | 16:19 |
gibi | but I guess we don't have to decide it now | 16:19 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Fix mocking SafeConnectedTestCase https://review.opendev.org/c/openstack/nova/+/851909 | 16:19 |
bauzas | gibi: well, I would have preferred to have it decided by now | 16:20 |
gibi | sure, then lets decide :) | 16:20 |
bauzas | but it looks that we don't have a lot of folks around | 16:20 |
gibi | anybody has any opinion? | 16:20 |
bauzas | rajat was asking me about this at least loudly | 16:20 |
artom | Decide who gets what microversion? | 16:21 |
bauzas | at least decide who would get 2.93 | 16:21 |
artom | Are all 2 guaranteed (inasmuch as that's possible in upstream world) to land? | 16:21 |
artom | *all 3 | 16:21 |
bauzas | I think we could say yes to https://review.opendev.org/c/openstack/nova/+/816157 | 16:21 |
bauzas | for 2.93 | 16:21 |
bauzas | dansmith already looked at it and it was already around last cycle | 16:22 |
bauzas | but this means we would prioritize this change | 16:22 |
artom | I'd say it's up to the owner and reviwers to determine how close something is to land, and to give the next smallest microversion to the closest, then next closest, and so on | 16:22 |
bauzas | artom: problem is about merge conflicts | 16:23 |
bauzas | at least we have now https://review.opendev.org/c/openstack/nova/+/816157 and https://review.opendev.org/c/openstack/nova/+/830883 that got merge conflicts | 16:23 |
gibi | (probably everything is in merge conflict as unittest.mock change landed) | 16:24 |
bauzas | gibi: and you're just telling me this before I'm going off ? :) | 16:24 |
gibi | bauzas: it is landed yesterday? | 16:24 |
bauzas | haven't seen it then | 16:25 |
gibi | Aug 01 21:07 | 16:25 |
bauzas | anyway | 16:25 |
bauzas | if we don't have consensus, let's just tell the owners they need to provide their changes and ask for reviewes | 16:25 |
bauzas | reviews* | 16:26 |
gibi | Im fine with https://review.opendev.org/c/openstack/nova/+/816157 being the next one | 16:28 |
sean-k-mooney[m] | o/ | 16:28 |
bauzas | gibi: cool, then let's prioritize it | 16:29 |
bauzas | whoami-rajat and Uggla could then modify their change to ask for 2.95 and we'll see in the meantime if jhartkopf can upload his series soon | 16:30 |
bauzas | I'll drop a gerrit comment on https://review.opendev.org/c/openstack/nova/+/816157 telling him to rebase quickly | 16:30 |
bauzas | if he can't, then whoami-rajat could use this API slot | 16:30 |
bauzas | wfy folks ? | 16:31 |
gibi | or they can both rebase to 2.93 and have a race for landing :) | 16:31 |
gibi | both works for me | 16:31 |
whoami-rajat | let me know which one is suitable and i will rebase | 16:31 |
whoami-rajat | s/which/whichever | 16:32 |
bauzas | gibi: yeah, we'll see | 16:34 |
bauzas | it's the first time we're trying to organize API microversions, I guess we don't wanna be too much optimistic | 16:34 |
bauzas | whoami-rajat: I'd say prepare for 2.94 but be ready to propose 2.93 if https://review.opendev.org/c/openstack/nova/+/816157 doesn't get rebased next week | 16:35 |
sean-k-mooney[m] | normally we only do this if they already have at least 1 +2 | 16:35 |
* artom wonders again if it'd be possible to automate that, and whether the effort would be worth it | 16:35 | |
artom | I guess you can't easily template Python code, which we would need | 16:36 |
artom | Otherwise, if we keep a single running counter of source in a file or something, folks can just write %{next_microversion} or similar | 16:36 |
whoami-rajat | ack | 16:36 |
bauzas | I think we're done with this | 16:37 |
bauzas | moving on | 16:37 |
bauzas | #topic Review priorities | 16:37 |
bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B1 | 16:37 |
bauzas | anything to discuss ? | 16:38 |
gibi | bauzas: you need to add OR label+2 | 16:39 |
gibi | as now the query shows only +1 | 16:40 |
gibi | ie | 16:40 |
gibi | https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:40 |
bauzas | wait | 16:40 |
bauzas | bad copy/paste | 16:40 |
bauzas | https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:41 |
bauzas | my query was ok but I pasted the wrong one in the agenda | 16:41 |
gibi | ahh | 16:41 |
gibi | OK | 16:41 |
bauzas | anyway, apart from the mdev issue, I have nothing to say | 16:42 |
bauzas | gibi: you asked for a FUP, I'm trying to upload it before I leave | 16:42 |
gibi | bauzas: OK | 16:42 |
gibi | I will check it tomorrow | 16:42 |
bauzas | if I can't, we'll need billy to write it | 16:42 |
bauzas | moving on then | 16:43 |
gibi | do you know the irc nick of billy? | 16:43 |
bauzas | #topic Stable Branches | 16:43 |
bauzas | gibi: nope | 16:43 |
gibi | :/ | 16:44 |
bauzas | #undo | 16:44 |
opendevmeet | Removing item from minutes: #topic Stable Branches | 16:44 |
bauzas | previously we were having quite a roster for asking to get the IRC nick | 16:44 |
gibi | we can move on, I just wanted to ping billy properly | 16:44 |
bauzas | cool | 16:45 |
bauzas | #topic Stable Branches | 16:45 |
bauzas | elodilles: your turn | 16:45 |
elodilles | yes | 16:45 |
elodilles | #info stable/pike was EOL'd for nova projects | 16:45 |
elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:46 |
elodilles | #info stable/train (and older) is blocked, see details in the etherpad ^^^ | 16:46 |
elodilles | some extra info for the blocker: | 16:46 |
elodilles | i did what sean-k-mooney[m] suggested and added a pre-yaml, | 16:46 |
elodilles | that installs python3-yaml which gets stuck originally, | 16:47 |
elodilles | and it installs fine with the pre.yaml, | 16:47 |
sean-k-mooney[m] | did that work | 16:47 |
sean-k-mooney[m] | cool | 16:47 |
elodilles | but then something else gets stuck :/ | 16:47 |
sean-k-mooney[m] | :) | 16:47 |
elodilles | so maybe something is crashing in the background... | 16:47 |
sean-k-mooney[m] | is it still glibc? | 16:48 |
sean-k-mooney[m] | or somethign else but ya possibly | 16:48 |
elodilles | anyway, needs further investigation :/ | 16:48 |
sean-k-mooney[m] | ack | 16:48 |
elodilles | sean-k-mooney[m]: something different | 16:48 |
elodilles | sean-k-mooney[m]: now at the ssh keys setup | 16:48 |
elodilles | sean-k-mooney[m]: so seems unrelated from the previous | 16:49 |
sean-k-mooney[m] | ok | 16:49 |
elodilles | i guess something else causing the issue in the background | 16:49 |
elodilles | anyway, that's my info for now :X | 16:49 |
bauzas | ack, thanks | 16:49 |
elodilles | (and still, any help/idea is welcome o:)) | 16:50 |
bauzas | I wish I could, but I'll be off | 16:51 |
bauzas | last topic I guess | 16:51 |
bauzas | #topic Open discussion | 16:51 |
bauzas | I have nothing on the agenda, except reminding that I'll be on PTO until August 29th (included) | 16:52 |
gibi | have a nice PTO | 16:52 |
gibi | I will try to run the meetings in the intermi | 16:52 |
bauzas | I could be around tho, probably tomorrow evening and on monday before I restart | 16:52 |
bauzas | at least for checking the 25k emails I should get during my vacation period | 16:53 |
bauzas | that's all I had, anything else people wanted to discuss ? | 16:53 |
gibi | - | 16:53 |
bauzas | if so | 16:54 |
bauzas | thanks all | 16:54 |
bauzas | #endmeeting | 16:54 |
opendevmeet | Meeting ended Tue Aug 2 16:54:27 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:54 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.html | 16:54 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.txt | 16:54 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-02-16.00.log.html | 16:54 |
elodilles | bauzas: have a nice time off o/ | 16:54 |
gibi | sean-k-mooney[m], bauzas: could you push through https://review.opendev.org/q/topic:os-traits-2.8.0 ? welcome back tonyb! | 16:54 |
Uggla | bauzas, have a nice PTO. | 16:54 |
sean-k-mooney[m] | oh right placment | 16:55 |
sean-k-mooney[m] | ya | 16:55 |
sean-k-mooney[m] | ill review tose now | 16:55 |
gibi | thanks | 16:55 |
sean-k-mooney[m] | do we want to reenabel the test or jsut leave it disabled | 16:57 |
sean-k-mooney[m] | i +w'd the frist patch | 16:57 |
sean-k-mooney[m] | so the requreiment patch should be unblocked | 16:57 |
auniyal | Please review this- | 17:00 |
auniyal | https://review.opendev.org/c/openstack/nova/+/851511 | 17:00 |
auniyal | https://review.opendev.org/c/openstack/nova/+/848886 | 17:00 |
gibi | sean-k-mooney[m]: lets reenable it. I think we need to move that test to python from gabbi | 17:02 |
sean-k-mooney[m] | ok we can do that as a followup | 17:03 |
sean-k-mooney[m] | ill approve renableing it so | 17:03 |
gibi | thanks I will try to do the move tomorrow | 17:03 |
sean-k-mooney[m] | before you drop | 17:04 |
sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/832330 | 17:04 |
sean-k-mooney[m] | can you add that to your review list | 17:04 |
sean-k-mooney[m] | stephenfin: ^ i added the doc you asked for by the way | 17:04 |
sean-k-mooney[m] | ill try and work on the rest of the chain later this week | 17:04 |
stephenfin | gibi: Done (the double mocking patch) | 17:04 |
stephenfin | sean-k-mooney[m]: thanks | 17:05 |
sean-k-mooney[m] | oh the doble mocking patch is up for review | 17:05 |
bauzas | gibi: I'm about to give it up for the FUP but I found https://launchpad.net/~billy-olsen | 17:30 |
opendevreview | Stanislav Dmitriev proposed openstack/nova master: Add support for sync writes with block migration https://review.opendev.org/c/openstack/nova/+/851892 | 17:42 |
opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Stop using mdev_name2uuid and fix mdev recreation https://review.opendev.org/c/openstack/nova/+/851924 | 18:15 |
bauzas | gibi: https://review.opendev.org/c/openstack/nova/+/851924 is the FUP I started to write | 18:15 |
*** bauzas is now known as bauzas_away | 18:17 | |
*** kopecmartin_ is now known as kopecmartin | 19:09 | |
opendevreview | Artom Lifshitz proposed openstack/nova master: Update libvirt enlightenments for Windows https://review.opendev.org/c/openstack/nova/+/847641 | 20:07 |
opendevreview | Merged openstack/placement master: disable traits count check to allow os-traits 2.8.0 https://review.opendev.org/c/openstack/placement/+/851792 | 20:24 |
opendevreview | Merged openstack/nova master: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/849104 | 20:24 |
opendevreview | Merged openstack/nova master: Remove double mocking https://review.opendev.org/c/openstack/nova/+/851445 | 20:24 |
opendevreview | Merged openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/c/openstack/nova/+/708768 | 20:25 |
opendevreview | Artom Lifshitz proposed openstack/nova master: Update libvirt enlightenments for Windows https://review.opendev.org/c/openstack/nova/+/847641 | 20:48 |
opendevreview | Merged openstack/placement master: Update placement for os-traits 2.8.0 release https://review.opendev.org/c/openstack/placement/+/851793 | 21:04 |
*** dasm is now known as dasm|off | 21:09 | |
opendevreview | melanie witt proposed openstack/nova master: block_device_info: Add swap to inline https://review.opendev.org/c/openstack/nova/+/826523 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Improve creating images INFO log https://review.opendev.org/c/openstack/nova/+/826524 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Remove defunct comment https://review.opendev.org/c/openstack/nova/+/826525 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: imagebackend: Cache the key manager when disk is encrypted https://review.opendev.org/c/openstack/nova/+/826756 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | 21:33 |
tonyb | gibi: it's wonderful to be back. I see that some of the patches have landed. I'll check on the progress after coffee | 22:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!