opendevreview | wangjiaqi proposed openstack/os-vif master: remove unicode from code https://review.opendev.org/c/openstack/os-vif/+/854486 | 03:26 |
---|---|---|
opendevreview | Ke Niu proposed openstack/os-vif master: remove unicode prefix from code https://review.opendev.org/c/openstack/os-vif/+/854488 | 03:31 |
opendevreview | Ke Niu proposed openstack/os-vif master: remove unicode prefix from code https://review.opendev.org/c/openstack/os-vif/+/854488 | 03:32 |
opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | 05:18 |
opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | 05:18 |
gmann | sean-k-mooney: ack | 05:44 |
gibi | good morning | 07:16 |
auniyal__ | Hi sean-k-mooney, gibi | 07:25 |
auniyal__ | can you please review these | 07:25 |
auniyal__ | https://review.opendev.org/c/openstack/nova/+/852171 | 07:25 |
auniyal__ | https://review.opendev.org/c/openstack/nova/+/853811 | 07:25 |
auniyal__ | https://review.opendev.org/c/openstack/nova/+/853812 | 07:26 |
gibi | auniyal__: sorry, I have to take these later due to the looming featur freeze deadline | 07:58 |
gibi | sean-k-mooney: I have to rebase the PCI series as I have a merge conflict in the middle. I will do this quickly but if you in the middle of the review then let me know to hold it | 07:58 |
auniyal__ | gibi, these 2 are already reviewed, need to backport - https://review.opendev.org/c/openstack/nova/+/853811, https://review.opendev.org/c/openstack/nova/+/853812 | 08:07 |
gibi | auniyal__: ack, I will try, but no promises :) | 08:08 |
auniyal__ | okay | 08:08 |
gibi | brace for impact | 08:09 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1986838 https://review.opendev.org/c/openstack/nova/+/853516 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Trigger reschedule if PCI consumption fail on compute https://review.opendev.org/c/openstack/nova/+/853611 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize https://review.opendev.org/c/openstack/nova/+/852396 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Generate request_id for Flavor based InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/853835 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Create RequestGroups from InstancePCIRequests https://review.opendev.org/c/openstack/nova/+/852771 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support move operations with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | 08:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | 08:10 |
gibi | poor zuul :/ | 08:10 |
gibi | stephenfin: if you have time the first two patches in the PCI series (a bugfix) needs a second core. mergeing that will also trigger of merging many patches from the PCI series already have 2 +2sx | 08:12 |
opendevreview | Merged openstack/nova master: Keep legacy admin behaviour in new RBAC https://review.opendev.org/c/openstack/nova/+/849209 | 09:12 |
auniyal__ | In devstack, is there a way to save all logs in file automatically | 09:29 |
auniyal__ | so right now we use journalctl -f -u devstack@n-* to see logs, can we do configuration so logs can get saved in /var/logs like openstack full deployment (canonical one, non-devstack) setup ? | 09:31 |
opendevreview | Jan Hartkopf proposed openstack/os-traits master: add new trait for config drive regeneration https://review.opendev.org/c/openstack/os-traits/+/854599 | 09:47 |
opendevreview | Jan Hartkopf proposed openstack/os-traits master: add new trait for config drive regeneration https://review.opendev.org/c/openstack/os-traits/+/854599 | 09:58 |
sean-k-mooney | stephenfin: im +w up until https://review.opendev.org/c/openstack/nova/+/850546/8 if you are happy with the first two patches https://review.opendev.org/c/openstack/nova/+/853516/2 and https://review.opendev.org/c/openstack/nova/+/853611/4 that will send 11 of ther remianing 27 into the gate queue. | 11:30 |
sean-k-mooney | im going to switch to melwitt's ephmeral encryption sereise for a bit but ill check back with the pci seriese later today | 11:31 |
gibi | sean-k-mooney: thanks | 11:38 |
gibi | sean-k-mooney: resize evac unshelve works locall and I'm finishing up resize to same host now | 11:38 |
gibi | same host resize is a b*tch | 11:39 |
sean-k-mooney | ack ya that can be a bit of a pain. are you going to use the falvor uuid in requester_id to correalte the allcoatiosn/devices | 11:39 |
sean-k-mooney | or that is not needed | 11:39 |
gibi | not needed | 11:40 |
sean-k-mooney | ack | 11:40 |
gibi | I needed to depend on the rt.tracked_migrations dict though | 11:40 |
gibi | to detect same host resize during placement update | 11:40 |
sean-k-mooney | ok you shoudl have access to that i guess | 11:41 |
gibi | yes | 11:41 |
sean-k-mooney | since the pci/placment stuff is happening in the compute manager | 11:41 |
gibi | it is happening in the rt | 11:41 |
sean-k-mooney | i dont think we have access to that in the driver do we? | 11:41 |
sean-k-mooney | the resouce tracker | 11:41 |
gibi | no we don't in the driver | 11:41 |
sean-k-mooney | ya thats what i tought ok so you need that in the move claim code? | 11:41 |
sean-k-mooney | i can just review the patch when you push it too | 11:42 |
sean-k-mooney | but i assume its needed to correctly figure out what devices to use | 11:42 |
gibi | it is needed to ignore devices where dev.instance_uuid is our instance but actually the dev is part of the source host allocation | 11:43 |
sean-k-mooney | ack ya i assumed it was somethign like that | 11:44 |
sean-k-mooney | do you also need it for the revert path | 11:44 |
gibi | yes | 11:45 |
gibi | in the drop migration claim | 11:45 |
sean-k-mooney | ya to free only the "dest" pci devices | 11:45 |
gibi | this is the same host resize fix without revert support https://review.opendev.org/c/openstack/nova/+/854441/2/nova/compute/resource_tracker.py | 11:45 |
gibi | the revert support is just passed locally | 11:45 |
gibi | btw, only the allocation healing needed tuning due to same host | 11:46 |
gibi | as it tried to heal allocation for the source devs | 11:46 |
gibi | the actual scheduling and claim code was OK | 11:46 |
sean-k-mooney | well the claim code shoudl be common for the placment/non placment workflows | 11:47 |
sean-k-mooney | and same hsot resize works for pci deivces in general | 11:47 |
sean-k-mooney | although i still suspect that bug you found with multiple alaises | 11:47 |
sean-k-mooney | coudl have causes some odd behaivor | 11:47 |
gibi | yes | 11:47 |
sean-k-mooney | but ya that makes sense that it woudl only be the allocations code that need tweaking | 11:48 |
gibi | and the allocation healing will go away after the upgrade | 11:48 |
gibi | as the scheduler will create proper allocations for new instances and new moves | 11:48 |
gibi | so all the allocation healing code is temporary until AA/BB | 11:49 |
gibi | so while same host needed a special case there, that special casing can be removed later | 11:49 |
sean-k-mooney | technially i think we could drop it in AA but we might want to kep it to BB | 11:49 |
gibi | it depends on how the neutron based sriov impl comes along | 11:50 |
gibi | as healing is needed there too | 11:50 |
sean-k-mooney | ya | 11:50 |
sean-k-mooney | so BB at the earlist then | 11:50 |
sean-k-mooney | we woudl have to deprecate the non placment path | 11:50 |
sean-k-mooney | in AA if we wanted to drop this in BB | 11:50 |
sean-k-mooney | so maybe even later | 11:51 |
gibi | yeah | 11:51 |
gibi | I think so | 11:51 |
sean-k-mooney | by the way i said i woudl reviwe the ephmeral encyption next but i started with the viommu seriese instad so ill finish that then swap | 12:00 |
sean-k-mooney | i +2 the new os-traits trait for config drive by the way | 12:00 |
sean-k-mooney | so if you can review that too we can mege it and get another release done today | 12:01 |
sean-k-mooney | before non client lib freeze | 12:01 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | 12:06 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | 12:06 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | 12:06 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | 12:06 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | 12:06 |
sean-k-mooney | gibi: can you look at https://review.opendev.org/c/openstack/os-traits/+/854599 | 12:07 |
gibi | yes I will today | 12:07 |
opendevreview | Merged openstack/nova master: Reproduce bug 1986838 https://review.opendev.org/c/openstack/nova/+/853516 | 12:23 |
*** tosky_ is now known as tosky | 12:25 | |
opendevreview | Merged openstack/os-traits master: add new trait for config drive regeneration https://review.opendev.org/c/openstack/os-traits/+/854599 | 12:27 |
sean-k-mooney | ricolin: i just reviewed the iommu seriese https://review.opendev.org/q/topic:bp%252Fvirtual-iommu-support | 12:39 |
sean-k-mooney | ricolin: +2 on the first patch and -2 on the last two | 12:39 |
sean-k-mooney | *-1 | 12:39 |
sean-k-mooney | the second patch is very close | 12:40 |
sean-k-mooney | the final patch need to be redone based on the libvirt version not using data that wont exsits with real libvirt | 12:40 |
* gibi will propose an os-traits release | 12:41 | |
sean-k-mooney | ricolin: ill take a look again next week if you respine them but feel free to ping me when thery are ready | 12:41 |
sean-k-mooney | gibi: ack as release liason i can provie the ptl ack once its proposed | 12:42 |
gibi | cool | 12:42 |
sean-k-mooney | did we relax the placement checks | 12:42 |
sean-k-mooney | or rather merge your patch to do that | 12:43 |
sean-k-mooney | or will this break placment again | 12:43 |
gibi | good question | 12:45 |
gibi | looking | 12:45 |
gibi | we merged https://review.opendev.org/c/openstack/placement/+/851966 that changed the testing strategy | 12:46 |
gibi | so the new os-traits should not break the placement tests | 12:47 |
sean-k-mooney | cool | 12:47 |
gibi | release patch is up https://review.opendev.org/c/openstack/releases/+/854617 | 12:48 |
sean-k-mooney | hum it proably coudl have been 2.8.1 but im ok with this i guess | 12:50 |
gibi | it is not a bugfix | 12:52 |
sean-k-mooney | ya but adding a constnat is not really a feature either | 12:52 |
sean-k-mooney | im +1 on it in any case | 12:53 |
sean-k-mooney | so the bot shoudl addd the ptl approved flag soon | 12:53 |
gibi | thanks | 12:53 |
sean-k-mooney | feature bumps are what we did in the past anyway | 12:53 |
sean-k-mooney | so your being consitnet with that | 12:53 |
gibi | ... it tells a lot that our func test helper mixin does help testing server multicreate :) | 13:13 |
gibi | but it wont stop me | 13:13 |
gibi | that is the last item on the PCI bucket list (as revert resize and rescheduler seems to work) | 13:14 |
*** dasm|off is now known as dasm | 13:31 | |
sean-k-mooney | ack. i think punting multi create is vaild given the know issue there if it comes to that | 13:38 |
opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | 13:39 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | 13:47 |
gibi | sean-k-mooney: ack, I give it a try but I will limit the effort | 13:47 |
sean-k-mooney | given its an exsiting limiation for ports with resouce request or any other usage of nested resouce providers i think its accpatble to adress this genericaly in a future release. | 13:50 |
sean-k-mooney | and posibly even backport it as its a know bug/limiation depending on what the fix looks like | 13:51 |
opendevreview | Arnaud Morin proposed openstack/nova master: Allow plugging port when device_id is instance_id https://review.opendev.org/c/openstack/nova/+/854627 | 13:53 |
sean-k-mooney | so hard no on ^ | 13:53 |
sean-k-mooney | #right | 13:53 |
amorin | hello | 13:54 |
sean-k-mooney | o/ | 13:54 |
sean-k-mooney | amorin: we do not want to supprot that workflow | 13:54 |
sean-k-mooney | its not a bug or oversite | 13:54 |
amorin | I am talking about this on neutron side | 13:54 |
sean-k-mooney | its intentoally not supproted | 13:54 |
amorin | why so? | 13:55 |
sean-k-mooney | for one it wont work for sriov type ports | 13:56 |
sean-k-mooney | it also wont populate teh virtual interfaces table correctly | 13:56 |
sean-k-mooney | in the nova cell db | 13:56 |
sean-k-mooney | and it has the potential to bypass some of our current polciy seeitngs | 13:56 |
sean-k-mooney | amorin: so this is not supproted the only way to attach or detach an inteface form a nova instance is via the nova api | 13:57 |
amorin | actually, I mostly agree with you, but we will need to talk with neutron then | 13:57 |
sean-k-mooney | yes we need to make the device_id field admin only | 13:57 |
sean-k-mooney | it will be a topic at the next ptg | 13:57 |
amorin | agree | 13:57 |
amorin | ok nice | 13:57 |
amorin | is it officially in the agenda? | 13:57 |
sean-k-mooney | am i dont think we have an adgenda for the corss project sessions yet | 13:58 |
sean-k-mooney | if not feel free to add it | 13:58 |
sean-k-mooney | gibi: do we have an etherpad yet | 13:58 |
amorin | perfect, is the etherpad already created? | 13:58 |
gibi | sean-k-mooney: good question | 13:58 |
sean-k-mooney | we had https://etherpad.opendev.org/p/nova-ptg-columbus-ops-presence | 13:59 |
sean-k-mooney | but i dont think we create the nova one yet | 13:59 |
gibi | I don't find it | 13:59 |
gibi | so I guess you are right we haven't created one yert | 13:59 |
sean-k-mooney | amorin: we did not know the name of the release when sylvain went on PTO | 13:59 |
sean-k-mooney | so i dont think we have one yet | 14:00 |
amorin | ack, no hurries here | 14:00 |
amorin | we can keep the review open until we fill the PTG etherpad then? | 14:00 |
sean-k-mooney | sure | 14:04 |
sean-k-mooney | i also added some more context to my -2 | 14:05 |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/854627/1#message-f3f27942e7252b5c074a3e95b2d09521d5187d3e | 14:05 |
sean-k-mooney | so that shoudl help set the stage for this with neutron | 14:05 |
amorin | ack, will go tomorrow on neutron-driver with your comment as argument | 14:06 |
opendevreview | Takashi Natsume proposed openstack/nova master: Add missing descriptions in HACKING.rst https://review.opendev.org/c/openstack/nova/+/853054 | 14:10 |
*** tosky is now known as Guest1129 | 15:12 | |
*** tosky_ is now known as tosky | 15:12 | |
opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | 16:08 |
opendevreview | Takashi Natsume proposed openstack/nova master: Add a hacking rule for the setDaemon method https://review.opendev.org/c/openstack/nova/+/854653 | 16:22 |
gibi | sean-k-mooney: re multi create: I think it works with PCI in placement. I had to fix how we generate the Selection objects as they were not aware of the fact the the scheduler already allocated some resources in placement. | 16:57 |
gibi | the re-used the same allocation request | 16:58 |
gibi | *the selection generation | 16:58 |
gibi | anyhow I think it works now | 16:59 |
gibi | so I'm happy :) | 16:59 |
sean-k-mooney | ok thats good news | 17:21 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | 17:23 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | 17:23 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | 17:43 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.power_on_error notification https://review.opendev.org/c/openstack/nova/+/852084 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.power_off_error notification https://review.opendev.org/c/openstack/nova/+/852278 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | 17:44 |
opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.93 https://review.opendev.org/c/openstack/nova/+/852088 | 17:44 |
opendevreview | Merged openstack/nova master: Trigger reschedule if PCI consumption fail on compute https://review.opendev.org/c/openstack/nova/+/853611 | 18:06 |
*** kopecmartin is now known as kopecmartin|pto | 18:57 | |
*** ianw_ is now known as ianw | 20:37 | |
*** tosky_ is now known as tosky | 22:06 | |
*** dasm is now known as dasm|off | 22:32 | |
opendevreview | Merged openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | 22:33 |
opendevreview | Merged openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | 22:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!