Thursday, 2022-08-25

opendevreviewwangjiaqi proposed openstack/os-vif master: remove unicode from code  https://review.opendev.org/c/openstack/os-vif/+/85448603:26
opendevreviewKe Niu proposed openstack/os-vif master: remove unicode prefix from code  https://review.opendev.org/c/openstack/os-vif/+/85448803:31
opendevreviewKe Niu proposed openstack/os-vif master: remove unicode prefix from code  https://review.opendev.org/c/openstack/os-vif/+/85448803:32
opendevreviewAmit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration  https://review.opendev.org/c/openstack/nova/+/79113505:18
opendevreviewAmit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail  https://review.opendev.org/c/openstack/nova/+/85449905:18
gmannsean-k-mooney: ack05:44
gibigood morning07:16
auniyal__Hi sean-k-mooney, gibi 07:25
auniyal__can you please review these07:25
auniyal__https://review.opendev.org/c/openstack/nova/+/85217107:25
auniyal__https://review.opendev.org/c/openstack/nova/+/85381107:25
auniyal__https://review.opendev.org/c/openstack/nova/+/85381207:26
gibiauniyal__: sorry, I have to take these later due to the looming featur freeze deadline07:58
gibisean-k-mooney: I have to rebase the PCI series as I have a merge conflict in the middle. I will do this quickly but if you in the middle of the review then let me know to hold it07:58
auniyal__gibi, these 2 are already reviewed, need to backport - https://review.opendev.org/c/openstack/nova/+/853811, https://review.opendev.org/c/openstack/nova/+/85381208:07
gibiauniyal__: ack, I will try, but no promises :)08:08
auniyal__okay 08:08
gibibrace for impact08:09
opendevreviewBalazs Gibizer proposed openstack/nova master: Reproduce bug 1986838  https://review.opendev.org/c/openstack/nova/+/85351608:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Trigger reschedule if PCI consumption fail on compute  https://review.opendev.org/c/openstack/nova/+/85361108:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting  https://review.opendev.org/c/openstack/nova/+/84618708:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits  https://review.opendev.org/c/openstack/nova/+/84621808:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject PCI dependent device config  https://review.opendev.org/c/openstack/nova/+/84643508:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config  https://review.opendev.org/c/openstack/nova/+/84643608:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag  https://review.opendev.org/c/openstack/nova/+/84621908:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject devname based device_spec config  https://review.opendev.org/c/openstack/nova/+/84646608:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration  https://review.opendev.org/c/openstack/nova/+/84647008:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before  https://review.opendev.org/c/openstack/nova/+/84700908:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider  https://review.opendev.org/c/openstack/nova/+/85054608:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict  https://review.opendev.org/c/openstack/nova/+/85135808:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker  https://review.opendev.org/c/openstack/nova/+/85135908:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize  https://review.opendev.org/c/openstack/nova/+/85239608:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations  https://review.opendev.org/c/openstack/nova/+/85239708:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement  https://review.opendev.org/c/openstack/nova/+/85046808:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Generate request_id for Flavor based InstancePCIRequest  https://review.opendev.org/c/openstack/nova/+/85383508:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Create RequestGroups from InstancePCIRequests  https://review.opendev.org/c/openstack/nova/+/85277108:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias  https://review.opendev.org/c/openstack/nova/+/85331608:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Split PCI pools per PF  https://review.opendev.org/c/openstack/nova/+/85444008:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs  https://review.opendev.org/c/openstack/nova/+/85411808:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters  https://review.opendev.org/c/openstack/nova/+/85411908:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation  https://review.opendev.org/c/openstack/nova/+/85412008:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest  https://review.opendev.org/c/openstack/nova/+/85412108:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling  https://review.opendev.org/c/openstack/nova/+/85412208:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Support move operations with PCI tracking in placement  https://review.opendev.org/c/openstack/nova/+/85424708:10
opendevreviewBalazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85444108:10
gibipoor zuul :/08:10
gibistephenfin: if you have time the first two patches in the PCI series (a bugfix) needs a second core. mergeing that will also trigger of merging many patches from the PCI series already have 2 +2sx08:12
opendevreviewMerged openstack/nova master: Keep legacy admin behaviour in new RBAC  https://review.opendev.org/c/openstack/nova/+/84920909:12
auniyal__In devstack, is there a way to save all logs in file automatically 09:29
auniyal__so right now we use journalctl -f -u devstack@n-* to see logs, can we do configuration so logs can get saved in /var/logs like openstack full deployment (canonical one, non-devstack) setup ?09:31
opendevreviewJan Hartkopf proposed openstack/os-traits master: add new trait for config drive regeneration  https://review.opendev.org/c/openstack/os-traits/+/85459909:47
opendevreviewJan Hartkopf proposed openstack/os-traits master: add new trait for config drive regeneration  https://review.opendev.org/c/openstack/os-traits/+/85459909:58
sean-k-mooneystephenfin: im +w up until https://review.opendev.org/c/openstack/nova/+/850546/8 if you are happy with the first two patches https://review.opendev.org/c/openstack/nova/+/853516/2 and https://review.opendev.org/c/openstack/nova/+/853611/4 that will send 11 of ther remianing 27 into the gate queue.11:30
sean-k-mooneyim going to switch to melwitt's ephmeral encryption sereise for a bit but ill check back with the pci seriese later today11:31
gibisean-k-mooney: thanks11:38
gibisean-k-mooney: resize evac unshelve works locall and I'm finishing up resize to same host now11:38
gibisame host resize is a b*tch11:39
sean-k-mooneyack ya that can be a bit of a pain. are you going to use the falvor uuid in requester_id to correalte the allcoatiosn/devices11:39
sean-k-mooneyor that is not needed11:39
gibinot needed11:40
sean-k-mooneyack11:40
gibiI needed to depend on the rt.tracked_migrations dict though11:40
gibito detect same host resize during placement update11:40
sean-k-mooneyok you shoudl have access to that i guess11:41
gibiyes11:41
sean-k-mooneysince the pci/placment stuff is happening in the compute manager11:41
gibiit is happening in the rt11:41
sean-k-mooneyi dont think we have access to that in the driver do we?11:41
sean-k-mooneythe resouce tracker11:41
gibino we don't in the driver11:41
sean-k-mooneyya thats what i tought ok so you need that in the move claim code?11:41
sean-k-mooneyi can just review the patch when you push it too11:42
sean-k-mooneybut i assume its needed to correctly figure out what devices to use11:42
gibiit is needed to ignore devices where dev.instance_uuid is our instance but actually the dev is part of the source host allocation11:43
sean-k-mooneyack ya i assumed it was somethign like that11:44
sean-k-mooneydo you also need it for the revert path11:44
gibiyes11:45
gibiin the drop migration claim11:45
sean-k-mooneyya to free only the "dest" pci devices11:45
gibithis is the same host resize fix without revert support https://review.opendev.org/c/openstack/nova/+/854441/2/nova/compute/resource_tracker.py11:45
gibithe revert support is just passed locally11:45
gibibtw, only the allocation healing needed tuning due to same host11:46
gibias it tried to heal allocation for the source devs11:46
gibithe actual scheduling and claim code was OK11:46
sean-k-mooney well the claim code shoudl be common for the placment/non placment workflows11:47
sean-k-mooneyand same hsot resize works for pci deivces in general11:47
sean-k-mooneyalthough i still suspect that bug you found with multiple alaises 11:47
sean-k-mooneycoudl have causes some odd behaivor11:47
gibiyes11:47
sean-k-mooneybut ya that makes sense that it woudl only be the allocations code that need tweaking11:48
gibiand the allocation healing will go away after the upgrade11:48
gibias the scheduler will create proper allocations for new instances and new moves11:48
gibiso all the allocation healing code is temporary until AA/BB 11:49
gibiso while same host needed a special case there, that special casing can be removed later11:49
sean-k-mooneytechnially i think we could drop it in AA but we might want to kep it to BB11:49
gibiit depends on how the neutron based sriov impl comes along11:50
gibias healing is needed there too11:50
sean-k-mooneyya 11:50
sean-k-mooneyso BB at the earlist then 11:50
sean-k-mooneywe woudl have to deprecate the non placment path11:50
sean-k-mooneyin AA if we wanted to drop this in BB11:50
sean-k-mooneyso maybe even later11:51
gibiyeah11:51
gibiI think so11:51
sean-k-mooneyby the way i said i woudl reviwe the ephmeral encyption next but i started with the viommu seriese instad so ill finish that then swap12:00
sean-k-mooneyi +2 the new os-traits trait for config drive by the way12:00
sean-k-mooneyso if you can review that too we can mege it and get another release done today12:01
sean-k-mooneybefore non client lib freeze12:01
opendevreviewBalazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling  https://review.opendev.org/c/openstack/nova/+/85412212:06
opendevreviewBalazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement  https://review.opendev.org/c/openstack/nova/+/85424712:06
opendevreviewBalazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85444112:06
opendevreviewBalazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85461512:06
opendevreviewBalazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85461612:06
sean-k-mooneygibi: can you look at https://review.opendev.org/c/openstack/os-traits/+/85459912:07
gibiyes I will today12:07
opendevreviewMerged openstack/nova master: Reproduce bug 1986838  https://review.opendev.org/c/openstack/nova/+/85351612:23
*** tosky_ is now known as tosky12:25
opendevreviewMerged openstack/os-traits master: add new trait for config drive regeneration  https://review.opendev.org/c/openstack/os-traits/+/85459912:27
sean-k-mooneyricolin: i just reviewed the iommu seriese https://review.opendev.org/q/topic:bp%252Fvirtual-iommu-support12:39
sean-k-mooneyricolin: +2 on the first patch and -2 on the last two12:39
sean-k-mooney*-112:39
sean-k-mooneythe second patch is very close12:40
sean-k-mooneythe final patch need to be redone based on the libvirt version  not using data that wont exsits with real libvirt12:40
* gibi will propose an os-traits release12:41
sean-k-mooneyricolin: ill take a look again next week if you respine them but feel free to ping me when thery are ready12:41
sean-k-mooneygibi: ack as release liason i can provie the ptl ack once its proposed12:42
gibicool12:42
sean-k-mooneydid we relax the placement checks 12:42
sean-k-mooneyor rather merge your patch to do that12:43
sean-k-mooneyor will this break placment again12:43
gibigood question12:45
gibilooking12:45
gibiwe merged https://review.opendev.org/c/openstack/placement/+/851966 that changed the testing strategy12:46
gibiso the new os-traits should not break the placement tests12:47
sean-k-mooneycool12:47
gibirelease patch is up https://review.opendev.org/c/openstack/releases/+/85461712:48
sean-k-mooneyhum it proably coudl have been 2.8.1 but im ok with this i guess12:50
gibiit is not a bugfix12:52
sean-k-mooneyya but adding a constnat is not really a feature either12:52
sean-k-mooneyim +1 on it in any case12:53
sean-k-mooneyso the bot shoudl addd the ptl approved flag soon12:53
gibithanks12:53
sean-k-mooneyfeature bumps are what we did in the past anyway12:53
sean-k-mooneyso your being consitnet with that12:53
gibi... it tells a lot that our func test helper mixin does help testing server multicreate :)13:13
gibibut it wont stop me13:13
gibithat is the last item on the PCI bucket list (as revert resize and rescheduler seems to work)13:14
*** dasm|off is now known as dasm13:31
sean-k-mooneyack. i think punting multi create is vaild given the know issue there if it comes to that13:38
opendevreviewRajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance  https://review.opendev.org/c/openstack/nova/+/85273713:39
opendevreviewBalazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85462613:47
gibisean-k-mooney: ack, I give it a try but I will limit the effort13:47
sean-k-mooneygiven its an exsiting limiation for ports with resouce request or any other usage of nested resouce providers i think its accpatble to adress this genericaly in a future release.13:50
sean-k-mooneyand posibly even backport it as its a know bug/limiation depending on what the fix looks like13:51
opendevreviewArnaud Morin proposed openstack/nova master: Allow plugging port when device_id is instance_id  https://review.opendev.org/c/openstack/nova/+/85462713:53
sean-k-mooneyso hard no on ^13:53
sean-k-mooney#right13:53
amorinhello13:54
sean-k-mooneyo/13:54
sean-k-mooneyamorin: we do not want to supprot that workflow13:54
sean-k-mooneyits not a bug or oversite 13:54
amorinI am talking about this on neutron side13:54
sean-k-mooneyits intentoally not supproted13:54
amorinwhy so?13:55
sean-k-mooneyfor one it wont work for sriov type ports13:56
sean-k-mooneyit also wont populate teh virtual interfaces table correctly13:56
sean-k-mooneyin the nova cell db13:56
sean-k-mooneyand  it has the potential to bypass some of our current polciy seeitngs13:56
sean-k-mooneyamorin: so this is not supproted the only way to attach or detach an inteface form a nova instance is via the nova api13:57
amorinactually, I mostly agree with you, but we will need to talk with neutron then13:57
sean-k-mooneyyes we need to make the device_id field admin only13:57
sean-k-mooneyit will be a topic at the next ptg13:57
amorinagree13:57
amorinok nice13:57
amorinis it officially in the agenda?13:57
sean-k-mooneyam i dont think we have an adgenda for the corss project sessions yet13:58
sean-k-mooneyif not feel free to add it13:58
sean-k-mooneygibi: do we have an etherpad yet13:58
amorinperfect, is the etherpad already created?13:58
gibisean-k-mooney: good question13:58
sean-k-mooneywe had https://etherpad.opendev.org/p/nova-ptg-columbus-ops-presence13:59
sean-k-mooneybut i dont think we create the nova one yet13:59
gibiI don't find it13:59
gibiso I guess you are right we haven't created one yert13:59
sean-k-mooneyamorin: we did not know the name of the release when sylvain went on PTO13:59
sean-k-mooneyso i dont think we have one yet14:00
amorinack, no hurries here14:00
amorinwe can keep the review open until we fill the PTG etherpad then?14:00
sean-k-mooneysure14:04
sean-k-mooneyi also added some more context to my -214:05
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/854627/1#message-f3f27942e7252b5c074a3e95b2d09521d5187d3e14:05
sean-k-mooneyso that shoudl help set the stage for this with neutron14:05
amorinack, will go tomorrow on neutron-driver with your comment as argument14:06
opendevreviewTakashi Natsume proposed openstack/nova master: Add missing descriptions in HACKING.rst  https://review.opendev.org/c/openstack/nova/+/85305414:10
*** tosky is now known as Guest112915:12
*** tosky_ is now known as tosky15:12
opendevreviewRajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance  https://review.opendev.org/c/openstack/nova/+/85273716:08
opendevreviewTakashi Natsume proposed openstack/nova master: Add a hacking rule for the setDaemon method  https://review.opendev.org/c/openstack/nova/+/85465316:22
gibisean-k-mooney: re multi create: I think it works with PCI in placement. I had to fix how we generate the Selection objects as they were not aware of the fact the the scheduler already allocated some resources in placement. 16:57
gibithe re-used the same allocation request16:58
gibi*the selection generation16:58
gibianyhow I think it works now16:59
gibiso I'm happy :)16:59
sean-k-mooneyok thats good news17:21
opendevreviewBalazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85462617:23
opendevreviewBalazs Gibizer proposed openstack/nova master: Support multi create with PCI in placement  https://review.opendev.org/c/openstack/nova/+/85466317:23
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db)  https://review.opendev.org/c/openstack/nova/+/83119317:43
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects)  https://review.opendev.org/c/openstack/nova/+/83940117:44
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction)  https://review.opendev.org/c/openstack/nova/+/83119417:44
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part)  https://review.opendev.org/c/openstack/nova/+/83309017:44
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api)  https://review.opendev.org/c/openstack/nova/+/83683017:44
opendevreviewribaudr proposed openstack/nova master: Bump compute version and check shares support  https://review.opendev.org/c/openstack/nova/+/85049917:44
opendevreviewribaudr proposed openstack/nova master: Add metadata for shares  https://review.opendev.org/c/openstack/nova/+/85050017:44
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach notification  https://review.opendev.org/c/openstack/nova/+/85050117:44
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach notification  https://review.opendev.org/c/openstack/nova/+/85102817:44
opendevreviewribaudr proposed openstack/nova master: Add shares to InstancePayload  https://review.opendev.org/c/openstack/nova/+/85102917:44
opendevreviewribaudr proposed openstack/nova master: Add instance.power_on_error notification  https://review.opendev.org/c/openstack/nova/+/85208417:44
opendevreviewribaudr proposed openstack/nova master: Add instance.power_off_error notification  https://review.opendev.org/c/openstack/nova/+/85227817:44
opendevreviewribaudr proposed openstack/nova master: Add helper methods to attach/detach shares  https://review.opendev.org/c/openstack/nova/+/85208517:44
opendevreviewribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working.  https://review.opendev.org/c/openstack/nova/+/85208617:44
opendevreviewribaudr proposed openstack/nova master: Add virt/libvirt error test cases  https://review.opendev.org/c/openstack/nova/+/85208717:44
opendevreviewribaudr proposed openstack/nova master: Change microversion to 2.93  https://review.opendev.org/c/openstack/nova/+/85208817:44
opendevreviewMerged openstack/nova master: Trigger reschedule if PCI consumption fail on compute  https://review.opendev.org/c/openstack/nova/+/85361118:06
*** kopecmartin is now known as kopecmartin|pto18:57
*** ianw_ is now known as ianw20:37
*** tosky_ is now known as tosky22:06
*** dasm is now known as dasm|off22:32
opendevreviewMerged openstack/nova master: Basics for PCI Placement reporting  https://review.opendev.org/c/openstack/nova/+/84618722:33
opendevreviewMerged openstack/nova master: Extend device_spec with resource_class and traits  https://review.opendev.org/c/openstack/nova/+/84621822:54

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!