| opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | 00:29 |
|---|---|---|
| *** lbragstad2 is now known as lbragstad | 01:04 | |
| opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | 01:05 |
| *** dasm is now known as Guest1466 | 01:41 | |
| opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | 04:05 |
| gibi | good morning | 07:07 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | 07:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Enable pci in placement feature https://review.opendev.org/c/openstack/nova/+/854925 | 07:39 |
| songwenping | gibi: hi, can we delete the server group policy that is used by the vms? | 08:29 |
| sean-k-mooney | songwenping: not really, you may be able to delete the server group but you will not be able to add those vms to anohter | 08:31 |
| sean-k-mooney | https://docs.openstack.org/api-ref/compute/?expanded=delete-server-group-detail#delete-server-group | 08:31 |
| songwenping | sean-k-mooney: thanks, but this will effect the vm's evacuate and migrate if delete. | 08:33 |
| sean-k-mooney | songwenping: there is an api to delete the server group but just be aware that your exiting instances cand be added to a new server group in the future | 08:33 |
| sean-k-mooney | if you delete the server group all affinity polices associated will be lost | 08:33 |
| songwenping | why donnot we limit the delete? | 08:35 |
| sean-k-mooney | limit the delete? | 08:35 |
| sean-k-mooney | server groups are a normal tenant concept | 08:35 |
| sean-k-mooney | so a project member should be able to create and or delete them | 08:36 |
| sean-k-mooney | why would we limit the delete | 08:36 |
| songwenping | no, if there are vms associated, we cannot delete the group. | 08:36 |
| sean-k-mooney | thats really a teanat choice | 08:37 |
| sean-k-mooney | we could block it | 08:37 |
| sean-k-mooney | but we generally assume our tenant and oeprator are compitent by default | 08:38 |
| sean-k-mooney | which is why we do not block delete falvors that are in user or images | 08:38 |
| sean-k-mooney | deleteing an image potentially make a vm un evacuatatble | 08:39 |
| songwenping | sean-k-mooney: thanks, got it. i have another question: on a customer's AMD server, the gpu's iommu group have many other devices which effects the passthrough to vm, how can we indivial the imommu group? | 09:11 |
| opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | 09:18 |
| sean-k-mooney | songwenping: did they set amd_iommu=on | 09:25 |
| songwenping | yes | 09:25 |
| sean-k-mooney | then they have 3 possiable path forward | 09:26 |
| *** elodilles is now known as elodilles_pto | 09:26 | |
| sean-k-mooney | 1 move the card to a pci slot that is directly connected to the cpu and not the chipset | 09:26 |
| songwenping | when i set all the devices' driver to vfio-pci, the gpu can passthrough to the vm. | 09:26 |
| sean-k-mooney | 2 check if the bios has the ablity to seperate the devie explictly | 09:27 |
| sean-k-mooney | 3 use the out of tree kernel patch for iommu remapping | 09:27 |
| sean-k-mooney | "PCIe ACS Override for bypassing IOMMU groups support." https://github.com/xanmod/linux-patches/blob/master/linux-5.19.y-xanmod/pci_acso/0001-pci-Enable-overrides-for-missing-ACS-capabilities.patch | 09:28 |
| sean-k-mooney | songwenping: yes that a limitation of vfio-pci | 09:30 |
| sean-k-mooney | "PCIe ACS Override for bypassing IOMMU groups support." https://github.com/xanmod/linux-patches/blob/master/linux-5.19.y-xanmod/pci_acso/0001-pci-Enable-overrides-for-missing-ACS-capabilities.patch | 09:30 |
| sean-k-mooney | would allow you to force the device into its own iommu group if they cant take the simpler options of movign the card to be driectly conneccted to the cpu instead of the chipset | 09:31 |
| songwenping | this patch is relatively new. | 09:31 |
| sean-k-mooney | that version of it | 09:31 |
| sean-k-mooney | the patch has been around for a few years | 09:32 |
| sean-k-mooney | the orginal one is form 2018 | 09:32 |
| sean-k-mooney | correct 2013 https://lkml.org/lkml/2013/5/30/513 | 09:32 |
| sean-k-mooney | i honeestly dont know why this has not landed other then alex is busy with other things | 09:33 |
| sean-k-mooney | it would be really really useful for vms | 09:33 |
| *** brinzhang0 is now known as brinzhang | 09:33 | |
| songwenping | thanks, i will try to merge the patch. | 09:35 |
| gibi | sean-k-mooney: I've reviewed the user_data and the rebuild bfv patches. I will go and dig into the func test part ofthe bfv patch now. | 09:36 |
| gibi | sean-k-mooney, stephenfin: if you have cycles then the next 11 PCI patch is ready to land ;) | 09:36 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/854979 | 09:39 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/854980 | 09:39 |
| admin1 | hi .. i am getting this error: nova-compute Connection to libvirt failed: authentication failed: authentication failed: libvirt.libvirtError: authentication failed: authentication failed and the compute node is unable to register itself .. i am using kolla-ansible yoga .. | 09:57 |
| sean-k-mooney | they changed how they connect | 10:14 |
| sean-k-mooney | that is really a question for the kolla channel since nova was not involved in this change | 10:14 |
| sean-k-mooney | admin1: they enabled more authentication by default | 10:14 |
| sean-k-mooney | admin1: you can tempoarly disable ths use of sasl authentication https://github.com/openstack/kolla-ansible/blob/master/doc/source/reference/compute/libvirt-guide.rst#sasl-authentication | 10:15 |
| sean-k-mooney | noonedeadpunk: was i chating to you about ^ in the past | 10:17 |
| sean-k-mooney | triging to rememebr who hit that before | 10:17 |
| * noonedeadpunk can't remember that at all | 10:18 | |
| sean-k-mooney | noonedeadpunk: porably wrong user name then | 10:18 |
| sean-k-mooney | im trying to think who works at blizzard | 10:19 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/854979 | 10:19 |
| noonedeadpunk | we never did sasl in osa, we use tls certs auth between computes for migrations | 10:19 |
| sean-k-mooney | its been a month or two | 10:19 |
| admin1 | maybe spatel :) | 10:19 |
| sean-k-mooney | noonedeadpunk: tls is more secure for sure | 10:19 |
| noonedeadpunk | afaik he's not from blizzard ) | 10:20 |
| sean-k-mooney | spatel is not no | 10:20 |
| admin1 | yeah | 10:20 |
| sean-k-mooney | i could proably gerp my logs but admin1 that is likely your issue | 10:20 |
| noonedeadpunk | btw talking about auth, it's sad that for offline migrations you still have to ensure SSH connection between computes :( | 10:20 |
| sean-k-mooney | offline you mean cold | 10:20 |
| noonedeadpunk | yeah, sorry, cold | 10:21 |
| sean-k-mooney | ya for the disk copy and more importantly if you are using cpeh/bfv for the file system check | 10:21 |
| noonedeadpunk | as for live migrations libvirt is jsut leveraged | 10:21 |
| sean-k-mooney | that could be remvoed | 10:21 |
| noonedeadpunk | can it? hm, I can recall I still had to ensure ssh even for ceph | 10:22 |
| sean-k-mooney | but it need some changes to how we check for shared filesystem | 10:22 |
| sean-k-mooney | we could replcase the ssh requirement with doign the check via an rpc | 10:23 |
| sean-k-mooney | right now we ssh to the dest and toch a file | 10:23 |
| noonedeadpunk | ah, ok, now I got what you meant | 10:23 |
| sean-k-mooney | then check on the source if we can see it | 10:24 |
| sean-k-mooney | but we could do that via an rpc | 10:24 |
| noonedeadpunk | yeah, I thought the same, but ENOTIME as usual | 10:24 |
| sean-k-mooney | for live migration we actully have the rpcs in place we woudl just do it avia the existing pre-migration rpcs | 10:25 |
| sean-k-mooney | i dont know if we can do the same for cold migratoin today as i dont know if we have rpcs to the dest at the right times that we can extend | 10:26 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.power_on_error notification https://review.opendev.org/c/openstack/nova/+/852084 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add instance.power_off_error notification https://review.opendev.org/c/openstack/nova/+/852278 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | 10:38 |
| opendevreview | ribaudr proposed openstack/nova master: Change microversion to 2.93 https://review.opendev.org/c/openstack/nova/+/852088 | 10:38 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/854979 | 10:53 |
| opendevreview | Amit Uniyal proposed openstack/nova stable/victoria: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/854980 | 10:53 |
| sean-k-mooney | gibi: did you fiture out why you could not do request_id=uuidutils.generate_uuid(dashed=True) | 10:54 |
| sean-k-mooney | by the way | 10:54 |
| sean-k-mooney | oh nevermind | 10:55 |
| sean-k-mooney | yes we did | 10:55 |
| gibi | yes I did and I already forgot it :) | 10:55 |
| sean-k-mooney | i was the util function | 10:55 |
| sean-k-mooney | you moved it to the object | 10:55 |
| gibi | ahh yes | 10:56 |
| gibi | true | 10:56 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/853835/9 | 10:56 |
| sean-k-mooney | i was just clenaing up the nova repo i had the DNM change checked out in | 10:57 |
| sean-k-mooney | im going to start backporting the first vdpa patch | 10:57 |
| sean-k-mooney | although i think i need to backport one of your patches first | 10:57 |
| sean-k-mooney | the compute manger restart patch | 10:58 |
| gibi | yeah on the libvirt tests fixture we overlap a bit | 10:59 |
| gibi | hopefully not much | 10:59 |
| sean-k-mooney | well im just using it for one test | 10:59 |
| sean-k-mooney | the evacuate test | 10:59 |
| sean-k-mooney | so i just need to backport it and then rebase on top | 10:59 |
| sean-k-mooney | ah found it https://review.opendev.org/c/openstack/nova/+/850510 | 11:00 |
| sean-k-mooney | ok so im going to try backporting that and then ill cherry pick my patch | 11:00 |
| gibi | now I'm done with the func test part of the rebuild bfv as well. I found nothing serious so I think we can land the series this week | 11:05 |
| gibi | next up is the manila series... | 11:05 |
| gibi | but I need to get food first | 11:05 |
| sean-k-mooney | has the userdata patch been updated | 11:05 |
| sean-k-mooney | if that is not updated today we should change the order or perhaps one of us can adress the nits | 11:06 |
| gibi | sean-k-mooney: it was updated during the weekend | 11:06 |
| sean-k-mooney | ah ok ill review that when im done with this then | 11:07 |
| gibi | there is some failing unit tests but the overal logic now looks good to me | 11:07 |
| sean-k-mooney | api sample tests or generic unit tests | 11:11 |
| sean-k-mooney | oh ... this might also need some of the double mockign seriese | 11:20 |
| sean-k-mooney | :) | 11:32 |
| stephenfin | sean-k-mooney: gibi: continuing it here, I think they need a PTL to ack the patch against openstack/release | 11:33 |
| sean-k-mooney | stephenfin: are there any others i should look at or jsut nova client | 11:33 |
| sean-k-mooney | stephenfin: no they dont | 11:33 |
| stephenfin | I'd ask elodilles directly but he's on PTO | 11:33 |
| sean-k-mooney | it ptl or whoever is listed here https://github.com/openstack/releases/blob/master/data/release_liaisons.yaml#L93-L96 | 11:34 |
| stephenfin | ah | 11:35 |
| stephenfin | sweet | 11:35 |
| stephenfin | then I guess you can do it :) | 11:35 |
| sean-k-mooney | im just looking at the changes between the current sha and the old one | 11:35 |
| sean-k-mooney | stephenfin: we might end up doing another release if we land some of the inflight changes | 11:38 |
| sean-k-mooney | but i have no issue with doing this release now | 11:38 |
| stephenfin | that's okay, I think? | 11:38 |
| sean-k-mooney | https://review.opendev.org/c/openstack/releases/+/854362 | 11:38 |
| sean-k-mooney | ptl-approved flag is no set | 11:38 |
| sean-k-mooney | ya its ok | 11:38 |
| sean-k-mooney | release are cheap | 11:38 |
| sean-k-mooney | i assume this is needed for ocs change to merge or simialr | 11:39 |
| sean-k-mooney | i know those micorversion also had osc patches | 11:39 |
| sean-k-mooney | stephenfin: anyway let me know if you need release for anything else in the nova deliverables or ping bauzas tomorrow | 11:42 |
| sean-k-mooney | if im not about | 11:42 |
| gibi | I'm not sure we have rel mgmt up yet as elodilles_pto is on pto today | 11:50 |
| sean-k-mooney | even if we do im not sure if we have two of them | 11:51 |
| sean-k-mooney | given its still pto season | 11:51 |
| gibi | yeah | 11:51 |
| sean-k-mooney | hum https://review.opendev.org/c/openstack/nova/+/851445 helped but i sill have 74 failing tests | 11:53 |
| sean-k-mooney | AttributeError: 'VGPUTests' object has no attribute 'libvirt' | 11:53 |
| sean-k-mooney | so the libvirt fixutre is still not quite working | 11:53 |
| gibi | hm, that is still somehow related to the mock stuf | 11:53 |
| gibi | have you looked at https://review.opendev.org/c/openstack/nova/+/852464 | 11:54 |
| sean-k-mooney | nope bug that looks relevent | 11:54 |
| sean-k-mooney | *but | 11:55 |
| sean-k-mooney | ill pull that in and see if it resolves the issue | 11:55 |
| sean-k-mooney | i wonder if i should squash the too for backport or not | 11:55 |
| gibi | probalby OK to squash | 11:55 |
| sean-k-mooney | ill try adding them seperatly and see if that resovles the issue then i can squash | 11:55 |
| gibi | ack | 11:56 |
| sean-k-mooney | im not actully backporting the mock removal by the way | 11:59 |
| sean-k-mooney | just the double mocking patch | 11:59 |
| sean-k-mooney | so stable will still use mock the lib | 11:59 |
| sean-k-mooney | but without the double mocking | 11:59 |
| gibi | hm, I think that is OK | 12:00 |
| sean-k-mooney | looks like ill need https://opendev.org/openstack/nova/commit/cd03bbc1c33e33872594cf002f0e7011ab8ea047 too | 12:03 |
| sean-k-mooney | that should be ok to backport too | 12:04 |
| sean-k-mooney | thats needed for fake_get_mac_by_pci_address | 12:05 |
| sean-k-mooney | that bug has existied since pf support was added so backporting to wallaby is fine | 12:05 |
| gibi | ahh yeah, that was en extension to the fixture | 12:05 |
| sean-k-mooney | ya i could just pull that in but if this does not cause much issue ill just backport it | 12:05 |
| gibi | but for the MAC update to work we need https://review.opendev.org/c/openstack/neutron/+/829247 on the neutron side too | 12:06 |
| sean-k-mooney | yes | 12:06 |
| gibi | this is getting hairy :) | 12:06 |
| sean-k-mooney | but having the mac info wont break anything | 12:06 |
| gibi | true | 12:06 |
| sean-k-mooney | so we can also backport the neutron patch but its not a blocker | 12:06 |
| gibi | then fine | 12:06 |
| sean-k-mooney | which is why you did not have a depens on | 12:06 |
| sean-k-mooney | if this proves unworkable ill pull in just the test fixture changes | 12:06 |
| gibi | ack | 12:07 |
| gibi | make sense | 12:07 |
| sean-k-mooney | gibi: ok i have a working backport series i need to add cherrypicked lines since i pull them in via interactive rebase to get the order right but ill push them and then do that | 12:58 |
| gibi | cool | 12:58 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/855022 | 12:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/855023 | 12:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking https://review.opendev.org/c/openstack/nova/+/855024 | 12:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/855025 | 12:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/855026 | 12:59 |
| sean-k-mooney | i was tempted to pull in the vdpa change to stop using sriov | 12:59 |
| sean-k-mooney | but im not sure if that was backportable | 13:00 |
| sean-k-mooney | so i didnt add it | 13:00 |
| gibi | OK I think I finished looking at the latest update of the manila series. what was fixed looks correct to me, but there is still open comment. I know Uggla working on them as we speak | 13:08 |
| gibi | I'm going to switch back to the PCI series adding unit tests. But I will keep an eye of incoming updates on user_data, bfv rebuild and manial | 13:10 |
| gibi | manila | 13:10 |
| gibi | serieses | 13:10 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/855022 | 13:10 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/855023 | 13:10 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking https://review.opendev.org/c/openstack/nova/+/855024 | 13:10 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/855025 | 13:10 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/855026 | 13:10 |
| sean-k-mooney | gibi: ack ^ those can wait until after FF but if you get time to look over them many were your patches orginally | 13:11 |
| gibi | sure that is a nice distraction for my afternoon coffee :) | 13:11 |
| gibi | was there any major merge conflict there? | 13:12 |
| sean-k-mooney | no not really. i had to decide when to stop pulling in patches to avoid them | 13:12 |
| sean-k-mooney | but most were trivia | 13:12 |
| Uggla | gibi, thank you for the review. Although I have a lot of work and corrections to do. ;) | 13:13 |
| gibi | Uggla: no worries. FF week is always a bit crazy :D | 13:13 |
| gibi | sean-k-mooney: ack | 13:14 |
| sean-k-mooney | gibi: very odd | 13:19 |
| sean-k-mooney | all the reference commits are not wrong but i copied them from gerrit | 13:19 |
| sean-k-mooney | so i dont knwo why they are wrong | 13:19 |
| gibi | maybe you copied from an older PS? | 13:20 |
| sean-k-mooney | actuly they are not wrong https://opendev.org/openstack/nova/commit/7bba330a1e6c09564b27bbbd85f42519c5b1598e | 13:20 |
| sean-k-mooney | https://opendev.org/openstack/nova/commit/8d2776fb34339b311c713992a39507452c4ae42f | 13:21 |
| sean-k-mooney | they both exist | 13:22 |
| sean-k-mooney | the one i have listed is the merged one | 13:22 |
| sean-k-mooney | the other wone is the one that came form the review | 13:22 |
| sean-k-mooney | gerrit rebases it when its applying it to the repo | 13:22 |
| sean-k-mooney | ill see what the bot says when it runs | 13:23 |
| sean-k-mooney | and ill either try fixing them again or leave them as is | 13:23 |
| sean-k-mooney | i was trying to use the commit form the gitia link | 13:23 |
| sean-k-mooney | if i need too ill just cherry-pick them all again form a clean start | 13:24 |
| sean-k-mooney | i might jsut do that now | 13:24 |
| sean-k-mooney | git review will do it the way the check script expects | 13:26 |
| gibi | yeah the only downside of the current hashes that they are not bringig up the original patch in gerrit ui | 13:29 |
| sean-k-mooney | because i pulled them in vai rebase i dont have all the conflict lines either so im redoing them now which will add those | 13:31 |
| sean-k-mooney | rebase is simpler to get it working but this will produce a better backport | 13:31 |
| gibi | ack, I noted a request in the commit message of https://review.opendev.org/c/openstack/nova/+/855025/2//COMMIT_MSG#27 about the zuul change | 13:34 |
| whoami-rajat | dansmith, sean-k-mooney hey, I changed the rpcapi pinning in compute but again the tests are failing, not sure how to deal with that failure without pinning the version there https://9e9cf999e8b8fa064cf7-7de3ea29d2988c6d3fb53b5f30580c1f.ssl.cf5.rackcdn.com/820368/35/check/openstack-tox-py38/b87dc94/testr_results.html | 13:46 |
| dansmith | whoami-rajat: I'm going through the feedback right now. I'm not sure what needed changing, but I'll look at it when I finish | 13:47 |
| whoami-rajat | dansmith, ack, thanks | 13:47 |
| sean-k-mooney | ack ill take a look at that shortly jsut finishing something locally | 13:48 |
| dansmith | whoami-rajat: oh because you changed L440 to 6.1? | 13:52 |
| dansmith | whoami-rajat: I think that is never supposed to be anything but x.0 | 13:52 |
| whoami-rajat | dansmith, ah, let me try to change that | 13:53 |
| dansmith | whoami-rajat: that's the default that gets used if a specific call doesn't use a higher version | 13:53 |
| dansmith | yeah, confirmed, that should stay 6.0 | 13:53 |
| whoami-rajat | dansmith, yep that passed the tests \o/ | 13:54 |
| sean-k-mooney | dansmith: we are pinning to oldest rpc major not latest rpc by default? | 13:55 |
| sean-k-mooney | i guess to test the back leveling | 13:55 |
| sean-k-mooney | just making sure why they are not tested with the latest version i guess when we add a new rpc we bump the affected calls | 13:56 |
| sean-k-mooney | in a new test | 13:56 |
| dansmith | sean-k-mooney: we always make calls at the lowest version they need | 13:56 |
| sean-k-mooney | and by pinning to the X.0 we meake suer we did not break it | 13:56 |
| sean-k-mooney | ok | 13:56 |
| dansmith | so calls that haven't changed since the last major bump are made at .0 | 13:56 |
| sean-k-mooney | ya i tought we did it the other way but that makes sense why we do it this way | 13:57 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/855022 | 13:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/855023 | 13:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking https://review.opendev.org/c/openstack/nova/+/855024 | 13:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/855025 | 13:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/855026 | 13:59 |
| opendevreview | sean mooney proposed openstack/nova stable/yoga: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/855035 | 13:59 |
| sean-k-mooney | dansmith: by the way the 5.x support is already deprecated yes we should ensure we can drop it next cycle without being impacted by the new lifecycle | 14:00 |
| sean-k-mooney | we dont have to drop it next cycle but i dont want to be force to keep it until BB | 14:01 |
| dansmith | I dunno, I thought we were thinking about keeping it around for longer | 14:01 |
| sean-k-mooney | now that we have 6.X RPCs | 14:01 |
| sean-k-mooney | well we shoudl dicuss it i guess | 14:02 |
| sean-k-mooney | the epecation in yoga was no new deploymets would use 5.X | 14:02 |
| sean-k-mooney | but we were keeping the compat for zed | 14:02 |
| *** dasm_ is now known as dasm | 14:03 | |
| dansmith | whoami-rajat: the patch underneath you has shifted again, so you should rebase *on* it before you push if possible | 14:17 |
| hkominos | Hi guys! I have a question regarding policies that I want to ask. When we edit lets say /etc/nova/policy.json , is the nova-api process that will read these new policies or the keystone process ? | 15:02 |
| dansmith | nova-api | 15:06 |
| hkominos | thx ! | 15:06 |
| gmann | gibi: dansmith: please check this documentation and releasenote for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | 15:24 |
| gibi | gmann: will check sooon | 15:24 |
| gmann | thanks | 15:24 |
| whoami-rajat | dansmith, yep, this time i first rebased on top of it then made changes :) | 16:30 |
| dansmith | whoami-rajat: good :) | 16:31 |
| sean-k-mooney | gibi: https://review.opendev.org/c/openstack/nova/+/816157/14#message-b94abbc42dea06b9d989f698ffbee826a9283a19 should fix the failing unit test in the userdata update patch | 17:36 |
| gibi | sean-k-mooney: thanks for looking into that | 17:37 |
| sean-k-mooney | the os-traits relases happened at the weekend yes? | 17:38 |
| gibi | I think so | 17:38 |
| gibi | otherwise the user_data patch could not bump the os-traits req in nova successfully | 17:38 |
| gibi | but it did :) | 17:38 |
| sean-k-mooney | ya actully my tox env was able to pull in the traits too | 17:39 |
| sean-k-mooney | just looking at the api check for the trait now | 17:39 |
| gibi | yepp it was merged on fridayt https://review.opendev.org/c/openstack/releases/+/854617 | 17:39 |
| sean-k-mooney | i think that was the last thing that needed to be updated since i last looked | 17:39 |
| sean-k-mooney | so once the unit test is fixed i think its ready to go | 17:39 |
| sean-k-mooney | just going to finish reviewing the rest of the change | 17:39 |
| gibi | yes, I had the same feeling this morning | 17:40 |
| gibi | it is fairly close | 17:40 |
| sean-k-mooney | do we have a way to reach out to the author | 17:40 |
| sean-k-mooney | do we know what timezone they are in? | 17:40 |
| gibi | he was on nova before with the nick jhartkopf but I don't know him | 17:42 |
| sean-k-mooney | looks like its a german email so emea timezones most likely | 17:43 |
| gibi | he updated the patch over the weekend so I think he is still actively engaged with this | 17:43 |
| sean-k-mooney | ok lets see if they update it in the morning | 17:43 |
| dansmith | if it's a semi-trivial test fix, perhaps we could just fix it for him? | 17:43 |
| sean-k-mooney | i mean i can do that if its ok with ye | 17:44 |
| dansmith | like, unless it's likely he has other things pending, the risk is low ... | 17:44 |
| sean-k-mooney | i dont think there is honestly anythign that could not be in a follow up change | 17:44 |
| gibi | I can do the test fix earlies tomorrow morning, but sean-k-mooney if you can do it I can review it | 17:44 |
| dansmith | it just sounded like sean-k-mooney has the fixes locally for testing, so might as well just push and update | 17:44 |
| sean-k-mooney | yep i have ok i can push them let me see if i have any pep issue first and run the full set of unit and funcitonal tests. | 17:46 |
| sean-k-mooney | if im pushing this do ye want me to cherry-pick the follow up patches and or rebases it to master | 17:47 |
| sean-k-mooney | i think its relitivly up todate but i know ye were waiting on a rebase over the weekend | 17:48 |
| sean-k-mooney | i think that was already done | 17:48 |
| dansmith | nah, I'd just push that up and let whoami-rajat rebase on the result | 17:48 |
| dansmith | oh, sorry, | 17:48 |
| dansmith | the follow-ups.. I dunno, less concerned about that than just the main one which is the key in the pipeline | 17:48 |
| sean-k-mooney | well followups i ment whoami-rajat seriese | 17:49 |
| sean-k-mooney | but sure ill just update this one when the test finish | 17:49 |
| dansmith | I'd let him do it, he's working on them now I htink | 17:49 |
| sean-k-mooney | and then whoami-rajat can update there set | 17:49 |
| dansmith | yea | 17:49 |
| * sean-k-mooney is currently using a lg c2 as a 4k display. not sure it was the best choice. on had blacks are amazing on an oled and the realistate is nice but it will take time to get used too/tweak | 17:52 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | 17:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Enable pci in placement feature https://review.opendev.org/c/openstack/nova/+/854925 | 17:54 |
| gibi | sean-k-mooney, stephenfin: ^^ I managed to finish all the TODOs in the series | 17:55 |
| gibi | from tomorrow I will start collecting the follow up from already merged patches | 17:55 |
| sean-k-mooney | well done :) i guess i know what im doing tomorrow | 17:56 |
| gibi | but now I need a glass of wine | 17:56 |
| gibi | see you all tomorrow o/. | 17:56 |
| whoami-rajat | sean-k-mooney, dansmith is there going to be an update on 2.93 patch? I'm finalizing tests and pushing changes | 18:07 |
| dansmith | whoami-rajat: yeah, just hold on a bit | 18:08 |
| whoami-rajat | ack | 18:08 |
| sean-k-mooney | the functional test are almost finsihed locally and then ill push likely in the next 60 secons | 18:08 |
| sean-k-mooney | just making sure it will pass ci | 18:08 |
| opendevreview | sean mooney proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | 18:13 |
| sean-k-mooney | whoami-rajat: ^ there you go | 18:13 |
| whoami-rajat | ack | 18:13 |
| sean-k-mooney | this was the fix https://review.opendev.org/c/openstack/nova/+/816157/14..15/nova/tests/unit/api/openstack/compute/test_server_actions.py | 18:13 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | 18:54 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | 18:54 |
| opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 18:54 |
| whoami-rajat | updated the series however I'm still facing some functional test failure related to green thread queue, I figured it might be my environment so pushed to see what gate thinks | 18:58 |
| opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | 18:58 |
| gmann | dansmith: ^^ fixed as per review comments | 19:02 |
| opendevreview | Ghanshyam proposed openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | 20:14 |
| gmann | dansmith: ^^ updated, I have fixed your comments | 20:15 |
| dansmith | gmann: looking now | 20:15 |
| dansmith | gmann: done thanks | 20:16 |
| gmann | dansmith: thanks | 20:17 |
| opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | 22:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!