opendevreview | Jorhson Deng proposed openstack/nova master: Remove the redundance code in HostState.update https://review.opendev.org/c/openstack/nova/+/864275 | 02:18 |
---|---|---|
*** slaweq_ is now known as slaweq | 07:57 | |
bauzas | happy Specs review day, folks | 08:24 |
gibi | o/ | 08:37 |
gibi | one done https://review.opendev.org/c/openstack/nova-specs/+/855514 many to go | 09:45 |
gibi | sean-k-mooney: do we need https://review.opendev.org/c/openstack/nova-specs/+/850352 or https://review.opendev.org/c/openstack/nova-specs/+/862626 will cover this as well? | 09:55 |
sean-k-mooney[m] | oh i can abandon that the new spec will cover it. i need to adress the capitalisation and spelling nits from dan | 09:58 |
sean-k-mooney[m] | but ill be doning that shortly | 09:58 |
gibi | sean-k-mooney: cool, then lets abadon the old one | 09:58 |
sean-k-mooney[m] | done | 09:59 |
gibi | thanks! | 10:03 |
gibi | one more done https://review.opendev.org/c/openstack/nova-specs/+/861033 for me it does not make sense but I maybe missing something | 10:04 |
bauzas | fwiw, I'm fast-approving already-approved specs that were in Zed | 10:07 |
gibi | bauzas: ack, go for it | 10:07 |
bauzas | just checking if the file was modified | 10:07 |
gibi | except maybe with https://review.opendev.org/c/openstack/nova-specs/+/863884 where we need to check that is in sync with the new direction | 10:08 |
bauzas | gibi: correct, I just approved Uggla's spec, that's it | 10:10 |
gibi | bauzas: OK | 10:10 |
bauzas | gibi: I was litterally diffing on my laptop the userdata one :) | 10:10 |
bauzas | and I see the new direction | 10:10 |
gibi | cool. I will get to it eventually too | 10:10 |
bauzas | I'll leave my comments now | 10:14 |
bauzas | I'm torn | 10:14 |
opendevreview | Merged openstack/nova-specs master: Re-propose "Allow Manila shares to be directly attached to an instance when using libvirt" https://review.opendev.org/c/openstack/nova-specs/+/864206 | 10:15 |
bauzas | gibi: if you're interested, that's my thoughts on the userdata things https://review.opendev.org/c/openstack/nova-specs/+/863884 | 10:28 |
gibi | I will check | 10:28 |
bauzas | tl;dr: I'd rather not want to have something specifically written while we already have os-instance-actions API | 10:29 |
* gibi like the spec review day. Good to have the dedicated time to focus | 10:29 | |
bauzas | indeed | 10:30 |
bauzas | but I also need to update my CPU spec :) | 10:30 |
* bauzas will miss the gym today, too many things to do | 10:31 | |
opendevreview | Kirill proposed openstack/nova-specs master: new spec: support of vnc console for ironic https://review.opendev.org/c/openstack/nova-specs/+/863773 | 10:52 |
opendevreview | sean mooney proposed openstack/nova-specs master: add spec for fqdn in hostname https://review.opendev.org/c/openstack/nova-specs/+/862626 | 11:06 |
sean-k-mooney[m] | gibi sorry was reworking the fqdn spec. ill take a look at he max physical adress spec. qemu does allow you to change the adress space that is virutalised. i have not read the spec but you can have a requirement to reduce that or increase that depending on some factors. the adress space of the vm cannot exceed the hardware its on so somethime you need to reduce it to allow kvm to work such as on an m1 macbookair. qemu does not | 11:11 |
sean-k-mooney[m] | default to the full adress space of the host either in some cpu models so you might need to increase it to create really large vms. | 11:11 |
gibi | sean-k-mooney[m]: the spec only ask for increasing the address space but as far as I understand that can be done by simply change the default to be as big as the host cpu | 11:12 |
sean-k-mooney[m] | i assume there use case is one of those. very big vm where the default is too low or restriced hardware where the default is two high. i feel like this is one case where a host option might work or image property. if we were to do it. | 11:12 |
sean-k-mooney[m] | can you change teh default in libvirt already? | 11:12 |
sean-k-mooney[m] | if so then we can just document that | 11:12 |
sean-k-mooney[m] | im going to step away for 5 mins and get coffee and then ill be back soon to review it. | 11:13 |
gibi | the libvirt doc suggested having a default so I assumed that it is a configurable default | 11:14 |
gibi | anyhow if the default is not configurable today then I still would like to have that configurable in libvirt instead of exposing yet another really low level HW knob in nova | 11:14 |
opendevreview | Kirill proposed openstack/nova-specs master: new spec: support of vnc console for ironic https://review.opendev.org/c/openstack/nova-specs/+/863773 | 11:22 |
opendevreview | Kirill proposed openstack/nova-specs master: new spec: support of vnc console for ironic https://review.opendev.org/c/openstack/nova-specs/+/863773 | 11:26 |
bauzas | gibi: yeah, I need to update the CPU spec, I didn't had time until noon https://review.opendev.org/c/openstack/nova-specs/+/861591 | 11:38 |
bauzas | gibi: I'll ping you later in the afternoon once I upload a new rev | 11:38 |
bauzas | should be an easy small spec | 11:39 |
gibi | bauzas: ack | 11:39 |
opendevreview | Merged openstack/nova-specs master: Robustify Compute Node Hostnames backlog spec https://review.opendev.org/c/openstack/nova-specs/+/853837 | 13:23 |
opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes cpu power managment in libvirt https://review.opendev.org/c/openstack/nova-specs/+/861591 | 13:28 |
bauzas | sean-k-mooney: gibi: just made modifications to the CPU mangement spec ^ | 13:29 |
sean-k-mooney | ack it will proably be an hour or so before i get to it | 13:35 |
JohnnyW | Hello, just a question about nova and barbican cooperation, maybe someone faced such issue already. I have two volumes encrypted, one is using a key which was created before an upgrade of barbican from ussuri version to yoga version, so far both are OK, but if I detach volume which is using ussuri key, then I cannot attach that volume to another | 13:38 |
JohnnyW | instance with information in nova logs: "libvirt.libvirtError: internal error: unable to execute QEMU command 'blockdev-add': Invalid password, cannot unlock any keyslot", but if I do the same operation with a volume which is using yoga key, then everything is fine. So far I checked that I'm able to retrieve secret payload from ussuri and yoga keys | 13:38 |
JohnnyW | and everything looks fine, there is no error logs in barbican. So I'm wondering what can be an issue here, any ideas? Thanks in advance for suggestions! | 13:38 |
sean-k-mooney | JohnnyW: do you onw the key and volume | 13:40 |
sean-k-mooney | if you are not the user that created teh encyped volume then the key in barbican will be owned by the orginal user and you will not be able to attach it to another vm | 13:40 |
sean-k-mooney | encypted volume encyption keys are onwed by the user that created it not the project | 13:41 |
sean-k-mooney | as is the case with all secrets stored in barbican | 13:41 |
JohnnyW | sure, I'm owner of both keys | 13:41 |
JohnnyW | that is why this behavior looks strange for me | 13:42 |
sean-k-mooney | ok then in that case im not really sure | 13:42 |
sean-k-mooney | its the same version fo nova/libvirt right | 13:42 |
sean-k-mooney | just one was created before the upgrade and the other after | 13:42 |
JohnnyW | nova/libvirt are exactly the same, only barbican version changed in between...and vault as a backend and SoftHSM for keys was upgraded, but only OS not version of vault itself | 13:43 |
sean-k-mooney | ya thats odd. i wonder if tehere was a bug fix wehre we did nto store some metadata or similar that we require to be able to do the attach | 13:44 |
sean-k-mooney | i.e. a bug that affected volumes created in teh older relase that nolonger happens in the later release | 13:45 |
JohnnyW | openstack secret get ... are able to return all payload, for "new" and "old" secret, so that's why it looks strange. Only nova seems to have an issue with reading keys, let say old volumes which are already mounted and old are OK right now, but after reattachment I'm sure that problem with old keys will be visible | 13:45 |
sean-k-mooney | have you compare the metadtaa on the volume or attachment info | 13:45 |
JohnnyW | hmm...let me try to compare metadata or attachment info, maybe that is a good hint, I haven't tried to compare it yet | 13:46 |
opendevreview | Merged openstack/nova-specs master: Clarify client changes in rebuild spec https://review.opendev.org/c/openstack/nova-specs/+/856164 | 13:55 |
*** dasm|off is now known as dasm | 13:58 | |
*** haleyb_ is now known as haleyb | 14:04 | |
JohnnyW | sean-k-mooney unfortunately or fortunately it's not up to metadata or attachment info, I already change on both sides to have similar and issue is the same. Logs from nova-compute says: https://paste.openstack.org/show/bNbPOHiQJOq8OsKZ5Gn2/ | 14:07 |
sean-k-mooney | ya so i have not see that issue before so i cant really say. it would be good to file a bug for this as it likely is an upstream bug but im not sure of the cause | 14:27 |
sean-k-mooney | JohnnyW: by the way today is a spec review day so most of the cores will be focused on that so if no one else chims in bring it up tomorrow and it might get more attention | 15:27 |
bauzas | reminder: nova meeting in ~30 mins | 15:32 |
JohnnyW | sean-k-mooney ok, thank you very much, already posted a bug here: https://bugs.launchpad.net/nova/+bug/1996622 and hope that everything is placed there | 15:47 |
bauzas | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Nov 15 16:00:19 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
bauzas | howdy everyone | 16:00 |
dansmith | o/ (but multitasking) | 16:00 |
* bauzas is swamped in a mud | 16:00 | |
elodilles | o/ | 16:00 |
Uggla | o/ | 16:00 |
bauzas | dansmith: ditto | 16:00 |
bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:01 |
gmann | o/ | 16:01 |
gibi | o/ | 16:01 |
bauzas | let's try to have a quick meeting | 16:01 |
sean-k-mooney | o/ | 16:01 |
Kirill_ | 0/ | 16:01 |
bauzas | #topic Bugs (stuck/critical) | 16:01 |
bauzas | #info No Critical bug | 16:01 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 7 new untriaged bugs (+2 since the last meeting) | 16:01 |
bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:01 |
bauzas | melwitt: I've seen you triaging bugs, anything in particular you wanted to discuss ? | 16:01 |
bauzas | looks not, moving on | 16:03 |
bauzas | Uggla: happy with getting the baton this week ? | 16:03 |
Uggla | bauzas, ok | 16:03 |
bauzas | artom is on some PTO until dec | 16:03 |
bauzas | cool | 16:03 |
bauzas | #info bug baton is being passed to Uggla | 16:03 |
bauzas | moving on | 16:03 |
bauzas | #topic Gate status | 16:04 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:04 |
bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:04 |
bauzas | we had a terrible week | 16:04 |
bauzas | yellows and reds everywhere | 16:04 |
gibi | I think it was a global CI outage | 16:04 |
gibi | at some point | 16:04 |
bauzas | yup | 16:04 |
bauzas | since all the runs happened on the same timeframe, this would explain | 16:05 |
bauzas | we shall check the statuses next week | 16:05 |
bauzas | agreed ? | 16:06 |
bauzas | #info all periodic runs turned into a bad shape this week due to some CI outage on Nov 12, we'll doublecheck next week how things go | 16:06 |
bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:07 |
gibi | sure | 16:07 |
bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:07 |
bauzas | #topic Release Planning | 16:07 |
bauzas | #link https://releases.openstack.org/antelope/schedule.html | 16:07 |
bauzas | #link https://releases.openstack.org/antelope/schedule.html | 16:07 |
bauzas | dang | 16:07 |
bauzas | #info Antelope-1 is planned in 2 days | 16:07 |
bauzas | #info Antelope-1 is planned in 2 days | 16:07 |
bauzas | #info Today is a spec review day | 16:08 |
bauzas | voilĂ | 16:08 |
bauzas | currently we're all busy at looking at some specs | 16:08 |
bauzas | so I'll tell the result of this spec day next week | 16:08 |
gibi | yepp | 16:08 |
bauzas | thanks btw. cores for taking time about ^ | 16:08 |
bauzas | moving on | 16:09 |
bauzas | #topic Review priorities | 16:09 |
bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:09 |
bauzas | given today is a spec review day, I'd like to skip this check | 16:09 |
bauzas | people can ping us on IRC for reviews, surely | 16:09 |
bauzas | #info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review | 16:09 |
bauzas | moving on | 16:10 |
bauzas | #topic Stable Branches | 16:10 |
bauzas | elodilles: floor is yours | 16:10 |
elodilles | #info stein, rocky and queens moved to End of Life, branches were deleted (last branch state can be found with tags: stein-eol, rocky-eol, queens-eol): https://review.opendev.org/862520 | 16:10 |
bauzas | \o/ | 16:10 |
elodilles | ~o~ | 16:10 |
elodilles | #info all open stable branches should be OK | 16:10 |
elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:10 |
elodilles | and that's it (to be quick :)) | 16:11 |
bauzas | nice | 16:12 |
bauzas | thanks | 16:12 |
elodilles | np | 16:12 |
bauzas | last topic with a good question | 16:12 |
bauzas | #topic Open discussion | 16:12 |
bauzas | (takashi) Release python-novaclient 18.2.0 | 16:12 |
bauzas | (sorry takashi, if you read the meeting notes, I don't know your IRC nick) | 16:12 |
bauzas | https://review.opendev.org/c/openstack/releases/+/861360 | 16:12 |
bauzas | The nova supports microversions 2.93 in the Zed release. However the support for microversions 2.93 has not been included in the python-novaclient 18.1.0 (the Zed release). | 16:13 |
bauzas | Add support for microversions 2.93 in the 18.2.0. | 16:13 |
bauzas | that's it from him | 16:13 |
bauzas | I'm not opposed to a .y release | 16:13 |
bauzas | any concerns ? | 16:13 |
bauzas | before I +1 the releases patch ? | 16:13 |
elodilles | no concern, should be OK, especially as we are at Antelope-1 | 16:14 |
bauzas | elodilles: yeah but we usually have a tradition to release client changes around milestone-1 | 16:14 |
gibi | 18.2.0 works for me | 16:15 |
bauzas | said +1d | 16:15 |
bauzas | should get the PTL-vote then | 16:15 |
bauzas | thanks takashi for your efforts, btw. | 16:15 |
bauzas | greatly appreciated | 16:15 |
gibi | ^^ +1 | 16:16 |
bauzas | I haven't looked at our libs recently | 16:16 |
bauzas | milestone-1 is maybe premature but we could release some libs updates like os-vif if that helps | 16:16 |
dvo-plv | Hello, All could you please review our blueprint: https://review.opendev.org/c/openstack/nova-specs/+/859290 | 16:16 |
sean-k-mooney | milestone 1 already... this will be a very short cycle | 16:17 |
bauzas | sean-k-mooney: yup, I said it loudly in the antelope release schedule patch | 16:17 |
elodilles | yepp, this is a 24 weeks long cycle | 16:17 |
bauzas | dvo-plv: we're on meeting now, but be sure we'll look at all specs today as this is a day prioritized for it | 16:18 |
bauzas | anyway, I guess we're done | 16:18 |
bauzas | like I said, no libraries need for release ? | 16:18 |
bauzas | disclaimer, I can check the git repos, I'm just lazy to do so | 16:18 |
elodilles | i haven't checked, but were there merged patches there? | 16:19 |
bauzas | that's my question :) | 16:19 |
bauzas | anyway, we're not constrained by the milestone, we can release whenever we want | 16:19 |
bauzas | that's it then for me today | 16:19 |
bauzas | any other topic to address before we end the meeting ? | 16:19 |
bauzas | thanks all, appreciated your presence while you all are quite busy this day | 16:20 |
bauzas | have a good day and let's continue our effort | 16:20 |
bauzas | #endmeeting | 16:20 |
opendevmeet | Meeting ended Tue Nov 15 16:20:49 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:20 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-11-15-16.00.html | 16:20 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-11-15-16.00.txt | 16:20 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-11-15-16.00.log.html | 16:20 |
elodilles | thanks o/ | 16:20 |
gibi | o/ | 16:21 |
elodilles | bauzas: the release patches were generated for Antelope-1, but I see only python-novaclient, so I guess no other lib release is needed: https://review.opendev.org/q/topic:antelope-milestone-1 | 16:21 |
elodilles | bauzas: wrong, there's os-vif: https://review.opendev.org/c/openstack/releases/+/864527 | 16:22 |
elodilles | sean-k-mooney: ^^^ | 16:22 |
bauzas | I don't think we need to tag it 3.1.0 | 16:23 |
bauzas | per the commit msg | 16:23 |
elodilles | we need to bump at least MINOR versions between series | 16:24 |
sean-k-mooney | elodilles: before we proceed with that i just want to make sure we have landed the tox/gitreview patches | 16:24 |
elodilles | sean-k-mooney: ++, thanks in advance for taking care of that! | 16:24 |
sean-k-mooney | oh never mind we dont need too | 16:24 |
sean-k-mooney | we only change them on stable to aovid that | 16:24 |
elodilles | then even better :) | 16:24 |
sean-k-mooney | i saw the email come in for the release this mornign but didnt open the patch yet | 16:25 |
elodilles | the generated patches on master branch seem to be merged | 16:26 |
sean-k-mooney | looking at the oneline summery i think this makes sense and i agree a feature bump is correct | 16:26 |
elodilles | ++ | 16:26 |
sean-k-mooney | so there was os-vif and novaclient if i rememebr correctly | 16:26 |
bauzas | ok, then I'll +1 it | 16:27 |
sean-k-mooney | https://review.opendev.org/c/openstack/releases/+/864536 | 16:27 |
bauzas | sean-k-mooney: that's a duplicate of https://review.opendev.org/c/openstack/releases/+/861360 | 16:28 |
sean-k-mooney | both have the swap to the new testing runtime merged and not much else so i think we can release that too | 16:28 |
sean-k-mooney | yes and no | 16:28 |
sean-k-mooney | the release was being doen for different reasons | 16:28 |
sean-k-mooney | but sure we can go with the takashi's patch | 16:29 |
bauzas | surely, but the result is the same even if the gerrit topics are different | 16:29 |
opendevreview | Ghanshyam proposed openstack/placement master: Policy defaults improvement spec https://review.opendev.org/c/openstack/placement/+/864385 | 16:34 |
gmann | bauzas: sean-k-mooney dansmith ^^ updated placement spec also for RBAC to add admin-or-service default what we discussed on IRC | 16:34 |
dansmith | ack | 16:35 |
bauzas | ack | 16:39 |
opendevreview | Merged openstack/nova-specs master: Policy service role spec https://review.opendev.org/c/openstack/nova-specs/+/864379 | 16:48 |
bauzas | sean-k-mooney: gibi: thanks for having commented out the CPU spec | 17:27 |
bauzas | will update it tomorrow | 17:27 |
* bauzas has a serious headache by now | 17:27 | |
sean-k-mooney | cool ill take a look then | 17:28 |
gibi | bauzas: no worries. feel free to ping me later and I cen re-review | 17:28 |
opendevreview | Ghanshyam proposed openstack/placement master: Policy defaults improvement spec https://review.opendev.org/c/openstack/placement/+/864385 | 17:51 |
gmann | sean-k-mooney: ^^ updated the upgrade impact and scope_type change. | 17:52 |
opendevreview | Merged openstack/nova-specs master: Re-propose spec for ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/864138 | 18:37 |
opendevreview | Merged openstack/nova-specs master: Re-propose spec for ephemeral encryption for libvirt https://review.opendev.org/c/openstack/nova-specs/+/864147 | 18:38 |
opendevreview | Dan Smith proposed openstack/nova-specs master: Add stable-compute-uuid spec https://review.opendev.org/c/openstack/nova-specs/+/863152 | 18:42 |
*** dasm is now known as dasm|off | 23:02 | |
opendevreview | Ghanshyam proposed openstack/nova master: Add service role in nova policy https://review.opendev.org/c/openstack/nova/+/864594 | 23:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!