| opendevreview | Ghanshyam proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | 05:26 |
|---|---|---|
| opendevreview | Nobuhiro MIKI proposed openstack/nova-specs master: Add maxphysaddr support for Libvirt https://review.opendev.org/c/openstack/nova-specs/+/861033 | 07:56 |
| opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor https://review.opendev.org/c/openstack/nova/+/867077 | 08:00 |
| sean-k-mooney | bauzas: hi i was wrogn yestereday johns ironic spec is not merged yet but im more or less happy with it https://review.opendev.org/c/openstack/nova-specs/+/862833 do you want to review or will i add +w | 10:54 |
| sean-k-mooney | there are a few nits that i think can be adressed in a followup but i dont see anything that would prevent us merging it as is | 10:54 |
| sean-k-mooney | gibi: i need to do one thing then grab coffee after that i will be staring to review the pci series | 11:31 |
| gibi | sean-k-mooney: OK. I replied to your comments about the rp_uuid vs rp_uuids | 11:31 |
| sean-k-mooney | ya i was just checkign that and going to ping you | 11:32 |
| sean-k-mooney | so based on your answer | 11:32 |
| sean-k-mooney | we are using that array for two different types | 11:33 |
| gibi | nope | 11:33 |
| sean-k-mooney | pool vs spec | 11:33 |
| gibi | pool has a single rp uuid, spec has a list of rp uuids serialized as comma separates string | 11:34 |
| sean-k-mooney | yes but ignored_tags is beign applied to both | 11:34 |
| gibi | ahh, yes that is applied to both yes | 11:35 |
| sean-k-mooney | ya so that is what was confusitng me | 11:35 |
| sean-k-mooney | since each type only have one fo the two field but we have on array of ignored tags | 11:35 |
| sean-k-mooney | anyway based on your comments and this converstaion i now understand the intent | 11:36 |
| sean-k-mooney | we might want to consider doing this diffently but i think im ok with this for now. but we my want to split this in a followup | 11:36 |
| gibi | I made a note and I will look into this | 11:37 |
| sean-k-mooney | ill leave a comment to that effect and see what stephen thinks when he gets to it and upgrade to +2 | 11:37 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/c/openstack/nova/+/659691 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/c/openstack/nova/+/670213 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Remove use of removeprefix https://review.opendev.org/c/openstack/nova/+/867788 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Remove unused mocks https://review.opendev.org/c/openstack/nova/+/867789 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for volume_target.* https://review.opendev.org/c/openstack/nova/+/867790 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.set_provision_state https://review.opendev.org/c/openstack/nova/+/867791 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.set_power_state https://review.opendev.org/c/openstack/nova/+/867792 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.vif* https://review.opendev.org/c/openstack/nova/+/867793 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for remaining network operations https://review.opendev.org/c/openstack/nova/+/867794 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for remaining ironic driver calls https://review.opendev.org/c/openstack/nova/+/867795 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for deprecated baremetal proxy API https://review.opendev.org/c/openstack/nova/+/867796 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Remove Ironic client wrapper https://review.opendev.org/c/openstack/nova/+/867797 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Remove unnecessary aliasing https://review.opendev.org/c/openstack/nova/+/867798 | 12:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use real SDK objects in tests https://review.opendev.org/c/openstack/nova/+/867799 | 12:51 |
| stephenfin | now back to reviews | 12:52 |
| opendevreview | Merged openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | 13:10 |
| sean-k-mooney | stephenfin: is that replaceing the ironic client usage with sdk | 13:13 |
| sean-k-mooney | we have a RFE bug for that if you were not aware can you link to that in the toic/commtis | 13:13 |
| * sean-k-mooney has not looked at the patches yet | 13:13 | |
| sean-k-mooney | gibi: bauzas this is the glace spec by the way that i mentioned yesterday https://review.opendev.org/c/openstack/glance-specs/+/863209 | 13:21 |
| bauzas | ok | 13:21 |
| sean-k-mooney | bauzas: did you see my ping for the ironic spec | 13:22 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/862833 | 13:23 |
| bauzas | sean-k-mooney: yup, I'll review about it | 13:23 |
| *** akekane is now known as abhishekk | 13:45 | |
| gibi | sean-k-mooney: I read through the glance spec above but I cannot really add much to it top of your and dansmith_s comments | 14:06 |
| sean-k-mooney | ack do you have any idea how backup works today? | 14:11 |
| sean-k-mooney | i always assumed we had glance details in our config | 14:11 |
| sean-k-mooney | backup predates microversion so i never really looked at the details sicne it also predates specs in nova | 14:12 |
| johnthetubaguy | bauzas: I am sort of around today if there are questions on the spec, in case that helps. | 14:12 |
| gibi | sean-k-mooney: never tried backup | 14:15 |
| johnthetubaguy | sean-k-mooney: I thought it was just a regular snapshot using the users token? Its not on a schedule, we just delete old ones after creating a new one... I thought. Been about 5 years since I tried it mind. Although those glance calls can also get a service token attached, to stop the user token expiry issues. | 14:16 |
| johnthetubaguy | you could require a service token, a bit like how we discussed for using user tokens for port binding in neutron | 14:17 |
| *** dasm|off is now known as dasm | 14:30 | |
| opendevreview | Merged openstack/python-novaclient master: tests: Fix Python 3.11 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/867270 | 14:42 |
| stephenfin | sean-k-mooney: yeah, exactly. What's the RFE/bug? | 14:43 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/nova master: Reproducer test of bug #1999674 https://review.opendev.org/c/openstack/nova/+/867807 | 15:00 |
| bauzas | johnthetubaguy: sean-k-mooney: fwiw, I'm on the spec since 30 mins | 15:11 |
| bauzas | should be done in 10 mins | 15:11 |
| sean-k-mooney | ack | 15:12 |
| * sean-k-mooney is multitasking lots of paperwork and reviews | 15:13 | |
| bauzas | johnthetubaguy: sean-k-mooney send to the gate with comments | 15:23 |
| bauzas | nothing important | 15:23 |
| bauzas | and as said, we can continue discussing about those during the implementation | 15:23 |
| bauzas | but I don't wanna hold this spec for this cycle | 15:23 |
| * bauzas goes off finding his child from the school | 15:23 | |
| opendevreview | Merged openstack/nova-specs master: Ironic shard_key to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | 15:35 |
| rloo | hi nova-folks. thanks johnthetubaguy for fixing https://bugs.launchpad.net/nova/+bug/1974070 because I need that fix in wallaby! Is this https://review.opendev.org/c/openstack/nova/+/864773 backportable, it added a new config option? | 16:02 |
| johnthetubaguy | rloo: your very welcome! I think it is backportable, because its a workaround config option, at least I think that is what we agreed. I haven't had chance to propose it myself though. | 16:05 |
| rloo | thx johnthetubaguy ! if i can recall how to, i'll try to propose them and see how that goes :) | 16:06 |
| rloo | btw johnthetubaguy, this didn't get merged, is it still desired? https://review.opendev.org/c/openstack/nova/+/842478 | 16:07 |
| opendevreview | Ruby Loo proposed openstack/nova stable/zed: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867642 | 16:09 |
| opendevreview | Konrad Gube proposed openstack/nova-specs master: Use extend volume completion action https://review.opendev.org/c/openstack/nova-specs/+/855490 | 16:17 |
| opendevreview | Konrad Gube proposed openstack/nova-specs master: Use extend volume completion action https://review.opendev.org/c/openstack/nova-specs/+/855490 | 16:24 |
| johnthetubaguy | rloo: good point, that is still needed for cases like when you mark and available node as in-maintenance but it gets picked before nova updates placement. we shouldn't need it work around automatic cleaning anymore though, so its more of an edge case now | 16:33 |
| opendevreview | John Garbutt proposed openstack/nova master: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/842478 | 16:33 |
| rloo | yes, i could see that being useful but am really interested (now anyway!) in the fix for cleaning. Thx johnthetubaguy, will keep an eye out for that one too if i remember. | 16:35 |
| johnthetubaguy | I kept running out of candidates that worked with the other fix, in the specific scenario where I was hitting the cleaning race, hence the better fix, kinda glad it didn't work first time, its a much better fix :) | 16:37 |
| rloo | definitely! | 16:41 |
| *** umbSubli1 is now known as umbSublime | 16:52 | |
| clarkb | bauzas: to followup on nova tox v4 compat my DNM change looked clean except for the openstacksdk functional job which is actually an openstacksdk tox.ini problem. I've pushed https://review.opendev.org/c/openstack/openstacksdk/+/867827 to address that (not sure if it is complete yet) | 17:00 |
| bauzas | on a meeting but ack | 17:03 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/nova master: Correctly reset instance task state in rebooting hard https://review.opendev.org/c/openstack/nova/+/867832 | 17:35 |
| sean-k-mooney | rloo: johnthetubaguy yes that shoudl be backporatble | 18:21 |
| sean-k-mooney | in fact since https://review.opendev.org/c/openstack/nova/+/867642 is proposed i might as well review it now | 18:22 |
| rloo | thx sean-k-mooney! I got a conflict when i tried to cherry pick to yoga, haven't yet had time to look at that. | 18:23 |
| sean-k-mooney | ack ill be around tomorrow as well but after that ill be back in the new year | 18:23 |
| sean-k-mooney | feel free to add me to them or ping me and ill happliy review the backports | 18:24 |
| rloo | Thanks sean-k-mooney!! | 18:24 |
| opendevreview | Merged openstack/nova master: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/842478 | 20:14 |
| opendevreview | Ruby Loo proposed openstack/nova stable/yoga: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867912 | 21:16 |
| *** blarnath is now known as d34dh0r53 | 22:29 | |
| opendevreview | Ruby Loo proposed openstack/nova stable/yoga: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867912 | 22:41 |
| *** sfinucan is now known as stephenfin | 22:55 | |
| opendevreview | Ruby Loo proposed openstack/nova stable/yoga: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867912 | 23:11 |
| opendevreview | Ruby Loo proposed openstack/nova stable/xena: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867338 | 23:14 |
| opendevreview | Ruby Loo proposed openstack/nova stable/xena: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867913 | 23:23 |
| opendevreview | Ruby Loo proposed openstack/nova stable/wallaby: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867914 | 23:24 |
| *** dasm is now known as dasm|off | 23:59 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!