| *** bhagyashris is now known as bhagyashris|ruck | 04:53 | |
| *** blarnath is now known as d34dh0r53 | 07:00 | |
| *** blarnath is now known as d34dh0r53 | 07:09 | |
| *** ozzzo1 is now known as ozzzo | 08:12 | |
| opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor https://review.opendev.org/c/openstack/nova/+/867077 | 09:10 |
|---|---|---|
| opendevreview | Nobuhiro MIKI proposed openstack/os-traits master: Add new 'COMPUTE_ADDRESS_SPACE_*' traits https://review.opendev.org/c/openstack/os-traits/+/871226 | 09:33 |
| kashyap | bauzas: sean-k-mooney: Can anyone please put this through? -- https://review.opendev.org/c/openstack/nova/+/870794/6 -- libvirt: At start-up allow skiping compareCPU() with a workaround | 10:38 |
| bauzas | kashyap: sure, adding on my today's list | 10:38 |
| kashyap | bauzas: FWIW, it is already tested in a real env by a downstream colleague | 10:41 |
| bauzas | kashyap: yup, I knew | 10:41 |
| kashyap | Ah, thx | 10:41 |
| sean-k-mooney | kashyap: so that is not really what i was asking for by th eway with the workaround | 10:41 |
| kashyap | sean-k-mooney: Sigh, what then? | 10:41 |
| sean-k-mooney | your orginal patch did this https://review.opendev.org/c/openstack/nova/+/869587/4/nova/virt/libvirt/driver.py | 10:42 |
| sean-k-mooney | removing both checks | 10:42 |
| sean-k-mooney | unconditionally | 10:42 |
| kashyap | sean-k-mooney: Right; but please see the discussion in the patch itself | 10:42 |
| sean-k-mooney | i wanted you to add the workaroudn if you were removing both checks | 10:42 |
| sean-k-mooney | the new one only removes the first check condtionally | 10:42 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/870794/6/nova/virt/libvirt/driver.py | 10:42 |
| kashyap | sean-k-mooney: Yes, the new one only removes the first check | 10:42 |
| kashyap | sean-k-mooney: That's because, the second check evaluates both model _and_ flags. So that is useful. | 10:43 |
| sean-k-mooney | if you wer only removing the first check but keeping the second i was ok with that being done unconditionally | 10:43 |
| kashyap | sean-k-mooney: Aaah | 10:43 |
| kashyap | I see | 10:43 |
| sean-k-mooney | right | 10:43 |
| sean-k-mooney | i wanted to keep the second correct check | 10:43 |
| kashyap | sean-k-mooney: So okay ... that is also a possibility | 10:43 |
| sean-k-mooney | so im ok with approving your currnt patch or you can just delete the first check | 10:43 |
| sean-k-mooney | its up to you | 10:43 |
| kashyap | sean-k-mooney: I can remove the first one unconditionally and keep the second under the workaround | 10:43 |
| sean-k-mooney | i dont think you need the workaround | 10:44 |
| sean-k-mooney | if you just delete the second one | 10:44 |
| sean-k-mooney | *first one | 10:44 |
| kashyap | Right. | 10:44 |
| sean-k-mooney | but if you want to future proof then sure you can put the remain check under a workaroudn | 10:44 |
| sean-k-mooney | anyway let me knwo which you would prefer | 10:44 |
| sean-k-mooney | the curernt patch https://review.opendev.org/c/openstack/nova/+/870794/6/nova/virt/libvirt/driver.py | 10:45 |
| sean-k-mooney | or just delete the first check | 10:45 |
| kashyap | sean-k-mooney: Yes, I want to future-proof it a bit by keeping the 2nd part under the workaround | 10:45 |
| kashyap | We can't test all possible CPU models on all hardware | 10:45 |
| kashyap | This check can prove to be useful | 10:45 |
| kashyap | sean-k-mooney: How about this: | 10:45 |
| sean-k-mooney | ok gibi ^ does that work for you | 10:45 |
| kashyap | remove the first check and keep the second one under the workaround. | 10:45 |
| sean-k-mooney | sure the second check is not under the workaround in the current patch by the way | 10:46 |
| sean-k-mooney | but im ok with what you are suggesting | 10:46 |
| kashyap | sean-k-mooney: Yes, yes. I know :) | 10:46 |
| bauzas | kashyap: shall I hold reviewing ? | 10:46 |
| kashyap | bauzas: Yes, pls | 10:47 |
| bauzas | k | 10:47 |
| bauzas | anyway, I need to do gym | 10:47 |
| gibi | sean-k-mooney, kashyap: removing the first check unconditionally and making the second check conditionally (and by default executed) works for me | 11:24 |
| kashyap | gibi: Nod; reworking ... the unit test | 11:25 |
| artom | bauzas, hey, so after gym, would https://review.opendev.org/c/openstack/nova/+/869812 be good to go? | 11:42 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/870794 | 11:49 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | 11:49 |
| kashyap | gibi: sean-k-mooney: --^ | 11:49 |
| kashyap | gibi: (I've also readjusted the wording where appropriate from the old patch) | 11:52 |
| kashyap | (Lost the +W on the 2nd patch) | 11:53 |
| gibi | kashyap: done. I'm happy that we found a solution that is acceptable to all involved parties | 12:37 |
| kashyap | gibi: Yes :) | 12:38 |
| kashyap | Thank you! | 12:38 |
| gibi | folks https://review.opendev.org/c/openstack/tempest/+/870974 just merged to skip the test case that causes OOM on the gate, so it should be easier now to land patches | 12:51 |
| kashyap | gibi: Ahh, I still have to fix 3-4 unit tests; just noticed. :( | 12:51 |
| gibi | kashyap: no worries, ping me and I can re-review | 12:51 |
| kashyap | Thanks | 12:51 |
| opendevreview | Merged openstack/nova master: Split ignored_tags in stats.py https://review.opendev.org/c/openstack/nova/+/867978 | 13:22 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Handle InstanceInvalidState exception https://review.opendev.org/c/openstack/nova/+/861738 | 13:25 |
| opendevreview | Elod Illes proposed openstack/nova stable/xena: nova-live-migration tests not needed for Ironic https://review.opendev.org/c/openstack/nova/+/855469 | 13:33 |
| bauzas | artom: verifying now | 14:18 |
| bauzas | artom: sending to the gate | 14:20 |
| artom | Cheers! | 14:22 |
| *** dasm|off is now known as dasm | 14:52 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out a mixin class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | 15:15 |
| * kashyap wonders what he's messing up with this unit test to get the TypeError - https://paste.opendev.org/show/bhbh4HNg0mAxWOKxqOAV/ | 15:16 | |
| kashyap | (It's failing as a result of my: https://review.opendev.org/c/openstack/nova/+/870794) | 15:16 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Show candidate combinatorial explosion by dev number https://review.opendev.org/c/openstack/nova/+/855885 | 15:18 |
| gibi | kashyap: noted the issue in https://review.opendev.org/c/openstack/nova/+/870794/7#message-a9e217530aaca46763329444a8776bc1eb1948d8 | 15:28 |
| kashyap | gibi: Duuh, I thought I was careful w/ the spaces and still messed | 15:29 |
| kashyap | Thanks for the eagle eyes, /me goes to fix... | 15:29 |
| opendevreview | Andre Aranha proposed openstack/nova stable/yoga: Test setting the nova job to centos-9-stream https://review.opendev.org/c/openstack/nova/+/860087 | 15:35 |
| opendevreview | Andre Aranha proposed openstack/nova stable/yoga: Test setting the nova job to centos-9-stream https://review.opendev.org/c/openstack/nova/+/860087 | 15:36 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/870794 | 15:38 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | 15:38 |
| kashyap | Hmm, one more UT to debug (unrelated to the formatting issue). | 15:43 |
| opendevreview | Dan Smith proposed openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | 15:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | 15:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Add get_available_node_uuids() to virt driver https://review.opendev.org/c/openstack/nova/+/863917 | 15:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | 15:57 |
| opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | 15:58 |
| opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | 15:58 |
| opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | 16:07 |
| opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | 16:07 |
| opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | 16:07 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out a mixin class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | 16:18 |
| opendevreview | David Hill proposed openstack/nova master: Change maximum value of pcie-ports to 64 https://review.opendev.org/c/openstack/nova/+/871305 | 16:44 |
| gibi | bauzas: fyi, all the mandatory pieces of bp/pci-device-tracking-in-placement has been landed. So the bp can be set completed in A. | 16:47 |
| gibi | there are two open patches https://review.opendev.org/q/topic:bp/pci-device-tracking-in-placement+status:open one is a small refactor that might or might not land. The other is just a demonstrator that we have a "limitation" | 16:48 |
| sean-k-mooney | congrats | 16:51 |
| gibi | It would have been impossible without sean-k-mooney's and stephenfin's help. thank you! | 16:58 |
| opendevreview | David Hill proposed openstack/nova master: Change maximum value of pcie-ports to 64 https://review.opendev.org/c/openstack/nova/+/871305 | 17:12 |
| opendevreview | David Hill proposed openstack/nova master: Change maximum value of pcie-ports to 32 https://review.opendev.org/c/openstack/nova/+/871305 | 17:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!