| *** ministry is now known as __ministry | 03:22 | |
| opendevreview | Ghanshyam proposed openstack/nova master: Add service role in nova policy https://review.opendev.org/c/openstack/nova/+/864594 | 05:26 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870933 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870937 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Add reset_encryption_fields() and save_all() to BlockDeviceMappingList https://review.opendev.org/c/openstack/nova/+/870938 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Update driver BDMs with ephemeral encryption image properties https://review.opendev.org/c/openstack/nova/+/870939 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | 05:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | 05:42 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Added a lock_unlock dcorator for instance https://review.opendev.org/c/openstack/nova/+/873648 | 05:56 |
| gibi_ | bauzas: the tempest fix laneded so I'm inclined to fast approve the revert of the ceph non voting patch https://review.opendev.org/c/openstack/nova/+/873590 | 08:57 |
| bauzas | gibi_: do it fer sur | 08:57 |
| * bauzas doing rechecks atm | 08:57 | |
| gibi_ | me too | 08:58 |
| bauzas | gibi_: I'm telling 'recheck Ia72b50f7f7bf64fe0ddd3f1a415b1807ff264b66 merged.' | 08:59 |
| *** gibi_ is now known as gibi | 09:00 | |
| gibi | bauzas: fyi I put a -1 on https://review.opendev.org/c/openstack/nova/+/873560 as it needs the cinder deps land first but they are not in a landing state | 09:16 |
| bauzas | gibi: yup, I had open comments that I didn't uploaded in Gerrit | 09:17 |
| gibi | I think I did what I could now so I'm switching to my other duty for a while. feel free to ping me if my eyes are needed on something here | 09:18 |
| bauzas | ++ | 09:18 |
| * bauzas disappears for the gym, back in 1.5h | 10:45 | |
| gibi | bauzas: ahh gmann caught that the tempest fix merged before we was able to merge the ceph non voting job. So I'm abandoning that non-voting and voting again series | 12:34 |
| bauzas | gibi: sec, what ? | 12:34 |
| gibi | bauzas: we never merged the ceph non voting patch, as the tempest fix merged first, then gmann stopped the merging of the non voting patch | 12:46 |
| bauzas | Ack ok then no worries | 13:02 |
| *** dasm|off is now known as dasm | 13:10 | |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/845748 | 13:10 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | 13:10 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/845754 | 13:11 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/ussuri: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/873575 | 13:13 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/845748 | 13:14 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | 13:14 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/845754 | 13:14 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/ussuri: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/873576 | 13:24 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/ussuri: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/873577 | 13:25 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/train: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/873578 | 13:27 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/train: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/873579 | 13:27 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/train: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/873580 | 13:28 |
| * bauzas feels like he's paid for troubleshooting all the jobs | 14:18 | |
| bauzas | gibi: looks like we have a problem with https://review.opendev.org/c/openstack/requirements/+/873416 | 14:27 |
| bauzas | I opened a discussion in the #openstack-requirements chat | 14:27 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/845748 | 15:03 |
| bauzas | reminder: nova meeting here in 42 mins | 15:18 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova stable/train: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851226 | 15:25 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova stable/train: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/873722 | 15:25 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/845748 | 15:32 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | 15:32 |
| gibi | bauzas: ack, I think that failure is all over the uc bump patches | 15:41 |
| gibi | bauzas: at least we have now patches in the nova gate queue :) | 15:41 |
| bauzas | yup | 15:41 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Feb 14 16:00:43 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| bauzas | howdy | 16:00 |
| bauzas | what a crazy week | 16:00 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:01 |
| bauzas | who's around ? | 16:01 |
| elodilles | o/ | 16:01 |
| bauzas | . | 16:01 |
| auniyal | o/ | 16:02 |
| bauzas | .. | 16:02 |
| bauzas | I can start a monolog, and people can join meanwhile | 16:03 |
| gibi | o/ | 16:03 |
| bauzas | #topic Bugs (stuck/critical) | 16:03 |
| bauzas | #info No Critical bug | 16:03 |
| * gibi here for the monologs | 16:03 | |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 17 new untriaged bugs (-11 since the last meeting) | 16:03 |
| bauzas | great numbers | 16:03 |
| bauzas | artom: thanks for that | 16:05 |
| gibi | oh wao | 16:05 |
| gibi | kudos artom | 16:05 |
| * bauzas was checking who was the owner last week :) | 16:05 | |
| bauzas | next in the roster is Uggla but he's on PTO till next week | 16:06 |
| bauzas | and next in the queue is sean (I'll avoid to highlight him, he needs rest :) ) | 16:06 |
| bauzas | so, I can try to triage a few bugs this week | 16:06 |
| bauzas | I mean, this isn't like I'm already doing a shit ton of bugs checks | 16:07 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:07 |
| bauzas | #info bug baton is being passed to bauzas this week | 16:07 |
| gibi | bauzas: thansk | 16:07 |
| bauzas | #topic Gate status | 16:08 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:08 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures | 16:08 |
| bauzas | that was (and that still is) an hectic week | 16:08 |
| bauzas | tl;dr: our gate was blocked but we eventually merged the fix | 16:08 |
| bauzas | but now we continue to have a ton of CI false positives with vif plugged events missed and other funs | 16:09 |
| bauzas | I must to admit I beg people to share my pain | 16:09 |
| gibi | I do share your pain | 16:10 |
| gibi | for some degree | 16:10 |
| opendevreview | Kashyap Chamarthy proposed openstack/nova stable/train: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/873722 | 16:10 |
| bauzas | anything now to raise except complaining that you do lots of rechecks ? | 16:10 |
| gibi | one thing | 16:10 |
| gibi | please be aware that upper constraints bumps cannot be merged at the moment due to failures | 16:11 |
| bauzas | oh that | 16:11 |
| bauzas | forgot to mention | 16:11 |
| gibi | so even though we released os-traits 2.10 | 16:11 |
| gibi | we cannot use that yet in placement and nova | 16:11 |
| bauzas | yeah, tbc, that's not only the nova master gate which is broken broken (c) elodilles | 16:11 |
| bauzas | the requirements project do has its own pain, and tempest too | 16:12 |
| gibi | yeah as far as I see every u-c bump is blocked | 16:12 |
| bauzas | correct | 16:12 |
| bauzas | we discussed that in #openstack-requirements earlier today | 16:12 |
| bauzas | there is a fix in the air | 16:12 |
| bauzas | but, | 16:12 |
| elodilles | it seems virtualenv release came just in time | 16:12 |
| bauzas | there is another open issue | 16:12 |
| bauzas | elodilles: yeah, that's lovely, a perfect Murphy timing | 16:13 |
| elodilles | bauzas: could have been worse -> more closer to release date :) | 16:13 |
| bauzas | not sure it changes anything tho | 16:13 |
| bauzas | but let's jump to the next topic | 16:14 |
| bauzas | fwiw, looking at https://etherpad.opendev.org/p/recheck-weekly-summary | 16:14 |
| bauzas | I can still see around 18% of rechecks that are bare rechecks | 16:14 |
| bauzas | this is desesperating | 16:14 |
| bauzas | I mean, we know we have CI failures | 16:14 |
| bauzas | but if you just call 'recheck' without further info, you basically piss off your problems | 16:15 |
| bauzas | and you make looking that you don't care about the CI, then why should we care about your own patches then ? | 16:15 |
| gibi | nova is on 13.5% that is an improvement from the last 90 days (18.5%) | 16:15 |
| bauzas | I'd like to be optimistic | 16:16 |
| bauzas | I know that debugging a CI failure is tricky | 16:16 |
| bauzas | but if you don't make the effort to try looking, then basically that means you don't care | 16:16 |
| * bauzas is grumpy today, sorry | 16:17 | |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:17 |
| bauzas | all greens | 16:17 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:17 |
| bauzas | (that's a wish) | 16:17 |
| bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:17 |
| bauzas | (that's a formal ask) | 16:17 |
| bauzas | next topic for the fun ? | 16:18 |
| gibi | one thing about CI | 16:18 |
| bauzas | sure | 16:18 |
| gibi | maybe we should make an dedicated effort next cycle to fix up CI first before we jump on adding new features | 16:19 |
| gibi | maybe, asking people with feature proposals to take a gate bug first | 16:19 |
| bauzas | gibi: that's litterally already in the PTG agenda :) | 16:19 |
| gibi | bauzas++ | 16:19 |
| bauzas | well, I was less harsh | 16:19 |
| bauzas | but I opened a bullet point about CI failures and I had some ideas | 16:19 |
| bauzas | I wrote some email yesterday | 16:20 |
| bauzas | if people want recognition, I offer them a Great Way to Be Recognized | 16:20 |
| gibi | cool | 16:20 |
| bauzas | moving on then (fwiw, I like your idea to somehow ask people to show some dedication to upstream while they propose) | 16:21 |
| kashyap | gibi: Fixed the thing in the above train backport too: https://review.opendev.org/c/openstack/nova/+/873722 | 16:21 |
| bauzas | this is actually a great jump to the next topic | 16:21 |
| kashyap | (Err, sorry; there's a meeting going on) | 16:21 |
| bauzas | kashyap: in a meeting | 16:21 |
| kashyap | Yep, yep; saw that | 16:21 |
| bauzas | moving on | 16:21 |
| bauzas | #topic Release Planning | 16:22 |
| bauzas | #link https://releases.openstack.org/antelope/schedule.html | 16:22 |
| bauzas | #info Antelope-3 is in 2 days | 16:22 |
| bauzas | #info FeatureFreeze is in 2 days | 16:22 |
| bauzas | #link https://etherpad.opendev.org/p/nova-antelope-blueprint-status Blueprint status for 2023.1 | 16:22 |
| bauzas | here, I'm also a bit grumpy | 16:22 |
| bauzas | we approved a couple of blueprints but despite this, a very few of them are actually reviewable | 16:23 |
| bauzas | the os-bricks issue prevents one to correctly get reviewed, but alas, the series is even not fully complete | 16:23 |
| bauzas | os-traits, not os-brick my bad | 16:23 |
| bauzas | so, yeah, back to gibi's proposal, I think we may be harsher next cycle | 16:24 |
| gibi | don't forget this was a shorter cycle | 16:24 |
| bauzas | and ask people to show some evidence of work | 16:24 |
| bauzas | gibi: that's a valid point | 16:24 |
| bauzas | I'm maybe overreacting | 16:24 |
| gibi | it is always emotional before FF | 16:24 |
| elodilles | next cycle will be longer :) | 16:24 |
| elodilles | 28 weeks | 16:25 |
| bauzas | compared to 24, correct ? | 16:25 |
| elodilles | yepp | 16:25 |
| bauzas | well, we'll see then | 16:25 |
| gibi | imageine how much recheck we could do in an extra month :D | 16:25 |
| opendevreview | Merged openstack/nova master: Add logging to find test cases leaking libvirt threads https://review.opendev.org/c/openstack/nova/+/872975 | 16:25 |
| bauzas | gibi: :D | 16:25 |
| bauzas | oh wow ^ | 16:25 |
| elodilles | \o/ | 16:26 |
| gibi | bauzas: now I need not to forget to check for that logs | 16:26 |
| gibi | in the coming days | 16:26 |
| bauzas | gibi: (off-meeting, I'll write a revert patch ;) ) | 16:26 |
| gibi | bauzas: good point | 16:26 |
| bauzas | yup | 16:26 |
| bauzas | anyway, back to the release | 16:26 |
| bauzas | I think we made good progress on reviews | 16:26 |
| bauzas | if we missed something or some patch, feel free to amend the etherpad please | 16:27 |
| bauzas | or comment it out | 16:27 |
| bauzas | I did a bit of research and digging but I think I found all the open changes | 16:27 |
| bauzas | moving on then, unless someone caring about an accepted blueprint makes to take the opportunity to raise a concern ? | 16:28 |
| gibi | yeah please cry out loudly if your series has a chance to land in the next two day and you lack reviews | 16:28 |
| bauzas | ++ | 16:29 |
| bauzas | ok, let's jump to the next one | 16:30 |
| bauzas | #topic vPTG Planning | 16:30 |
| bauzas | will be short | 16:30 |
| bauzas | just a reminder | 16:30 |
| bauzas | #link https://www.eventbrite.com/e/project-teams-gathering-march-2023-tickets-483971570997 Register your free ticket | 16:30 |
| bauzas | #link https://etherpad.opendev.org/p/nova-bobcat-ptg Draft PTG etherpad | 16:30 |
| bauzas | feel free to add the items you wanna discuss in ^ | 16:30 |
| bauzas | #topic Review priorities | 16:30 |
| bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:30 |
| bauzas | I'll be honest, I lost my attention | 16:30 |
| bauzas | but I'll try to look at those once we cut m-3 | 16:31 |
| bauzas | #info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review | 16:31 |
| bauzas | #topic Stable Branches | 16:31 |
| bauzas | elodilles: showcase. | 16:31 |
| elodilles | ~o~ | 16:31 |
| elodilles | #info ussuri and train gates are fixed (ensure-rust role was added to grenade and tempest jobs) | 16:32 |
| elodilles | #info stable/victoria gate is blocked (failing openstacksdk-functional-devstack job needs to be removed: https://review.opendev.org/c/openstack/nova/+/873295 similarly as in wallaby) | 16:32 |
| elodilles | #info rest of the stable branches seem to be OK | 16:32 |
| elodilles | or at least unblocked | 16:32 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:32 |
| elodilles | i think that is all i can tell now | 16:32 |
| bauzas | cool | 16:34 |
| bauzas | I just rechecked the CVE fix for the ussuri branch | 16:34 |
| bauzas | should land hopefully | 16:34 |
| elodilles | fingers crossed | 16:34 |
| gibi | bauzas: do we have CVE fix for stable/train? | 16:34 |
| gibi | or we punted on that? | 16:35 |
| gibi | due to oslo | 16:35 |
| bauzas | gibi: as I said last week, I loudly said no to it | 16:35 |
| gibi | OK | 16:35 |
| bauzas | if someone wants to propose it, fair | 16:35 |
| gibi | thanks for the refrsh | 16:35 |
| bauzas | but yeah, due to the oslo.utils dep, that's not gonna be a fun conversation | 16:35 |
| bauzas | and most distros now include the fix in their own products | 16:35 |
| bauzas | that's it. | 16:36 |
| gibi | thanks | 16:36 |
| bauzas | #topic Open discussion | 16:36 |
| bauzas | anything anyone ? | 16:36 |
| bauzas | the agenda is empty | 16:37 |
| gibi | I assume that if there are no loud cries for review on the week of FF then we are done a good job :) | 16:38 |
| artom | So I have a weird thing | 16:38 |
| artom | https://opendev.org/openstack/nova/src/branch/master/nova/image/glance.py#L392 | 16:38 |
| artom | Count the length of that line | 16:38 |
| * bauzas calls len() | 16:39 | |
| artom | (We could also end the meeting and chat about that in "normal" IRC) | 16:39 |
| gibi | 83? | 16:40 |
| bauzas | artom: sure, that's a good point | 16:40 |
| bauzas | I have 82 | 16:40 |
| auniyal | 1116 | 16:40 |
| artom | Yep. So... what's our pep8 job doing? | 16:40 |
| bauzas | but AFAIR, we only enforce line lengths on code | 16:40 |
| bauzas | that has to be doublechecked | 16:40 |
| bauzas | anyway | 16:41 |
| bauzas | let's wrap it now and chase this question outside of the meeting | 16:41 |
| bauzas | thanks all | 16:41 |
| bauzas | #endmeeting | 16:41 |
| opendevmeet | Meeting ended Tue Feb 14 16:41:22 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:41 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-02-14-16.00.html | 16:41 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-02-14-16.00.txt | 16:41 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-02-14-16.00.log.html | 16:41 |
| bauzas | so | 16:41 |
| bauzas | we now enforce the line lengths by a pre-commit | 16:41 |
| bauzas | not sure our tox pep8 target continues to check it | 16:42 |
| artom | I only noticed it because a downstream pep8 job failed | 16:42 |
| artom | It's from a commit in 2020 | 16:42 |
| artom | https://review.opendev.org/c/openstack/nova/+/738738 | 16:42 |
| bauzas | oh | 16:42 |
| bauzas | no, I'm wrong | 16:42 |
| bauzas | we autopep8 it with the pep8 target | 16:42 |
| bauzas | https://github.com/openstack/nova/blob/master/tox.ini#L100 | 16:43 |
| clarkb | bauzas: the --inplace flag doesn't appear to be a currently documented flag. Maybe it is fixing your code in CI and the flake8 passes after | 16:45 |
| bauzas | clarkb: that's my guess but that doesn't explain this https://opendev.org/openstack/nova/src/branch/master/nova/image/glance.py#L392 | 16:46 |
| clarkb | looking at the flake8 script it passes in the target posargs as the arguments to flake8 | 16:50 |
| clarkb | the CI jobs don't have posargs by default (you could override them though I think, but I'm not seeing that in logs). Does flake8 check things without args? | 16:51 |
| clarkb | you might simply be not checking things? I dunno | 16:51 |
| gibi | I just tried, flake8 check all files if called without args and it finds the long line I add in nova/image/glance.py but not the L392 | 16:53 |
| clarkb | autopep8 relies on pycodestyle to know whento change things too. Maybe the issue is in pycodestyle then where it doesn't see that as a problem so neither autopep8 nor flake8 complain | 16:54 |
| artom | Yeah, same here. And it's not a comment thing (at least with # ) because if I comment out the long line it still finds it | 16:54 |
| gibi | artom: yeah, I added a long line in the same doc comment and it finds that | 16:55 |
| artom | Ah, but apparently not the *first* line? | 16:56 |
| artom | So yeah | 16:56 |
| artom | def _get_verifier(self, context, image_id, trusted_certs): | 16:56 |
| artom | """Really long line long long long long long long long long long long long | 16:56 |
| artom | Really long line long long long long long long long long long long long long long | 16:56 |
| artom | """ | 16:56 |
| artom | It complains about the second line (without """) | 16:56 |
| artom | But not the first line | 16:56 |
| gibi | yeah it seems the leading line is ignored | 16:57 |
| clarkb | is the threshold different? I wonder if it complains eventually | 16:57 |
| gibi | I moved L392 to a new line and padded it with 3 leading char and it finds it | 16:57 |
| gibi | yeah if I pad the leading line with 10 extra chars then it finds it | 16:58 |
| artom | Is that a bug in hacking or pep8? As I said, a downstream pep8 check does find it, using an older version of hacking/pep8 I think | 16:58 |
| clarkb | artom: considering that autopep8 which also relies on pycodestyle doesn't complain about it either probably a thing in pycodestyle | 16:59 |
| artom | Ah, so it looks like it ignores the leading """ or something? | 16:59 |
| gibi | I have to add 6 or more chars to get a failure | 17:00 |
| gibi | and when I get the failure it says line too long (80 > 79 characters) | 17:00 |
| gibi | so it is counting the charachters wrongly | 17:00 |
| gibi | as at that point the line is 88 chars long | 17:01 |
| gibi | what else will break on us this week?!?! | 17:03 |
| artom | Presumably that's been broken for a while, and it's minor | 17:03 |
| artom | Ah https://github.com/PyCQA/pycodestyle/issues/679 | 17:05 |
| artom | Which leads down the rabbit hole https://github.com/PyCQA/flake8/issues/1534 | 17:05 |
| artom | Seems like it should be fixed in flake8 5.0.0? | 17:06 |
| gibi | nice | 17:10 |
| artom | Ah, I think our flake8 is capped by our hacking version | 17:10 |
| artom | hacking>=3.1.0,<3.2.0 # Apache-2.0 | 17:10 |
| artom | From test-requirements | 17:10 |
| gibi | that will be a "nice" bump to make | 17:11 |
| artom | I imagine there's a reason that it was there in the first place? | 17:12 |
| artom | All I can find is https://review.opendev.org/c/openstack/nova/+/727589 | 17:12 |
| artom | Which appears to just decide that 3.2.0 is the max for some reason | 17:12 |
| gibi | even if we bump hacking to the maximum we only get to flake8 4.0 https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L1 | 17:17 |
| artom | Huh, so why is that capped | 17:19 |
| artom | No documented reason that I can see, even going back as far as e664ef421c60ade4c2557e8d7029b81ccb8478a0 | 17:21 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Revert "Add logging to find test cases leaking libvirt threads" https://review.opendev.org/c/openstack/nova/+/873584 | 17:21 |
| bauzas | gibi: artom: sorry, I got distracted by other embargoed things | 17:23 |
| gibi | artom: with hacking 5.0.0 (max) we have couple of findings https://paste.opendev.org/show/bQD8LQ9tmyPFD0NouJnv/ but nothing major | 17:23 |
| bauzas | so yeah, like I said, I think the linter doesn't check the line length on a docstring | 17:23 |
| artom | gibi, ok, but flake8 is still stuck on 4.0.1, so it doesn't catch the line length thing | 17:24 |
| artom | I don't feel like I know enough about the release sausage to propose an increase in the cap of flake8 and hacking | 17:25 |
| bauzas | gibi: it doesn't block our gate, does it ? | 17:25 |
| artom | It feels like we should, though... | 17:25 |
| artom | bauzas, no, it's cosmetic and minor | 17:25 |
| bauzas | I'm very afraid of bumping our hacking requirements so close to the holy FF | 17:26 |
| artom | bauzas, bumping *our* hacking requirement wouldn't be enough | 17:26 |
| artom | We'd need to bump *hacking's* flake8 cap | 17:26 |
| bauzas | I see | 17:26 |
| artom | Which sounds even worse | 17:26 |
| bauzas | if it's cosmetic, then you have MHO | 17:26 |
| bauzas | probably better to just change the docstring | 17:27 |
| gibi | artom: bumping hacking to flake8 5.0.4 causes unit test failures in hacking :/ | 17:27 |
| artom | Wow, wtf | 17:27 |
| bauzas | but if that doesn't cause any harm, please defer it to Bobcat | 17:27 |
| gibi | hold on, that might be not due to flake8 5.0.4 | 17:28 |
| gibi | bauzas: don't worry we won't bump hacking now :) | 17:28 |
| bauzas | I mean, another library upgrade and then I get a heartbroke | 17:29 |
| gibi | yeah the unit test of hacking fails on me on master too :/ | 17:30 |
| artom | Err | 17:30 |
| artom | I guess stuff changed, and the unit tests job just never ran? | 17:30 |
| gibi | anyhow I think the whole 1) bump hacking to use flake8 5.0 3) release a new hacking 2) bump nova to use latest hacking. Is doable probably. | 17:31 |
| gibi | artom: or my local env is bork | 17:31 |
| gibi | we will see https://review.opendev.org/c/openstack/hacking/+/873737 | 17:33 |
| gibi | and I'm feeling lucky https://review.opendev.org/c/openstack/hacking/+/873738 | 17:35 |
| artom | You absolute madlad | 17:37 |
| gibi | I don't know what was in my afternoon coffee but I feel like a squirrel on cocain | 17:39 |
| artom | Well you just answered your own questions. You coffee contained squirrels. And cocaine. | 17:39 |
| gibi | :D | 17:39 |
| gibi | interestingly it is from the same batch of beans that I used in the last couple of weeks without such effect. | 17:40 |
| artom | So obviously this morning a squirrel decided to use it to stash its cocaine. | 17:41 |
| gibi | yepp the hacking unit test on master fails in CI too https://13105f8ef823650ec019-cb65abe58d87a1a010092a9adcbaff91.ssl.cf2.rackcdn.com/873737/1/check/openstack-tox-py38/9f6af81/testr_results.html | 17:43 |
| gibi | those squirrels should go and fix it instead of dealing with substances | 17:44 |
| artom | Seriously, what good is a cocaine habit if you're not putting it to good use | 17:45 |
| gibi | you are absolutely right :) | 17:48 |
| gibi | ... when you realize that the last commit in hacking was coming from you... | 17:52 |
| gibi | so the unit test failure in hacking is due to the new tox versions somehow, in a yoga container I can run the test successfuly on master with tox 4 I cannot. There is some magic in load_test in import pdb; pdb.set_trace() | 18:07 |
| gibi | I mean https://github.com/openstack/hacking/blob/2931131b69af7f1e76d8ab506c250a94b330ffb9/hacking/tests/test_doctest.py#L70 | 18:08 |
| gibi | this change makes the tests pass for me https://review.opendev.org/c/openstack/hacking/+/873740 locally. So I moved the flake8 5.0 bump top of it https://review.opendev.org/c/openstack/hacking/+/873738 | 18:15 |
| artom | Nice, thanks for taking care of that | 18:22 |
| gibi | now that the tests are running we see some real failures from the flake8 5.0 bump https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dcc/873738/2/check/openstack-tox-py310/dccd580/testr_results.html | 18:23 |
| gibi | but the coffee is wearing off so I stop here now. artom feel free to pick ^^ up | 18:24 |
| artom | gibi, ack, cheers! | 18:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!