opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/876931 | 03:13 |
---|---|---|
opendevreview | Rajesh Tailor proposed openstack/nova master: Fix duplicate cell creation with same name https://review.opendev.org/c/openstack/nova/+/876940 | 07:08 |
dvo-plv | Hello, Could you please help me with zuul regression. https://review.opendev.org/c/openstack/nova/+/876075/ I have two components, nova depends on os-traits. I use Depends-on variable to link them, but it does not work for me. | 08:37 |
opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/876931 | 09:02 |
elodilles | bauzas: hi, fyi, reno workaround was released and upper constraints was bumped, so this is good to go now: https://review.opendev.org/c/openstack/nova/+/876553 | 09:34 |
gibi | elodilles: +2 | 10:48 |
opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | 10:52 |
elodilles | thx :] | 10:56 |
bauzas | elodilles: sent to the gate | 10:58 |
bauzas | Uggla: btw. not sure you've seen my comment https://review.opendev.org/c/openstack/releases/+/876758 | 10:58 |
bauzas | Uggla: you probably need to update both your Gerrit config and your git ownership | 10:59 |
Uggla | Hello bauzas , not yet I will have a look | 10:59 |
bauzas | Uggla: tl;dr your git user.email is different from your gerrit config | 11:00 |
bauzas | and make sure you have a full name in https://review.opendev.org/settings/#Profile | 11:01 |
Uggla | bauzas, yes I use my personal one for the fondation and gerrit | 11:01 |
bauzas | Uggla: cool, so please changing your git user.email value for this repo | 11:02 |
bauzas | I'll myself update then the liaison email to be your personal email | 11:03 |
Uggla | bauzas, ok I will check after lunch. | 11:03 |
bauzas | Uggla: elodilles: updated https://review.opendev.org/c/openstack/releases/+/876758 | 11:05 |
elodilles | bauzas: +2'd. let me know if we can merge that. | 11:26 |
sean-k-mooney | elodilles: from my perspective yes that is suitable to merge | 12:19 |
ratailor_ | sean-k-mooney, elodilles bauzas gibi can I get reviews on my patches https://review.opendev.org/c/openstack/nova/+/873901 https://review.opendev.org/c/openstack/nova/+/860938 https://review.opendev.org/q/Id4c8c5f3b32985ac7d3d7c833b82e0876f7367c1 https://review.opendev.org/q/Ia738a0972b050f549f446c85171d3f33e60ada4f saome are under review since long time. | 12:41 |
sean-k-mooney | we are currently minimising the patches we merge to master until after the final RC deadline | 12:42 |
sean-k-mooney | which is march 20th | 12:42 |
sean-k-mooney | we technically could merge this now but we likely will wait until after that | 12:43 |
ratailor_ | sean-k-mooney, ack. sure. Thanks! | 12:43 |
sean-k-mooney | ill see if i can find tiem to review but we will likely hold +w for another week or so | 12:43 |
ratailor_ | sean-k-mooney, ack. np. | 12:43 |
bauzas | we can merge some bugfixes if we want, that's not a problem | 12:50 |
dvo-plv | Hello, Could you please help me with zuul regression. https://review.opendev.org/c/openstack/nova/+/876075/ I have two components, nova depends on os-traits. I use Depends-on variable to link them, but it does not work for me. | 12:51 |
dvo-plv | I found that it install os-trait from pip | 12:52 |
dvo-plv | 2023-03-09 11:15:37.630 | Collecting os-traits===2.10.0 2023-03-09 11:15:37.634 | Downloading https://mirror-int.dfw.rax.opendev.org/pypifiles/packages/77/ce/66b9fc86ab69e4ad60d07901e9324cb44d72c75b9b0a989bfef0fc4ad4e3/os_traits-2.10.0-py3-none-any.whl (41 kB) | 12:52 |
dvo-plv | this log from here | 12:52 |
dvo-plv | https://6e5de493453a596bf54b-e12a251c5f6363a4d35eb8aac39c4442.ssl.cf2.rackcdn.com/876075/3/check/tempest-integrated-compute-ubuntu-focal/270fa66/controller/logs/devstacklog.txt | 12:52 |
sean-k-mooney | if its not listed as a required project depends on does not work | 12:55 |
sean-k-mooney | i would guess that that is the isseu there with that job | 12:55 |
sean-k-mooney | looking at the parent of the job that is indeed the case | 12:57 |
sean-k-mooney | you could add it as a required project here https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L146-L166 | 12:58 |
sean-k-mooney | you woudl add | 12:59 |
sean-k-mooney | required-projects: | 12:59 |
sean-k-mooney | - openstack/os-traits | 12:59 |
opendevreview | Jorge San Emeterio proposed openstack/nova master: Re-enable "test_tagged_attachment" test. https://review.opendev.org/c/openstack/nova/+/876699 | 13:04 |
opendevreview | Merged openstack/nova master: Update master for stable/2023.1 https://review.opendev.org/c/openstack/nova/+/876553 | 13:06 |
dvo-plv | Sean, do I need to fix all gates or only for integrated-compute. Because it looks like depends-on veriable does not work for all tempest jobs | 13:41 |
sean-k-mooney | it will work only for required proejct im not sure we want to supprot it in general for os-vif | 14:26 |
sean-k-mooney | *os-traits | 14:26 |
sean-k-mooney | tis somethign we shoud discuss | 14:26 |
sean-k-mooney | if we were to fix it for all tempet jobs we woudl do so in the devstack base job | 14:26 |
sean-k-mooney | however os-traits is a libary and we normally want ot only use that from pypi release | 14:27 |
sean-k-mooney | dvo-plv: it is expected that your code will fail until an os-traits release is doen | 14:27 |
sean-k-mooney | i woudl focuse on the reapoval of the spec and we can do an os-traits release with teh traits after march 20th | 14:28 |
sean-k-mooney | that will fix all the jobs with out always installing os-traits form git | 14:28 |
sean-k-mooney | if we add os-traits as a required proejct it will always beinstalled form git instead of the most recent release even when we dont have a depens-on | 14:29 |
sean-k-mooney | which is not what we want in general | 14:29 |
bauzas | sean-k-mooney: well, we could ask devstack to run our librairies from git | 14:32 |
bauzas | but I'm not super OK if this is about ci jobs | 14:32 |
bauzas | it's simplier to release a library if needed | 14:32 |
sean-k-mooney | bauzas: we alredy can do this | 14:38 |
sean-k-mooney | btu we intentionally dont | 14:38 |
bauzas | I know and I agree | 14:38 |
bauzas | hence the "could" | 14:38 |
sean-k-mooney | ack | 14:38 |
bauzas | dvo-plv: if you get stuck by a lagging os-traits, come to us | 14:39 |
sean-k-mooney | dvo-plv: the other thing you can do is for now just use a custome trait in the nova code and you can update it to the real one later but it woudl be simpler ot just approvhe the spec agains and merge the trait and do a release in 2 weeks | 14:39 |
bauzas | but I think we recently released the last traits update | 14:39 |
sean-k-mooney | bauzas: the new triat is not merged yet becuase the spec need to be aprpoved first | 14:40 |
bauzas | sean-k-mooney: maybe we could have an experimental job that would pull os-traits from git | 14:40 |
bauzas | if that helps | 14:40 |
sean-k-mooney | that wont help they wanted to get a clen ci run | 14:40 |
bauzas | sean-k-mooney: ah I see, that's for a new feature | 14:40 |
sean-k-mooney | yep https://review.opendev.org/c/openstack/nova/+/876075/ | 14:41 |
dvo-plv | I will re-execute all tests locally to be sure that all works properly and will wait for spec approve and os-traits merge. Thnak you | 14:41 |
sean-k-mooney | dvo-plv: for now you could just use a custom trait and or comment it out | 14:41 |
bauzas | is it for helping to implement ? | 14:42 |
bauzas | or is it for us reviewing ? | 14:42 |
bauzas | if the former, nothing prevents you to test your patch against a running devstack which pulls ostraits from git | 14:42 |
sean-k-mooney | i.e more the request filter and traits reproting to a seocnd patch | 14:42 |
bauzas | if the latter, add a bit fat comment in the commit msg saying the CI is broken because of the missing release | 14:43 |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/876075/3/nova/scheduler/request_filter.py is just brekign things currently | 14:43 |
sean-k-mooney | since os_traits.COMPUTE_NET_VIRTIO_PACKED does not exist yet | 14:43 |
dvo-plv | yes, exactly | 14:43 |
bauzas | yeah got it | 14:43 |
bauzas | but again, nothing prevents you to test this filter with a devstack having a LIBS_FROM_GIT | 14:44 |
*** sfinucan is now known as stephenfin | 14:44 | |
bauzas | once the spec is approved, we could move forward and release ostraits soon | 14:45 |
dvo-plv | I just wanted to be sure that all works properly with zull environment. But I will wait for approve and do best to fix all problems, what I will find locally | 14:45 |
bauzas | dvo-plv: if you really want to make yourself confident of your patch, then use a custom trait indeed | 14:46 |
bauzas | but this will have to be cleaned up before review time | 14:46 |
bauzas | gibi: a quick swing would be appreciated on https://review.opendev.org/c/openstack/nova/+/874515 | 14:48 |
gibi | bauzas: looks good | 14:49 |
bauzas | thanks | 14:49 |
bauzas | gibi: sean-k-mooney: I have a few other nitty changes in my gerrit that are overdue | 14:49 |
bauzas | stay around :) | 14:50 |
dvo-plv | btw, we already update and move packed virtqueue support spec file to the 2023/2 https://review.opendev.org/c/openstack/nova-specs/+/868377 | 14:53 |
sean-k-mooney | i need to go to the chemeyist and pick up my perscirption but ill be back in a while and can take a look then | 14:54 |
bauzas | dvo-plv: this week, I'm overbusy with PTL scrubbing tasks, but I'll give a round on reviews next week | 14:55 |
bauzas | (specs reviews I mean) | 14:55 |
dvo-plv | Thank you | 14:56 |
-opendevstatus- NOTICE: Yesterday's change to Gerrit configs to use submit-requirements had a boolean logic bug. This has now been corrected and any changes that did not merge as a result can be rechecked. We have reenqueued the changes we identified as being affected. | 17:24 | |
spatel | sean-k-mooney Quick question related nova-schedule not able to find sriov nodes. I do have this in nova - https://paste.opendev.org/show/bASaMtV2z9K8N24FZAk4/ | 18:41 |
spatel | I have created AZ group and added single compute node to that AZ | 18:41 |
opendevreview | Merged openstack/nova master: fup for power management series https://review.opendev.org/c/openstack/nova/+/874515 | 18:41 |
spatel | In flavor i didn't specify any properties | 18:41 |
spatel | Does placement has any entry of PCI_DEVICE? | 18:45 |
*** thelounge553 is now known as thelounge55 | 20:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!