| opendevreview | Amit Uniyal proposed openstack/nova master: WIP: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 06:33 |
|---|---|---|
| dvo-plv | gibi, sean-k-mooney, sbauza: Hello. I have update nova code after os-traits release. Coud you please review packed ring support bp: https://review.opendev.org/q/bp/virtio | 07:28 |
| bauzas | sean-k-mooney: could you please give a +2 on https://review.opendev.org/c/openstack/nova/+/882786 so I could prepare both a 2023.1 and Zed releases for both the CVEs ? | 08:08 |
| bauzas | (or any stable core, like gibi) ^ | 08:09 |
| opendevreview | Merged openstack/nova stable/2023.1: Bump nova-ceph-multstore timeout https://review.opendev.org/c/openstack/nova/+/882784 | 08:23 |
| zigo | Hi! I'm trying to backport https://review.opendev.org/c/openstack/nova/+/882869 to Victoria. So far, it seems working, except, I have a unit test failure: | 09:03 |
| zigo | https://paste.opendev.org/show/br48JgltG6neK70WbkQA/ | 09:03 |
| zigo | This is in the new unit test test_cleanup_disconnect_volume() | 09:03 |
| zigo | Does anyone know what I can do? | 09:03 |
| zigo | I really would prefer to keep that unit test if possible ... | 09:04 |
| zigo | melwitt: ^ | 09:04 |
| dvo-plv | bauzas: Hello. I have update nova code after os-traits release. Coud you please review packed ring support bp: https://review.opendev.org/q/bp/virtio | 09:58 |
| opendevreview | Amit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | 11:18 |
| sean-k-mooney | dvo-plv: the code looks ok but your missing test coverage | 11:30 |
| dvo-plv | seean-k-mooney: We would like to implement tests after code approval in the separate bp. Does it possible, or we should to create a test immediately? | 11:41 |
| sean-k-mooney | dvo-plv: no | 11:42 |
| sean-k-mooney | we do not merge untested code in genral | 11:42 |
| sean-k-mooney | so you need to have tests either in the same commmit or a followup commit | 11:42 |
| sean-k-mooney | if its in a followup we will hold the first commit until we are happy with both and then merge them togeter | 11:43 |
| sean-k-mooney | for openstack we treat master as if all commits could be deployed to production. | 11:44 |
| sean-k-mooney | for lareger feature we genreally gate multi commit feature by having the change that enables the feature to be used last in the serise | 11:44 |
| dvo-plv | I think we will implement and update this commit with tests coverage | 11:45 |
| sean-k-mooney | that works | 11:45 |
| *** haleyb_ is now known as haleyb | 15:29 | |
| opendevreview | Merged openstack/nova stable/yoga: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882863 | 15:31 |
| opendevreview | Merged openstack/nova stable/yoga: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882864 | 15:33 |
| *** Guest1107 is now known as atmark | 17:04 | |
| *** d34dh0r5- is now known as d34dh0r53 | 17:07 | |
| dansmith | fungi: if we change the wallaby implementation of the cve fix in gerrit (to address the thing raised in the bug), do we have to update errata or not? | 17:24 |
| dansmith | the patch was in the bug, but wallaby should be out of bounds now | 17:24 |
| fungi | technically we don't need to reference it because that branch is no longer under normal maintenance | 17:30 |
| fungi | though i might amend the errata list with it and just not announce that so as to keep the noise level to a minimum | 17:31 |
| fungi | we have a bit of flexibility with branches no longer under normal maintenance since those fixes are merely being included as a convenience and on a best-effort basis | 17:32 |
| dansmith | ack, cool | 17:32 |
| dansmith | I think you said "patches for older branches are appreciated but not required" so I just didn't know how that mapped to "provided as a courtesy and then changed" | 17:32 |
| dansmith | melwitt: ^ | 17:32 |
| fungi | it's sort of a grey area | 17:33 |
| dansmith | I'm a walking grey area | 17:33 |
| fungi | we didn't provide any non-nova wallaby patches anyway | 17:33 |
| fungi | everything else stopped at xena (which is also no longer under normal maintenance at this point) | 17:34 |
| * dansmith nods | 17:34 | |
| melwitt | fungi: I had named the patch nova-2004555-xena_and_wallaby.patch erroneously thinking xena and wallaby were identical but it's really just nova-2004555-xena.patch | 17:35 |
| fungi | makes sense | 17:35 |
| fungi | for the downstream notification (and advisory of course) i split them up | 17:36 |
| melwitt | oh, I see | 17:36 |
| fungi | lots of the patches were "this applies to branches x and y" so i made separate identical branch x and branch y patches, because we don't want consumers to have to sort through a maze of patch name to branch mappings | 17:37 |
| dansmith | melwitt: you're probably going to have to fix the job config on wallaby if you actually want to merge it too | 17:41 |
| melwitt | fungi: that makes sense | 17:41 |
| dansmith | the recent cinder tempest plugin changes for the ceph job have broken it.. I think just disabling the ceph job on wallaby is probably best | 17:41 |
| melwitt | dansmith: good point | 17:41 |
| melwitt | I at least wanted the current ps to be correct if anyone pulls it manually | 17:42 |
| dansmith | yeah | 17:43 |
| dansmith | well, it'll help the ubuntu wallaby patches and the reporter at least | 17:43 |
| opendevreview | melanie witt proposed openstack/nova stable/wallaby: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882869 | 17:47 |
| opendevreview | melanie witt proposed openstack/nova stable/wallaby: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882870 | 17:47 |
| dansmith | jamespage: you might want to notice this ^ update along with the traffic on https://bugs.launchpad.net/nova/+bug/2004555 | 18:08 |
| dansmith | related to the ubuntu packages for that cve | 18:08 |
| fungi | jamespage: also https://review.opendev.org/c/openstack/ossa/+/883202 "Add errata 3 for OSSA-2023-003" | 18:54 |
| sean-k-mooney | i tought the general guidancce was to not track the ubuntu package state in the laucnchpad bug and only use them for the upstream openstack projects | 19:28 |
| sean-k-mooney | i was always toold it was conidered rude to add the disto pacakges to the bug at elast when i was at intel my perception was it caused consution with regards to is this fixed on the upstream branch or downstream branch | 19:29 |
| melwitt | zigo: I looked into the victoria issue, note that I updated the wallaby patch review for something different so please pull the latest one. besides that, I think you can add something like 'mount_device': None here under connection_info https://review.opendev.org/c/openstack/nova/+/882869/2/nova/tests/unit/virt/libvirt/test_driver.py#19646 to pass the test | 19:34 |
| melwitt | the victoria code expects an additional key 'mount_device' key in the block_device_mapping | 19:38 |
| melwitt | *an additional key in | 19:38 |
| *** dmellado92 is now known as dmellado9 | 20:07 | |
| *** dmellado92 is now known as dmellado9 | 20:16 | |
| opendevreview | Merged openstack/nova stable/xena: CI: fix backport validator for new branch naming https://review.opendev.org/c/openstack/nova/+/882967 | 22:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!