Wednesday, 2023-05-31

LarsErikPfrickler: (reading backlog) - ok, thanks =)06:23
opendevreviewSylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error  https://review.opendev.org/c/openstack/nova/+/88480807:40
opendevreviewSylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error  https://review.opendev.org/c/openstack/nova/+/88480807:44
bauzaselodilles: gibi: could you please give a swing to https://review.opendev.org/c/openstack/nova/+/883724 as a stable/yoga patch ? It would be nice thanks07:46
opendevreviewSylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372507:47
gibibauzas: I guess you mean the stable/zed first)07:48
gibi:)07:48
bauzasgibi: indeed07:49
bauzas+ yoga07:49
bauzasI'm trying to backport https://review.opendev.org/c/openstack/nova/+/883725 down to wallaby but I also need to create some backport for https://review.opendev.org/c/openstack/nova/+/884808 down to Wallaby too07:50
gibibauzas: it seems that unit test errors in https://review.opendev.org/c/openstack/nova/+/883726 are relevant07:51
bauzasgibi: indeed, I'm working atm on this07:52
bauzaswe need a dependent backport07:52
bauzashttps://review.opendev.org/c/openstack/nova/+/705792 hits me hard07:53
bauzasthat's why I sometimes hate to just modify a lot of methods :(07:53
opendevreviewSylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error  https://review.opendev.org/c/openstack/nova/+/88480808:17
opendevreviewSylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372508:17
opendevreviewSylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372608:26
opendevreviewSylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error  https://review.opendev.org/c/openstack/nova/+/88483008:26
*** Continuity_ is now known as Continuity08:28
bauzasgibi: thanks for the stable reviews, could you also please look at https://review.opendev.org/c/openstack/nova/+/884808 ?08:43
bauzasand I think I fixed the wallaby issues for https://review.opendev.org/c/openstack/nova/+/88372608:44
gibibauzas: I have a request in https://review.opendev.org/c/openstack/nova/+/88483008:50
bauzasgibi: easy request08:51
bauzasgibi: in general, we don't remove that in the backports, amarite elodilles ?08:51
bauzasbut sure, I can do it08:51
gibiI think we do, but I deffer to elodilles 08:51
bauzasI can hold until he replies08:54
bauzasor the other way08:55
elodilleso/09:02
elodilleswhat is the question? :)09:03
elodillesyepp, the conflicts that are not valid anymore just confuse reviewers, so best to drop them09:04
bauzascool, will do09:09
bauzaselodilles: thanks09:09
opendevreviewSylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error  https://review.opendev.org/c/openstack/nova/+/88483009:14
opendevreviewSylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372609:14
elodillesnp09:14
bauzaselodilles: your help would be appreciated :)09:14
elodillesi need to be AFK, but sure, when i'll be back i'll review it o:)09:15
bauzaselodilles: could you please look at https://review.opendev.org/c/openstack/nova/+/883724 and then https://review.opendev.org/c/openstack/nova/+/884808/ ?09:15
bauzaselodilles: tl;dr: we want to backport a bugfix down to Wallaby09:15
bauzasand we need to backport a dependent change09:15
elodillesACK, added to my TODO :)09:16
bauzasthanks09:17
gibibauzas: could you look at the backports of https://review.opendev.org/q/topic:bug%252F1941005 I think stable/wallaby is the next one10:52
opendevreviewAmit Uniyal proposed openstack/nova master: Reproducer for dangling bdms  https://review.opendev.org/c/openstack/nova/+/88145712:12
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228412:12
bauzasgibi: I'll try to look at those patches for sure13:10
sean-k-mooneybauzas: gibi can one of ye review https://review.opendev.org/c/openstack/nova/+/87321613:22
bauzassean-k-mooney: it seems a legit bug 13:22
bauzasI'll review it13:23
sean-k-mooneybug/feature but its a bug that was reported downstream, which was then fixed by our customer and has been waiting for upstream review for a while13:23
sean-k-mooneywe did a downstream bug scub yesterday and this was one of the ones that we decied to try and move forward since it was passing ci and bacially ready to go13:24
bauzassean-k-mooney: I just Review-Prio +1d it13:50
sean-k-mooneythanks13:50
opendevreviewDan Smith proposed openstack/nova master: Populate ComputeNode.service_id  https://review.opendev.org/c/openstack/nova/+/87990414:13
opendevreviewDan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations  https://review.opendev.org/c/openstack/nova/+/87949914:13
opendevreviewDan Smith proposed openstack/nova master: Add dest_compute_id to Migration object  https://review.opendev.org/c/openstack/nova/+/87968214:13
opendevreviewDan Smith proposed openstack/nova master: Add compute_id to Instance object  https://review.opendev.org/c/openstack/nova/+/87950014:13
opendevreviewDan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields  https://review.opendev.org/c/openstack/nova/+/87990514:13
opendevreviewDan Smith proposed openstack/nova master: Add online migration for Instance.compute_id  https://review.opendev.org/c/openstack/nova/+/88475214:13
dansmithwell, rebasing a migration due to a conflict is nicer under alembic, that's for sure14:13
sean-k-mooneyi have not looked at the delta too closely but i assuem with alembic ist largely just updating some hashes liek this https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py#2614:21
sean-k-mooney"""Another thing to notice is the down_revision variable. This is how Alembic knows the correct order in which to apply migrations. When we create the next revision, the new file’s down_revision identifier would point to this one:"""14:23
dansmiththis is all I had to do: https://review.opendev.org/c/openstack/nova/+/879499/9..10/nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py14:23
sean-k-mooneyso i guess if a migration has landed in teh interm you just need to update that but your migration will still refer to the same revision ids in the pater patches14:24
sean-k-mooney ya thats what i ment14:24
sean-k-mooneyit makes sens that that just need to be updated to refernce the latest revision14:24
*** Continuity__ is now known as Continuity15:15
opendevreviewMerged openstack/nova stable/zed: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372315:46

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!