| *** JasonF is now known as JayF | 00:01 | |
| mdbooth | I'll be running a forum session on Kubernetes on OpenStack in Vancouver next week. It's for users and developers of all related projects to talk to each other. Etherpad is here if there's anything you'd like to discuss: https://etherpad.opendev.org/p/openinfra-2023-kubernetes-on-openstack | 11:01 |
|---|---|---|
| opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | 11:57 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 11:57 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | 15:53 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 15:53 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: fix the privsep issue when offlining the cpu https://review.opendev.org/c/openstack/nova/+/885293 | 16:23 |
| bauzas | sometimes I hate myself ^ | 16:23 |
| bauzas | gibi: dansmith: ^ | 16:23 |
| bauzas | we need to backport it to Antelope | 16:24 |
| dansmith | ouch | 16:24 |
| bauzas | yeah :( | 16:24 |
| bauzas | and the functests don't verify it | 16:24 |
| bauzas | maybe I should also create a relnote | 16:25 |
| bauzas | so operators would see to use the next Antelope .z release if they want to use it | 16:25 |
| dansmith | maybe you'll need to make a release before your demo so people can actually use it :D | 16:26 |
| bauzas | yeah, I'll prepare a release | 16:28 |
| bauzas | and I'll tell it loudly | 16:28 |
| bauzas | as I'm very sad :( | 16:28 |
| bauzas | also we maybe should have some test that verify that we don't forget a privsep decorator | 16:30 |
| bauzas | like we do with objects or other stuff | 16:30 |
| bauzas | but that's a bit difficult | 16:31 |
| dansmith | yeah, not sure how to do that | 16:47 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: fix the privsep issue when offlining the cpu https://review.opendev.org/c/openstack/nova/+/885293 | 17:42 |
| bauzas | dansmith: added a relnote for making it more public | 17:43 |
| bauzas | and again, sorry for this bug :( | 17:43 |
| dansmith | how could permissions cause a FileNotFound/ | 17:43 |
| dansmith | that doesn't seem right o me | 17:43 |
| bauzas | dansmith: see the bug report | 17:43 |
| bauzas | I added the log | 17:44 |
| dansmith | the bug report *says* there's a FileNotFound but I don't see *why* that would happen | 17:44 |
| dansmith | users can see the file | 17:44 |
| bauzas | this is a permission error as the base exception | 17:44 |
| dansmith | oh I see, we're translating | 17:45 |
| bauzas | yeah | 17:45 |
| dansmith | okay, so the reno reads a bit strange to me because of the "if you want".. can I suggest alternative wording? | 17:45 |
| bauzas | dansmith: sure, do this | 17:45 |
| bauzas | tbc, I prefer -1s rather than +2s :) | 17:46 |
| dansmith | commented | 17:49 |
| dansmith | bauzas: if you're using the offlining the scaling being missing from /sys isn't a problem right? Could we enable this in nova-next or something so we see some coverage? | 17:50 |
| bauzas | dansmith: you mean about the fact that we miss scaling_governor in my instance ? | 17:53 |
| bauzas | I can find a way to say 'meh, fair enough' if you wan | 17:53 |
| bauzas | want | 17:53 |
| bauzas | so in this case, we would only support to ask to offline/online cpus | 17:54 |
| dansmith | don't you choose modes, either to use scaling or cpu offlniing? | 17:55 |
| dansmith | if you're using offlining, I would expect the missing cpufreq support wouldn't be a problem and that we could just enable this in nova-next | 17:56 |
| bauzas | dansmith: yeah, we have a config option for saying which strategy you want https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.cpu_power_management_strategy | 17:58 |
| dansmith | right, so can we configure nova-next for offlining mode so we get some CI coverage? | 17:58 |
| bauzas | we could so | 17:59 |
| bauzas | okay, so I'll create another bugfix for making sure that if you want to offline, it's fine if we don't verify the scaling governor | 17:59 |
| bauzas | unless you ask for it by the config opt | 18:00 |
| dansmith | oh, is that not currently working? | 18:00 |
| dansmith | because we should not depend on a working cpufreq implementation if we're using offlining | 18:00 |
| dansmith | I can imagine some of the other platforms (maybe arm or power) don't always have cpufreq enabled | 18:00 |
| bauzas | unfortunately no, because when we restart we check both the governor and the state here : https://github.com/openstack/nova/blob/master/nova/virt/libvirt/cpu/api.py#L143 | 18:01 |
| dansmith | and some server hardware if you enable platform-based scaling I think they don't expose it to the OS | 18:01 |
| bauzas | so I'll change this | 18:01 |
| dansmith | bauzas: okay yeah, that'd be good | 18:01 |
| bauzas | dansmith: ++ your concern is awesome btw. | 18:01 |
| bauzas | dansmith: because indeed I wasn't thinking about the other platforms but indeed you're right | 18:02 |
| dansmith | yeah | 18:02 |
| bauzas | +++ definitely, will fix it too and will backport it | 18:02 |
| dansmith | cpufreq is pretty common these days, but if you unload a module or don't have it built into your kernel, we shouldn't fail | 18:02 |
| dansmith | (shouldn't fail to allow offlining I mean) | 18:03 |
| bauzas | indeed | 18:03 |
| * bauzas goes to dinner, be back later | 18:04 | |
| dansmith | bauzas: so I didn't look, but I assume the scaling approach already has the privsep helper? | 18:05 |
| dansmith | and it was just the online helper that was missing it? | 18:05 |
| bauzas | dansmith: yeah, we only forgot it for set_offline | 18:05 |
| dansmith | okay cool, just checking | 18:05 |
| bauzas | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/cpu/api.py is the private API | 18:05 |
| bauzas | and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/cpu/core.py is the internal code | 18:05 |
| bauzas | that's where we decorate the callers | 18:06 |
| dansmith | I believe you, just making sure | 18:06 |
| * bauzas still wonders how I could have missed the decorator since I didn't really copy/paste both methods but fair | 18:07 | |
| bauzas | dansmith: no worries, was just for explaining you what we do internally since you didn't had time to review the series | 18:07 |
| dansmith | decorators are easy to miss and git rebase/merges sometimes snip them out if they're used in front of all the functions | 18:07 |
| bauzas | https://review.opendev.org/q/topic:bp%252Flibvirt-cpu-state-mgmt | 18:08 |
| bauzas | that's the series if you wanna peak it | 18:08 |
| dansmith | yeah, I found it last week, I had missed it for sure | 18:08 |
| bauzas | and https://review.opendev.org/c/openstack/nova/+/868237/12/nova/virt/libvirt/driver.py is where we offline/online | 18:08 |
| bauzas | the closest I found when we spawn | 18:08 |
| *** efried1 is now known as efried | 20:13 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!