Wednesday, 2023-06-07

opendevreviewAmit Uniyal proposed openstack/nova master: Reproducer for dangling bdms  https://review.opendev.org/c/openstack/nova/+/88145706:08
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228406:08
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228406:55
gibidansmith: re https://www.youtube.com/watch?v=dLjNzwEULG8 so I should tatoo some instance.update notification to my body :)08:07
opendevreviewAmit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes  https://review.opendev.org/c/openstack/nova-specs/+/87875708:14
gibiid we changed cirros guest image recently on master? Yesterday and today 08:29
gibiI started to see guest block io failures08:29
gibisee https://review.opendev.org/c/openstack/nova/+/873216/7#message-4584b616820a42414995f77c6e495aafd6499ebc08:30
gibiand 08:30
gibihttps://review.opendev.org/c/openstack/nova/+/873216/7#message-0306974232385dedf7a9553ad65459e4f8849e2808:30
gibiand one more https://review.opendev.org/c/openstack/nova/+/885352/3#message-0ed9f92e5069e79cb7b60724c048ca038c7c094e08:52
gibibauzas: I have questions in https://review.opendev.org/c/openstack/nova/+/88535209:04
bauzasgibi: will look in a sec once I eventaually send the email I have in my inbox for a while :D09:05
bauzasthere09:11
bauzasgibi: ack, thanks for your points, have like 2-min for discussing them .09:14
bauzas?09:14
gibiyepp I have09:14
bauzascool09:16
bauzasso, I don't really want to avoid providing a FileNotFound exception if you want to set a governor09:16
bauzasif so, operators would see that their OS platform is not supporting the governors09:17
gibiOK. so it is intentional that the FileNotFound exception propagates09:17
gibidoes it make the nova-compute fail to start if governor is requested in the config but not available on the hypervisor?09:18
gibior only the intance operaton that calls set_governor will fail?09:18
fricklergibi: iiuc the GPT messages are normal due to the way cirros works. the vdb issue would be an additional volume failing, not related to cirros?09:26
frickleralso no change on cirros image yet, I want to get the new version cached in infra images first09:27
fricklerhttps://review.opendev.org/c/openstack/project-config/+/88500509:27
gibifrickler: thanks09:28
gibifrickler: then I need to check deeper about the volume issue09:28
bauzasgibi: sorry, was looking at something else09:30
gibibauzas: as far as I see if the configured governor is not available then the instance operation will fail09:31
bauzasgibi: yeah, if the ops wants to set a governor strategy, then we'll try to set it at startup09:31
bauzasgibi: so the service restart will fail09:31
gibibauzas: could you point to it?09:31
bauzasgibi: https://review.opendev.org/c/openstack/nova/+/885352/3/nova/tests/functional/libvirt/test_power_manage.py#24409:32
gibilooking09:35
gibiahh it goes through power_down_all_dedicated_cpus09:36
gibiduring init_host09:36
bauzasyes09:36
gibicool then09:36
bauzasand that's why it failed previously09:36
bauzaswell, not exactly09:36
bauzasit failed in the validate_cpu() method because we were comparing the governors if you set cp_state strategy09:37
gibipreviously it is failed on the governor property 09:37
gibiyeah09:37
gibiand there now we return None09:37
bauzasthat's a proposal I made09:37
gibiso the len of the governors will be 1 in this case and that check passses09:37
gibithen the power_down_all_dedicated_cpus will be called and fail09:37
bauzasI'm open to other ideas like dansmith's one about the 'none' string09:37
gibiI'm OK with None09:38
bauzasgibi: depending on the strategy, yes it will fail if governor is set09:38
gibias we are only using that value to collect the different actual governors across the pcpus09:39
bauzasan alternative would be to raise an InvalidConfiguration exception instead of a somehow meaningless FileNotFound09:39
gibiif FileNotFound explains the missing file path then I think that is enough for the deployer to figure out what is the issue09:40
bauzaswe do return this InvalidConf exception if you want to change the governors but you have some CPUs offline09:40
bauzasgibi: yeah I was torn09:40
bauzasgibi: between raising the FileNotFound exception that would show the filename, or a better direct exception that would directly tell 'sorry, you want to change the governors but your OS doesn't support it"09:41
gibiI'm OK as is09:43
gibisummarized our discussion in the review now. Thanks for clearing this up for me09:44
bauzasgibi: np and thanks for the review09:45
opendevreviewSylvain Bauza proposed openstack/nova master: cpu: make governors to be optional  https://review.opendev.org/c/openstack/nova/+/88535209:55
sean-k-mooneybauzas: i have not read back fully but it should be a hard error if you have enabled the govenors10:56
sean-k-mooneybut if you have enabeld cpu state then the lack of the cpu frequency govoner should not break things10:57
sean-k-mooneybauzas: gibi  what os was this on by the way11:04
sean-k-mooneyyou are right that not all plathform will have this but any majour linux disto on x86 should so im wondering what exotic config was being used to find this11:05
sean-k-mooneyhum q35 vms?11:07
sean-k-mooneyhttps://www.phoronix.com/news/KVM-CPUFreq-RFC-Patches that might changegoing forward11:10
gibisean-k-mooney: It was theorethical based on reading the code :)11:19
gibibut bauzas helped me understand it. 11:19
sean-k-mooneyok well it wont work in vms currently11:20
sean-k-mooneyso that is the refernce plathform :)11:20
gibiso a configured but missing governor will be a hard failure on nova-compute startup11:20
sean-k-mooneywell a configured but missing govoner should be a hard fail11:20
gibiit is :) so everything is good11:20
sean-k-mooneybut what would not be ok is if the cpu state part didnt work11:20
gibieypp11:21
gibiyepp11:21
sean-k-mooneyif you configure that just because the govoner is not supported11:21
sean-k-mooneyso thats the bug right11:21
gibiyes, and it is being fixed ow11:21
gibinow11:21
sean-k-mooneyya i looked at the patch quickly11:21
*** blarnath is now known as d34dh0r5312:42
dansmithbauzas: replied13:25
bauzasdansmith: ok, so you would prefer to have an empty string ?13:41
bauzasinstead of None 13:42
dansmithbauzas: I would, but don't hold this up on me.. None is fine.13:42
dansmithseriously, three people are fine with None, it's fine13:42
bauzasokidoki13:42
dansmithbauzas: sorry I thought there was still a style thing to fix, I +2d now14:14
opendevreviewMerged openstack/nova master: Process unlimited exceptions raised by unplug_vifs  https://review.opendev.org/c/openstack/nova/+/87935014:16
*** ralonsoh__ is now known as ralonsoh14:26
opendevreviewMerged openstack/nova master: Fix failed count for anti-affinity check  https://review.opendev.org/c/openstack/nova/+/87321614:35
opendevreviewMerged openstack/nova master: db: Don't rely on branched connections  https://review.opendev.org/c/openstack/nova/+/88066316:54
opendevreviewMerged openstack/nova master: db: Remove unnecessary 'insert()' argument  https://review.opendev.org/c/openstack/nova/+/88066416:54
opendevreviewMerged openstack/nova master: tests: Pass parameters to sqlalchemy.text() as bindparams  https://review.opendev.org/c/openstack/nova/+/88066516:54
opendevreviewMerged openstack/nova master: tests: Add missing args to sqlalchemy.Table  https://review.opendev.org/c/openstack/nova/+/88066716:54
opendevreviewMerged openstack/nova master: cpu: fix the privsep issue when offlining the cpu  https://review.opendev.org/c/openstack/nova/+/88529321:37

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!