Monday, 2023-06-26

bauzasfolks, I have a couple of review requests, is there anyone fancy to do it ?08:56
bauzasfirst one is an easy peasy, it just adds some functional verification for cross_az_attach https://review.opendev.org/c/openstack/nova/+/87894808:57
bauzasI need a second core ^08:57
bauzassecond one is important for fixing a cpu power management issue, should be easy to review too https://review.opendev.org/c/openstack/nova/+/88535208:58
bauzasneeds a second core as well ^08:58
opendevreviewJohn Garbutt proposed openstack/nova master: Deprecate ironic.peer_list  https://review.opendev.org/c/openstack/nova/+/88334608:59
bauzasthird one is a specless bp change, simple for just adding a new cod-migrate policy https://review.opendev.org/c/openstack/nova/+/88156208:59
bauzasso, who can help me ? :)08:59
gibibauzas: o/ remind me, did we discussed that specless on the meeting?09:06
bauzasgibi: it was approved IIRC, but lemme double-check09:06
bauzashttps://blueprints.launchpad.net/nova/+spec/cold-migrate-to-host-policy correct it was09:06
gibibauzas: thanks09:07
bauzashttps://meetings.opendev.org/meetings/nova/2023/nova.2023-04-25-16.00.log.html#l-20309:07
bauzasgibi: thanks for doing this round of reviews, I know you're busy09:07
gibiohh sh*t now I have to do these reviews :D09:08
bauzasgibi: nah, don't feel pressured09:14
bauzasI'm thinking of creating an etherpad of code reviews either way :)09:14
gibidone :D09:15
gibiI mean with the reviews09:15
sean-k-mooneyi can review some of them while i wait for my dev env to deploy09:23
sean-k-mooneythere is one minor english issue in https://review.opendev.org/c/openstack/nova/+/881562/2/api-ref/source/servers-admin-action.inc and a slight nit later09:26
sean-k-mooneybut im +2 on it09:26
sean-k-mooneyi held +w in case you want to quickly fix it?09:26
bauzassean-k-mooney: sorry was working on updating some change09:30
bauzassean-k-mooney: sure, I can quickly respin for that english point09:31
sean-k-mooneyack ill fast approve once its ready09:31
bauzasshould be better than a FUP09:31
opendevreviewSylvain Bauza proposed openstack/nova master: Add a new policy for cold-migrate with host  https://review.opendev.org/c/openstack/nova/+/88156209:34
bauzassean-k-mooney: gibi: ^09:34
* bauzas goes back on https://review.opendev.org/c/openstack/nova/+/845757 which sounds eventually nice for operators given the Summit and the ML :)09:35
opendevreviewsean mooney proposed openstack/nova master: Remove deprecated AZ filter.  https://review.opendev.org/c/openstack/nova/+/88677910:02
sean-k-mooneybauzas: speaking of easy reviews can you hit this https://review.opendev.org/c/openstack/nova/+/886596 to drop fedora form teh experimental pipeline10:11
sean-k-mooneythe infra team are woking on droping the fedora images from ci10:11
opendevreviewJohn Garbutt proposed openstack/nova master: WIP: Limit nodes by ironic shard key  https://review.opendev.org/c/openstack/nova/+/88698011:00
opendevreviewJohn Garbutt proposed openstack/nova master: Deprecate ironic.peer_list  https://review.opendev.org/c/openstack/nova/+/88334611:09
opendevreviewJohn Garbutt proposed openstack/nova master: WIP: Limit nodes by ironic shard key  https://review.opendev.org/c/openstack/nova/+/88698011:10
opendevreviewMerged openstack/nova master: Verify a move operation for cross_az_attach=False  https://review.opendev.org/c/openstack/nova/+/87894811:44
opendevreviewDanylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added.  https://review.opendev.org/c/openstack/nova/+/87607512:15
* bauzas wraps his head with all the VGPU limitations :(14:24
dansmithbauzas: I would sure love to have some review on my compute object id set15:07
dansmithI wrote it a long time ago, but I barely remember what's in it anymore, so addressing feedback becomes more and more expensive as time goes on... :/15:08
bauzasdansmith: aha, right, I need to look at your series15:08
bauzasreminder : tomorrow will be our spec review day15:29
bauzas(adding this reminder also for me :) )15:29
opendevreviewJohn Garbutt proposed openstack/nova master: Limit nodes by ironic shard key  https://review.opendev.org/c/openstack/nova/+/88698016:00
opendevreviewJohn Garbutt proposed openstack/nova master: WIP: Add nova-manage ironic-compute-node-move  https://review.opendev.org/c/openstack/nova/+/88698916:42
gmannbauzas: dansmith: can either of you approve this, adding py310 func job on gate pipeline too  https://review.opendev.org/c/openstack/nova/+/88133917:56
dansmithapproved, but I guess I'm not sure it's really important to run on so many python versions17:58
dansmithit's not likely that python version problems will crop up between check and gate :)17:59
gmannnova-tox-functional-py39 can be removed as py38 and py310 can cover it18:00
dansmithdefinitely seems prudent to do that yeah18:01
opendevreviewmelanie witt proposed openstack/nova-specs master: Re-propose spec for ephemeral storage encryption  https://review.opendev.org/c/openstack/nova-specs/+/88701123:00
opendevreviewmelanie witt proposed openstack/nova-specs master: Re-propose spec for ephemeral encryption for libvirt  https://review.opendev.org/c/openstack/nova-specs/+/88701223:14

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!