Tuesday, 2023-07-04

« Monday, 2023-07-03 Index Wednesday, 2023-07-05 »
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228406:27
opendevreviewMerged openstack/nova stable/yoga: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372410:57
sean-k-mooneydvo-plv: you could just add your check to _validate_flavor_image_numa_pci although that is strictly not what that is for but its called form _validate_flavor_image_nostatus11:41
sean-k-mooneyso if you add it to _validate_flavor_image_numa_pci it will be called everywhere it shoudl be11:41
sean-k-mooneyi actullly think that current if/else for BFV instance might be a bug11:41
sean-k-mooneybut that is unrealted to yoru change11:42
dvo-plvI thought do it in the next way for resize https://paste.opendev.org/show/bUEZJuI6huYrnmAVSGsZ/11:43
dvo-plvand this for rebuild https://paste.opendev.org/show/b5zFmXnXpVE4iNezPiSi/11:43
sean-k-mooneyi would kind of like to avoid adding the call in multiple places to make sure we dont miss a palce11:44
sean-k-mooneywhat you suggest will work11:45
sean-k-mooneywe just need to allso ensure its called on server create11:45
dvo-plvsure11:45
sean-k-mooneyso there are tree cases we need to check (create, resize and rebuild)11:45
sean-k-mooneymaybe rebuild11:46
sean-k-mooneysorry maybe rescue11:46
sean-k-mooneyfor rescue im conflcited11:46
sean-k-mooneythe rescue image is tempory so normally i would say just never set this for the rescue image11:46
sean-k-mooneyso we should not need to check it 11:47
sean-k-mooneyill leave it up to you if you want to add the 3 checks then that is ok11:47
sean-k-mooneyjust add them in similar location to the existing _validate_flavor_image_nostatus checks11:48
dvo-plvlooks like we will not have ability to do this without additional changes11:52
dvo-plv self._validate_flavor_image_nostatus(context, image, new_flavor, root_bdm=None,validate_pci=True) this method get not full image parameter11:53
dvo-plvit pass only metadata https://github.com/openstack/nova/blob/master/nova/compute/api.py#L425411:54
dvo-plv(Pdb) image11:54
dvo-plv{'min_ram': '0', 'min_disk': '1', 'disk_format': 'raw', 'container_format': 'raw', 'properties': {'kernel_id': 'nokernel', 'ramdisk_id': 'nokernel', 'hw_virtio_packed_ring': 'true', 'base_image_ref': 'c456eb30-91d7-4f43-8f46-2efd9eccd744', 'boot_roles': 'reader,member,admin'}}11:54
sean-k-mooneyack you actully only need the metadata not the full image11:55
sean-k-mooneyfor yoru hardware.py funciton11:55
dvo-plvbut we need full object https://review.opendev.org/c/openstack/nova/+/876075/14/nova/virt/hardware.py#194111:55
sean-k-mooneyoh you mean it gets a dict not the object?11:56
dvo-plvbecause exception needs next field11:56
dvo-plvhttps://review.opendev.org/c/openstack/nova/+/876075/14/nova/virt/hardware.py#197711:56
sean-k-mooneywe dont neeed the iamge name error masge11:56
dvo-plvyes, I need object + this object have to have name field11:56
sean-k-mooneyya but we dont need the name filed11:56
sean-k-mooneyuse the uuid c456eb30-91d7-4f43-8f46-2efd9eccd744 from base_image_ref if you want11:57
dvo-plvokay I can use uuid11:58
sean-k-mooneybut you do not need the flavor or iamge name for the message11:58
sean-k-mooneyreally you just need to say "Flavor has ... image has ...."11:58
sean-k-mooneythe user knows what flavor and image they use11:59
dvo-plvYes, I will rewrite log, because id also does not exists in some cases (Pdb) image_meta12:02
dvo-plvImageMeta(checksum=<?>,container_format='raw',created_at=<?>,direct_url=<?>,disk_format='raw',id=<?>,min_disk=1,min_ram=0,name=<?>,owner=<?>,properties=ImageMetaProps,protected=<?>,size=<?>,status=<?>,tags=<?>,updated_at=<?>,virtual_size=<?>,visibility=<?>)12:02
sean-k-mooneyack12:02
dvo-plvsean-k-mooney, I would like to clarify how properly I need to fix next unit test, which start to fall after adding those functional12:28
dvo-plvhttps://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute.py#L1421312:28
dvo-plv /opt/stack/nova/nova/compute/api.py(758)_validate_flavor_image_nostatus()12:28
dvo-plv-> image_meta = objects.ImageMeta.from_dict(image)12:28
dvo-plv(Pdb) image12:28
dvo-plv{'id': 'fbb69a20-3717-439e-88ec-7954e6f801af', 'status': 'active', 'properties': {'hw_cpu_policy': 'bar'}}12:28
dvo-plv(Pdb) cont12:28
dvo-plvit fails which is expected, according to this verification12:28
dvo-plvhttps://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L23412:29
sean-k-mooneyit shoudl not fail by adding your fucntion12:30
sean-k-mooneydid you change the object passed to _validate_flavor_image_nostatus12:30
sean-k-mooneyi was tryign to steer you away form that since i expecte that to cause a lot of unit/funcitonal test filaures12:31
dvo-plvhttps://paste.opendev.org/show/b84ihg1M7WPIpDTSVyXc/12:31
dvo-plvno I just make object from dict for verification12:31
sean-k-mooneyyes but that will have the same effect12:32
sean-k-mooneyit will cause the image proeprty validation to be enfroced12:32
sean-k-mooneyi understand why you wourl prefer to use the object12:33
sean-k-mooneybut it might be simpler to make get_packed_virtqueue_constraint use the dict12:33
dvo-plvOkay, I will try to use dict instead, I believe that vit will be better if verification method will be similar to the other, which check conflcits 12:35
sean-k-mooneyyep the other way to work aroudn this12:38
sean-k-mooneyis to make the convertion internal to get_packed_virtqueue_constraint and make it conditional12:39
sean-k-mooneyso that you can pass a dict of object12:39
sean-k-mooneyand then in the relvent tests that fial just mock out get_packed_virtqueue_constraint to return true12:39
sean-k-mooneyim just not sure how many tests you will have to fix if you take that approch12:40
opendevreviewMerged openstack/nova stable/xena: Fix segment-aware scheduling permissions error  https://review.opendev.org/c/openstack/nova/+/88480812:56
ykarelgibi, sean-k-mooney bauzas can you please revisit https://review.opendev.org/c/openstack/nova/+/86841912:56
sean-k-mooneysure i have a meeting at the top of the hour but ill look quickly12:56
bauzasykarel: ack, will look12:57
ykarelThanks12:57
sean-k-mooneyack so you move this to the libvirt section from workarounds12:57
ykarelyes12:57
sean-k-mooneythat was the only outstding issue as far as i was concerned12:58
sean-k-mooneyso i think this is good as is now12:58
sahido/ quick question guys, we are trying to use nova-manage db archive_deleted_rows but for some reason we dont't see anything migrated in the shadow tables even if the output is reporting something13:04
sahidmore of that when we list instances with deleted_at not null we can still see them13:05
sahidand the final strp of crazy is that, when re-executing the script it sees nothing else to archive...13:06
sahidi was thinking about something related to the cells...13:06
sahidlist_cells only report cell0 so I guess we are good13:08
sahidone point that i don't understand, we have nova and nova_cell0 databases13:10
sahidin nova we have a certain number of instances deleted13:10
sahidin nova_cell0 we have nothing 13:11
opendevreviewMerged openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id  https://review.opendev.org/c/openstack/nova/+/88372513:14
dvo-plvlooks like we did it :)13:22
dvo-plv  py38: commands succeeded13:22
dvo-plv  congratulations :)13:22
bauzassahid: tbc, there is no longer a 'nova' DB, there is either a nova API DB or a nova cell DB13:33
bauzasin devstack, we name them nova_api and nova_cell113:33
bauzas+ there is a specific nova_cell0 DB which is exactly like nova_cell1 but where only have NoValidHosts instances13:34
opendevreviewDanylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added.  https://review.opendev.org/c/openstack/nova/+/87607513:46
sean-k-mooneydvo-plv: cool ill take a look shortly14:08
sean-k-mooneydvo-plv: fyi the funtional tests are not run as part of the py38 target14:11
sean-k-mooneyyou need to run tox -e functional14:11
sean-k-mooneyoptionally wiht -py38 at the end14:11
sahidbauzas: we are running ussuri :D14:17
sahidin all cases I don't get what is happening with this script14:21
plibeauhello guys if you have time to review: https://review.opendev.org/c/openstack/nova/+/861172 thx14:45
bauzassahid: do you have all the right cells ?14:52
sahidI don't know I think there is something I don't get14:56
sahidwhen I list cells, I have 2 rows, one for rabbit without name and one cell014:57
sahidthe database connection for cell0 looks to use nova_cell0 dbname14:57
sahidbut in nova_cell0 db, there are nothing I mean If I count the instances fro; this database (nova_cell0), there are nothing14:58
sahidthe right database used is the dbname called 'nova'14:59
sahidI don't know if that is normal...14:59
bauzassahid: can you list them in an etherpad ?15:07
bauzassahid: cell0 is just a DB for instances that were not accepted 15:07
bauzasI mean, when an instance doesn't have a specific host because of some problem (scheduling in general), then we create the record in cell015:08
bauzasinstead of recording the instance in the cell DB related to the host15:08
bauzasso you should have 3 DBs : one for the API, one for cell0 and one (at least) for *one* cell15:09
bauzasyou should have *at least* 3 (I mean)15:09
sahidnova, nova_api and nova_cell015:10
sahidhttps://etherpad.opendev.org/p/cells15:11
sahidbauzas: the issue we have is that, we are trying to archive deleted instances15:12
sahidbut when executing the script they stay15:12
sahidand nothing in shadow tables15:12
sean-k-mooneythe nova database there is the nova cell 1 database15:16
sean-k-mooneysahid: some tools did that but we recommend actully not calling it nova but nova_cell115:16
sean-k-mooneybasicly it simpliced upgrades so they kept the old name15:16
bauzassahid: sean-k-mooney: mmm, I wonder why the cell1 doesn't have a name15:16
sean-k-mooneythe actuall db schame name is not used for anything15:17
sean-k-mooneywhen we splict the monolitic nova db into the celldb and api db 15:17
sean-k-mooneymost instaler did that by extracting the api tables into a differnt schema 15:18
sean-k-mooneyand reusing the existing db as the cell1 db15:18
bauzasok, but then I wonder why nova-manage db archive_deleted_rows doesn't work15:19
sahidbauzas, sean-k-mooney I should perhaps try to name cell1 the cell with empty name?15:22
sean-k-mooneyit should wrok waht is the error15:22
sean-k-mooneywhere was it run15:23
sahidno errors are reported15:23
sahidbut nothing change15:23
sean-k-mooneyit gets the info form the nova.conf 15:23
sean-k-mooneydoes the nova.conf have the api and cell db set15:23
sahidit has section [database] that mentions as connection = .../nova_cell015:25
sahidand ..15:25
sahid[api_database] that mentions as connection = .../nova_api15:26
sahid(for both of the section we have a slave_connection)15:26
bauzassahid: you shouldn't mention the cell0 connection string in the nova.conf15:27
bauzas[database] should refer to to cell connection it's attached to15:28
sean-k-mooneyit depends on which service that nova.confi is for15:28
sean-k-mooneyif it was the api's nova.conf or sheduler then pointing at cell0 is fine15:29
sahidit is for nova-api15:29
sean-k-mooneyok so what command are you trying to run exactly15:30
bauzassean-k-mooney: correct, I was assuming sahid was referring to the compute's nova.conf15:31
sahidI have tried several ways but basically, nova-manage archive_deleted_rows --all-cells --unit-complete --verbose15:31
sean-k-mooneyack so provided you have the cells mapped properly that should lookup the other cells db via the api db15:32
sean-k-mooneynomally we woudl run this using the conducotrs nova.conf15:32
bauzassahid: you need to have a right nova.conf that gives the right connection for API DB15:33
bauzashttps://docs.openstack.org/nova/latest/cli/nova-manage.html#db-archive-deleted-rows15:33
sean-k-mooneysahid: are you using templated URLs15:33
bauzas"  Move deleted rows from production tables to shadow tables. Note that the corresponding rows in the instance_mappings, request_specs and instance_group_member tables of the API database are purged when instance records are archived and thus, api_database.connection is required in the config file."15:33
elodillesi know that nova meeting will have start in less than 30 mins, but i have a question about nova gate:15:33
sean-k-mooneysure15:33
elodillesis there a reported bug about the nova-lvm gate issue? https://zuul.opendev.org/t/openstack/builds?job_name=nova-lvm&skip=015:34
sean-k-mooneyi was not aware there was one but apprelty so15:34
elodillesit's 100% failing on master and newer stable branches15:34
sean-k-mooneyok so it looks like15:35
elodillesthe issue is mostly the same as it was last week with the ceph job15:35
sean-k-mooneythe tempest test is not using sshable15:35
elodillesbut it's different15:35
sean-k-mooneyand we dont have that configued in the job15:35
sean-k-mooneytempest.lib.exceptions.InvalidParam: Invalid Parameter passed: When validation.connect_method equals floating, validation_resources cannot be None15:35
sean-k-mooneytest_rebuild_volume_backed_server15:35
sean-k-mooneyso that should be a simple fix15:35
elodilles(the patch that introduced is this i think: https://review.opendev.org/c/openstack/tempest/+/831018 )15:36
elodillessean-k-mooney: so you mean we have to add a new config value to the job def15:36
sean-k-mooneyya so that added the second image15:36
sean-k-mooneybut if the job was nto already setup for ssh vericaiton then it would fail15:37
sean-k-mooneylet me check the job config15:37
elodillessean-k-mooney: thanks in advance15:37
sean-k-mooneyso i tought this was seup in tempest-multinode-full-py3 or one of the parent of that job 15:38
sean-k-mooneythat is the parent of nova-lvm15:38
elodillesmaybe we override something in nova-lvm?15:38
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/.zuul.yaml#L26715:39
sean-k-mooneywe have tempest validation turned off expiclty for some reason15:39
sean-k-mooneybut its definlty now required15:39
elodilles"to save time"15:39
elodilles:)15:39
sean-k-mooneyso im just going to remove that one sec15:40
elodillesshould i open a bug for this?15:40
sean-k-mooneysure does not hurt its techncially a gate blocker15:40
elodillesack, will do it now15:40
opendevreviewsean mooney proposed openstack/nova master: enable validations in nova-lvm  https://review.opendev.org/c/openstack/nova/+/88763215:44
sean-k-mooneyi can update ^ with the bug refernce but that should do the trick15:44
elodillessean-k-mooney: here's the bug: https://bugs.launchpad.net/nova/+bug/202581315:48
elodillessean-k-mooney: and thanks for the patch! \o/15:48
sean-k-mooneycool ill update it now. there is no need for a release note since this is purly ci15:48
elodillesyepp, this is CI only issue15:48
opendevreviewsean mooney proposed openstack/nova master: enable validations in nova-lvm  https://review.opendev.org/c/openstack/nova/+/88763215:49
sahidbauzas, sean-k-mooney it's owrk I was using wrong conf file15:50
sahidthe needed one was nova-conductor15:50
sahidthanks15:50
bauzassahid: ok, gtk15:50
bauzassahid: fwiw, you can use any one having a right connection URL :)15:51
bauzasbut yeah, given the super conductor in general uses the api db, you can use this one :)15:51
sean-k-mooneyya the only gotcha is if you are using templated cell db urls and you have a differnet password per cell15:53
sean-k-mooneyin that case you cannot use --all-cells15:53
sean-k-mooneyand isntead need to run it per cell with the correct passowrd15:53
sean-k-mooneyhowever i dont belive anything other then tripleo even supprot that15:54
sean-k-mooneyso it should not be an issue for canonicals charm based installer15:54
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Jul  4 16:00:37 2023 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
bauzashey folks16:00
Uggla_o/16:00
bauzassome people are on PTO today, so let's try to have a quick meeting16:01
elodilleso/16:01
gibio/16:02
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:03
bauzaslet's start16:03
sean-k-mooneyo/16:03
bauzas#topic Bugs (stuck/critical) 16:03
bauzas#info One Critical bug16:04
bauzas#link https://bugs.launchpad.net/nova/+bug/202581316:04
bauzaswe can discuss this one now or later in the gate section16:04
bauzasas people want16:04
gibiI don't have much context on it16:06
elodillesit's "only" about nova-lvm job16:06
elodillesbut sean-k-mooney has a fix already :)16:06
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/88763216:07
sean-k-mooneyreviews welcome :)16:07
bauzasalready voted.16:07
bauzasok, let's move on 16:07
sean-k-mooneyi might need to adjust the job timeout16:07
sean-k-mooneybut we will see when zuul runs16:07
* gibi approved the fix and CI will decide :)16:07
bauzas++16:08
bauzasbad news, I forgot I was on PTO for 2 days last week, so 16:08
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 34 new untriaged bugs (+3 since the last meeting)16:08
bauzas:(16:08
bauzasI'll pass the baton but I'll really try to look at some when I have time16:09
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:09
bauzasgibi: do you want to take that one ?16:09
gibibauzas: I take it16:09
bauzascool thanks16:10
gibithere is one in that 34 that I wanted to look anyhow16:10
bauzas#info bug baton is being passed to gibi16:10
bauzas#topic Gate status 16:10
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:10
bauzas #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status16:10
bauzasall greens16:10
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:11
bauzasfwiw, given https://etherpad.opendev.org/p/recheck-weekly-summary I'll stop to tell about bare rechecks :)16:12
bauzasthe stats are very good for the nova project, thanks to the team who understands it16:12
bauzasso, please continue to not only say 'recheck' but add a specific phrase16:13
bauzasanyway, moving on16:13
bauzas#topic Release Planning 16:13
bauzas#link https://releases.openstack.org/bobcat/schedule.html16:13
bauzas#info Nova deadlines are set in the above schedule16:13
bauzas#link https://releases.openstack.org/bobcat/schedule.html#b-nova-spec-freeze Nova Spec Freeze in two days !16:13
bauzasauniyal: I saw you asked for a review request for your spec, don't worry, we know it16:14
auniyalack bauzas16:14
bauzasI'll ping folks tomorrow to ask for reviews16:14
auniyalactually 6th is a last date, so added16:14
bauzasmoving on16:17
bauzas#topic Review priorities 16:17
bauzas#link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2)16:17
bauzas#info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review16:17
Uggla_auniyal, can you provide your spec link ?16:17
bauzas#topic Stable Branches 16:17
bauzasUggla_: https://review.opendev.org/c/openstack/nova-specs/+/87875716:18
auniyalyes Uggla_, will share here after meet16:18
Uggla_thx16:18
bauzaselodilles: want to tell something ?16:18
elodillesyepp16:18
elodilles#info stable gates should be OK from stable/xena to stable/train16:18
elodilles#info stable gate of stable/2023.1 -> stable/yoga mostly broken due to nova-lvm job issue - https://bugs.launchpad.net/nova/+bug/202581316:18
elodillesthe same thing that we discussed about master gate16:18
elodilles#info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci16:19
elodillesthat was the general gate status part :)16:19
bauzascool thanks16:20
elodillesnp16:20
bauzasabout the train-eol patch, it's on me16:20
bauzasI need to update it based on last week's consensus16:20
elodilles+116:20
elodillesthanks in advance!16:21
bauzasauniyal: you added some items I guess ?16:21
auniyalyes 16:21
auniyal#info Please review these backport patches of stable 2023.1, zed and yoga for next minor release16:21
auniyalmost of these already have one +2.16:21
auniyal#link https://etherpad.opendev.org/p/release-liaison-PatchesToReview16:21
auniyalbauzas, thats all, thanks16:21
bauzascool, thanks for the reminder16:22
bauzastbh for some obvious reasons, my main prio until Friday will be specs review :)16:22
elodilles:)16:22
bauzasok, anything else to add ?16:23
bauzaslooks not16:23
bauzasthen,16:23
bauzas#topic Open discussion 16:23
bauzas(nothing)=16:24
bauzasanything anyone ?16:24
bauzaslooks not16:24
bauzasso,16:25
bauzasyou know whay ? 16:25
bauzasI give you back 35 mins !16:25
bauzasthanks16:25
bauzas#endmeeting16:25
opendevmeetMeeting ended Tue Jul  4 16:25:18 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:25
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2023/nova.2023-07-04-16.00.html16:25
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-07-04-16.00.txt16:25
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2023/nova.2023-07-04-16.00.log.html16:25
elodillesthanks bauzas o/16:25
sean-k-mooneythe only open topic i had is m2 is thruday right16:25
sean-k-mooneyso all spec that shall be approved need to be approved by then16:25
elodillesauniyal: thanks, too, for preparing for stable releases. let me know if i can help with anything for that16:26
sean-k-mooneyand i assume no spec excpeitons this release16:26
auniyalelodilles, ack, someone  already added comments, they are helping16:27
auniyalis it you ?16:27
elodillesyepp, it was me :]16:27
auniyalthanks16:28
elodillesnp :)16:28
auniyal#openstack-nova: free spec to review:  https://review.opendev.org/c/openstack/nova-specs/+/878757 :) 16:28
bauzassean-k-mooney: correct, I said it in the meeting16:35
sean-k-mooneyoh ok i missed that16:35
sean-k-mooneyall good then16:35
bauzasnp16:35
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228418:57
opendevreviewAmit Uniyal proposed openstack/nova master: Delete dangling bdms  https://review.opendev.org/c/openstack/nova/+/88228419:10
opendevreviewMohammed Naser proposed openstack/nova master: docs: fix 404 for ironic docs  https://review.opendev.org/c/openstack/nova/+/88764320:43
mnaser^ five minuter doc fix20:43
opendevreviewArnaud Morin proposed openstack/nova master: Correctly reset instance task state in rebooting hard  https://review.opendev.org/c/openstack/nova/+/86783221:29
« Monday, 2023-07-03 Index Wednesday, 2023-07-05 »

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!