Monday, 2023-07-10

*** Continuity_ is now known as Continuity08:58
opendevreviewNobuhiro MIKI proposed openstack/nova master: libvirt: Add 'COMPUTE_ADDRESS_SPACE_*' traits support  https://review.opendev.org/c/openstack/nova/+/87322109:49
opendevreviewKashyap Chamarthy proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Bobcat"  https://review.opendev.org/c/openstack/nova/+/88725513:07
kashyapsean-k-mooney: --^ Hope that looks better; I'd also like a closer look at the MIN_LIBVIRT_AARCH64_CPU_COMPARE const removal code (Cc: gibi)13:11
dansmithbauzas: I'd really like to get some review on this while I have time to address any concerns and so there's some soak time before release: https://review.opendev.org/q/topic:bp/compute-object-ids+status:open14:42
dansmithif I should just stop asking for this release let me know :)14:42
bauzasdansmith: no no, sorry, last week I was focusing on spec14:51
bauzasthis week, I'll start to look on the series :)14:51
dansmiththanks14:52
auniyal71hey dansmith, can you please have another look on this - Refactoring CinderFixture - https://review.opendev.org/c/openstack/nova/+/885756/6 15:30
dansmithauniyal71: yep, I will.. I haven't yet processed my review email from being on PTO :)15:31
auniyal71ack, yes, was waiting for you :) thanks 15:31
opendevreviewDan Smith proposed openstack/nova master: Refactor CinderFixture  https://review.opendev.org/c/openstack/nova/+/88575616:24
dansmithauniyal71: fixed ^16:24
auniyal71ack, thanks, how did you knew it failed at _test_attach_volume_error16:49
auniyal71dansmith, did it show  in error16:50
auniyal71with tox16:51
dansmithauniyal71: you saw what I saw, which is what was shown in CI16:51
auniyal71yes16:52
dansmiththe problem was not *your* autospec=False thing, it was that case of the test was attempting to re-mock something you already had mocked and *that* was the failing autospec16:52
dansmithi.e. the mock decorator on that test sub-case that I removed16:52
auniyal71okay, 16:54
auniyal71yes, I understood , it was re-mocking and thats problem  but couldn't find at what place.16:56
dansmithto find that, I added a try..except around the action() call, and then if failed, printed which one of those in the list was causing the problem16:56
dansmiththen going to that, it was clear to find that decorator mock16:56
auniyal71oh okay, got it, thanks dansmith 16:57
auniyal71dansmith, can you please review these as well: 17:02
auniyal71https://review.opendev.org/c/openstack/nova/+/87364817:02
auniyal71https://review.opendev.org/c/openstack/nova/+/87744617:02
dansmithauniyal71: yep I have them on my list but it looks like still some outstanding replies from others are expected17:07
auniyal71ack, 17:07
opendevreviewsean mooney proposed openstack/os-vif stable/train: Use TCP keepalives for ovsdb connections  https://review.opendev.org/c/openstack/os-vif/+/84177918:40
opendevreviewsean mooney proposed openstack/os-vif stable/train: only register tables used by os-vif  https://review.opendev.org/c/openstack/os-vif/+/84178018:40
opendevreviewsean mooney proposed openstack/os-vif stable/ussuri: Use TCP keepalives for ovsdb connections  https://review.opendev.org/c/openstack/os-vif/+/84177718:53
opendevreviewsean mooney proposed openstack/os-vif stable/ussuri: only register tables used by os-vif  https://review.opendev.org/c/openstack/os-vif/+/84177818:53
opendevreviewsean mooney proposed openstack/os-vif stable/train: Use TCP keepalives for ovsdb connections  https://review.opendev.org/c/openstack/os-vif/+/84177919:08
opendevreviewsean mooney proposed openstack/os-vif stable/train: only register tables used by os-vif  https://review.opendev.org/c/openstack/os-vif/+/84178019:08
opendevreviewmelanie witt proposed openstack/nova master: Improve logging at '_numa_cells_support_network_metadata'  https://review.opendev.org/c/openstack/nova/+/86093022:05

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!