| opendevreview | melanie witt proposed openstack/nova stable/victoria: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888203 | 02:38 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova stable/victoria: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888204 | 02:38 |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888205 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888206 | 02:41 |
| kashyap | gibi (or anyone): When you get a min, I feel _something_ is off with the code removal of MIN_LIBVIRT_AARCH64_CPU_COMPARE: https://review.opendev.org/c/openstack/nova/+/887255/2/nova/virt/libvirt/driver.py#b9978 | 09:01 |
| kashyap | I can't quite tell what, though | 09:01 |
| opendevreview | alecorps proposed openstack/nova master: Workaround for issues with ephemeral disk named disk.local during resize https://review.opendev.org/c/openstack/nova/+/888220 | 09:42 |
| gibi | kashyap: left feedback in the patch | 09:42 |
| opendevreview | alecorps proposed openstack/nova master: Workaround to fix the issue in resize with ephemeral disk named disk.local. Add a condition to ensure the backing file is present on target host. https://review.opendev.org/c/openstack/nova/+/888221 | 09:42 |
| kashyap | gibi: Thank you; looking | 09:49 |
| *** ministry is now known as __ministry | 10:13 | |
| gibi | kashyap: added one more comment to that review now | 10:45 |
| frickler | sean-k-mooney: gibi: may I turn your attention to https://review.opendev.org/c/openstack/nova/+/871968 once more? there's a comment about a missing backport and I'm not sure whether the CI failure is maybe related or not | 10:49 |
| sean-k-mooney | i belive that is blocked by my fixes for the gate blocker | 10:51 |
| gibi | so one of the error: | 10:51 |
| gibi | tempest.lib.exceptions.InvalidParam: Invalid Parameter passed: When validation.connect_method equals floating, validation_resources cannot be None | 10:51 |
| sean-k-mooney | frickler: basically a test was merged in tempest that required validation to be enabled | 10:51 |
| gibi | this is a known issue | 10:51 |
| sean-k-mooney | i have not backported that fix for nova-lvm to zed yet | 10:51 |
| gibi | ahh both job hit the same | 10:51 |
| sean-k-mooney | only master and the 2023.1 patch is pending a second backport in the devstack ceph plugin | 10:52 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/887674 is the current backport on the nova side | 10:53 |
| sean-k-mooney | but we might need https://review.opendev.org/c/openstack/tempest/+/886991 https://review.opendev.org/c/openstack/devstack/+/887660 or https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/887879 as well | 10:54 |
| opendevreview | sean mooney proposed openstack/nova stable/2023.1: enable validations in nova-lvm https://review.opendev.org/c/openstack/nova/+/887674 | 10:55 |
| sean-k-mooney | i have also added the depends-on for the change elodilles suggested in devstack and we can see if that helps | 10:56 |
| sean-k-mooney | if it fails again ill try also pulling in the second devstack-plugin-ceph patch but im not actully sure that is requried | 10:56 |
| frickler | so what about backporting https://review.opendev.org/c/openstack/nova/+/869950 , should that still also happen? at least to zed? | 11:00 |
| sean-k-mooney | it needs to go to yoga im currently creatign one for zed | 11:00 |
| sean-k-mooney | i was waiting for the antelope patch to actully be working before creating it but i can push one up qickly | 11:01 |
| sean-k-mooney | i need to cherry pick 3 patchs total across 3 repos i think so im goign to do the other two first and then the nova patch which depend on them | 11:04 |
| opendevreview | sean mooney proposed openstack/nova stable/zed: enable validations in nova-lvm https://review.opendev.org/c/openstack/nova/+/888230 | 11:11 |
| sean-k-mooney | frickler: so i think ^ will work if the antelope one is now correct | 11:11 |
| kashyap | gibi: Thanks! That return was the thing I was not quite sure of :) | 11:49 |
| kashyap | But your reason makes sense | 11:49 |
| kashyap | gibi: Just nuking that return should be fine there, I think. | 11:52 |
| frickler | sean-k-mooney: that's not the change I was mentioning above, but ok let's wait how your patches fare in CI first | 11:58 |
| sean-k-mooney | frickler: i know i did not want to update the change you asked about | 12:02 |
| sean-k-mooney | frickler: its blocked by the know gate issue and the patch i linked should solve the know gate issue | 12:02 |
| sean-k-mooney | right now all nova stable branches are blocked between antelope and yoga | 12:02 |
| sean-k-mooney | older ones em branches have pinned tempest | 12:03 |
| gibi | kashyap: I did not notice that return first either. Needed to run the unit test to catch it | 12:04 |
| kashyap | gibi: Thanks for taking the time to do it! | 12:04 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | 13:04 |
| astupnik | Hello. Looking for +2/WF+1 for stable/wallaby backport https://review.opendev.org/c/openstack/nova/+/879405 (improves logging for nova-scheduler) Thanks in advance! | 13:17 |
| dansmith | got it | 13:19 |
| astupnik | thank you very much dansmith | 13:21 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | 13:21 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | 13:21 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 13:21 |
| opendevreview | Stephen Finucane proposed openstack/placement master: db: Workaround SQLAlchemy 2.x bug https://review.opendev.org/c/openstack/placement/+/888281 | 14:09 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | 14:20 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | 14:20 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 14:20 |
| auniyal | dansmith, regarding which exception to raise if provided connector is not correct; https://review.opendev.org/c/openstack/nova/+/877446/comment/16f7cd47_d2c8aef9/; | 15:00 |
| auniyal | I think if new Exception shouldn't be from NovaException then as you suggested RuntimeError makes more sense; | 15:00 |
| auniyal | will it be okay to use RuntimeError directly inside compute/manager ? or new Exception InvalidConnectorError(RuntimeError) should be in exception.py ? | 15:00 |
| opendevreview | Merged openstack/nova stable/wallaby: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879405 | 15:12 |
| dansmith | auniyal: this is nova-manage right? | 15:22 |
| dansmith | I think it's fine to have "class HostConflict(Exception): pass" in manage.py and then use that internally to manage itself | 15:22 |
| dansmith | I would not do that in any service code probably | 15:22 |
| auniyal | yes, nova-manage | 15:24 |
| auniyal | ack | 15:24 |
| dansmith | sean-k-mooney: can you rubber-stamp this cinder fixture refactor? https://review.opendev.org/c/openstack/nova/+/885756 | 15:27 |
| dansmith | converts stub_out to MockPatch so we can get that out from under auniyal's other stack | 15:27 |
| sean-k-mooney | ill take a look now | 15:28 |
| dansmith | don't look, just +W (j/k) | 15:28 |
| sean-k-mooney | oh this hit the complexity limit right | 15:28 |
| dansmith | yeah | 15:28 |
| opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Optionally set lessee on deployment https://review.opendev.org/c/openstack/nova/+/888290 | 15:31 |
| astupnik | It will be great if anyone has time to give +2/wf+1 for https://review.opendev.org/c/openstack/nova/+/883014 (already has +2 from Elod). Fix is about deleting nova flavor | 15:41 |
| astupnik | eleted projects from flavor's | 15:41 |
| astupnik | access lists | 15:41 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 15:59 |
| auniyal | thanks dansmith, sean-k-mooney for +2 | 16:01 |
| auniyal | sean-k-mooney can you please have another look at https://review.opendev.org/c/openstack/nova/+/873648/ | 16:03 |
| opendevreview | Merged openstack/nova master: Refactor CinderFixture https://review.opendev.org/c/openstack/nova/+/885756 | 16:11 |
| astupnik | thank you again Dan! | 16:19 |
| opendevreview | Merged openstack/nova stable/xena: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/883014 | 21:58 |
| opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/888333 | 22:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!