| opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | 00:28 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | 00:28 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | 01:13 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | 01:13 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888508 | 02:02 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | 02:02 |
| opendevreview | melanie witt proposed openstack/nova master: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/888513 | 02:56 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | 07:18 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 07:18 |
| *** elodilles is now known as elodilles_pto | 10:34 | |
| opendevreview | suzhengwei proposed openstack/nova-specs master: spec: evacuate api return migration https://review.opendev.org/c/openstack/nova-specs/+/888101 | 10:38 |
| noonedeadpunk | folks, have anything landed recently to stable branches that could result in `Placement service credentials do not work.` during nova-status upgrade check? | 10:54 |
| noonedeadpunk | I bet we're doing smth wrong with service_tokens to be fair, but not sure I see what exactly | 10:55 |
| noonedeadpunk | as that wasn't an issue couple of days ago | 10:56 |
| noonedeadpunk | like that's nova.conf https://zuul.opendev.org/t/openstack/build/1c40a9d73f1c44a8b61da87bc101b89e/log/logs/etc/host/nova/nova.conf.txt#84 | 10:58 |
| noonedeadpunk | (and I don't see anything obvious in git logs) | 11:00 |
| anskiy | noonedeadpunk: https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/886458 could it be this thing?.. | 11:17 |
| noonedeadpunk | hm... | 11:21 |
| noonedeadpunk | well, this patch is defenitelly in-place, as these would be "changed" otherwise https://zuul.opendev.org/t/openstack/build/1c40a9d73f1c44a8b61da87bc101b89e/log/job-output.txt#24524-24526 | 11:22 |
| noonedeadpunk | so it might be it indeed | 11:23 |
| noonedeadpunk | anskiy: but it could be intermittent as well (or related to the patch?) as https://review.opendev.org/c/openstack/openstack-ansible/+/887866 is not failing the same way | 11:35 |
| noonedeadpunk | I don't see how it can be related to the patch itself though... | 11:37 |
| *** haleyb_ is now known as haleyb | 13:49 | |
| *** d34dh0r5- is now known as d34dh0r53 | 14:04 | |
| opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | 14:48 |
| auniyal | hi dansmith, regarding context is not targeted and context cell uuid is None; as we need admin context if cell_uuid is presentI think we should raise AdminRequired exception | 15:25 |
| auniyal | is it okay ? or only Exception ? | 15:26 |
| dansmith | auniyal: admin has nothing to do with being targeted or not, so I'm not sure what you mean.. this is always using an empty admin context, no? | 15:33 |
| auniyal | context.target_cell(context.get_admin_context(), im.cell_mapping) | 16:17 |
| auniyal | dansmith^^, we use admin context for same | 16:17 |
| dansmith | auniyal: right.. I'm still not sure what you're asking | 16:40 |
| auniyal | I need to raise an Exception of context.cell_uuid is not correct, as this context is made by admin context; I think possible case would be caller did not create it using admin context | 16:42 |
| auniyal | so its appropriate to raise AdminRequired exception | 16:43 |
| dansmith | auniyal: no, I do not think that's reasonable | 16:46 |
| auniyal | ack | 16:47 |
| auniyal | so then Exception('targetcell is not correct') ? | 16:47 |
| dansmith | admin is not even required (for the locking) and you don't need to get *another* context in there like you're doing, right? Use the targeted context that you're being passed | 16:48 |
| dansmith | auniyal: just do 'assert cctxt.cell_uuid is not None' and that's it | 16:48 |
| dansmith | it'll raise AssertionError if that fails | 16:48 |
| auniyal | okay, thanks dansmith | 16:49 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 16:58 |
| sean-k-mooney | dansmith: im going to call it a day but im +2w on all but the second last patch. you can see the comment inlien but i think it would be good to add a release not to that and think about docs or a nova-staus check for unmapped instnaces | 17:09 |
| dansmith | yep was just replying | 17:09 |
| dansmith | sean-k-mooney: thanks for all that and I'll hit the reno and status check next week | 17:10 |
| sean-k-mooney | if your going to do that as a fllow up ill upgrade to +2 and we can see about landing the core part today/monday | 17:14 |
| dansmith | up to you, it's already missing a +2 from bauzas so ... | 17:21 |
| dansmith | I'm fine with leaving it, it's a lot closer than it was yesterday thanks to you, so I'm satisfied :) | 17:21 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | 18:45 |
| *** haleyb_ is now known as haleyb | 21:26 | |
| opendevreview | melanie witt proposed openstack/nova stable/train: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/888509 | 22:18 |
| opendevreview | Merged openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | 22:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!