opendevreview | Merged openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | 02:04 |
---|---|---|
*** ministry is now known as __ministry | 04:40 | |
carloss | o/ Uggla I believe we finally have some testable code in the Manila side for the VirtioFS implementation | 10:41 |
carloss | the Manila changes: | 10:42 |
carloss | https://review.opendev.org/c/openstack/manila/+/887115 - Resource Locks: Support for share deletion lock | 10:42 |
carloss | https://review.opendev.org/c/openstack/manila/+/887725 - Allow restricting access rules fields and deletion | 10:42 |
carloss | OSC changes in case you want to interact with manila through the CLI: | 10:43 |
carloss | https://review.opendev.org/c/openstack/python-manilaclient/+/888006 - Support for resource locks | 10:43 |
carloss | https://review.opendev.org/c/openstack/python-manilaclient/+/888355 - Allow restricting access rules | 10:43 |
carloss | and finally, the SDK part of the implementation: | 10:43 |
carloss | https://review.opendev.org/c/openstack/openstacksdk/+/889519 - Resource locks and access rules restrictions | 10:43 |
carloss | please let me know if I can help with something :) | 10:44 |
carloss | you'll notice some of the changes are still WIP, but that is mostly for some missing coverage in unit/functional tests | 10:44 |
opendevreview | sean mooney proposed openstack/nova master: use disk caching to hide slow cinder performance https://review.opendev.org/c/openstack/nova/+/889383 | 10:57 |
sean-k-mooney | carloss: cool the nova code shoudl use the sdk not the manilaclient | 11:00 |
sean-k-mooney | so we actully only depend on the maniala change and the sdk changes | 11:00 |
sean-k-mooney | its cutting it kind of tight to get this all landed this cycle | 11:01 |
carloss | > carloss: cool the nova code shoudl use the sdk not the manilaclient | 11:03 |
carloss | yep... the sdk change should be in a good shape as well... I did some testing on it yesterday and it behave fine when I did stuff with it manually | 11:03 |
carloss | > its cutting it kind of tight to get this all landed this cycle | 11:03 |
carloss | sean-k-mooney: ack - we'll do our best to have it landing asap in manila | 11:03 |
sean-k-mooney | at least with depend on we can test some of this before its landed | 11:04 |
carloss | ++ | 11:04 |
carloss | I think both manila side changes are ready for some feedback as well, so if you want to share your thoughts, please do so | 11:04 |
sean-k-mooney | have you considered addding tempest coverage? | 11:04 |
sean-k-mooney | or testing it in the manila ci beyond unit/funcitonal tests | 11:05 |
carloss | yeah, we have some changes up for functional testing on manila-tempest-plugin as well: | 11:06 |
carloss | https://review.opendev.org/c/openstack/manila-tempest-plugin/+/888618 - Test resource locks | 11:06 |
carloss | https://review.opendev.org/c/openstack/manila-tempest-plugin/+/889331 - Add access rules restriction tests | 11:06 |
carloss | resource locks is failing because of a known issue in our CI | 11:06 |
carloss | and access rules restrictions is on me... I need to fix some issues with testing, but I also tested it locally and it worked | 11:07 |
carloss | I should figure out such issues with access rules restriction testing over the course of this week | 11:07 |
carloss | s/locally/in a devstack env | 11:08 |
carloss | sean-k-mooney: forgot to share those changes in advance with the other ones I sent, sorry 😅 | 11:09 |
sean-k-mooney | no worries im sure they will be useful for Uggla as a refernce for how to use the apis | 11:37 |
Uggla | Hey carloss, thanks for the information. As sean-k-mooney said I'm currently moving from the manilaclient to sdk. As soon as ready (soon). I will try to implement and test the new "lock and restricted access rules" features. | 12:36 |
Uggla | carloss, also thanks for the hard work, I can't stand to integrate that. | 12:38 |
opendevreview | Stephen Finucane proposed openstack/nova master: Remove unused mocks https://review.opendev.org/c/openstack/nova/+/867789 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/c/openstack/nova/+/659691 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/c/openstack/nova/+/670213 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for volume_target.* https://review.opendev.org/c/openstack/nova/+/867790 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.set_provision_state https://review.opendev.org/c/openstack/nova/+/867791 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.set_power_state https://review.opendev.org/c/openstack/nova/+/867792 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.vif* https://review.opendev.org/c/openstack/nova/+/867793 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for remaining network operations https://review.opendev.org/c/openstack/nova/+/867794 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for remaining ironic driver calls https://review.opendev.org/c/openstack/nova/+/867795 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for deprecated baremetal proxy API https://review.opendev.org/c/openstack/nova/+/867796 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Remove Ironic client wrapper https://review.opendev.org/c/openstack/nova/+/867797 | 12:41 |
opendevreview | Stephen Finucane proposed openstack/nova master: Remove unnecessary aliasing https://review.opendev.org/c/openstack/nova/+/867798 | 12:42 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use real SDK objects in tests https://review.opendev.org/c/openstack/nova/+/867799 | 12:42 |
sean-k-mooney | stephenfin: just one or two ptaches ya | 12:42 |
sean-k-mooney | is that all of the convertion to the sdk | 12:42 |
stephenfin | only two changed, yes 😇 (the rest are just rebases) | 12:43 |
stephenfin | yup, full conversion of ironic calls to SDK | 12:43 |
sean-k-mooney | oh just ironic i tough ti say some neutron ones | 12:43 |
stephenfin | nah, the network operations referred to are still ironic calls | 12:44 |
stephenfin | neutron is a much bigger fish | 12:44 |
sean-k-mooney | ok and same for volume it just the ironic volume bits | 12:44 |
sean-k-mooney | still woul be nice to get that done this cycle | 12:45 |
carloss | Uggla: yw - happy to help... gouthamr and I did our best to get this to a testable state, so have fun testing! :D | 12:45 |
stephenfin | yup, ironic volumes | 12:45 |
Uggla | carloss, \o/ | 12:46 |
opendevreview | Merged openstack/nova master: db: Store unmasked password https://review.opendev.org/c/openstack/nova/+/880669 | 14:40 |
*** d34dh0r5- is now known as d34dh0r53 | 15:01 | |
opendevreview | Vladislav Belogrudov proposed openstack/nova master: Nova instance snapshot should wait for volumes https://review.opendev.org/c/openstack/nova/+/848638 | 15:11 |
opendevreview | Stephen Finucane proposed openstack/nova master: Use real SDK objects in tests https://review.opendev.org/c/openstack/nova/+/867799 | 15:49 |
sean-k-mooney | test_get_console_output_server_id_in_shutoff_status is failling alot i nthe nova_lvm job | 16:17 |
dansmith | bauzas: are you around? | 16:32 |
opendevreview | Dan Smith proposed openstack/nova master: Add upgrade check for compute-object-ids linkage https://review.opendev.org/c/openstack/nova/+/889740 | 17:24 |
dansmith | sean-k-mooney: ^ | 17:24 |
dansmith | I wonder if you could proxy bauzas' +2 on this patch, since he's already +2d the followup which was his reason for not +2ing the first place: https://review.opendev.org/c/openstack/nova/+/884752/2 | 17:25 |
dansmith | that way I can continue my slow grind to recheck these mofos through the gate :/ | 17:25 |
sean-k-mooney[m] | im kind of done for today so ill review the final patch tomorrow but maybe melwitt can take a look | 17:27 |
dansmith | ack, I won't need that +2 for probably several more weeks, but I just want to be able to land it without asking in case I get super lucky ;) | 17:28 |
dansmith | to be clear, the proxy vote is on a patch you already +2d, not the new one | 17:30 |
-opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade at 21:00 utc, approximately an hour from now | 20:03 | |
-opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade, but should return shortly | 21:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!