*** dmellado819 is now known as dmellado81 | 06:55 | |
auniyal | Hey gibi, can you please have a look on https://review.opendev.org/c/openstack/nova/+/882920 mostly good just a backpot for yoga | 08:19 |
---|---|---|
tobias-urdin | two small doc/log fixes when somebody has some seconds to review https://review.opendev.org/c/openstack/nova/+/880819 https://review.opendev.org/c/openstack/nova/+/873846 | 09:03 |
opendevreview | Danylo Vodopianov proposed openstack/nova master: Napatech SmartNIC support https://review.opendev.org/c/openstack/nova/+/859577 | 09:22 |
opendevreview | Danylo Vodopianov proposed openstack/os-vif master: Openvswitch driver was extended https://review.opendev.org/c/openstack/os-vif/+/859574 | 09:24 |
tobias-urdin | another one https://review.opendev.org/c/openstack/nova/+/874083 | 09:24 |
auniyal | thanks gibi | 10:20 |
opendevreview | Danylo Vodopianov proposed openstack/os-vif master: Openvswitch driver was extended https://review.opendev.org/c/openstack/os-vif/+/859574 | 11:33 |
opendevreview | Merged openstack/nova stable/yoga: Have host look for CPU controller of cgroupsv2 location. https://review.opendev.org/c/openstack/nova/+/882920 | 11:53 |
opendevreview | Viktor Křivák proposed openstack/nova-specs master: Add availability zone-aware affinity filter to the scheduler https://review.opendev.org/c/openstack/nova-specs/+/890779 | 12:54 |
opendevreview | Viktor Křivák proposed openstack/nova-specs master: Add availability zone-aware affinity filter to the scheduler https://review.opendev.org/c/openstack/nova-specs/+/890779 | 13:15 |
opendevreview | Dan Smith proposed openstack/nova master: WIP: Support glance's new location API https://review.opendev.org/c/openstack/nova/+/891036 | 14:56 |
dansmith | abhishekk: ^ untested, but that's part of your patch but with some new-or-old logic in it and less change overall as I think we can just ignore the return from that operation | 14:56 |
dansmith | we'll see how that goes, not sure I'll have a change to test locally today but we can iterate from that | 14:57 |
abhishekk | looking | 14:57 |
abhishekk | I didn't understood raise exc part at line #571 | 15:00 |
dansmith | abhishekk: oh that was supposed to end up under the badrequest thing | 15:03 |
dansmith | ah right but I need to test | 15:03 |
dansmith | so the goal is to try each of those interfaces, but if neither work, raise the error we got from the last one | 15:03 |
dansmith | so we might be able to just raise the badrequest whenever we get it, but I need to test glance's behavior with each of the new stuff missing and the old stuff disabled | 15:04 |
abhishekk | ack, so you need another plain Exception block as well | 15:04 |
abhishekk | ? | 15:04 |
dansmith | so that _reraise was supposed to be a pass and replace the raise below | 15:04 |
dansmith | no, I think we want to try both and raise the last one | 15:05 |
dansmith | and we need to catch whatever expected exceptions will come from trying the new interface if it's missing | 15:05 |
abhishekk | ack, because what I understood is lien #571 might express as raise None | 15:05 |
dansmith | should just be notfound right? | 15:05 |
dansmith | oh, two notfounds could raise none, yeah you're right | 15:06 |
dansmith | anyway, like i said, untested, just kinda what I'm thinking :) | 15:06 |
abhishekk | :D | 15:06 |
abhishekk | I am not sure client will be updated today to raise Notfound if version is less than 2.17 | 15:07 |
dansmith | if glance is not updated, the URL should generate a notfound, no? | 15:07 |
dansmith | you think glanceclient will translate that into something else? | 15:08 |
abhishekk | NO, as you added depends on in commit message, it will call add_image_location, right? | 15:08 |
dansmith | right, but we need to handle the case where glance is not upgraded | 15:09 |
abhishekk | yes, | 15:09 |
dansmith | so actually, let me change this so it's clearer | 15:09 |
abhishekk | that needs to be there in client patch, but since your patch has glance and client dependency it will call new API i guess | 15:09 |
opendevreview | Dan Smith proposed openstack/nova master: WIP: Support glance's new location API https://review.opendev.org/c/openstack/nova/+/891036 | 15:10 |
opendevreview | Dan Smith proposed openstack/nova master: DNM: Test glance new location api https://review.opendev.org/c/openstack/nova/+/891207 | 15:10 |
dansmith | this stack needs to work ^ | 15:11 |
dansmith | er, well, actually, | 15:11 |
dansmith | the glanceclient depends-on should go in the first patch I guess. | 15:11 |
dansmith | we can require glanceclient version, but we can't require glance version | 15:11 |
abhishekk | right | 15:11 |
opendevreview | Dan Smith proposed openstack/nova master: WIP: Support glance's new location API https://review.opendev.org/c/openstack/nova/+/891036 | 15:13 |
opendevreview | Dan Smith proposed openstack/nova master: DNM: Test glance new location api https://review.opendev.org/c/openstack/nova/+/891207 | 15:13 |
dansmith | first depends on glanceclient, second depends on glance | 15:14 |
abhishekk | This looks good now | 15:17 |
abhishekk | thank you for your time !! | 15:17 |
dansmith | ack, I'll try to poke more at it on monday | 15:17 |
abhishekk | Cool, will be around as well | 15:17 |
*** ykarel is now known as ykarel|away | 15:59 | |
abhishekk | dansmith, nova-ceph-multistore passed on both the patches | 17:35 |
dansmith | yeah I saw | 17:36 |
dansmith | did you confirm in the glance log that it's hitting the new one? | 17:37 |
abhishekk | looking for it now, | 17:40 |
abhishekk | https://zuul.opendev.org/t/openstack/build/9c045d22dee34b08bb8767a1f972db09/log/job-output.txt#22303 this is the test right? | 17:40 |
dansmith | I see location_import task running so I assume that means it is | 17:42 |
dansmith | abhishekk: any server snapshot task should trigger it | 17:42 |
abhishekk | yeah | 17:42 |
abhishekk | me too | 17:42 |
abhishekk | location_import-CalculateHash | 17:44 |
abhishekk | at least some positive signs :D | 17:45 |
dansmith | yup, I definitely expected more fails for sure | 17:47 |
abhishekk | on that note, I am stepping in the weekend mood | 17:52 |
dansmith | enjoy ;) | 17:53 |
abhishekk | See you monday, happy weekend o/~ | 17:53 |
opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing py3.11 job https://review.opendev.org/c/openstack/nova/+/891228 | 19:42 |
opendevreview | Ghanshyam proposed openstack/nova stable/2023.1: DNM: testing py3.11 job not running on 2023.1 template https://review.opendev.org/c/openstack/nova/+/891113 | 19:43 |
opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing some zuul template config https://review.opendev.org/c/openstack/nova/+/891235 | 20:43 |
opendevreview | Ghanshyam proposed openstack/nova stable/2023.1: DNM: testing some zuul template config https://review.opendev.org/c/openstack/nova/+/891114 | 20:43 |
opendevreview | melanie witt proposed openstack/nova master: Use futurist.ThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/c/openstack/nova/+/650172 | 20:50 |
opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing some zuul template config https://review.opendev.org/c/openstack/nova/+/891235 | 21:14 |
opendevreview | Ghanshyam proposed openstack/nova stable/2023.1: DNM: testing some zuul template config https://review.opendev.org/c/openstack/nova/+/891114 | 21:14 |
opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2023.2 Bobcat https://review.opendev.org/c/openstack/nova/+/876447 | 21:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!