opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | 01:07 |
---|---|---|
opendevreview | sean mooney proposed openstack/nova master: remove untils.spawn_n https://review.opendev.org/c/openstack/nova/+/892722 | 01:59 |
opendevreview | Natz cheng proposed openstack/nova master: Updated links in documentation to be safe links https://review.opendev.org/c/openstack/nova/+/892724 | 02:51 |
opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/891648 | 03:33 |
opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | 03:54 |
dvo-plv | sean-k-mooney, Hello | 08:07 |
dvo-plv | I would like to talk regarding issue, which you mentioned here: https://review.opendev.org/c/openstack/neutron/+/869510 | 08:08 |
kashyap | gibi: Just saw your ping earlier; will check (the bug https://bugs.launchpad.net/nova/+bug/2023035) | 08:12 |
gibi | kashyap: thanks! | 08:13 |
kashyap | gibi: Related: Can you get unblock the Workflow-1 here? : https://review.opendev.org/c/openstack/nova/+/871968 | 08:20 |
kashyap | Elod is on PTO and that W-1 doesn't apply (as he did based on a comment from Amit, and Amit took back his -1) | 08:21 |
opendevreview | Ryota, Ochiai proposed openstack/nova master: doc: Update the installation guide for RHEL and CentOS https://review.opendev.org/c/openstack/nova/+/892607 | 08:28 |
gibi | kashyap: do I understand correctly that we don't want to backport https://review.opendev.org/c/openstack/nova/+/869950 just https://review.opendev.org/c/openstack/nova/+/871968 ? | 08:49 |
gibi | btw I cannot remove elodilles_pto's -w you need infra's help for that | 08:53 |
gibi | kashyap: according to my sources Elod is back on Monday | 09:03 |
auniyal | yes kashyap, I was in doubt if this need to be backported too - https://review.opendev.org/c/openstack/nova/+/869950, | 09:12 |
auniyal | so the reason to remove +1 is to get attention of cores, as there was no backport patch for 869950 | 09:12 |
auniyal | gibi, can you please review this - https://review.opendev.org/q/topic:dangling-volumes | 09:14 |
kashyap | gibi: Yes, your understanding is correct. Only https://review.opendev.org/c/openstack/nova/+/871968 | 09:20 |
kashyap | auniyal: (It - 869950 - is not required.) | 09:20 |
opendevreview | Ryota, Ochiai proposed openstack/nova master: doc: Update the installation guide for RHEL and CentOS https://review.opendev.org/c/openstack/nova/+/892607 | 09:20 |
auniyal | ack | 09:25 |
dvo-plv | sean-k-mooney, I found that socket can be different for vendors. So I would like to use something like that https://paste.opendev.org/show/bKfuy2TzkygTyLtyW8TE/ | 09:48 |
dvo-plv | this method creates scoket name accodring to the formula which user can provide via binding port profile. So in the result we will get multinic support and each nix can have uniq socket name | 09:49 |
dvo-plv | this method we can call here to format correct socket name https://review.opendev.org/c/openstack/neutron/+/869510/13/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#221 | 09:50 |
opendevreview | Merged openstack/nova master: Fix exception catch when volume mount fails https://review.opendev.org/c/openstack/nova/+/852795 | 10:44 |
sean-k-mooney | speaking of +1... gibi care to take a look at https://review.opendev.org/c/openstack/nova/+/873061/9 | 12:50 |
sean-k-mooney | i dont know if we need more disucssion on that in general but i also too a swing at removing spwan_n entirly in the followup patch | 12:51 |
sean-k-mooney | melwitt: ^ | 12:51 |
sean-k-mooney | that might need more discusion but i think its proably a good idea in the long run. | 12:52 |
gibi | sean-k-mooney: I will check. I see that it was improved since I last read it | 12:58 |
*** TheJulia is now known as needs_brains_and_sleep | 13:04 | |
*** needs_brains_and_sleep is now known as TheJulia | 13:23 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: [functional] Avoid leaking greenlet in UnifiedLimits tests https://review.opendev.org/c/openstack/nova/+/892791 | 13:55 |
auniyal | Hi dansmith, can you please have another look on https://review.opendev.org/c/openstack/nova/+/881457 | 13:56 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [functional]Fix remaining greenlet leaks https://review.opendev.org/c/openstack/nova/+/892793 | 14:17 |
gibi | sean-k-mooney: fixed the remaining functional leaks and set the env variable for the functionl env to enforce we don't introduce new ones. | 14:18 |
gibi | so we can patch the leaks without switching to spawn or using cast as call | 14:23 |
sean-k-mooney | we can yes | 14:23 |
sean-k-mooney | i just fixed them becuase i was force to do it when swaping to spawn | 14:23 |
sean-k-mooney | so i did it in one pathc | 14:23 |
sean-k-mooney | i was not swaping to spwan to fix tehm i was fixing them so we could swap to spawn form spawn_n | 14:24 |
sean-k-mooney | i am fine to proceed with your leak fix for the final test | 14:25 |
sean-k-mooney | and then rebase the spawn change on top | 14:25 |
sean-k-mooney | so it clearer what is required for that | 14:25 |
sean-k-mooney | your fixes are less invasive then mine | 14:25 |
gibi | cool | 14:26 |
gibi | in the long run I have no problem removing the spawn_n usage from nova | 14:26 |
gibi | as far as I remember there was no good reason to have it in the first place | 14:26 |
gibi | it is less resource to use spawn_n but I don't think it is significant compared to spawn | 14:27 |
sean-k-mooney | so thats the thing | 14:28 |
sean-k-mooney | technially since its just a greenlet it shoudl be | 14:28 |
sean-k-mooney | but i dont think in reality it has any really difference | 14:28 |
sean-k-mooney | and melwitt pointed out a thing i forgot | 14:29 |
sean-k-mooney | when we were talking to the eventlet maintainers | 14:29 |
sean-k-mooney | they mentioned that there was some undefiend behavior with raw greenlets | 14:29 |
sean-k-mooney | so im hoping there will be no effective difference performance wise | 14:29 |
sean-k-mooney | and correctness wise im hopeing for less edgecases by this change | 14:29 |
gibi | it is less resource to use spawn_n but I don't think it is significant compared to spawn | 15:23 |
gibi | sorry | 15:23 |
gibi | yeah I agree with the overall direction | 15:24 |
dansmith | auniyal: is it passing tests now? | 15:33 |
auniyal | yes CI passing :) | 15:34 |
dansmith | auniyal: one very small (but weird) formatting nit | 15:47 |
dansmith | auniyal: if you can fix that real quick I'll +2 | 15:47 |
opendevreview | Dan Smith proposed openstack/nova master: VERYWIP: Support setting alias on libvirt disks https://review.opendev.org/c/openstack/nova/+/892800 | 15:48 |
opendevreview | Dan Smith proposed openstack/nova master: VERYWIP: Set libvirt device alias for volumes https://review.opendev.org/c/openstack/nova/+/892801 | 15:48 |
dansmith | oh I guess kashyap isn't here | 15:49 |
sean-k-mooney | any reason for the ua- prefix for the volume id | 15:56 |
dansmith | auniyal: comments on the reproducer too | 15:56 |
dansmith | sean-k-mooney: required by libvirt (as noted in the commit message) | 15:56 |
dansmith | sean-k-mooney: interestingly if you omit that, it just ignores what you gave it and uses its own value with no warning :/ | 15:56 |
sean-k-mooney | .. of couse it does | 15:57 |
sean-k-mooney | im debating in my head the value fo doint that in the call site as you did vs prefixing it here https://review.opendev.org/c/openstack/nova/+/892800/1/nova/virt/libvirt/config.py#1205 | 15:57 |
dansmith | well, one reason is that libvirt gives everything auto-generated aliases if you don't specify one, | 15:58 |
dansmith | and so we'd need to strip out the ua- from the parsing if we do it on the input, and then there's no way to tell from the higher layers if it's one we set or libvirt set | 15:59 |
dansmith | default looks like: | 15:59 |
dansmith | <alias name='virtio-disk0'/> | 15:59 |
sean-k-mooney | ok thats good to know. | 15:59 |
sean-k-mooney | then one suggestion would be add a is a uuid_to_alais funciton | 16:00 |
sean-k-mooney | so we can just use taht everywhere | 16:00 |
sean-k-mooney | but thats a minor nit | 16:00 |
sean-k-mooney | i guess we wont alwasy have a uuid | 16:01 |
dansmith | right | 16:01 |
sean-k-mooney | for pci devie form flavor alaises for example | 16:01 |
dansmith | and root disk, if we wanted to set that | 16:01 |
dansmith | anyway, I mostly just wanted to make sure we could plumb that through and it would stick in libvirt | 16:01 |
sean-k-mooney | im not sure if we dont because we dont supprot detaching that but it would help for swap on reize perhaps | 16:01 |
sean-k-mooney | ya its good to get this basic proof of concept and find the "ua-" issue | 16:02 |
dansmith | I don't know that we need it at all, I'm just saying if we set the alias for those devices, we won't have a uuid | 16:02 |
sean-k-mooney | related question | 16:03 |
sean-k-mooney | do we know if libvirt has an api to get/remove a device via the alais | 16:03 |
sean-k-mooney | it would be nice if it did but probaly does not | 16:03 |
dansmith | idk, but it's not required I think | 16:03 |
sean-k-mooney | ya its likely not but it would be nice just to detach a volume by doing libvir.detach_device(alias=<volume uuid>) | 16:04 |
dansmith | https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceAlias | 16:04 |
dansmith | that will be *very* nice, IMHO | 16:04 |
sean-k-mooney | oh perfect | 16:04 |
sean-k-mooney | ya so that is what i was hoping for i think | 16:05 |
sean-k-mooney | it also renforice the idea that this is how libvirt want use to name/specify things to detatch ectra | 16:05 |
dansmith | up | 16:05 |
dansmith | also yup | 16:05 |
sean-k-mooney | so this was added in 3.9.0 which was released in late 2017 so when we first started lookign at teh lun issue it did not exist and when we looed at them last i dont know if we have a high enough min libvirt | 16:07 |
sean-k-mooney | but for master this looks like a nice cleanup over all | 16:07 |
sean-k-mooney | thanks for starting a poc of this | 16:07 |
dansmith | yeah, I'll get going on a spec just to lay some of this otu | 16:08 |
kashyap | dansmith: Hi! I hear you were looking for me :) | 16:09 |
dansmith | I'll have to survey where all we look up devices to see where we need to convert them to use this | 16:09 |
dansmith | kashyap: was just going to point you at this: https://review.opendev.org/q/topic:libvirt-dev-alias | 16:09 |
dansmith | and sean-k-mooney and I were chatting about it briefly just now | 16:09 |
kashyap | Yeah, just found 'em | 16:10 |
kashyap | dansmith: Just added a small comment here - https://review.opendev.org/c/openstack/nova/+/892800 | 16:13 |
kashyap | My guess is you already know it | 16:14 |
dansmith | kashyap: it's in the commit message | 16:14 |
dansmith | well, the ua- part is anyway | 16:15 |
kashyap | Ohh, I read the commit message, but I didn't see the "ua-" part explicitly called out. Blind me | 16:17 |
kashyap | (Oh, it's in the other commit message. Just saw it) | 16:19 |
auniyal | dansmith, ack, will update , thanks | 16:21 |
sean-k-mooney | dansmith: looking out our downstream multi attach volume docs it says "Live migration of multi-attach volumes is not available" that cinder volume migration right | 16:22 |
sean-k-mooney | ill check our upstrema docs but as far as i am aware we supprot live migration of vms with multi attach | 16:22 |
dansmith | sean-k-mooney: no idea | 16:22 |
kashyap | sean-k-mooney: dansmith: I just read your brief discussion on the upstream log. (I agree that we should indeed retain the prefix or else ... the odd behavior Dan noted is not nice.) | 16:23 |
opendevreview | Merged openstack/nova master: introduce global greenpool https://review.opendev.org/c/openstack/nova/+/873061 | 16:28 |
opendevreview | Dan Smith proposed openstack/nova-specs master: WIP: Add libvirt-dev-alias spec https://review.opendev.org/c/openstack/nova-specs/+/892806 | 16:33 |
dansmith | sean-k-mooney: kashyap^ just brain dump level to get it started | 16:34 |
kashyap | Nice; the outline looks already quite good to me. Cced myself, will do a concetrated read on Mon | 16:41 |
kashyap | Heh, how plainly you write the alternative "We could maintain our own mapping in our database for those device types" | 16:41 |
kashyap | (I mean, I like the matter-of-factly stating) | 16:41 |
opendevreview | Amit Uniyal proposed openstack/nova master: Add function to get all attachments in Cinder.API module https://review.opendev.org/c/openstack/nova/+/881457 | 16:46 |
opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/889947 | 16:46 |
opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 16:46 |
dansmith | auniyal: looks like you committed a bunch of extra changes into that base patch? | 16:50 |
auniyal | yes, that was a pep8 fix I have to do after rebase | 16:52 |
auniyal | I added a note in commit msg for same | 16:52 |
dansmith | auniyal: they're in files you haven't touched | 16:52 |
dansmith | they should not be in that patch | 16:53 |
auniyal | ack, will remove them, | 16:53 |
opendevreview | Amit Uniyal proposed openstack/nova master: Add function to get all attachments in Cinder.API module https://review.opendev.org/c/openstack/nova/+/881457 | 17:03 |
opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/889947 | 17:03 |
opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | 17:03 |
auniyal | thanks dansmith | 17:11 |
sean-k-mooney | dansmith: this wont shock you but since we are discussin cinder voluems in varios place i cam acroos an unsupproted edgecase a while back | 17:24 |
sean-k-mooney | if you have an image of format=iso you can both a vm form it and then install to a cinder data volume | 17:24 |
sean-k-mooney | however you cant do that if you try to do bfv | 17:24 |
sean-k-mooney | as we assume all bfv case are block devices not "cd-roms" | 17:25 |
sean-k-mooney | so we try to use the volume contianign the iso data as a block device | 17:25 |
sean-k-mooney | so wehn the vm boot it cant actully load the bootload/root filesytem | 17:25 |
sean-k-mooney | i feel like that should be simple to fix if we ever had time to do it | 17:26 |
sean-k-mooney | as a result you cant actully use cidner volumes as "dirver disks" or install media today without somehow converting the iso to a bootable filesystem | 17:27 |
dansmith | why would you bfv with the root disk as the iso? | 17:30 |
dansmith | you want bfv with the root disk as a volume and the iso as a secondary non-root device right? same for driver disks | 17:30 |
sean-k-mooney | well that also wotn work volume created form iso just dont work when attach to a vm | 17:31 |
sean-k-mooney | but my usecase was installing openshift on openstack using the installer iso | 17:31 |
sean-k-mooney | my home cloud is configured ot only do bfv | 17:32 |
sean-k-mooney | i worked aroudn it by temproy addign a flavor with some local storage and then did the install to a cienr volume and then booting another vm form that data volume after the fact | 17:32 |
dansmith | yeah I think the iso-on-volume thing is known, | 17:33 |
dansmith | Im just not sure that it has anything to do with bfv necessarily except that's the situation you need it for more I uess | 17:33 |
sean-k-mooney | it actully woudl be fairly simple to fix just add metadata on teh volume to say it not a block device but rather a cd/removal media | 17:33 |
sean-k-mooney | oh its not its just if you dont do boot form volume | 17:34 |
sean-k-mooney | the workflow of boot form iso and then install do data volume works | 17:34 |
sean-k-mooney | the gap/bug is just we cant take a cinder volume and attach it as a cd to the vm | 17:34 |
sean-k-mooney | that is totally fixable with metadta if we wanted too | 17:35 |
dansmith | how do you do boot from iso if it's not the image and not in a volume/ | 17:35 |
sean-k-mooney | the iso data woudl be in the volume | 17:36 |
sean-k-mooney | we just need metadata do say use device=cdrom | 17:37 |
dansmith | I'm talking about currently, you said you can currently boot from iso | 17:37 |
sean-k-mooney | actully you could probly do that today by setting type=cdrom in the bdms | 17:38 |
sean-k-mooney | oh right i booth form an image | 17:38 |
sean-k-mooney | but we have code to handel if they image type in glance is iso | 17:38 |
sean-k-mooney | and we attach it as a cdrom in that case | 17:38 |
sean-k-mooney | actully so ya lookign at our docs | 17:40 |
sean-k-mooney | if you manually specifed the bdm on the api request it would work | 17:40 |
sean-k-mooney | this is just an issue if you use --volume i think | 17:40 |
sean-k-mooney | we docuemnt device_type may be disk, cdrom, floppy, lun | 17:41 |
dansmith | ...right | 17:41 |
sean-k-mooney | i have not seen that menetion in other docs so i either forgat the that or the doc i was followign didnt mention that | 17:42 |
sean-k-mooney | dansmith: so i think my main issue was a i was trying to do this via horizon which cant do ti and b i forgot about that field in the mappigns thanks for talkign this true | 18:10 |
dansmith | gui strikes again :) | 18:10 |
sean-k-mooney | still proably a docs bug but ill try doing it proplry and might submit a docs patch if it work | 18:10 |
sean-k-mooney | i feel like addign device_type to the image or voluem would still be nicer long term but that a seperate topic | 18:11 |
*** tbachman_ is now known as tbachman | 18:31 | |
opendevreview | Merged openstack/nova master: [functional] Avoid leaking greenlet in UnifiedLimits tests https://review.opendev.org/c/openstack/nova/+/892791 | 18:44 |
atmark | hello, I'm getting this error failing to delete a compute node using `openstack compute service delete X` | 19:18 |
atmark | Failed to delete compute service with ID 'X': HttpException: 500: Server Error for url: | 19:18 |
atmark | Running stable/victoria | 19:18 |
sean-k-mooney | that not really enough info for use to comment | 19:18 |
sean-k-mooney | you will need to look at the nova-api log to see what the actula error is | 19:18 |
atmark | k, one sec | 19:19 |
atmark | hitting same issue https://bugs.launchpad.net/nova/+bug/1964137 | 19:19 |
atmark | https://paste.openstack.org/show/bIU0SLPjbnkWSFzFHaFu/ | 19:22 |
sean-k-mooney | ok so its sayign the placement resouce provider was delete | 19:24 |
sean-k-mooney | did you perhaps manually delete it at some point | 19:24 |
sean-k-mooney | teh compute serivce delete also cleans it up | 19:24 |
atmark | yes, I manually deleted it from db cuz it won't let me delete via API | 19:25 |
atmark | still seeing the compute when running `openstack compute service list` | 19:25 |
atmark | this is a dev env | 19:26 |
sean-k-mooney | ok so you porblay could not delete it form the api because it had allcoation assocated with it | 19:26 |
atmark | how can I totally clean this up? | 19:26 |
sean-k-mooney | asuming you have stoped nova-compute on the host in your dev env | 19:26 |
atmark | yep it's stopped | 19:27 |
sean-k-mooney | then you will likely need to delete the compute service in the cell 1 db | 19:27 |
sean-k-mooney | is this devstack or somethign else | 19:27 |
atmark | kolla-ansible | 19:27 |
sean-k-mooney | ok i need to check the db name but it will likely be either nova_cell1 or just nova | 19:27 |
atmark | there's no nova | 19:28 |
atmark | nova_cell1 and nova_cell0 | 19:28 |
sean-k-mooney | ya so in nova_cell1 there is a comptue service table and a compute nodes table and you will need to mark the relevent row as deleted in both | 19:28 |
atmark | compute_nodes ? | 19:29 |
atmark | is that the table name ? | 19:29 |
atmark | that's the only table name that starts with compute_* | 19:30 |
sean-k-mooney | hum i guess that is a recent change my home kolla ansibel has nova isntead of nova_cell1 | 19:31 |
sean-k-mooney | one sec while i check | 19:31 |
sean-k-mooney | so you will have a table called services | 19:31 |
atmark | yeah, my prod env has three nova tables, nova, nova_cell0 and nova_cell1 | 19:32 |
atmark | dev only has two | 19:32 |
atmark | this isn't any issue right ? | 19:33 |
sean-k-mooney | you should really have nova_api nova_cell1 and nova_cell0 | 19:33 |
atmark | i have nova_api all envs | 19:33 |
atmark | in all envs* | 19:33 |
sean-k-mooney | ah ok | 19:33 |
sean-k-mooney | ya so the nova cell1 db used to be called nova | 19:33 |
atmark | but no 'nova' db in dev | 19:33 |
sean-k-mooney | we recommend however that you call it nova_cell1 | 19:33 |
sean-k-mooney | that fine they proably just change the defautl name to follow our recomendations | 19:34 |
sean-k-mooney | select count(*) from nova_cell1.services; | 19:34 |
sean-k-mooney | if you do that you will have multiple rows | 19:34 |
atmark | https://paste.openstack.org/show/b5Sy9Ww7HUGcRG7zWKhc/ | 19:35 |
sean-k-mooney | so if you do "select * from nova.services s where s.binary='nova-compute';" you will see the compute node records | 19:36 |
sean-k-mooney | and you will need to clean up the one for the host you removed | 19:36 |
atmark | got it | 19:36 |
sean-k-mooney | you shoudl also do the same in the compute_nodes table but it the service table that is used when you do a openstack compute service list | 19:36 |
atmark | nova_cell1.services and nova_cell0.services right ? | 19:37 |
sean-k-mooney | the compute_nodes table is use by openstack hypervisor list | 19:37 |
sean-k-mooney | no you only need to remove the compute record form cell 1 | 19:37 |
sean-k-mooney | dont remove them all | 19:37 |
sean-k-mooney | technially you actully want ot set deleted=id for that specific row | 19:38 |
atmark | ok nova_cell0 table are controllers services | 19:39 |
atmark | make sense | 19:39 |
sean-k-mooney | yes | 19:39 |
sean-k-mooney | cell0 is special and never has computes | 19:39 |
sean-k-mooney | cell1 is the first "real" cell in that it the first cell that can have computes | 19:40 |
sean-k-mooney | the name does not actully matter but cell0 or rhat the cell with the all 0 uuid is special in nova | 19:40 |
opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Optionally set lessee on deployment https://review.opendev.org/c/openstack/nova/+/888290 | 20:08 |
opendevreview | Merged openstack/nova master: [functional]Fix remaining greenlet leaks https://review.opendev.org/c/openstack/nova/+/892793 | 20:31 |
opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Optionally set lessee on deployment https://review.opendev.org/c/openstack/nova/+/888290 | 20:48 |
JayF | https://review.opendev.org/c/openstack/nova/+/888290 is tested in devstack, working, simple, and limited to Ironic's virt driver. Your reviews are appreciated :) | 20:50 |
atmark | sean-k-mooney: what should be id for deleted in compute_nodes table ? | 20:57 |
atmark | the id between services and compute_nodes table don't match https://paste.openstack.org/show/b2yJiggYenod3SoioAyo/ | 20:57 |
atmark | i'm trying to get rid of compute05.dev | 20:58 |
atmark | sean-k-mooney: figured it out. I matched the value in id and deleted in compute_nodes table | 21:38 |
atmark | Thanks for your help | 21:38 |
opendevreview | sean mooney proposed openstack/nova master: remove untils.spawn_n https://review.opendev.org/c/openstack/nova/+/892722 | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!