opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | 00:36 |
---|---|---|
opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/903427 | 02:29 |
*** jph5 is now known as jph1 | 08:19 | |
*** jph1 is now known as jph | 08:20 | |
opendevreview | Vasyl Saienko proposed openstack/nova master: Fix returning empty availability zone https://review.opendev.org/c/openstack/nova/+/902875 | 09:04 |
*** elodilles_pto is now known as elodilles | 09:06 | |
alisafari | sean-k-mooney Hi, could you check out these backports? https://review.opendev.org/q/topic:%22fix-traits-to-cpu-flags-mapping%22 | 09:11 |
elodilles | bauzas: sorry, i forgot to let you know that i'll be on PTO yesterday :/ | 10:04 |
bauzas | elodilles: no worries at all :) | 10:04 |
elodilles | o:) | 10:04 |
elodilles | nevertheless, i have a question: have you heard about this qemu feature: cpu-pm? -> https://patchwork.kernel.org/project/qemu-devel/patch/20180622003140.164613-2-mst@redhat.com/ | 10:05 |
elodilles | or maybe the question is also to sean-k-mooney ^^^ | 10:06 |
elodilles | do you remember maybe if someone was preparing to include this in OpenStack? a patch, a blueprint, or something like that? | 10:07 |
opendevreview | Nobuhiro MIKI proposed openstack/nova master: scheduler: Request COMPUTE_ADDRESS_SPACE_* traits https://review.opendev.org/c/openstack/nova/+/895761 | 10:14 |
opendevreview | Nobuhiro MIKI proposed openstack/nova master: libvirt: Add config option to support maxphysaddr https://review.opendev.org/c/openstack/nova/+/895759 | 10:21 |
bauzas | elodilles: sorry, just saw your ping | 10:29 |
bauzas | elodilles: nope, wasn't aware of it | 10:29 |
elodilles | bauzas: thanks. well, i'm not even sure it's still there in qemu, and i haven't seen sign of it in libvirt either, though i thought it worth a question o:) | 10:38 |
opendevreview | Stephen Finucane proposed openstack/nova master: docs: Address nits in new security group doc https://review.opendev.org/c/openstack/nova/+/903590 | 12:50 |
gibi | sean-k-mooney: an easy power management bugfix backport that has elodilles' +2 https://review.opendev.org/c/openstack/nova/+/903151 | 13:38 |
sean-k-mooney | "raise exception.InvalidConfiguration(msg) from e" ah your using that to convert the excpetion cool | 13:47 |
sean-k-mooney | +2w | 13:49 |
artom | Ooo, `raise from` is a thing? | 14:05 |
sean-k-mooney | its a python 3 only thing | 14:05 |
artom | So I could import zombie; raise zombie from the_dead? :D | 14:05 |
sean-k-mooney | but yes | 14:05 |
sean-k-mooney | ... | 14:05 |
sean-k-mooney | your a terrible terrible person. a good person but a teribel one :P | 14:05 |
artom | :D | 14:06 |
gibi | :D | 14:09 |
gibi | artom: you need to declare the_dead before | 14:10 |
gibi | :) | 14:10 |
sean-k-mooney | artom: +2 on https://review.opendev.org/c/openstack/nova/+/899776 but add a release note please if you respin | 14:15 |
sean-k-mooney | gibi: if your review then ^ is small | 14:18 |
artom | Yeah, agree on the release note | 14:18 |
sean-k-mooney | its not vital but it woudl be good to advertise this. if you want to respin anyway jsut ping me and ill take a look again | 14:19 |
opendevreview | Artom Lifshitz proposed openstack/nova master: libvirt: Stop unconditionally enabling evmcs https://review.opendev.org/c/openstack/nova/+/899776 | 14:23 |
artom | Done ^^ :) | 14:23 |
sean-k-mooney | ack +2'd | 14:30 |
kashyap | elodilles: Hi, I was just pointed to your question about https://patchwork.kernel.org/project/qemu-devel/patch/20180622003140.164613-2-mst@redhat.com/ | 14:47 |
kashyap | elodilles: It's a QEMU command-line option, as you see. We don't have a BP (not that I know of) for it | 14:47 |
kashyap | Have you tested it w/ "<qemu:commandline> | 14:48 |
kashyap | ... in the guest XML? Do you see noticeable benefits? | 14:48 |
sean-k-mooney | we do not allow <qemu:commandline> to be used in nova | 14:49 |
sean-k-mooney | so even if that worked it would need to be expose via an actual libvirt element | 14:49 |
sean-k-mooney | its fine for testing hwoever | 14:49 |
gibi | artom, sean-k-mooney +2+W | 14:50 |
sean-k-mooney | elodilles: so i had heard about the fucntionaltiy but not looked into it much | 14:53 |
sean-k-mooney | elodilles: i could see use in the future enableing this by default for guest with pinned but not mixed cpus | 14:54 |
sean-k-mooney | since this does not seam to be per core we cant supprot mixed cpus | 14:54 |
*** d34dh0r5- is now known as d34dh0r53 | 14:59 | |
elodilles | kashyap: i'm not aware of any testing, but yeah, that's probably would be a good start to see if it has any benefit. | 15:00 |
kashyap | sean-k-mooney: I of course know we don't allow. I explicitly said "testing" there | 15:01 |
kashyap | The qemu:commandline thing. It is alwys mentioned in context of developer testing in this channel for a million years now. | 15:01 |
kashyap | elodilles: Yeah; some data on that would be good. What made you think of that feature? | 15:01 |
elodilles | sean-k-mooney: ACK, yepp, only for guests with pinned CPUs, yepp. that was my understanding too. | 15:01 |
sean-k-mooney | elodilles: if you do try this in devstack just not i disabled the apic by default in devstack becasue of a bug in cirros 5.x | 15:02 |
elodilles | kashyap: well, i got a question from downstream team :) | 15:02 |
kashyap | Ah, makes sense :) | 15:02 |
sean-k-mooney | that bug nolonger exists in 6.x but i have not disabeld that workaround | 15:02 |
sean-k-mooney | so you might need to makesure it off in your env if you try it | 15:03 |
sean-k-mooney | off meaing the workaroudn is disabeld and the apic is present in the guest | 15:03 |
sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#workarounds.libvirt_disable_apic | 15:03 |
sean-k-mooney | oh actully ignore that | 15:04 |
sean-k-mooney | its acpi that is used for power not apic | 15:05 |
elodilles | :) | 15:07 |
kashyap | Yeah, confusing acronyms | 15:08 |
opendevreview | Merged openstack/nova stable/2023.2: [pwmgmt]ignore missin governor when cpu_state used https://review.opendev.org/c/openstack/nova/+/903151 | 16:22 |
opendevreview | Balazs Gibizer proposed openstack/nova stable/2023.1: [pwmgmt]ignore missin governor when cpu_state used https://review.opendev.org/c/openstack/nova/+/903553 | 16:52 |
gibi | elodilles, sean-k-mooney: thanks for the review on the backport of the power management fix here is the Antelope backport ^^ | 16:53 |
gibi | still clean cherry-pick | 16:53 |
elodilles | gibi: will look into it | 17:00 |
gibi | thanks! | 17:34 |
sean-k-mooney | looks liek bobcat one already merged. that was fastere then i expected which is nice | 18:01 |
sean-k-mooney | i agree its a clean backport and the commit ectra is all correct so +2w | 18:02 |
sean-k-mooney | i rememeber correctly this shoudl be the final backport correct | 18:02 |
sean-k-mooney | the feature was added in antelope | 18:02 |
sean-k-mooney | so once that merges the issue will be closed across all affected branches | 18:03 |
opendevreview | Artom Lifshitz proposed openstack/nova master: POC: glanceclient streaming uploads https://review.opendev.org/c/openstack/nova/+/903611 | 18:32 |
sean-k-mooney | that sound like a new feature | 18:32 |
sean-k-mooney | hum just enabing an exisitng glance one. i wonder if that needs to be a config option however | 18:33 |
sean-k-mooney | i think streaming upload/download may have some depenices on how glance or the webserver/loadbalance its deployed behind are configured | 18:34 |
sean-k-mooney | it was added by https://opendev.org/openstack/glance/commit/7f761e16ce69ec549be1a66bd2797e53d0a1d988?style=unified&whitespace=show-all&show-outdated= | 18:34 |
sean-k-mooney | application/octet-stream that shoudl work | 18:36 |
sean-k-mooney | its the same content type as a normal upload | 18:37 |
opendevreview | Stephen Finucane proposed openstack/nova master: docs: Address nits in new security group doc https://review.opendev.org/c/openstack/nova/+/903590 | 19:53 |
opendevreview | Artom Lifshitz proposed openstack/nova master: POC: glanceclient streaming uploads https://review.opendev.org/c/openstack/nova/+/903611 | 19:59 |
opendevreview | Merged openstack/nova master: Use SDK for remaining ironic driver calls https://review.opendev.org/c/openstack/nova/+/867795 | 20:00 |
artom | sean-k-mooney, so chunked is apparently not the same as streaming | 20:03 |
artom | Though if I'm honest I'm not sure I understand the difference on the wire. The mechanics appear to be - pass a generator to Python requests = chunked, pass a file handler = streaming | 20:04 |
artom | Maybe I should check what Nova currently passes... I kinda assumed it just yeeted the entire image in the POST body | 20:04 |
artom | Hrmp, no mention of 'chunked' anywhere in our git log | 20:05 |
opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | 20:06 |
opendevreview | Merged openstack/nova master: docs: Revamp the security groups guide https://review.opendev.org/c/openstack/nova/+/903507 | 20:32 |
opendevreview | Merged openstack/nova master: docs: Address nits in new security group doc https://review.opendev.org/c/openstack/nova/+/903590 | 20:37 |
JayF | gibi: When you get a chance, https://review.opendev.org/c/openstack/nova/+/867797/ and the children below it are almost ready to land in that big Ironic<>Nova openstacksdk migration chain; I've been trying to usher these through the gate so a review and approval there (and on the other patches in the stack, as appropriate) would be appreciated. Thank you! | 20:46 |
opendevreview | Merged openstack/nova master: [codespell] fix typos in tests https://review.opendev.org/c/openstack/nova/+/897213 | 23:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!