Thursday, 2024-01-11

opendevreviewYalei Li proposed openstack/nova master: Implement get_power_state using domain.state  https://review.opendev.org/c/openstack/nova/+/90497001:12
opendevreviewsean mooney proposed openstack/nova master: add bin dir for non eventlet console_scripts  https://review.opendev.org/c/openstack/nova/+/90442403:24
opendevreviewsean mooney proposed openstack/nova master: remove use of eventlet.queue.LightQueue  https://review.opendev.org/c/openstack/nova/+/90068103:24
opendevreviewsean mooney proposed openstack/nova master: set rpc executor based on monkey patch state  https://review.opendev.org/c/openstack/nova/+/90528403:24
opendevreviewsean mooney proposed openstack/nova master: use futureist for scater_gather  https://review.opendev.org/c/openstack/nova/+/90528503:24
opendevreviewsean mooney proposed openstack/nova master: move context executor to utils and remove eventlet.tpool  https://review.opendev.org/c/openstack/nova/+/90528704:37
opendevreviewMerged openstack/nova master: Lower num_pcie_ports to 12 in the nova-next job  https://review.opendev.org/c/openstack/nova/+/90217505:00
sahido/ 09:02
sahidanychance that you make progress on that one? https://review.opendev.org/c/openstack/nova/+/896512 I think we are good with it, no? something else is needed?09:03
sahids/you make/we make :-)09:03
noonedeadpunkI actually have question slightly realted to this ^ 10:04
noonedeadpunkLike right now looking at AggregateMultitenancyIsolation and fail to understand a way to make an aggregate isolated for tenant. 10:04
noonedeadpunkIsolated in term - only tenants specified in aggregate can create instances in the aggregate. And not on any other computes - just this aggregate10:05
noonedeadpunkI assumed, that using placement isolation together with  AggregateMultitenancyIsolation will do that, but seems it's not...10:05
noonedeadpunkOr well, maybe I have to add all other computes to different aggregate....10:06
noonedeadpunkSo I have this: enable_isolated_aggregate_filtering = True, limit_tenants_to_placement_aggregate = True, placement_aggregate_required_for_tenants = False10:08
opendevreviewRajesh Tailor proposed openstack/nova-specs master: List requested availability zones  https://review.opendev.org/c/openstack/nova-specs/+/90436810:12
bauzassahid: unfortunately, we haven't yet accepted https://blueprints.launchpad.net/nova/+spec/aggregatemultitenancyisolation-to-support-unlimited-tenant as a specless bp10:13
bauzassean-k-mooney was having some concern when we discussed it on a team meeting10:14
bauzasfor me I'm OK but we don't have consensus10:14
noonedeadpunkSo my assumption was, that if request comes from a tenant that is not in filter_tenant_id,  AggregateMultiTenancyIsolation will filter out all hosts that belong to aggregates with filter_tenant_id defined. And if request comes from tenant with filter_tenant_id - placement will return only hosts that have this metadata 10:15
noonedeadpunkBut in fact, aggregate is not restricted for "outsiders"10:15
noonedeadpunkoh, I see now.....10:17
noonedeadpunkhttps://opendev.org/openstack/nova/src/branch/master/nova/scheduler/filters/aggregate_multitenancy_isolation.py#L4710:18
noonedeadpunksuffix is only applicable for placement isolation: https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/request_filter.py#L11510:19
noonedeadpunkSo kinda.... I can't define even 2 tenants to be working both for placement and filter?10:21
noonedeadpunkas placement is not trying to split on comas, and filter not trying to search for suffixes :(10:24
noonedeadpunkok, so I'm actually facing exact same usecase that sahid patch covers....10:26
bauzasI think we could approve sahid's blueprint today and then we could discuss on his change then with sean-k-mooney10:26
bauzassean-k-mooney: are you okay then ?10:27
noonedeadpunkugh, I for some reason thought that this flow is already working though and was counting for it ;(10:34
noonedeadpunkI still have a feeling I'm missing smth in tenant isolation topic though...11:46
noonedeadpunkoh, maybe I can have both pre and post enabled indeed, huh11:48
noonedeadpunkIn terms - define list of tenants for post filter in `filter_tenant_id` through comma, and then have `filter_tenant_id_suffix` for pre-filter. While `filter_tenant_id` will be invalid for pre-filter, rest should work...12:02
noonedeadpunkSlightly nasty, but looks like working at scratch...12:02
noonedeadpunk*at a glance12:02
ratailorbauzas, noonedeadpunk could you please review https://review.opendev.org/c/openstack/nova-specs/+/904368 spec, I have updated it as per yesterday's discussion.12:07
ratailorsean-k-mooney, gibi_off please review ^^12:08
dvo-plvsean-k-mooney, Thank you. I will try to finc some examples13:53
bauzassean-k-mooney: gibi_off: we missed to ask auniyal to provide a blueprint for https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/enforce-remote-console-session-timeout.html14:19
bauzasI'll be creating the blueprint14:19
sean-k-mooneyack14:31
opendevreviewTakashi Kajinami proposed openstack/nova master: Fix test failures with oslo.limit 2.3.0  https://review.opendev.org/c/openstack/nova/+/90531415:16
opendevreviewDan Smith proposed openstack/nova master: Support glance's new location API  https://review.opendev.org/c/openstack/nova/+/89103615:29
opendevreviewDan Smith proposed openstack/nova master: DNM: Test glance new location api  https://review.opendev.org/c/openstack/nova/+/89120715:29
opendevreviewDan Smith proposed openstack/nova master: WIP: Catch ImageNotFound on snapshot failure  https://review.opendev.org/c/openstack/nova/+/90531615:29
opendevreviewSylvain Bauza proposed openstack/nova-specs master: add the blueprint link to the spec  https://review.opendev.org/c/openstack/nova-specs/+/90534216:10
bauzassean-k-mooney: could you quickly +2 this ^16:11
bauzasnoonedeadpunk: fwiw looks like we gonna miss https://review.opendev.org/c/openstack/nova-specs/+/890779 for Caracal due to the spec approval freeze16:13
opendevreviewTakashi Kajinami proposed openstack/nova master: Fix test failures with oslo.limit 2.3.0  https://review.opendev.org/c/openstack/nova/+/90531416:14
bauzasnoonedeadpunk: so that's cool you abandoned your spec proposal but fwiw I don't see any new revision for the other spec since 6 months :(16:15
sean-k-mooneybauzas: done16:16
bauzassean-k-mooney: cool thanks16:17
bauzasfwiw, I have some concerns when some good contributor abandons some change due to some other existing but the other is not revised from 6 months :(16:18
noonedeadpunkbauzas: yeah, that's clear at this point :(16:18
noonedeadpunkBut realizing complexity more I'm not that self-confident anyway to pick implementation alone16:19
noonedeadpunkAs that sounds slightly like leveraging taskflow16:20
pmarsaisHi nova community, I am looking at enabling TPM for my instances in my openstack cluster. Looking at nova source code, it seems that the shelving/unshelving workflow designed in https://specs.openstack.org/openstack/nova-specs/specs/victoria/implemented/add-emulated-virtual-tpm.html#shelve-offload-and-unshelve is currently not implemented (no references to "tpm_object_id" and "tpm_object_sha256"). Is that correct or am I mi16:40
pmarsaisIf so, are there plan to get this in, or should I try to take a stab at implementing it ? (I already started the CCLA process internally with my employer)16:40
auniyalhi sean-k-mooney, can you please have another look on this - https://review.opendev.org/c/openstack/nova/+/905134  [Refactor vf profile for PCI device17:24
auniyal]17:24
sean-k-mooneypmarsais: no there is no plan to proceed with storing the tpm data in swrift for shelve/unshleve17:28
sean-k-mooneyif we wanted to od that we woudl have to repropose it as a feature via a new spec.17:29
sean-k-mooneyit was not implmented because we felt it was overly complext and we were not sure we wanted to require swift to be present to use it17:30
sean-k-mooneytoday is the spec freeeze deadline for calacal os this woudl be a topic of next cycle (starting in march)17:31
pmarsaisOk, thanks for the context !17:35
sean-k-mooneymelwitt: im going to set up a devstack vm to test your disk encyprtion series so i can start reviewing it next week17:43
sean-k-mooneymelwitt:do you have a local.conf you can share17:43
sean-k-mooneyi belive i need barbican correct17:47
melwittsean-k-mooney: oh, yep. sec17:48
melwittsean-k-mooney: I set up jobs to test myself, you can use as reference as well https://review.opendev.org/c/openstack/nova/+/86241617:49
sean-k-mooneyim currenly installing ubuntu so no rush17:49
sean-k-mooneyah perfect17:49
melwittobvs everything you need will be in there17:49
sean-k-mooneyyep i can figure it out form there17:50
melwittok great17:50
sean-k-mooneynow that i think about it i should proably clone this vm so i cna also test with rbd17:50
sean-k-mooneyill start with qcow17:50
melwittsean-k-mooney: something to know is that it's a good idea to include swap or ephemeral or both in flavors you test with bc the code takes a slightly different path for creating swap or ephemeral disks. so including swap and/or ephemeral you will cover those paths as well17:57
sean-k-mooneycool i can add both17:57
sean-k-mooneyhave you tested with ephpemeral with multiple ephermeral disks17:57
opendevreviewDan Smith proposed openstack/nova master: Catch ImageNotFound on snapshot failure  https://review.opendev.org/c/openstack/nova/+/90531617:58
opendevreviewDan Smith proposed openstack/nova master: Support glance's new location API  https://review.opendev.org/c/openstack/nova/+/89103617:58
opendevreviewDan Smith proposed openstack/nova master: DNM: Test glance new location api  https://review.opendev.org/c/openstack/nova/+/89120717:58
sean-k-mooneyi.e. "openstack server create --ephemeral 10  --ephemeral 20 ..." with a flavor with 30 G of ephemeral17:58
sean-k-mooneyill create an etherpad whith what i tested with when i get to that point17:59
melwittsean-k-mooney: I think I did but it's been awhile. that's a good thing to test. i'm thinking to write tempest tests for cases like that17:59
sean-k-mooneyya we shoudl perhaps as follow ups but it woudl be good to cover that 18:00
melwittyeah. I'm working on the docs now and keeping a list of a few cases that are not currently covered in tempest presently, to write tests for those gaps.  I'm thinking maybe we could run the encryption jobs (once cleaned up from DNM) at least as periodic jobs or something18:02
sean-k-mooneyother then the fact it needs barbican18:03
sean-k-mooneyis there any reason not to perhaps include this in one of our other jobs18:03
sean-k-mooneyim fine wiht a perodic job too18:03
melwittencryption is pretty noticeably slow. so I'm not sure if it'll fly but we can try18:03
sean-k-mooneybut would integrating it in the nova-live-migration jobs be an issue18:04
melwittI'm thinking ahead to if it ends up being too slow, I would at least want periodics18:04
sean-k-mooneyyep18:04
sean-k-mooneyso what im thinkin is18:05
sean-k-mooneythe perodics can do a broader range fo testing18:05
sean-k-mooneybut nova-live-migration and nova-live-migration-ceph could perhaps also do some basic testing for us18:05
sean-k-mooneyas those are pretty small jobs18:05
sean-k-mooneythey just run       tempest_test_regex: (^tempest\.api\.compute\.admin\.(test_live_migration|test_migration))18:06
melwittinitially I was running those jobs with flavor with 1G disk, 1G ephemeral and 512MB swap and I got quite a bit of timed out jobs for raw and rbd18:06
melwittso I removed the ephemeral disk and left swap, that runs at normal durations18:07
sean-k-mooneyok well we loop back to this then and start with just perodics and experimental18:07
melwittyeah I think that approach makes sense18:07
melwittit might be fine, just saying we  might need to tweak things if it's too slow18:08
sean-k-mooneyyep18:09
sean-k-mooneythats why i was looking for jobs that currently run few tests18:09
sean-k-mooneymelwitt: i need to read the spec again18:10
sean-k-mooneybut if i recall you request encyption via a flavor/image property right18:10
sean-k-mooneyso if we had barbican in a job we could add a single test that boots a vm with a flavor that uses it 18:10
sean-k-mooneyinstead of confiugring the jobs to use that falvor for evertything18:11
melwittsean-k-mooney: another thing to know is that for rbd I had to do a standard snapshot (not direct/clone snapshot) because the current stable release of ceph (quincy) does not support clone with a child having a different passphrase as the parent18:11
melwitt*than the parent18:11
melwittsean-k-mooney: right. flavor you use hw:ephemeral_encryption = true  and image hw_ephemeral_encryption = true18:12
sean-k-mooneyso vtpm need barbican to be tested too18:15
melwittyes18:15
sean-k-mooneyso it might be good to add barbican to one of our jobs and do a simpel boot test and also test vtpm in the future18:15
sean-k-mooneywe have some whitebox tests to verify vtpm18:15
sean-k-mooneymelwitt: why are you using a cutom ploicy file for barbican18:31
sean-k-mooneyhum i see18:31
sean-k-mooneyyou are giving admin extra premisison18:31
sean-k-mooneywe likley shoudl fix that18:32
sean-k-mooneyeither by skiping those tests 18:32
sean-k-mooneyor by ensuring they are not useing the admin user18:32
melwittsean-k-mooney: there's at least one tempest test that involves admin doing something on behalf of a user, and by default, admin don't have permission to user's barbican secrets18:32
melwittyeah. I'm not sure if that's really what we want but I was just looking to see if I could pass all of tempest as-is18:32
melwittack18:32
sean-k-mooneyright so i would not expect an admin to be able to start a vm with disk encyption18:33
sean-k-mooneyif they tweak the policy they could18:33
sean-k-mooneybut  i dont think we ned to test that18:33
melwittok, that makes it easy then18:33
sean-k-mooneyim going to skip that locally for now18:33
melwittsure18:33
sean-k-mooneywe could docuemnt this i just dont know if we want to test it as i would generally think its best to test with default policy18:34
melwittI think that would be fine. I agree it's best to test with default policy18:35
sean-k-mooneyill be around for about another hour18:35
sean-k-mooneyim going to kick off https://termbin.com/k0sv18:35
sean-k-mooneyand then ill proably start playing with it tomorrow or  monday18:36
melwittthe admin test is good to verify that it is _possible_ to let admin do stuff if someone wanted that18:36
melwittbut that's all it's for18:36
melwittok cool18:37
sean-k-mooneyi need to do some prep on the vm fist like install git and clone devstack18:37
sean-k-mooneybut that wont thake that long18:37
wncsllnhi o/, anyone can help me to enable boot with uefi mode, please?18:47
sean-k-mooneyyou just need to set hw_firmware_type=uefi in the glance iamge properties i belive18:48
sean-k-mooneyoh an hw_machine_type=q3518:48
wncsllnjust set this two properties?18:48
sean-k-mooneyassuming you have the correct ovmf firmware installed on all your compute nodes18:48
wncsllnhmmm i dont think i have 18:49
sean-k-mooneyyep if you have install the ovmf package on all your compute nodes then qemu will have access to the uefi firmeware18:49
sean-k-mooneyhttps://docs.openstack.org/nova/yoga/admin/uefi.html18:49
sean-k-mooneyhw_machine_type=q35 is semi optional18:51
sean-k-mooneyqemu considers uefi with the the pc machine type to be experimantal and not recommended18:51
sean-k-mooneymost distos dont ship a ovmf fireware that properly supprots it18:52
wncsllni have deployed with kolla-ansible so nova agents are containers. this is a problem? 18:52
sean-k-mooneyso q35 should be used18:52
sean-k-mooneyno i have kolla-ansible at home18:52
sean-k-mooneyi am pretty sure there contienres have to correct pakcages already18:52
sean-k-mooneyso you just need ot set those tow imagea proepries in glance on the image and it should work18:52
sean-k-mooneyassuming the glance iamge supprot uefi18:53
sean-k-mooneythe image need to have a gpt partion table and an efi partion 18:53
sean-k-mooneysame as real hardware18:53
wncsllni setted the properties but the vm wont boot. could be a problem in the image19:02
sean-k-mooneyi would try somethign like the latest ubuntu cloud image19:02
sean-k-mooneyi think that support uefi boot but its been a while since i tried it19:03
wncsllnthere is a way to know if the image have a gpt and efi partion? 19:03
sean-k-mooneyyou can download it and inspect it in a vm or with tools like libguestfs19:03
wncsllnok, i'll make some tests here19:05
wncsllnsean-k-mooney: thanks for the help19:05
wncsllnsean-k-mooney: i found the problem xD probably the image that im using has no uefi/gpt. i downloaded the ubuntu cloud image with support to uefi and worked fine19:38
sean-k-mooneycool19:44
sean-k-mooneyya that make sense a lot of older images wont19:44
sean-k-mooneyand if you created it form an iso inn a vm you need to make sure that initall vm is also set up for uefi19:45
sean-k-mooneysame for windows as the installers have diffent default based on how the vm was booted19:45
wncsllnthe image with problem is a snapshot from a vm annndddd probably the old image does not have uefi19:46
opendevreviewMerged openstack/nova-specs master: List requested availability zones  https://review.opendev.org/c/openstack/nova-specs/+/90436819:50
sean-k-mooneymelwitt: https://paste.opendev.org/show/biqXsY6SO6ePMPosdwIW/19:54
melwittsean-k-mooney: that's good right? haha20:00
sean-k-mooneyyep https://termbin.com/9tk320:00
sean-k-mooneywell sort of20:01
sean-k-mooneyi copied that config form your raw job20:01
sean-k-mooneyso its is using disk encyption20:01
sean-k-mooneyand i can log into the vm via the console20:01
sean-k-mooneyso it booted fine20:02
sean-k-mooneyhowever its still booting form a qcow with a raw backing file20:02
sean-k-mooneyso its not actully checking raw images properly20:02
sean-k-mooneybut ya it looks like everything is working correctly other then that. and i booted with both swap and ephmeral20:02
sean-k-mooneyim going to leave it there for tonight just wanted to let you knwo i ahve successfuly deployed our code and booted a vm with it20:03
melwittsean-k-mooney: you have set both use_cow_images = False and images_type = raw? bc if you don't set both it won't do raw20:03
sean-k-mooneyimages_type=raw or flat20:04
melwittok, thanks :)20:04
sean-k-mooneyactully im goign to check something20:05
melwittok. at least for me if use_cow_images is not set to False, it will do qcow2 instead of raw despite images_type = raw or flat20:06
sean-k-mooneyi started with your raw job 20:06
sean-k-mooneybut i might not have kept that in the local.conf when i finished editing it20:06
sean-k-mooneyok ya20:07
sean-k-mooneyi removed that in my editing20:07
melwittok. that's the only way I know of that what you're seeing could be happening. if you do have use_cow_images = False then something else is wrong that I haven't seen yet20:07
sean-k-mooneyso everything is working as expecte its using qcow for the vms because that is the default20:07
sean-k-mooneyno in my local.conf i don thave those set so we are getting the default 20:07
melwittok I see20:08
sean-k-mooneyso cool i wont have time to do much with this tomorrow but ill play around with it on monday and start reivewing the series20:09
sean-k-mooneyhave you done any multi node testing.20:09
sean-k-mooneyi.e. cold/live migration20:09
sean-k-mooneythe current zuul jobs seam to be single node20:10
sean-k-mooneyon a related note i ported your scater gather patch on to my serise and i got a pretty clean zuul run https://review.opendev.org/c/openstack/nova/+/90528520:11
sean-k-mooneythe main delta between what i have doen is how we monkeypatch20:12
melwittsean-k-mooney: hm looks like no. I did resize in place. I'll add a multinode job on that patch 20:12
sean-k-mooneyok cool ill add a second node and play with that locally too next week20:13
melwittsean-k-mooney: ok cool. I dunno if you saw I wrote up a comment on the scatter gather patch about how I am seeing requests getting "stuck" on nova-api, like it receives the request and does all the stuff but does not respond. I have seen this in other failures that are not related with my patch too but with the patch it seems to happen much more often20:14
sean-k-mooneyya i did20:14
melwittoh ok20:15
sean-k-mooneyi wanted to see if i saw the same behvior 20:15
sean-k-mooneyi was wondering if htat coudl be related to how/when monkey patching was done 20:15
melwittok yeah20:15
sean-k-mooneybut there is also this comment on my patch https://review.opendev.org/c/openstack/nova/+/905285/1/nova/compute/multi_cell_list.py20:15
sean-k-mooneythat might be related too20:16
sean-k-mooneythe timeout might need to be done in the try?20:16
sean-k-mooneyor rather the creation or the timer20:16
melwittthat's good. really want to find what/why that's happening20:16
melwittyeah I was thinking about that too20:16
sean-k-mooneyim not familar enough with timers in python to say one way or another but i dont think it would hurt to include it in the try block20:17
sean-k-mooneymelwitt: another data point on the previosu patch that uses the standar lib queue https://review.opendev.org/c/openstack/nova/+/900681/8?tab=change-view-tab-header-zuul-results-summary i got a bunch of timeourts20:18
sean-k-mooneybut i have not had time to look at way20:18
sean-k-mooney*why20:18
melwittyeah, agree. it would be safer to move it into the try, I was going to do that anyway. I think I followed this example initially https://eventlet.net/doc/modules/timeout.html#eventlet.timeout.Timeout20:18
melwittwhoa that is a lot of timeouts indeed20:19
melwittsean-k-mooney: I wasn't sure how to interpret this when I looked at it too, does this mean the eventlet queue does something special to work with greenlets? "The eventlet.queue module implements multi-producer, multi-consumer queues that work across greenlets, with the API similar to the classes found in the standard Queue and multiprocessing modules." https://eventlet.net/doc/modules/queue.html20:21
melwittif so, that could be why20:22
sean-k-mooneyya so you have done the queue chagne in the same patch that swap to futureist20:22
sean-k-mooneyi have them split out20:22
melwittright, I know :)20:22
sean-k-mooneyso it could be related20:23
melwittI'm saying if eventlet.queue is "special" and you're not using it, maybe queue won't work right. oh, but eventlet should be patching queue right? hm20:23
sean-k-mooneyya i was assuming eventlet was patching it20:23
melwittif it's patching it I dunno why it wouldn't work 🤔 20:23
melwittyeah20:23
sean-k-mooneyok i need to get dinner and feed frya. she is getting barky 20:24
sean-k-mooneycaht to you tomrorow20:24
JayFsome eventlet queue usages have known bugs20:24
melwitthaha k, talk to you tomorrow20:24
JayFLet me read scrollback and see if you are in those categories, if so I can likely find the bugs20:24
JayFitamarst has been digging them up left and right as part of the "fix eventlet" work20:24
JayFHe leaves me frightening issue links in my slack every now and then :D 20:25
melwittJayF: it's the opposite, what we were chatting about. sean did an in-place swap from eventlet.queue to standard lib queue and got a lot of timed out jobs. which might not be related to the switch https://review.opendev.org/c/openstack/nova/+/900681/8?tab=change-view-tab-header-zuul-results-summary20:26
JayFYeah this tracks20:26
JayFbecause I think there's an RLock used by stdlib queue20:26
JayFwhich is still getting monkey patched in this case20:27
JayFlet me dig20:27
JayFso my hypothesis is this:20:27
melwittearlier runs looked fine and I dunno if I see any difference in the code so I'm not sure20:27
JayFby using a stdlib queue, you're exposing yourself to using threading.Nlock (N can be multiple things). Some of these, particularly Rlock, is bugged in inconsistent ways (I am still looking for the github issue)20:28
melwittI didn't look in detail yet20:28
melwitthm ok20:31
sean-k-mooneyhum ok not back for long  what i might do instead is  this20:32
sean-k-mooneyadd a inderiction where we import a diffent queue based on if we are patched or not and cenntralise that in the utils module20:32
sean-k-mooneyso that we can drop the selection of which to use in one place if we wever fully remove eventlet20:33
melwittack20:34
sean-k-mooneythat way if the code in question is not monkypatche it will use the std lib one and where it is it will use the eventlet one20:34
JayFsean-k-mooney: is "monkeypatched" a boolean for you? You're not playing games with monkeypatching on/off for different modules, are you?20:34
sean-k-mooneyits gloabl20:35
JayFsean-k-mooney: that I think is going to be an attractive pattern that may lead to more pain than it's worth, based on my understanding many of the eventlet bugs in python3.11/3.12 which are just ... unfixable by design are mostly at the edges of stdlib interacting with monkey patched bits of code20:35
JayFOK good, hopefully that means you'll avoid the sharpest edges20:35
sean-k-mooneyso in my case it depens on what direcotry the console cript is defiend in20:35
sean-k-mooneyif its under nova.cmd its monky patched20:35
sean-k-mooneyif its under nova.bin its not20:35
JayFbut there's never a case, as conjectured above, where say, queue would be std lib but threading would be eventlet?20:36
sean-k-mooneynot unless i screwed up20:36
sean-k-mooneyso the nova api in my serise can be patch or unpatched20:36
sean-k-mooneyif run via the wsgi script its unpatched20:36
sean-k-mooneyif run via nova.cmd.nova-api it is20:37
JayFokay cool, in that case my hypothesis is invalid and unlikely to be happening20:37
JayFand I'd suggest potentially even enforcing that if possible20:37
sean-k-mooneybut within any binary its one of the otehr20:37
JayFDo you mind a quick topic change?20:38
sean-k-mooneysure but i need to leave in a few20:38
sean-k-mooneywhats on your mind20:38
JayFJust curious for ironic-guest-metadata, would you mind doing the piece of that work of splitting out the libvirt code to the common compute driver?20:38
JayFI'd prefer not operate in a portion of the nova codebase outside of the ironic driver codepath, just based on familiarity20:38
JayFbut I can if you are too busy helping save the world from eventlet (a project which I too am invested in)20:39
sean-k-mooneyhum i might be able to ill have to see if i have time but should nbot be terrible complex20:39
sean-k-mooneyask me again next week and ill see if i can help20:39
sean-k-mooneyi need to make some progress on the healtcheck stuff but im hoping to spend most of the next 4-5 weeks until codefreeze mainaly on upstream nova stuff20:40
sean-k-mooneyJayF: the eventlet stuff is just somethign im looking at in my personal time20:41
sean-k-mooneyso im not goign to be spending that much time looking at it untill we have some more detailed disucssions in the next ptg20:41
sean-k-mooneyi know others have concerse over if moving to asyncio or realtreading is really the right move20:42
JayFHonestly, I joke sometimes that I'm a sysadmin who pretends to be a developer, but what that means in reality is for stuff like "should we use asyncio or $other?" type discussions, I tend to let folks with stronger opinions and foundational knowledge battle it out :) 20:48
JayFmy concern is that we use something well maintained, with reasonable patterns that anyone who works on openstack for the next decade will be able to follow20:48
JayFso like, I have zero opinions about how we move; I have lots of opinions that moving is important, and doing it well is important (and as I've mentioned elsewhere, I've gotten a part time developer assigned to OpenStack upstream at GR-OSS, he is onboarding now and will be pointed at eventlet migrations for underresourced openstack projects once we have a migration path set)20:49
opendevreviewmelanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd  https://review.opendev.org/c/openstack/nova/+/86241622:22
opendevreviewmelanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd  https://review.opendev.org/c/openstack/nova/+/86241623:04

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!