| opendevreview | Nobuhiro MIKI proposed openstack/nova master: libvirt: Support maxphysaddr. https://review.opendev.org/c/openstack/nova/+/907516 | 05:17 |
|---|---|---|
| mohsen | https://www.irccloud.com/pastebin/277NPQbS/ | 06:10 |
| mohsen | Hello dear friends. I wanted to report a misconfiguration in the official documentation of OpenStack nova. I put the link at the end of this message. | 06:15 |
| mohsen | In the [service_user] section, they should place the port number of keystone which is 5000 but it has been mistakenly omitted and caused a lot of trouble and error during the installation procedure of the nova on both controller and compute node. | 06:15 |
| mohsen | https://docs.openstack.org/nova/2023.2/install/controller-install-ubuntu.html | 06:15 |
| mohsen | https://docs.openstack.org/nova/2023.2/install/compute-install-ubuntu.html | 06:15 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | 06:31 |
| bauzas | sean-k-mooney: can you please swing https://review.opendev.org/c/openstack/nova/+/907516 again , | 10:59 |
| bauzas | ? | 10:59 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | 11:05 |
| sean-k-mooney | bauzas: sure | 11:06 |
| sean-k-mooney | i saw it come in but wanted to wait for you to see if your happy | 11:06 |
| sean-k-mooney | bauzas: based on the delta form v3 it looks ok to me | 11:08 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | 11:10 |
| auniyal | hi bauzas, regarding comment "LOG.info(_("foo %s", something))" on sonsole patch - on using "_(" pre-commit says - N319 Don't translate logs | 12:33 |
| auniyal | and with fstring in logs we get like this https://paste.opendev.org/show/bM1D6nY1sxuHibnpHEax/ | 12:34 |
| sean-k-mooney | auniyal: yes just remove _( ) | 12:57 |
| sean-k-mooney | LOG.info("foo %s", something) | 12:57 |
| auniyal | ack | 12:58 |
| auniyal | sean-k-mooney, regarding other 2 comments ? | 12:58 |
| sean-k-mooney | i do not have the review open, link? | 12:59 |
| auniyal | https://review.opendev.org/c/openstack/nova/+/901824 | 12:59 |
| sean-k-mooney | so the fstrings are rendered before being passed to the log fuction | 13:00 |
| sean-k-mooney | so the log function get the rendered string | 13:00 |
| auniyal | as suggested above will go with this for logging? - LOG.info("foo %s", something) | 13:02 |
| sean-k-mooney | bauzas: im still +2 on https://review.opendev.org/c/openstack/nova/+/901824 i replied to yoru comments but we dont striclty need to change anything IMO | 13:06 |
| sean-k-mooney | im ok with fixing the nits too | 13:07 |
| auniyal | sean-k-mooney, I think bauzas is away for now, I have updated the cahgnes, running quick tests locally will respin once done | 13:15 |
| opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | 13:24 |
| bauzas | auniyal: I'll lookup | 13:34 |
| bauzas | auniyal: and sorry about the translations, I forgot that now only the exceptions should be translated | 13:35 |
| bauzas | (before, the logs with levels >= info were needed to be translating) | 13:35 |
| elodilles | bauzas: sorry for pinging, could you please double check this release patch? https://review.opendev.org/c/openstack/releases/+/909402 | 13:39 |
| bauzas | elodilles: done :) | 13:40 |
| bauzas | thanks for pinging me :) | 13:40 |
| elodilles | thanks too o/ | 13:40 |
| bauzas | (I have a lot of Gerrit emails :) | 13:40 |
| sean-k-mooney | elodilles: minor issue in commit message | 13:41 |
| sean-k-mooney | prior to the lib freeze for 2024.1 Bobcat going into effect | 13:41 |
| sean-k-mooney | elodilles: the patch is correct in general | 13:43 |
| elodilles | sean-k-mooney: oh, nice :/ all the generated patches were merged with that wrong release name :/ | 13:45 |
| elodilles | sean-k-mooney: thanks for checking | 13:45 |
| sean-k-mooney | well we dont need to break the patteren then | 13:45 |
| bauzas | sean-k-mooney: +2d https://review.opendev.org/c/openstack/nova/+/901824 | 13:45 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/901824/19..20/nova/objects/console_auth_token.py ... | 13:46 |
| sean-k-mooney | fine it does not matter but we dont need to check and provide None | 13:46 |
| * bauzas now starting to review again the ephemeral encryption series | 13:47 | |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | 14:36 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | 14:37 |
| dansmith | bauzas: quick question on https://review.opendev.org/c/openstack/nova/+/904258 | 14:47 |
| bauzas | dansmith: shoot | 15:03 |
| bauzas | dansmith: OK, I'll provide another revision for ^ | 15:06 |
| bauzas | dansmith: about https://review.opendev.org/c/openstack/nova/+/909598/1/nova/virt/libvirt/driver.py#12756 | 15:16 |
| bauzas | do you have time for discussing it ? | 15:16 |
| dansmith | bauzas: yep | 15:30 |
| bauzas | dansmith: just replied | 15:32 |
| dansmith | bauzas: sorry was on a call | 15:32 |
| bauzas | np at all (and yeah actually I remember your call :p ) | 15:32 |
| dansmith | bauzas: quick gmeet? | 15:32 |
| bauzas | if you want | 15:32 |
| bauzas | we have upstream meeting in 28 mins | 15:32 |
| dansmith | meet.google.com/mkb-cxhg-qkh | 15:32 |
| dansmith | we'll be quick | 15:33 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Feb 27 16:00:41 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:00 |
| bauzas | hey folks | 16:00 |
| bauzas | let's have a quick meetingb | 16:00 |
| elodilles | o/ | 16:01 |
| fwiesel | o/ | 16:01 |
| kgube | o/ | 16:01 |
| bauzas | okay, moving on | 16:02 |
| bauzas | #topic Bugs (stuck/critical) | 16:02 |
| dansmith | o/ | 16:02 |
| bauzas | #info One Critical bug | 16:02 |
| bauzas | #link https://bugs.launchpad.net/nova/+bug/2052937 | 16:02 |
| bauzas | sean-k-mooney: do you want to discuss it now? | 16:02 |
| auniyal | o/ | 16:04 |
| bauzas | looks he's not around | 16:04 |
| bauzas | I wonder what we need to do related to thaty | 16:05 |
| gibi | o/ | 16:05 |
| sean-k-mooney | o/ | 16:06 |
| sean-k-mooney | sorry was double booked | 16:06 |
| sean-k-mooney | am im not sure what there is to say really for that bug | 16:06 |
| sean-k-mooney | im a littel concerned | 16:06 |
| sean-k-mooney | that our heal allocation code might actully be broken by it | 16:07 |
| sean-k-mooney | on the otehr hand with a quick look at the code | 16:07 |
| bauzas | why is it in Critical state for nova ? | 16:07 |
| sean-k-mooney | it was a gate blocker | 16:07 |
| sean-k-mooney | that is what broke nova-next last week | 16:07 |
| sean-k-mooney | when i looked at the nova manage code i belive its using a neutron client with both a service token and admin token | 16:08 |
| sean-k-mooney | so it should be fine | 16:08 |
| sean-k-mooney | but when i we removing the check in post it looks like heal allcoations was not properly healing the port resouce resuets | 16:08 |
| bauzas | can we then move it to High ? | 16:09 |
| sean-k-mooney | sure | 16:09 |
| bauzas | ack | 16:09 |
| bauzas | if you want, we can continue to discuss the bug next week | 16:09 |
| sean-k-mooney | we should likely at least spotcheck that heal allcotions works | 16:10 |
| sean-k-mooney | otherwize we might need to fix it in the RC period | 16:10 |
| bauzas | ack | 16:11 |
| sean-k-mooney | https://zuul.opendev.org/t/openstack/build/3c2c7955a4b34112a377a857623d6a73/log/job-output.txt#37642-37669 | 16:11 |
| sean-k-mooney | the heal there looks like its broken | 16:12 |
| sean-k-mooney | lets move on for now | 16:13 |
| bauzas | cool | 16:13 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 70 new untriaged bugs (+4 since the last meeting) | 16:13 |
| * bauzas hides but I'll do something | 16:13 | |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:13 |
| bauzas | #info bug baton is bauzas | 16:14 |
| bauzas | moving on ? | 16:14 |
| bauzas | #topic Gate status | 16:14 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:15 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:15 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:15 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:15 |
| bauzas | nothing here to report | 16:15 |
| bauzas | anyone else ? | 16:15 |
| dansmith | just rechecked a random timeout | 16:15 |
| bauzas | cool | 16:16 |
| bauzas | #topic Release Planning | 16:16 |
| sean-k-mooney | was it the rbac jobs | 16:16 |
| bauzas | #link https://releases.openstack.org/caracal/schedule.html#nova | 16:16 |
| sean-k-mooney | they seam to be timing out more often then others | 16:17 |
| sean-k-mooney | but it alwasy just seams like a slow node when i looked | 16:17 |
| gibi | ddd | 16:20 |
| bauzas | last but not * least (private joke) | 16:20 |
| gibi | sorry | 16:20 |
| bauzas | #info Caracal-3 (and feature freeze) milestone in 2 days | 16:20 |
| bauzas | voila | 16:20 |
| * bauzas doing atm a lot of reviews | 16:20 | |
| bauzas | #topic Review priorities | 16:21 |
| bauzas | #link https://etherpad.opendev.org/p/nova-caracal-status | 16:21 |
| bauzas | #link https://etherpad.opendev.org/p/nova-caracal-status | 16:21 |
| bauzas | #topic Stable Branches | 16:21 |
| bauzas | elodilles: ? | 16:21 |
| elodilles | o/ | 16:21 |
| elodilles | #info stable gates seem to be OK | 16:21 |
| elodilles | surprisingly, might be even zed is OK | 16:21 |
| elodilles | as nova-grenade-multinode is just passing :-o | 16:22 |
| elodilles | i don't know how | 16:22 |
| elodilles | so maybe it's just a bug :D | 16:22 |
| elodilles | it should be using unmaintained/yoga | 16:22 |
| bauzas | ... | 16:23 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:23 |
| elodilles | please add here any issue if you see one on stable branches ^^^ | 16:24 |
| elodilles | that's all from me for now | 16:24 |
| bauzas | thanks | 16:25 |
| bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:25 |
| bauzas | fwiesel: ? | 16:25 |
| fwiesel | #info FIPS do work now, but not reliably (Pass 459 Failure 23 Skip 44) (previously Passed: 435, Failed: 41, Skipped: 42) | 16:26 |
| fwiesel | #link http://openstack-ci-logs.global.cloud.sap/openstack/nova/1858cf18b940b3636e54eb5aafaf4050bdd02939/tempest.html | 16:26 |
| fwiesel | Better, but not quite there yet. | 16:27 |
| bauzas | kudos | 16:27 |
| fwiesel | Serveral of the failures have simpler reasons. I'll probably get those down first before I dig into the FIP issue. | 16:27 |
| fwiesel | Questions? | 16:28 |
| bauzas | none from me, good luck for debugging | 16:28 |
| fwiesel | Okay, then that's from my side. Back to you. | 16:28 |
| bauzas | thanks | 16:29 |
| bauzas | #topic Open discussion | 16:29 |
| bauzas | anything anyone ? | 16:29 |
| kgube | Hi, I wanted to ask a question on how to proceed with my feature: https://review.opendev.org/c/openstack/nova/+/873560 | 16:30 |
| kgube | It has a cinderclient dependency, so we need to bump the cinderclient version | 16:30 |
| bauzas | good question | 16:31 |
| kgube | the problem is that the needed change will only be in the comming cinderclient release | 16:31 |
| kgube | wich happens together with the featurefreeze | 16:31 |
| bauzas | kgube: have you seen my question about a Tempest test checking your patch ? | 16:31 |
| bauzas | I wonder how Zuul can say +1 if nothing is changed | 16:32 |
| kgube | bauzas, yes, none of the current tempest jobs are using the codepath that calls the new volume action | 16:32 |
| kgube | so it just works with the previous version | 16:33 |
| bauzas | kgube: do you have a follow-up patch for Tempest about it ? | 16:33 |
| bauzas | like another attribute | 16:33 |
| kgube | so the only job that will be testing the new volume action is the devstack-plugin-nfs one | 16:34 |
| kgube | I have a patch for this, but it also needs changing once the feature is merged | 16:35 |
| kgube | https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/896196 | 16:35 |
| kgube | so it's currently marked as WIP | 16:35 |
| bauzas | okay, then we need to have a consensus for accepting your feature without Tempest scenarios | 16:36 |
| bauzas | what people think about ^ ? | 16:37 |
| bauzas | as kgube said, we only know it doesn't trample the other usages | 16:37 |
| kgube | well, the second change I posted has successful tempest runs for nfs online extend, with all of the changes merged in | 16:39 |
| kgube | it just isn't part of the nova tempest jobs | 16:39 |
| bauzas | kgube: I'll ping other cores async | 16:40 |
| bauzas | to see what they think | 16:40 |
| kgube | thank you! | 16:41 |
| bauzas | any other things before we close ? | 16:41 |
| bauzas | looks not | 16:42 |
| bauzas | thanks all | 16:42 |
| bauzas | #endmeeting | 16:42 |
| opendevmeet | Meeting ended Tue Feb 27 16:42:38 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:42 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-02-27-16.00.html | 16:42 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-02-27-16.00.txt | 16:42 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-02-27-16.00.log.html | 16:42 |
| sean-k-mooney | bauzas: the tempest test is not the issue we cant merge the patch without the client bump | 16:47 |
| sean-k-mooney | so we should ask for an early cinder clinent release | 16:48 |
| sean-k-mooney | and if they need to do another one they can | 16:48 |
| sean-k-mooney | at ff | 16:48 |
| sean-k-mooney | the release process is fully automated out sied of the patch review so that should be quick and simple to do | 16:48 |
| bauzas | well, the depends-on is a cinderclient patch | 16:48 |
| sean-k-mooney | right but the nova patch need a min version bump | 16:49 |
| bauzas | once the patch is merged, then Zuul can accept | 16:49 |
| sean-k-mooney | no because our unit/fucntional test will fail | 16:49 |
| bauzas | sean-k-mooney: correct, we should target the required need | 16:49 |
| sean-k-mooney | well it depend on that the client change is doing | 16:50 |
| sean-k-mooney | depends on is not used for the tox changes | 16:50 |
| sean-k-mooney | so those will fial if we are usign a new api form it but we are probaly mocking it | 16:50 |
| sean-k-mooney | so maybe they wont fial | 16:50 |
| *** dasm is now known as Guest1195 | 16:51 | |
| bauzas | sean-k-mooney: my point is that nothing blocks the nova change to be merged | 16:51 |
| bauzas | because I guess it's only additive opt-in changes | 16:51 |
| bauzas | paperwork-ish, we should ask for an reqs.txt update | 16:53 |
| bauzas | anyway, I need to leave now b/c of a physical local meetup in Grenoble | 16:53 |
| sean-k-mooney | bauzas: my point is it really shoudl be blocked | 16:56 |
| sean-k-mooney | bauzas: that not how we handel depencies | 16:56 |
| sean-k-mooney | the path that need the new feature does the requirements bump | 16:57 |
| bauzas | sean-k-mooney: please then add a comment in the nova patch | 16:57 |
| sean-k-mooney | i did thats why i -1 it | 17:31 |
| sean-k-mooney | bauzas: on the good news front https://zuul.opendev.org/t/openstack/build/2a3f86e4974b4a4a9e875477c77f81e0/logs | 17:32 |
| sean-k-mooney | bauzas: that fialed one test that shoudl not work in that job config | 17:32 |
| sean-k-mooney | bauzas: i have confirmed that we have 2 compute nodes and each is only reporting 3 ironic nodes | 17:33 |
| sean-k-mooney | each compute is exposing diffent shards | 17:33 |
| sean-k-mooney | adn we can boot nova instnace across either shard | 17:34 |
| *** Guest1195 is now known as dasm | 17:34 | |
| sean-k-mooney | bauzas: i was just chatting with JayF and im goign to rework this to be mergable and start wroking on a simple post hook to validate that each compute service is only reportin the ironic nodes we expect | 17:35 |
| sean-k-mooney | long term we may be able to simplfy the setup too but i think this give nova the coverage we ant for the shard work. ironic will seperaly be testing the api in there jobs too | 17:36 |
| JayF | that is already merged and has been running for weeks now (ironic api test job) | 17:54 |
| JayF | https://opendev.org/openstack/ironic-tempest-plugin/commit/f2b9c74c9cb8459a979d9002aae3c1a41737c77a | 17:54 |
| *** elodilles is now known as elodilles_pto | 19:46 | |
| opendevreview | sean mooney proposed openstack/nova master: add multinode ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | 21:36 |
| sean-k-mooney | bauzas: https://review.opendev.org/c/openstack/nova/+/910333 is enabling the ironic job in experimetal and perodic weekly | 21:49 |
| sean-k-mooney | assuming that passes i think that woudl be enough with the exiting ironic testing on there side to progress and we can spend some time adding better coverage post FF and early next cycle | 21:50 |
| sean-k-mooney | the coverage in the job is minimal as it stands today but i have partsed the logs myself and convicned my self that its actully sharding properly | 21:52 |
| sean-k-mooney | see https://review.opendev.org/c/openstack/nova/+/910333/4/.zuul.yaml#974 | 21:52 |
| sean-k-mooney | i am not conviced this job woudl cache if that broken on teh ironic side | 21:52 |
| sean-k-mooney | but we can evolve it to do that | 21:53 |
| JayF | We also have explicit API testing that will make loud noises if we ever break shard querying in our API... | 22:04 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!