| *** tkajinam is now known as Guest1349 | 01:24 | |
| opendevreview | Merged openstack/nova master: Modify the mdevs in the migrate XML https://review.opendev.org/c/openstack/nova/+/904258 | 06:58 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Report ephemeral disk encryption in the metadata API https://review.opendev.org/c/openstack/nova/+/909945 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Deprecate legacy ephemeral storage encryption using dm-crypt https://review.opendev.org/c/openstack/nova/+/909947 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | 07:36 |
| opendevreview | melanie witt proposed openstack/nova master: testing: Add ephemeral encryption support to fixtures https://review.opendev.org/c/openstack/nova/+/910571 | 07:36 |
| *** elodilles_pto is now known as elodilles | 08:29 | |
| stblatzheim | sean-k-mooney: Thanks for the review. Just a quick question as it's my first work on openstack: Which id do i need to append to the release-note file under /releasenotes/notes? Atm i have a file called bug-2055245-fix-nova-metadata-api.yaml . | 11:32 |
| stephenfin | Uggla: Have you link to the discussion where we decided not to bump the object version for a new field enum? That's pretty unusual unless we're not transmitting over the wire (in which case why _not_ bump) https://review.opendev.org/c/openstack/nova/+/908864 | 11:33 |
| stephenfin | cc sean-k-mooney ^ | 11:33 |
| sean-k-mooney | so you can generate a templesate doing "tox -e venv reno new bug-2055245-fix-nova-metadata-api" | 11:34 |
| sean-k-mooney | stblatzheim: well you can generate a file form the template i should say | 11:34 |
| sean-k-mooney | then you can take the content you have and put it in that file under the fixes section | 11:35 |
| sean-k-mooney | just remove all the other sections | 11:35 |
| sean-k-mooney | stephenfin: we normally do bump them | 11:35 |
| sean-k-mooney | and you need compat code to remove the new values when backleveling | 11:36 |
| stephenfin | yeah that's my thinking. It's pretty unusual not to | 11:36 |
| stephenfin | as I said in the review, if there's a good reason not then it should be noted in the commit message | 11:36 |
| sean-k-mooney | if we look at the video model | 11:36 |
| sean-k-mooney | that is proably the closest example to the compat code | 11:36 |
| sean-k-mooney | https://github.com/openstack/nova/commit/35a591d33d8b1a6c30bf40ddc48a07715fd87339 | 11:37 |
| sean-k-mooney | Uggla: ^ | 11:37 |
| sean-k-mooney | adding new enum fields to the VideoModel enum required an object bump for the image metadata object and backleveling code | 11:38 |
| sean-k-mooney | so you woudl need that for attaching too | 11:38 |
| opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | 11:42 |
| stblatzheim | sean-k-mooney: Thank you, I just uploaded the release file | 11:43 |
| sean-k-mooney | stblatzheim: did you forget a git add ^ | 11:43 |
| opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | 11:44 |
| sean-k-mooney | :) | 11:44 |
| stblatzheim | Sorry, my fault :D | 11:44 |
| sean-k-mooney | stephenfin: while your here ^ nice quick review for you if you have time | 11:45 |
| *** tosky_ is now known as tosky | 11:48 | |
| sean-k-mooney | bauzas: are you around | 11:54 |
| bauzas | yup | 11:54 |
| sean-k-mooney | can we chat about the ironic shards work | 11:54 |
| sean-k-mooney | basically im wondering are you ok to proceed with it | 11:55 |
| sean-k-mooney | also the mdev presitance https://review.opendev.org/c/openstack/nova/+/910041 im not sure i have time to review that today | 11:56 |
| opendevreview | Merged openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | 11:56 |
| sean-k-mooney | so i assume the mdev persistnace will go to D since mel has a -w on it | 11:56 |
| bauzas | sure | 11:57 |
| stephenfin | sean-k-mooney: your opinion is requested on https://review.opendev.org/c/openstack/nova/+/833090/43/nova/compute/api.py | 12:05 |
| sean-k-mooney | bauzas: is that sure your goign t | 12:06 |
| sean-k-mooney | to review them or... | 12:06 |
| bauzas | ok, I need to go to lunch but I'll look at it | 12:08 |
| sean-k-mooney | stephenfin: ya i chatted to gibi about it a little. he pointed out that the attachment is actully done in the api | 12:09 |
| opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | 12:09 |
| sean-k-mooney | stephenfin: he was ok with using attachment to future proof the name | 12:09 |
| sean-k-mooney | but right now its acutly doing the manilla export | 12:10 |
| opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | 12:13 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further clarifications to the SG doc https://review.opendev.org/c/openstack/nova/+/903675 | 12:20 |
| stephenfin | melwitt: Respun that small SG docs patch again ^ Sorry for the delay: I missed your response. Would appreciate a (re-)review when you can 🙏 | 12:21 |
| sean-k-mooney | stephenfin: i am +2 on it i think the changes are a nice improvement | 12:24 |
| stephenfin | ty | 12:24 |
| sean-k-mooney | espically the metadata one | 12:24 |
| sean-k-mooney | i actully think that might depend on the driver tha tis used on teh neutron side | 12:25 |
| sean-k-mooney | but its good to have a note | 12:25 |
| sean-k-mooney | neutorn has some default ruels that are alwasy applike like allowing arp and dhcp i belive | 12:25 |
| sean-k-mooney | but i also think ml2/ovs and ml2/ovn differ on what is always allwoed | 12:26 |
| sean-k-mooney | stephenfin: this is what i was thinking of https://github.com/openstack/neutron/blob/12ed429e7b41c7f1ce0901fdc4215216a80b9374/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py#L68-L69 | 12:30 |
| sean-k-mooney | so if the subnet has dhcp it opens dhcp automatically | 12:31 |
| sean-k-mooney | but it doe s not do that for metadata | 12:31 |
| sean-k-mooney | whihc is why we need the note you added for metadata but not for dhcp | 12:32 |
| stblatzheim | In ovn context there needs to be a SG for DHCP and metadata if i remember well. We scame across this behavior when we built a new cloud with ovn. | 12:33 |
| stblatzheim | I think there was also a difference between geneve networks and native_vlan networks. | 12:36 |
| Uggla | sean-k-mooney, stephenfin ok I'have seen your comments. I'll update the version. | 13:32 |
| Uggla | sean-k-mooney, stephenfin, thx for explanation | 13:33 |
| opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | 13:57 |
| *** ralonsoh_ is now known as ralonsoh | 13:59 | |
| opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | 14:10 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: SEV: Add TODO note about iommu setting done in recent QEMU https://review.opendev.org/c/openstack/nova/+/909635 | 14:20 |
| opendevreview | Merged openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | 14:27 |
| opendevreview | Merged openstack/nova master: Separate OSError with ValueError https://review.opendev.org/c/openstack/nova/+/908825 | 14:27 |
| opendevreview | Merged openstack/nova master: HyperV: Remove extra specs of HyperV driver https://review.opendev.org/c/openstack/nova/+/906992 | 15:54 |
| opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | 16:14 |
| opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Report ephemeral disk encryption in the metadata API https://review.opendev.org/c/openstack/nova/+/909945 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Deprecate legacy ephemeral storage encryption using dm-crypt https://review.opendev.org/c/openstack/nova/+/909947 | 16:16 |
| opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | 16:16 |
| opendevreview | Merged openstack/nova master: docs: Further clarifications to the SG doc https://review.opendev.org/c/openstack/nova/+/903675 | 17:03 |
| melwitt | dansmith, sean-k-mooney: just to be clear, the patch where stuff starts actually happening is the "support create" patch, so if the intention is not to put that out there without the rest of the series, it shouldn't be merged this cycle | 17:05 |
| dansmith | melwitt: yeah that's what I was intending to say | 17:06 |
| melwitt | ack | 17:06 |
| sean-k-mooney | ack works for me | 17:14 |
| bauzas | that blueprint needs a core swing for being accepted, gave my blessing already https://review.opendev.org/c/openstack/nova/+/904568 | 17:53 |
| opendevreview | Merged openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | 18:46 |
| opendevreview | Merged openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | 18:46 |
| opendevreview | Merged openstack/nova master: Make compute node rebalance safer https://review.opendev.org/c/openstack/nova/+/903917 | 18:48 |
| gmann | bauzas: sean-k-mooney: as you were reviewing the TC 2024.2 testing runtime, I pushed the new version for possibility of adding ubuntu 24.02 testing after release, please review and add your feedback/vote https://review.opendev.org/c/openstack/governance/+/908862 | 19:07 |
| sean-k-mooney | ack py3.12 is what im most interested in but moving to 24.04 when its relatead woudl be nice too | 19:14 |
| sean-k-mooney | even if its only for tox py3.12 jobs initally | 19:14 |
| sean-k-mooney | gmann: my only real request woudl be to add py3.12 as best effort too | 19:15 |
| sean-k-mooney | for nova i would like to add a tox job or perhaps a periodic-weekly tempest job | 19:16 |
| JayF | I think it's misleading to say best effort for python 3.12 | 19:16 |
| sean-k-mooney | well i wanted to say required | 19:16 |
| JayF | when we know there are projects that won't work with python 3.12, or at least, will lose some features | 19:16 |
| sean-k-mooney | but other pushed back | 19:16 |
| JayF | (oslo_service.sslutils) | 19:16 |
| JayF | I assume you read my comment about that? | 19:17 |
| gmann | sean-k-mooney: my main concern is we do not know how much it is failing and before adding it as nv or so it is confusing to say this as 'bets effort' | 19:17 |
| sean-k-mooney | how are canonical dealing with that in ubuntu 24.04 | 19:17 |
| sean-k-mooney | like they are releaseign caracal on 3.12 on ubuntu 24.04 | 19:17 |
| JayF | sean-k-mooney: I have no idea whatsoever. I just know this eventlet stuff was swept under the rug repeatedly and we idnd't take real action to address it | 19:17 |
| sean-k-mooney | so either those feature are not imporant to them or they hae worked around it | 19:18 |
| dansmith | JayF: I really don't understand the sslutils thing so I must be missing something.. they moved to wrapping the context instead of the socket, right? there's some other issue? | 19:18 |
| gmann | adding 24.04 is a good signal to know how much it fail | 19:18 |
| JayF | dansmith: going to look at the code again, they may have improved it since I last evaluated | 19:18 |
| sean-k-mooney | gmann: ya so i think im fine with the propsal | 19:18 |
| sean-k-mooney | but i want to try and figure out what is broken and see if we can start adressing it | 19:19 |
| dansmith | JayF: okay afaict, that issue is resolved | 19:19 |
| sean-k-mooney | even if it take use another release or two too figure that out | 19:19 |
| dansmith | sean-k-mooney: that was my exact reason for wanting 24.04 on the slate as best effort earlier | 19:20 |
| sean-k-mooney | i have hte 24.04 aplah nightly downloaded but i havent had time to give it a spin yet | 19:20 |
| gmann | sean-k-mooney: true, and once we set the 3.12 tox jobs like on 24.04 we can always add them as periodic->nv etc even they are not required in runtime. this is how we did in past too | 19:20 |
| dansmith | maybe "best effort" connotes too much "effort" or maybe too much "best" | 19:20 |
| JayF | too much best *was* my objection | 19:20 |
| dansmith | JayF: that's valid, so let's come up with some other term or something | 19:21 |
| JayF | but dansmith is right, we should be able to adapt oslo_service.sslutils to the new api | 19:21 |
| dansmith | JayF: 24.04 is best BIG LOOMING ICEBERG | 19:21 |
| JayF | lol | 19:21 |
| sean-k-mooney | hehe maybe we need a "some, proably not much, effort" section | 19:21 |
| dansmith | half-assed effort | 19:21 |
| gmann | idea when we added 'best effort' was to have at least one temepst job running. | 19:21 |
| JayF | "We're gonna try but like, there's only one of us for every 17 projects /s" | 19:21 |
| JayF | ;) | 19:21 |
| dansmith | gmann: but for py38 that was only unit and functional | 19:21 |
| sean-k-mooney | gmann: well we have 3.12 in centos 9 stream today as a non default | 19:21 |
| gmann | dansmith: py38 was mandatory not in best effort | 19:22 |
| sean-k-mooney | and soon ubuntu 24.04 | 19:22 |
| dansmith | gmann: mandatory but unit and functional only | 19:22 |
| JayF | dansmith: sean-k-mooney: my objection to python 3.12 being listed best effort is no longer valid in light of the new information ... as long as someone is actually going to adapt that interface lol | 19:22 |
| sean-k-mooney | so ya we can tyr to get some teempest testign started when its not FF | 19:22 |
| gmann | dansmith: ah, yes | 19:22 |
| dansmith | gmann: so if the big concern is how best our effort is, then let's use different words, that's fine with me | 19:22 |
| gmann | it says this which I think should be clear ? 'This distribution list is the best effort to test them in OpenStack CI/CD.These may not be part of integrated testing and may be tested periodically only.' | 19:24 |
| gmann | or we can add more description here for example. pre-released things also if available like 24.04 case today | 19:25 |
| dansmith | gmann: I get it. pick different words :) | 19:26 |
| gmann | :) 'Optional Testing', 'Advance Testing' | 19:27 |
| gmann | 'Unstable Testing' | 19:27 |
| sean-k-mooney | im just going to download the iso, install it and see if it works and report back | 19:27 |
| dansmith | gmann: I think optional sounds too unconcerned, but the others are reasonable to me | 19:28 |
| gmann | ack, let me add 'Advance/Unstable Testing' so that we can cover any advance testing for non-released versions or unstable one like Centos Stream | 19:29 |
| dansmith | sean-k-mooney: this is the next one of melwitt's series I think we need your re-+2 on: https://review.opendev.org/c/openstack/nova/+/826755/36 | 19:37 |
| sean-k-mooney | i was looking at https://review.opendev.org/c/openstack/nova/+/910571 just now but sure ill swap to that | 19:38 |
| dansmith | okay just saying that's the next one ready (almost) to go to the gate | 19:38 |
| sean-k-mooney | so ot me that shows i still have a +2 on that | 19:39 |
| sean-k-mooney | on https://review.opendev.org/c/openstack/nova/+/826755/36 | 19:39 |
| sean-k-mooney | so it just need a +w right | 19:39 |
| dansmith | oh sorry, it doesn't for me, but I see now | 19:39 |
| dansmith | it put your +2 in the "and 5 more" overflow meny | 19:39 |
| dansmith | how dumb | 19:39 |
| dansmith | I can +w | 19:39 |
| sean-k-mooney | ya it did the saem for you in one of the other pathces | 19:40 |
| sean-k-mooney | i hate the new way the ui handeles this | 19:40 |
| dansmith | seems like it should sort people with votes tot he top | 19:40 |
| dansmith | tyeah | 19:40 |
| sean-k-mooney | so im +2 back up to the create patch | 19:41 |
| sean-k-mooney | whic i have not re reviewd since we are stoping at the testing one | 19:41 |
| sean-k-mooney | so i think the stack is good for what we neeed today | 19:41 |
| dansmith | from you yeah, I haven't made it through all up to there though | 19:42 |
| sean-k-mooney | im going to try and get a few other bitd done related to down stream and then im going to finish for today and cook food | 19:45 |
| sean-k-mooney | ping me if anything comes up | 19:45 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/877446 | 19:46 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Removed explicit call to delete attachment https://review.opendev.org/c/openstack/nova/+/891289 | 19:46 |
| sean-k-mooney | dansmith: actully before i leave the glance multiple location stuff is not done yet right | 19:47 |
| sean-k-mooney | well glance client is not in any case | 19:48 |
| dansmith | officially punted | 19:48 |
| sean-k-mooney | https://review.opendev.org/c/openstack/python-glanceclient/+/890634 | 19:48 |
| dansmith | so no need to look | 19:48 |
| sean-k-mooney | ok | 19:48 |
| gmann | dansmith: sean-k-mooney: updated version for testing runtime https://review.opendev.org/c/openstack/governance/+/908862 | 20:56 |
| dansmith | gmann: yeah it's in my queue | 21:21 |
| *** jph6 is now known as jph | 22:24 | |
| opendevreview | melanie witt proposed openstack/nova master: testing: Add ephemeral encryption support to fixtures https://review.opendev.org/c/openstack/nova/+/910571 | 23:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!