stan | is there any way to connect the vm instance CPU and memory usage? | 03:08 |
---|---|---|
opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos and punctuation issues https://review.opendev.org/c/openstack/nova/+/878779 | 08:28 |
*** ministry is now known as __ministry | 08:44 | |
*** ministry is now known as __ministry | 08:54 | |
opendevreview | Dan Smith proposed openstack/nova master: Enable OCaaS for several nova jobs https://review.opendev.org/c/openstack/nova/+/919738 | 14:19 |
opendevreview | Dan Smith proposed openstack/nova master: Stop using split UEC image (mostly) https://review.opendev.org/c/openstack/nova/+/919739 | 14:19 |
sean-k-mooney | dansmith: OCasS is openstack client as a service right? creating a single cleint instnace and reusing it to make queies | 14:25 |
dansmith | yes | 14:25 |
sean-k-mooney | when did that merge cause i rememebr that beign a thing in the works for years | 14:26 |
dansmith | saves 5m of wasted wall clock time alone on a simple devstack run, not to mention the cpu and disk | 14:26 |
dansmith | sean-k-mooney: yesterday, I just freshened it up and fixed some stuff and we shoved it in | 14:26 |
sean-k-mooney | ok cool | 14:26 |
sean-k-mooney | ill review both those once the ci runs | 14:28 |
sean-k-mooney | dansmith: can you hit this https://review.opendev.org/c/openstack/nova/+/915562 | 14:28 |
sean-k-mooney | there is a placement one too | 14:28 |
sean-k-mooney | here https://review.opendev.org/c/openstack/placement/+/915568 | 14:29 |
dansmith | gladly | 14:30 |
opendevreview | mike_mp@zzzcomputing.com proposed openstack/nova master: do not use str(url) to stringify a URL for subsequent use https://review.opendev.org/c/openstack/nova/+/913910 | 15:08 |
chris218 | Hi I'm reading about CPU topologies and pinning in the docs, from the looks of it if I configure few CPUs as dedicated I won't be able to use them as shared if I run out CPUs specified as shared? | 15:08 |
gibi | chris218: you understand it correctly. You need to statically split your physical CPUs between shared, dedicated, reserved for the os | 15:10 |
chris218 | So there isn't a way to tell nova to treat all the CPUs as shared or dedicated depending on what the users will request? | 15:11 |
opendevreview | Alexey Stupnikov proposed openstack/nova master: [doc] Improve description for nova-manage db purge https://review.opendev.org/c/openstack/nova/+/919746 | 15:20 |
opendevreview | Stephen Finucane proposed openstack/nova master: do not use str(url) to stringify a URL for subsequent use https://review.opendev.org/c/openstack/nova/+/913910 | 15:24 |
stephenfin | melwitt: Fixed the test ^ | 15:25 |
melwitt | stephenfin: ack, will look | 15:26 |
stephenfin | bauzas: The OpenAPI spec has 2 +2s but I think folks are waiting on you to review it again. Could you do that or indicate if we can merge as-is? https://review.opendev.org/c/openstack/nova-specs/+/909448 | 15:30 |
bauzas | stephenfin: I'll try for sure | 15:30 |
opendevreview | Merged openstack/nova master: Remove SQLAlchemy tips jobs https://review.opendev.org/c/openstack/nova/+/915562 | 16:51 |
opendevreview | Merged openstack/placement master: Remove SQLAlchemy tips jobs https://review.opendev.org/c/openstack/placement/+/915568 | 16:51 |
sean-k-mooney | dansmith: is there a reason we are not setting openstack-cli-server: true in the base tempest job? | 17:29 |
sean-k-mooney | well or base devstack job | 17:29 |
dansmith | sean-k-mooney: just wanted to be gradual | 17:29 |
dansmith | oh you mean in the other repo or ours? | 17:29 |
sean-k-mooney | in the ohter repo | 17:30 |
sean-k-mooney | but if you want to test it in ours first | 17:30 |
dansmith | yeah, I don't think the owners are quite ready for that | 17:30 |
sean-k-mooney | then im ok with that | 17:30 |
dansmith | I think we should lead the way here and show that it's stable and then we can argue for it | 17:30 |
sean-k-mooney | ok just confiming | 17:30 |
sean-k-mooney | i was checkign the local.conf in tempest-integrated-compute and realised it was not set | 17:31 |
sean-k-mooney | then i realsed you only enbaled it in some of the jobs and i was trying to figure out why | 17:31 |
clarkb | dansmith: nova-next's devstack runtime was just under 11 minutes with your change. Thats pretty impressive | 17:37 |
dansmith | clarkb: yeah, I saw a super fast nova-live migration too | 17:38 |
JayF | clarkb: fyi I have https://review.opendev.org/c/openstack/ironic/+/919620 up as well, harder to tell w/ironic b/c our times vary so much per cloud | 17:38 |
sean-k-mooney | 39 mins | 17:38 |
JayF | with a ty to Dan for enabling that in Ironic | 17:39 |
sean-k-mooney | i -1 the patch because your current patch is only setting it on the conotler nodes not the compute nodes | 17:39 |
sean-k-mooney | but over all it looks good | 17:39 |
clarkb | JayF: the devstack log file logs a bunch of devstack specific runtime info at the end | 17:40 |
sean-k-mooney | well no 39 mins was the full jobs i realise now when you said 9 mints that just devstack | 17:40 |
sean-k-mooney | JayF: https://zuul.opendev.org/t/openstack/build/265ec9ab7be145ef9925f5bfef62e2f4/log/controller/logs/devstacklog.txt#21773 | 17:42 |
clarkb | JayF: for example https://zuul.opendev.org/t/openstack/build/68136706b3a446ecabfcee5e895f079c/log/controller/logs/devstacklog.txt#37755-37771 the osc line there is 2 minutes of osc but if you look at other jobs outisde of this change its like in the 5-10 minute range | 17:42 |
sean-k-mooney | clarkb: yep and the async_wait is likely reduced as well | 17:42 |
sean-k-mooney | we were likely hiding some of the latency isn async tasks | 17:43 |
clarkb | https://zuul.opendev.org/t/openstack/build/c01518a4f3a64114851dd40f7d1598e1/log/controller/logs/devstacklog.txt#31045-31061 same ironic job against a different change for comparison | 17:43 |
clarkb | 410 second difference between those two runs of the same job in the osc accounting. That is almost 7 minutes | 17:44 |
JayF | clarkb: sean-k-mooney: before: 353, after: 101 -- both on rackspace cloud | 17:44 |
sean-k-mooney | JayF: ya there is a lot of veriabity in the jobs however | 17:44 |
sean-k-mooney | but its non trivial in any case | 17:45 |
JayF | I'm sure, but 250 seconds is well beyond variance | 17:45 |
sean-k-mooney | sadly no | 17:45 |
clarkb | sean-k-mooney: in this case the low value is the indicator there is improvement | 17:45 |
clarkb | there may be that much variance but only on the high end not the low end | 17:45 |
sean-k-mooney | we see 20-30 mins of variance in some jobs depending on the provider. even within a single provier its sever mintues | 17:45 |
clarkb | particularly for osc | 17:46 |
JayF | yeah, that's what I'm saying, 100 seconds in OSC is well below the value I've seen for anything else | 17:46 |
JayF | not talking overall job run speed, just seconds in osc | 17:46 |
sean-k-mooney | clarkb: oh im not doubing this is an improvment | 17:46 |
sean-k-mooney | just that we will need more then one ci run to see how much | 17:46 |
JayF | I'm on the third example of that job and haven't found one >300 yet, in fact 353 is my lowest number yet, so I'm going to stop trying to kill my joy and say thank you for the extra 4 minutes :D | 17:47 |
sean-k-mooney | dansmith: so your change is currently only setting this on the contoler node on our multi node jobs. do we want to merge it as is and have a fix up later or fix it to apply to both. most of the destack time happens on the contoler anyway | 17:48 |
sean-k-mooney | so the speedup on the compute while non 0 will not be the main speedup in the job | 17:49 |
clarkb | I bet all of the osc stuff is on the controller too | 17:49 |
clarkb | since you interact with the apis on the controller and not compute nodes directly. | 17:49 |
sean-k-mooney | ya most if not all | 17:49 |
sean-k-mooney | actully i can check the devstack log on the compute | 17:50 |
dansmith | sean-k-mooney: I haven't looked yet, but almost if not all is on the controller, and they don't *need* to both use the server | 17:50 |
sean-k-mooney | osc 0 | 17:51 |
dansmith | yeah :) | 17:51 |
sean-k-mooney | ok so the compute does not use osc | 17:51 |
sean-k-mooney | in that case ill change my -1 to +2 | 17:51 |
dansmith | JayF: 4 minutes is about the minimum speedup I've been seeing, yeah.. up to like 6 minutes on some jobs that setup more services | 17:51 |
dansmith | ten jobs at 4 minutes each is 40 minutes of cumulative gate time which is non-trivial, IMHO | 17:52 |
JayF | 4 minutes on a job that usually takes 40-60 is amazing | 17:52 |
opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Handle MAC dash-addresses during migration https://review.opendev.org/c/openstack/nova/+/919760 | 17:57 |
dansmith | JayF: yeah, that does not suck | 18:04 |
opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | 18:09 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | 18:10 |
opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | 18:10 |
opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | 18:10 |
opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | 18:10 |
opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | 18:10 |
sean-k-mooney | dansmith: by the way i have like 4 other test tweek patchs that these are conficting with but ill rebase my commits after your two land | 18:16 |
dansmith | sean-k-mooney: ack, no rush on mine, but might make yours faster if you do :) | 18:17 |
dansmith | so.. | 18:17 |
dansmith | python3.12 changes the repr() format for collections.OrderedDict, which is breaking our object hash calculation (for notifications) | 18:17 |
sean-k-mooney | i added all the ci job patches im aware of to https://etherpad.opendev.org/p/nova-dalmatian-status#L17 | 18:25 |
opendevreview | Dan Smith proposed openstack/nova master: Fix notification object hashes for python 3.12 https://review.opendev.org/c/openstack/nova/+/919763 | 18:47 |
opendevreview | Dan Smith proposed openstack/nova master: Fix hacking test with syntax error https://review.opendev.org/c/openstack/nova/+/919764 | 18:47 |
dansmith | this should get the py3.12 unit job working ^ | 18:47 |
dansmith | I wonder if we could get Uggla_ to submit the manila series in smaller chunks.. I think that series is basically consuming all the nova quota in check right now | 18:51 |
opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | 19:08 |
opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | 19:10 |
opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | 19:10 |
sean-k-mooney | dansmith: so the fix is to just bite the bullet and update the hash | 19:11 |
dansmith | sean-k-mooney: well, change the hashed things to something that is stable on both, and then yeah, update them all :( | 19:11 |
dansmith | it sucked | 19:11 |
opendevreview | Dan Smith proposed openstack/nova master: Fix notification object hashes for python 3.12 https://review.opendev.org/c/openstack/nova/+/919763 | 19:13 |
opendevreview | Dan Smith proposed openstack/nova master: Fix hacking test with syntax error https://review.opendev.org/c/openstack/nova/+/919764 | 19:13 |
opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | 19:13 |
sean-k-mooney | ack so you cahnged form an ordered dict to calling sorted on the maping over the items of the schema | 19:14 |
dansmith | it was already calling sorted on the dict.items(), it was just re-dicting them with OrderedDict, which isn't necessary (dicts are ordered in python3) but even still, we don't need the extra dict layer anyway | 19:16 |
sean-k-mooney | SCHEMA is technialy a normal dict which maintains insertion order as of py3.7 i think an dhten calling items on that gives us a view object | 19:16 |
dansmith | so I just removed the ordereddict layer | 19:16 |
sean-k-mooney | yep im just confirming that the thing we are now string should be still ordered and stable | 19:17 |
dansmith | yep, sorted() is a good safety measure to keep it stable, but we don't need the extra top-level dict | 19:17 |
sean-k-mooney | which it should be | 19:17 |
dansmith | yeah | 19:17 |
dansmith | gmann: why no functional 3.12 job yet? our functionals pass on 3.12, but based on my experience above, we better go ahead and have a voting job to make sure we don't regress on that | 19:22 |
dansmith | or, hmm, do we only get functional jobs from our own tree? we don't even have a 311 job in nova | 19:23 |
dansmith | ah, I guess the base is there and I can add it | 19:24 |
sean-k-mooney | dansmith: i think gmann had a patch up for this for placement but i have not seen one for nova | 19:26 |
dansmith | coming | 19:26 |
sean-k-mooney | i think the definiton of the functional 3.12 job was pending | 19:26 |
opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit and functional voting https://review.opendev.org/c/openstack/nova/+/919767 | 19:26 |
dansmith | the base job appears to exist, so I think this ^ should do it | 19:26 |
sean-k-mooney | oh i was thinking of https://review.opendev.org/c/openstack/osc-placement/+/904612 | 19:27 |
sean-k-mooney | yep they were added by https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/918946 | 19:28 |
sean-k-mooney | which looks like it merged last week | 19:28 |
opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit and functional voting https://review.opendev.org/c/openstack/nova/+/919767 | 19:29 |
dansmith | this patch removes 38 too by the way | 19:29 |
dansmith | which I think is legit now | 19:29 |
sean-k-mooney | yes it is | 19:29 |
sean-k-mooney | som ehave started blocking install on 38 but i know you dont want to do that in nova | 19:30 |
dansmith | yeah I wouldn't personally, but I'm just one guy :) | 19:30 |
sean-k-mooney | so we are missing 3.11 for functional | 19:31 |
sean-k-mooney | 3.12 is not requried but if its passing and voting then sure | 19:31 |
dansmith | yeah, missing 3.11 | 19:31 |
sean-k-mooney | do we want to remove 3.10 or bump it to 3.11 | 19:31 |
dansmith | I think we should keep 3.12 passing as long as it is | 19:31 |
dansmith | we could.. testing either end is enough for me | 19:32 |
sean-k-mooney | yep just wonder if you want 2 jobs or 3 while its working | 19:32 |
sean-k-mooney | ok im going to finish for today ill take a look at this tomorwow | 19:33 |
sean-k-mooney | 3.10 may have been the default on ubuntu 22.04 | 19:33 |
dansmith | it is, and that's still our primary platform for this release | 19:33 |
sean-k-mooney | so that might have been why we were tsting it and not 3.11 or we just forgot | 19:33 |
sean-k-mooney | ya so i would be fine not adding 3.11 and keeping 3.10 | 19:34 |
dansmith | me too | 19:34 |
sean-k-mooney | in that case ill +2 https://review.opendev.org/c/openstack/nova/+/919767 and gmann or others can disagree | 19:34 |
dansmith | ack, thanks | 19:36 |
dansmith | py312 unit job passed now on the patch below | 19:36 |
sean-k-mooney | oh you mena in zuul, it has not reported yet | 19:38 |
sean-k-mooney | its failed on the first patch but passing in the second and hopefully 3 | 19:38 |
sean-k-mooney | ah right the failure in the first patch is the hacking testcase | 19:40 |
sean-k-mooney | ya that all makes sesnse | 19:40 |
dansmith | yeah | 19:42 |
opendevreview | Merged openstack/nova master: do not use str(url) to stringify a URL for subsequent use https://review.opendev.org/c/openstack/nova/+/913910 | 20:05 |
gmann | dansmith: sean-k-mooney : yes, i was waiting for this to merge https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/918946 | 21:06 |
gmann | dansmith: sean-k-mooney +A on nova change. can you review osc-placement also where I am making it voting and its base change https://review.opendev.org/c/openstack/osc-placement/+/919101/1 | 21:08 |
gmann | as soon as we have py3.12 pass we should make it voting to avoid any incompatible change merge | 21:08 |
dansmith | gmann: yep, agree, got those | 21:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!