| opendevreview | melanie witt proposed openstack/nova master: docs: Add more information about unified limits https://review.opendev.org/c/openstack/nova/+/919913 | 02:25 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: docs: Add more information about unified limits https://review.opendev.org/c/openstack/nova/+/919913 | 03:32 |
| opendevreview | melanie witt proposed openstack/nova master: docs: Add more information about unified limits https://review.opendev.org/c/openstack/nova/+/919913 | 04:05 |
| opendevreview | melanie witt proposed openstack/nova master: docs: Add more information about unified limits https://review.opendev.org/c/openstack/nova/+/919913 | 04:26 |
| opendevreview | Robert Hoffmann proposed openstack/nova master: Fix backups hanging in creating state https://review.opendev.org/c/openstack/nova/+/919923 | 07:41 |
| opendevreview | Robert Hoffmann proposed openstack/nova master: Fix backups hanging in creating state https://review.opendev.org/c/openstack/nova/+/919923 | 10:05 |
| opendevreview | Mauricio Faria de Oliveira proposed openstack/nova master: libvirt: Filter out disabled guest CPU features in _get_cpu_feature_traits() https://review.opendev.org/c/openstack/nova/+/919949 | 13:13 |
| opendevreview | Andrew Bonney proposed openstack/nova master: [WIP] Set port dns_name when unshelving instances https://review.opendev.org/c/openstack/nova/+/919961 | 14:10 |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] ensure correct cleanup of multi-attach volumes https://review.opendev.org/c/openstack/nova/+/916322 | 17:56 |
| opendevreview | sean mooney proposed openstack/nova master: add functional repoducer for bug 2048837 https://review.opendev.org/c/openstack/nova/+/919979 | 17:56 |
| sean-k-mooney | i spend the better part of 6 hours trying to get that repoduce to pass ^ and then i realsied the reason i could not get it to pass was my fix didnt work... | 17:57 |
| sean-k-mooney | on the plus side i now have a repoducer for the orginal bug... | 17:57 |
| melwitt | too real | 17:59 |
| sean-k-mooney | melwitt: you dont happen to knwo if we stash if a volume is a multi attach volume in the bdms do you | 18:05 |
| melwitt | sean-k-mooney: there isn't a dedicated field for it that I see. I dunno if it could possibly be in the connection_info though | 18:07 |
| sean-k-mooney | ack no worries | 18:08 |
| sean-k-mooney | it is in the conection info yes | 18:09 |
| sean-k-mooney | actully we do cache that in the bdms right | 18:09 |
| melwitt | yeah. sorry, connection_info is a field on the bdm. I was just saying there isn't a field that is only for multiattach | 18:10 |
| sean-k-mooney | right so the simple way to fix the bug is to take a lock on the volume when delete the instnace | 18:11 |
| sean-k-mooney | basiclly @utils.synchronized(f'disconnect_volume_{volume_id}') | 18:11 |
| sean-k-mooney | but instead of doing that in the virt driver in _disconnect_volume | 18:12 |
| melwitt | ok I see | 18:12 |
| sean-k-mooney | i need to do that in _delete_instance in the compute manger | 18:12 |
| sean-k-mooney | but i only need to do that for multi attach volumes | 18:13 |
| sean-k-mooney | i was orginally tring to do the locking as fine grained as possible | 18:14 |
| sean-k-mooney | but that wont work | 18:15 |
| melwitt | oh yeah. so you're thinking you can check bdm.connection_info to see if it's multiattach? | 18:15 |
| sean-k-mooney | ya | 18:15 |
| sean-k-mooney | the other option is to basiclaly reuse or reinvent https://github.com/openstack/nova/blob/ab3ca1e2059f951b44d723c15a5065c6532540da/nova/virt/libvirt/volume/mount.py#L33 | 18:16 |
| melwitt | seems like that would work 🤔 | 18:16 |
| sean-k-mooney | the _HostMountStateManager basicaly impelmentes refernce counting for host mounts | 18:17 |
| sean-k-mooney | but we dont use that for anything other the nfs | 18:17 |
| sean-k-mooney | the problem is this logic https://github.com/openstack/nova/blob/ab3ca1e2059f951b44d723c15a5065c6532540da/nova/virt/libvirt/driver.py#L2045-L2065 | 18:19 |
| sean-k-mooney | if we have 2 vms on the same host using the same multi attach volume | 18:19 |
| sean-k-mooney | and you delete both of them at the same time | 18:19 |
| melwitt | ah ok | 18:19 |
| sean-k-mooney | then because we are looking at the host's instance list until know if we should do the disconenct there is a race | 18:20 |
| sean-k-mooney | so to fix it we either need a refence count and delete it when that hits 0 or we need to just seriase the delete | 18:21 |
| sean-k-mooney | i think the latter is simpler and safer | 18:21 |
| melwitt | I agree | 18:21 |
| sean-k-mooney | ok now that i know someone else does not think this is an insane approch i think im going to call it a day | 18:23 |
| melwitt | haha :) | 18:23 |
| sean-k-mooney | the worst part was i didnt even thing the issue was with my fix. i was confived the issue was with my repoducer test for so long | 18:23 |
| melwitt | I know the feeling 😝 | 18:24 |
| opendevreview | melanie witt proposed openstack/nova master: docs: Add more information about unified limits https://review.opendev.org/c/openstack/nova/+/919913 | 19:26 |
| opendevreview | melanie witt proposed openstack/nova master: Consolidate vTPM and ephemeral encryption secret creation https://review.opendev.org/c/openstack/nova/+/912094 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add optional 'description' kwarg to create_secret() https://review.opendev.org/c/openstack/nova/+/919986 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Validate key manager create access in API https://review.opendev.org/c/openstack/nova/+/919989 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Clean up unused ephemeral encryption libvirt secrets https://review.opendev.org/c/openstack/nova/+/919990 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: "Auto heal" ephemeral encryption secrets on guest launch https://review.opendev.org/c/openstack/nova/+/919991 | 23:42 |
| opendevreview | melanie witt proposed openstack/nova master: Support encrypted source images for qcow2 https://review.opendev.org/c/openstack/nova/+/919992 | 23:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!