opendevreview | Merged openstack/nova master: api: Fix bugs in schemas https://review.opendev.org/c/openstack/nova/+/915843 | 02:24 |
---|---|---|
opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | 02:34 |
*** bauzas_ is now known as bauzas | 03:36 | |
*** bauzas_ is now known as bauzas | 05:21 | |
opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | 08:37 |
*** ykarel__ is now known as ykarel | 10:37 | |
opendevreview | Fabian Wiesel proposed openstack/nova-specs master: Lazy Metadata Loading in order to Reduce Server Load https://review.opendev.org/c/openstack/nova-specs/+/922201 | 11:10 |
opendevreview | Max proposed openstack/nova master: performance: reduce calls to libvirt / add caching https://review.opendev.org/c/openstack/nova/+/922855 | 11:49 |
opendevreview | Bence Romsics proposed openstack/os-vif master: Do not add taps in trunk bridges to the dead vlan https://review.opendev.org/c/openstack/os-vif/+/923036 | 11:51 |
opendevreview | Fabian Wiesel proposed openstack/nova-specs master: Lazy Metadata Loading in order to Reduce Server Load https://review.opendev.org/c/openstack/nova-specs/+/922201 | 12:06 |
opendevreview | Merged openstack/nova-specs master: Follow-up for openapi spec https://review.opendev.org/c/openstack/nova-specs/+/919603 | 12:52 |
opendevreview | Merged openstack/nova master: tests: Ensure API schemas are valid https://review.opendev.org/c/openstack/nova/+/915844 | 13:44 |
opendevreview | Michal Arbet proposed openstack/nova-specs master: Add availability zone-aware affinity filter to the scheduler https://review.opendev.org/c/openstack/nova-specs/+/890779 | 13:56 |
opendevreview | Michal Arbet proposed openstack/nova-specs master: Add availability zone-aware affinity filter to the scheduler https://review.opendev.org/c/openstack/nova-specs/+/890779 | 13:58 |
opendevreview | Dan Smith proposed openstack/nova master: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923255 | 14:09 |
opendevreview | Dan Smith proposed openstack/nova master: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923256 | 14:09 |
opendevreview | Dan Smith proposed openstack/nova master: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923257 | 14:09 |
opendevreview | Dan Smith proposed openstack/nova master: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923258 | 14:09 |
opendevreview | Dan Smith proposed openstack/nova stable/2024.1: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923273 | 14:10 |
opendevreview | Dan Smith proposed openstack/nova stable/2024.1: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923274 | 14:10 |
*** bauzas_ is now known as bauzas | 14:10 | |
opendevreview | Dan Smith proposed openstack/nova stable/2024.1: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923275 | 14:10 |
opendevreview | Dan Smith proposed openstack/nova stable/2024.1: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923276 | 14:10 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.2: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923284 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.2: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923285 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.2: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923286 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.2: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923287 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.1: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923288 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.1: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923289 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.1: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923290 | 14:11 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.1: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923291 | 14:11 |
mnaser | dansmith: sorry I know its a busy morning but I was working on back porting the patches to unmaintained/zed | 14:35 |
mnaser | https://review.opendev.org/c/openstack/nova/+/923291/1/nova/tests/unit/virt/libvirt/test_utils.py | 14:35 |
mnaser | I think this will fail pep8 because of lack of new line above test_create_image_encryption | 14:35 |
dansmith | yep, looks like it already did | 14:37 |
dansmith | thanks | 14:37 |
dansmith | that was last minute yesterday | 14:37 |
mnaser | yeah it's all been last minute all over the place | 14:37 |
dansmith | it passed pep8 on master when I tried, so maybe the backport trimmed | 14:37 |
dansmith | srsly | 14:38 |
mnaser | I am taking care of zed for all the projects | 14:38 |
mnaser | https://review.opendev.org/c/openstack/nova/+/923297 if you want to eye it over (and it matters to you that is :p) | 14:38 |
sean-k-mooney | it passed for me locally too | 14:38 |
sean-k-mooney | i think its because in the gate its applied to the tip of the branch | 14:38 |
sean-k-mooney | when we run the jobs | 14:38 |
mnaser | ahh right maybe it ran it over the last commit that was clean | 14:39 |
sean-k-mooney | so to see it locally we might need to rebase | 14:39 |
tkajinam | I downloaded the chain for master but pep8 fails in my local (even after rebasing the chain on the latest master). zuul hasn't run pep8 year over 923258 but I suspect it may detect the same error. | 14:45 |
tkajinam | s/year/yet/ | 14:45 |
dansmith | oh it does fail for me on master, | 14:46 |
dansmith | I ran preivously before the tests were added | 14:46 |
dansmith | I will fix | 14:46 |
opendevreview | Dan Smith proposed openstack/nova master: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923258 | 14:47 |
sean-k-mooney | reappoved | 14:47 |
opendevreview | Dan Smith proposed openstack/nova stable/2024.1: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923276 | 14:50 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.2: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923287 | 14:55 |
dansmith | mnaser: tkajinam sorry about that, thanks for the heads up 2023.1 coming in a sec | 14:58 |
opendevreview | Dan Smith proposed openstack/nova stable/2023.1: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923291 | 15:00 |
JayF | melwitt: sean-k-mooney: re: the lock greening errors in python 3.12: https://github.com/eventlet/eventlet/issues/969 is what itamarst tracked it to. | 15:09 |
frickler | sean-k-mooney: dansmith: do you want us to promote any of the approved patches into gate or do you prefer for all check jobs to finish first? | 15:12 |
dansmith | frickler: definitely want to see the tests first | 15:13 |
sean-k-mooney | frickler: based on the quick review we have done we belive the patchs shoudl be correct however we need the wider coverage form check to confirm we are not regressing any edgecases. if we see a timeout ectra or other infa issues we can consier promotiign or requeing | 15:19 |
frickler | well I'm not talking about force-merging (yet), you'll have the same jobs running in the gate pipeline again (except n-v), but anyway, the decision is up to you | 15:22 |
opendevreview | Fabian Wiesel proposed openstack/nova-specs master: Lazy Metadata Loading in order to Reduce Server Load https://review.opendev.org/c/openstack/nova-specs/+/922201 | 15:27 |
tkajinam | dansmith, no problem, and thank you ! | 15:32 |
*** bauzas_ is now known as bauzas | 15:34 | |
dansmith | definitely want to see all the scenarios run against this since its so much change and it's nearly impossible to do that ahead of time | 15:54 |
dansmith | if we hit obviously unrelated things I think promote/force is the tool we can use to expedite | 15:54 |
dansmith | thanks frickler for checking | 15:54 |
sean-k-mooney | im checkign now but the nova-live-migration job fails on the second patch | 15:56 |
sean-k-mooney | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7fc/923256/1/check/nova-live-migration/7fc79c6/ | 15:56 |
opendevreview | Fabian Wiesel proposed openstack/nova-specs master: Lazy Metadata Loading in order to Reduce Server Load https://review.opendev.org/c/openstack/nova-specs/+/922201 | 15:56 |
sean-k-mooney | the ceph one passed | 15:56 |
dansmith | hmm | 15:56 |
dansmith | that is odd or sure | 15:57 |
dansmith | *for | 15:57 |
dansmith | I have to do a medial thing in a few minutes, so I will be out a bit around there | 15:57 |
sean-k-mooney | looks like only the blockmigation tests | 15:57 |
dansmith | right but perhaps something is upset about the disk image? | 15:57 |
dansmith | Jul 02 15:17:20.783035 np0037859393 nova-compute[41928]: ERROR oslo_messaging.rpc.server nova.exception.ImageUnacceptable: Image 02acc766-7c4b-4ffb-a72d-080ea50527d4 is unacceptable: Image not in a supported format | 15:57 |
dansmith | eff | 15:57 |
sean-k-mooney | yep | 15:58 |
sean-k-mooney | AttributeError: 'NoneType' object has no attribute 'from_file' | 15:58 |
sean-k-mooney | but i tought we caught that | 15:59 |
sean-k-mooney | so this is raising https://review.opendev.org/c/openstack/nova/+/923256/1/nova/virt/images.py#152 | 16:01 |
sean-k-mooney | and we take this else https://review.opendev.org/c/openstack/nova/+/923256/1/nova/virt/images.py#174 | 16:01 |
sean-k-mooney | oh ok i need to look at the ohte rhost to see it properly | 16:02 |
sean-k-mooney | Jul 02 15:19:58.679517 np0037859379 nova-compute[85178]: WARNING nova.virt.images [None req-3f27d1d1-b0a1-46a9-ac4b-6b869e49ea15 tempest-LiveMigrationTest-599041496 tempest-LiveMigrationTest-599041496-project-admin] Unable to perform deep image inspection on type 'aki' | 16:04 |
sean-k-mooney | so we have special cased for ami image but not aki | 16:04 |
sean-k-mooney | so i think its passing on the ami iamge and failing on the kernel image | 16:05 |
sean-k-mooney | dansmith: and we are only seeing it in that job becasue tis the only one using uec images | 16:06 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/.zuul.yaml#L120-L121 | 16:06 |
sean-k-mooney | so "if disk_format == 'ami':" should be "if disk_format in ('ami','aki'):" | 16:07 |
sean-k-mooney | here https://review.opendev.org/c/openstack/nova/+/923256/1/nova/virt/images.py#166 | 16:07 |
*** bauzas_ is now known as bauzas | 16:07 | |
dansmith | sean-k-mooney: aha, so I think we need to have a serious discussion about AMI in nova because as far as I can tell, the disk image can be anything from a qcow to a raw ext2 or ntfs filesystem and trying to determine safety there is a nightmare | 16:14 |
sean-k-mooney | dansmith: im carefully going to put a patch on the end to fix 'aki' | 16:14 |
sean-k-mooney | ya | 16:14 |
dansmith | perhaps if we fix our own losing track of the format of the base images in nova we could handle it better, but idk | 16:14 |
dansmith | sean-k-mooney: ack on the fix thanks ++ | 16:14 |
sean-k-mooney | i was also wonderign about the other contaienr formats like ova ovf | 16:14 |
sean-k-mooney | so we will need to squash the fix into patch 2 | 16:15 |
sean-k-mooney | but i dont want to kick the current set out of the gate | 16:15 |
dansmith | okay, yeah, let's confirm it fixes it and there's nothing else before we squash but sounds good | 16:15 |
sean-k-mooney | hench put it on the end and we can either force merge or pull it back depending on perfernce/urgency | 16:15 |
dansmith | we'll have to fix all the backports too | 16:15 |
sean-k-mooney | i sould aslo includ ari | 16:16 |
sean-k-mooney | https://creodias.docs.cloudferro.com/en/latest/cloud/What-Image-Formats-are-available-in-OpenStack-Creodias-Cloud.html | 16:16 |
dansmith | do we ever run qemu-img cmmands on the ramdisk? I'd guess not | 16:20 |
opendevreview | sean mooney proposed openstack/nova master: add support for aki and ari images https://review.opendev.org/c/openstack/nova/+/923317 | 16:20 |
sean-k-mooney | dansmith: i dont think we do but if we do its failign before we get to that point | 16:21 |
dansmith | maybe we just run it on all three pieces for no reason? but okay, no complaints about the patch as-is | 16:22 |
sean-k-mooney | proably realistically if any of the aobve were qcows i would expect it to trigger the vulnerablity | 16:22 |
sean-k-mooney | so checking all 3 part is a good thing to do regardless | 16:23 |
dansmith | ah, that's a good point | 16:23 |
sean-k-mooney | brb ill keep an eye on the jobs when im back | 16:25 |
gibi | I'm arond until the top of the hour (already +2 on the Sean's patch) | 16:26 |
sean-k-mooney | openstacksdk-functional-devstack failed on the 4 patch but is passing on the rest | 16:46 |
sean-k-mooney | enstack.exceptions.ConflictException: ConflictException: 409 | 16:46 |
sean-k-mooney | in the TestAutoAllocatedTopology test | 16:46 |
sean-k-mooney | i have seen that fail on othe rpatches and it seams to just be flaky | 16:46 |
sean-k-mooney | so for now ill leave the curernt set complete | 16:46 |
sean-k-mooney | it will get rerun once i rebase the patches for the ami/aki/ari fix anyway | 16:47 |
dansmith | ack | 16:47 |
sean-k-mooney | im assumign that merged reletivly recently because i have only started to see it fail like that in the last 2-3 weeks | 16:48 |
sean-k-mooney | i dont recall that job failing previously to that | 16:48 |
sean-k-mooney | hum no apprently that was added 8 years ago | 16:50 |
sean-k-mooney | that makes me feel old given the autoallocate stuff was added to enable people to move form nova-networks... | 16:51 |
sean-k-mooney | ofcouse everythign pre covide feels ancient at this point | 16:51 |
dansmith | sean-k-mooney: going to need a very quick approval on a job change in nova's ceph job to unblock glance in a sec | 17:40 |
opendevreview | Dan Smith proposed openstack/nova master: Fix disk_formats in ceph job tempest config https://review.opendev.org/c/openstack/nova/+/923322 | 17:45 |
dansmith | sean-k-mooney: ^ | 17:46 |
dansmith | or any other nova cores | 17:48 |
dansmith | frickler: that one will take a long time in the current queue to merge and glance can't merge their stuff without it, so if you have thoughts... :) | 17:49 |
gmann | dansmith: one question, this is tempest default, that is what you mean in commit msg https://github.com/openstack/tempest/blob/6b8ff89c8fffcc231d9e5b639d57d6e4a8bd47d3/tempest/config.py#L657 | 17:52 |
dansmith | gmann: yes | 17:52 |
dansmith | abhishek_: ^ | 17:52 |
dansmith | gmann: this is basically the problem: https://github.com/openstack/tempest/blob/master/tempest/api/image/base.py#L103 | 17:52 |
abhishek_ | yes | 17:52 |
gmann | dansmith: ohk, +2 but it will be good if we can also fix test to fetch the required image instead of replying on list order in config option | 17:56 |
gmann | *relying | 17:56 |
dansmith | replied agree of course | 17:56 |
gmann | dansmith: thanks | 17:57 |
abhishek_ | gmann: agree to fix the test as well | 17:57 |
gmann | +1 | 17:57 |
frickler | dansmith: the only chance to speed up the CI in the current situation likely would be to temporarily abandon all the stable branch changes that eat up resources but fill anyway, and restore them once all fixes have merged in master | 18:17 |
dansmith | seems like a bad plan | 18:17 |
frickler | s/fill/will fail/ | 18:18 |
frickler | other then that, just wait until zuul has worked through the queue | 18:18 |
dansmith | roger that | 18:18 |
JayF | sean-k-mooney: https://github.com/eventlet/eventlet/pull/970/files is the fix for that eventlet "couldn't green locks" issue we saw popup in python 3.12. I'd expect it to merge+be in next eventlet release. TL;DR: eventlet monkey-patching was happening after we greened locks + as a side effect of running the lock greening, we'd create more locks to be greened AIUI | 18:20 |
sean-k-mooney | JayF: ack ill try and take a look | 18:38 |
JayF | sean-k-mooney: consider it just an FYI and notice that I made sure it was taken care of | 18:39 |
JayF | not sure you have an AI | 18:39 |
sean-k-mooney | JayF: thanks it more i was on calls for the last hour or so and i want to check back in on the status fo the cve | 18:40 |
sean-k-mooney | so ill read over that tomorrow | 18:40 |
JayF | yeah that is more important, only reason I'm letting you know is to get it off your list if it was ever on it | 18:40 |
sean-k-mooney | :) | 18:40 |
fungi | with regard to speeding up fixes, we *can* enqueue the more urgent changes directly into the gate pipeline without waiting for them to clear check. the gate pipeline automatically gets resource priority over the check pipeline | 19:10 |
dansmith | fungi: up to you really... we have the nova and glance patches that both need to go | 19:11 |
fungi | once they're in the gate, we can also reorder the queue to put them ahead of the rest | 19:11 |
dansmith | they're just tempest/zuul changes and gmann is +2, so... might be good | 19:11 |
fungi | they'll need workflow +1 votes before i can enqueue them, but they'll still have to pass the same tests in the gate before they can merge anyway so that should be safe | 19:12 |
dansmith | the nova one should be good | 19:12 |
fungi | i'm juggling a lot of things, so if someone can explicitly list the more urgent change numbers i need to move to the gate pipeline i'm happy to do that as long as they've gotten approval votes from someone | 19:13 |
dansmith | https://review.opendev.org/c/openstack/glance/+/923321 | 19:13 |
dansmith | and yeah the glance one too | 19:13 |
fungi | thanks | 19:13 |
dansmith | nova one is https://review.opendev.org/c/openstack/nova/+/923322 in case you didn't et it | 19:13 |
fungi | yep, i'll enqueue those momentarily | 19:14 |
fungi | they're both at the top of the gate pipeline now | 19:19 |
dansmith | thanks fungi | 19:20 |
fungi | and already getting nodes assigned | 19:22 |
dansmith | fungi: we may have spoken too soon | 19:40 |
dansmith | abhishek_: ^ | 19:40 |
dansmith | looks like that small change had some knock-on effects in tempest I don't fully understand | 19:41 |
dansmith | gmann: might could use some help | 19:41 |
fungi | i'm around to re-enqueue a revision if it's worked out | 19:41 |
dansmith | gmann: does image.disk_formats look right here? https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_991/923321/2/check/tempest-integrated-storage-import/991d0c2/controller/logs/tempest_conf.txt | 19:42 |
dansmith | looks like the list syntax is not parsed and we grab a chunk of it | 19:43 |
dansmith | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_991/923321/2/check/tempest-integrated-storage-import/991d0c2/testr_results.html | 19:43 |
dansmith | maybe the inner quotes are not needed? | 19:44 |
dansmith | abhishek_: ^ | 19:44 |
dansmith | I bet that's the case and oslo.config is splitting on comma only | 19:44 |
dansmith | so it gets everything up to the first comma | 19:44 |
abhishek_ | ok | 19:44 |
abhishek_ | so without inner '' quotes? | 19:45 |
dansmith | so maybe should be: | 19:45 |
dansmith | disk_formats: qcow2,ari,aki,vhd,vmdk,raw,ami,vdi,iso,vhdx | 19:45 |
dansmith | ? | 19:45 |
dansmith | tbh I dunno because the example above that one has inner and outer quotes | 19:47 |
abhishek_ | not sure how it is working for image_import_plugins: "['inject_image_metadata', 'image_conversion']" | 19:47 |
dansmith | but it sure looks to me like it needs no quotes at all | 19:47 |
dansmith | right | 19:47 |
abhishek_ | enabled_import_methods: "[\"copy-image\", \"glance-direct\"]" | 19:48 |
abhishek_ | or should do something like this? | 19:48 |
dansmith | idk | 19:48 |
abhishek_ | available_type_drivers: flat,geneve,vlan,gre,local,vxlan | 19:50 |
abhishek_ | I see somewhwere this | 19:50 |
abhishek_ | in neutron jobs | 19:51 |
dansmith | ack, I think what matters is how the tempest.conf is read, but I dunno | 19:51 |
dansmith | might as well change it I guess, it's not going to work as-is | 19:51 |
dansmith | oh yeah, | 19:52 |
dansmith | I see in tempest config for neutron | 19:52 |
dansmith | I think that's right | 19:52 |
opendevreview | Dan Smith proposed openstack/nova master: Fix disk_formats in ceph job tempest config https://review.opendev.org/c/openstack/nova/+/923322 | 19:53 |
abhishek_ | hmm, ket me do that | 19:53 |
fungi | lmk as soon as it has an approval vote and i can reenqueue it into the gate | 19:53 |
dansmith | I guess this is why we don't (normally) skip check | 19:54 |
abhishek_ | ++ | 19:55 |
fungi | heh | 19:56 |
fungi | we're not normally in quite so much of a hurry ;) | 19:56 |
dansmith | I'm want to get off the merry-go-round | 19:58 |
fungi | if we get it spinning fast enough, you can take advantage of centripetal force to make a speedy exit | 19:59 |
fungi | you'll probably land somewhere over by the cotton candy booth | 19:59 |
sean-k-mooney | given the week in it i expect a lot of people to dissapre after tomorrow one way or another | 20:01 |
dansmith | fungi: both of those are fixed (we think) and re-approved.. up to you if you want to take another gamble on the roulette wheel | 20:02 |
dansmith | sean-k-mooney: looks like unless ceph fails, everything passed except for that live migration job, which is fairly effing amazing | 20:03 |
dansmith | actually ceph already passed on the second one | 20:04 |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/923317/1 | 20:04 |
sean-k-mooney | my fix passed | 20:04 |
dansmith | sweet, I'll squash here in a few when the ones below are done | 20:04 |
sean-k-mooney | and was green on all jobs | 20:04 |
dansmith | amazing | 20:04 |
sean-k-mooney | so ya you could also squash in the vmdk fix fi you wanted to reduce the set of patches | 20:05 |
sean-k-mooney | but ill leave that up to your judgement | 20:05 |
sean-k-mooney | part of me does not reallly want to mess with them if they are passing even if the end result is the same | 20:05 |
fungi | the new revisions of both changes are at the top of the gate pipeline again now | 20:06 |
abhishek_ | thank you! | 20:09 |
sean-k-mooney | we have resutls for https://review.opendev.org/c/openstack/nova/+/923256 now and the only failure was the aki/ari issue | 20:23 |
sean-k-mooney | tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/98a696b69cc844c6bdf9f7cb4b73f54d : SUCCESS in 2h 00m 47s | 20:23 |
sean-k-mooney | that job has a 2 hour timeout so it got very close | 20:23 |
sean-k-mooney | the last job on the 3rd patch is almost done too | 20:26 |
sean-k-mooney | ok thats done too | 20:28 |
sean-k-mooney | ill wait aorund for another 5 minutes otherwise ill check back in an hour or 2 before i go to sleep | 20:29 |
opendevreview | Dan Smith proposed openstack/nova master: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923255 | 20:29 |
opendevreview | Dan Smith proposed openstack/nova master: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923256 | 20:29 |
opendevreview | Dan Smith proposed openstack/nova master: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923257 | 20:29 |
opendevreview | Dan Smith proposed openstack/nova master: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923258 | 20:29 |
sean-k-mooney | im not sure you ment to update the first patch.. | 20:30 |
dansmith | oh crap, yeah I rebased my origin master chasing the other fire | 20:30 |
dansmith | oh well, that sucks | 20:30 |
dansmith | it was rechecking anyway | 20:30 |
sean-k-mooney | i +2w'd the set | 20:31 |
dansmith | thanks much | 20:31 |
dansmith | I'm just about exhausted and fading pretty fast here | 20:32 |
sean-k-mooney | ok im going to go eat. ill check back in an hour or two before i go to sleep and ill check them in the morning if they have any issues | 20:32 |
sean-k-mooney | dansmith: go rest | 20:32 |
dansmith | I have one other thing to do and then I will probably need to take a break for a bit | 20:32 |
sean-k-mooney | well theere in the ci so not much more for you do do on the nova side | 20:33 |
sean-k-mooney | unless your plannig to respin the backports but we can do that once they start to merge | 20:33 |
dansmith | I'm going to hold off on those until we make progress yeah | 20:34 |
fungi | argh, one job timed out on the glance change | 22:08 |
fungi | during volume tests, though that may have been coincidence | 22:09 |
fungi | though the one remaining job on the nova change may be about to do the same | 22:10 |
fungi | they're both starting over at the top of the gate pipeline again | 22:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!