Thursday, 2024-07-04

opendevreviewMerged openstack/nova master: Additional qemu safety checking on base images  https://review.opendev.org/c/openstack/nova/+/92325703:06
*** bauzas_ is now known as bauzas03:28
opendevreviewMerged openstack/nova stable/2023.1: Fix disk_formats in ceph job tempest config  https://review.opendev.org/c/openstack/nova/+/92334406:13
opendevreviewMaxime Lubin proposed openstack/nova-specs master: USB over IP  https://review.opendev.org/c/openstack/nova-specs/+/92068707:19
fricklermore gate resets happening all the time. I'll regate https://review.opendev.org/c/openstack/nova/+/923258 now, but not promote in order to give the glance stack a chance first07:25
abhishekkthank you!07:28
opendevreviewMaxime Lubin proposed openstack/nova-specs master: USB over IP  https://review.opendev.org/c/openstack/nova-specs/+/92068707:32
amorinhey team, just wondering if there is any way to start nova-conductor when nova-placement is down? It seems nova-conductor refused to start if placement API is not up07:49
amorinopenstack.exceptions.NotSupported: The placement service for keystone.x.y.z xists but does not have any supported versions.07:49
frickleramorin: what would be the use case for that? I don't think the conductor can do anything useful without placement?07:55
amorinI mean, maybe it can start anyway, and try to reconnect later, at least it will start and answer to computes that need some data07:56
frickleramorin: hmm, maybe, but then let me ask a different question: in what scenario would you expect your placement service to be down for an extended period? or would just retrying a couple of times at startup be enough?08:06
amorinagree that this scenario of placement down is wrong08:19
amorinI am just surprised that this is the behavior of nova-conductor. 08:20
amorinmy good old stein openstack was not complaining about this :)08:27
*** bauzas_ is now known as bauzas08:45
fricklerdid that even have the split placement service yet? ;)08:55
amorinyes, placement was splitted (at least in our deployment)08:57
gibiamorin: I think by https://github.com/openstack/nova/commit/232684b44022f1bc4d72b07045900780de456e6309:01
gibiit shoud not happen any more09:01
bauzasthis is indeed an expected behaviour09:02
amorinperfect!09:11
amorinwill try cherry-picking that to my antelope openstack then09:12
amorinbut wait, it should be there09:12
amorinthe exeption raised is the following: exceptions.NotSupported09:15
amorinwhich is not in the first except block, so it's conesidered as a fatal one09:16
amorinmy service is stop and returning http 50309:16
gibiamorin: do you have placement in openstack endpoint list?09:26
frickleramorin: that sounds like the keystone lib might be mishandling that error09:32
amorinyes gibi, it's all set correctly, as soon as I start placement, everything works fine :)09:35
fricklerfrickler: can you try to run something like "openstack --debug resource provider list" while placement is down and show the output on paste.opendev.org? (and possibly let's move this to #openstack-sdks)09:37
fricklerehm amorin ^^09:37
sean-k-mooneyamorin: this is a similar but slightly diffent issue09:51
sean-k-mooneythe orginal fix was to allow it to start when there was a keyston outaage not placment actully down09:51
sean-k-mooneyi think we have a diffent patch to make loading the placement client lazy09:51
sean-k-mooneyso that provided you dont make an api call that need it to talk to palcment it wont try09:52
sean-k-mooneywe worked on that for the schduler too but i dont recall whicih serviecs got that change and whihc did not09:52
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/878238 that was the scheduler change09:53
sean-k-mooneyi guess it thet same apprch https://github.com/openstack/nova/commit/232684b44022f1bc4d72b07045900780de456e63 make the report clint a property and lazy loads it too09:56
sean-k-mooneymy guess is that a "503 Service Unavailable" responce does not count as ConnectionFailure and we just need to add that to the first expection block to cover your edgecase09:58
fricklerseems there is another different set of error classes for that, like in this case keystoneauth1.exceptions.http.ServiceUnavailable10:10
sean-k-mooneyya so we just need to add them10:15
sean-k-mooneywith that said nova does expect placment ot be aviabel when wee start up we just added this lazy loading to make it more graceful10:15
sean-k-mooneyif placement is down for a protacted period of tiem we want to allow you to manage things that dont require interaction with placement but obvioulsy you wont be abel to boot new vms, evaucate them or move them in any way10:16
sean-k-mooneystart/stop/snapshot/attache port ectra is ok10:16
sean-k-mooneybut we would consdier the openstack to be in a degreated state and expect some operations ot fail10:17
opendevreviewStephen Finucane proposed openstack/placement master: tox: Simplify functional testenv definitions  https://review.opendev.org/c/openstack/placement/+/91957810:20
opendevreviewStephen Finucane proposed openstack/placement master: Integrate pre-commit  https://review.opendev.org/c/openstack/placement/+/91957910:20
opendevreviewStephen Finucane proposed openstack/placement master: pre-commit: Add sphinx-lint  https://review.opendev.org/c/openstack/placement/+/91958010:20
opendevreviewStephen Finucane proposed openstack/placement master: pre-commit: Add autopep8  https://review.opendev.org/c/openstack/placement/+/92349010:20
opendevreviewStephen Finucane proposed openstack/placement master: Fix typos  https://review.opendev.org/c/openstack/placement/+/92349110:20
sean-k-mooneysigh.... https://github.com/al45tair/netifaces netifaces is not buildable on debian testin on python 3.12... we need to drop that depency form nova11:37
sean-k-mooneyit works on 3.1111:37
opendevreviewsean mooney proposed openstack/nova master: port format insepctor tests from glance  https://review.opendev.org/c/openstack/nova/+/92350411:42
opendevreviewsean mooney proposed openstack/nova master: port format inspector tests from glance  https://review.opendev.org/c/openstack/nova/+/92350411:42
fricklerhmm, seems at least canonical managed to make it work https://launchpad.net/ubuntu/+source/netifaces11:52
sean-k-mooneyit works on 3.11 but it raise an error where it say "you must add supprot for your plathform"11:52
sean-k-mooneyill get the exact message in a sec11:52
sean-k-mooneyit might be because im using debian testing11:53
sean-k-mooneybut the project is archivbed and not maintaned anymore11:53
sean-k-mooneyso we need to replace it anyway11:53
sean-k-mooneyi dont thnk nova really should have thsi dep anymore anyway it was mainly for nova-net before and os-vif on windows i think11:54
fricklerack. I'm just wondering why the py312 tests don't seem to notice it11:54
sean-k-mooneyso we can likely jsut remove the code that is using it11:54
sean-k-mooneyhttps://paste.opendev.org/show/bzSoczPxEGhAlGJPfcCc/11:55
sean-k-mooneythats what im seeing on 3.1211:56
opendevreviewsean mooney proposed openstack/nova master: port format inspector tests from glance  https://review.opendev.org/c/openstack/nova/+/92350411:56
sean-k-mooneyok this is what is firing https://github.com/al45tair/netifaces/blob/master/netifaces.c#L206-L21111:57
fricklerhmm, can you check why pip is wanting to build the wheel, are you on arm? on noble I just get "Using cached netifaces-0.11.0-cp312-cp312-linux_x86_64.whl"11:59
sean-k-mooneydebian testing on x8611:59
sean-k-mooneyx86_64 to be precise12:00
sean-k-mooneyhow would i check that12:00
fricklergood question, add some "-v"'s?12:01
sean-k-mooneysure i can add some to tox12:01
sean-k-mooneywell the install line in tox.ini12:01
sean-k-mooneyhttps://paste.opendev.org/show/bbCcX0QUpd3RdqD5jUTt/12:02
sean-k-mooneyi think all that is wrong is i dont have the required bindep or dev libs installed to allow it to build12:05
sean-k-mooneyim not sure why it not finding the prebuilt wheel12:05
sean-k-mooneygiven it is using weels for most of the other deps12:05
sean-k-mooneyhttps://etherpad.opendev.org/p/netifaces-py31212:07
sean-k-mooneythats the full output 12:07
sean-k-mooneyit might be somethign to do with the version of pip or settuptools and pyproject.toml or something like that12:08
sean-k-mooneyit looks like its beign pull in by oslo.utils and barbican-client12:09
sean-k-mooneyanyway that a problem for another day im going to go back to fixing iso supprot which means we need 2 new format detectors, for http://wiki.osdev.org/ISO_9660 and http://wiki.osdev.org/UDF although one is an exteion of the other12:13
fricklerfwiw I can also build from source on noble without issues (after running devstack, so that may have installed some necessary deps)12:15
sean-k-mooneyyep proably12:15
sean-k-mooneyif i was using one of my dev vms it would be fine i suspect12:16
sean-k-mooneyill likel move to one of the shortly as eventrually ill need to do some testing with devstack too12:16
fricklerbauzas: Uggla: auniyal: please check https://review.opendev.org/c/openstack/releases/+/923118 which is due today12:19
opendevreviewsean mooney proposed openstack/nova master: repoduce iso regression with deep format inspection  https://review.opendev.org/c/openstack/nova/+/92350712:57
*** iurygregory_ is now known as iurygregory13:02
sahido/13:31
sahidany chance that you re-approve https://review.opendev.org/c/openstack/nova/+/92166513:31
sahidi had to rebase13:32
sean-k-mooneydone14:14
opendevreviewBence Romsics proposed openstack/os-vif master: Do not add taps in trunk bridges to the dead vlan  https://review.opendev.org/c/openstack/os-vif/+/92303614:43
opendevreviewBalazs Gibizer proposed openstack/nova stable/2024.1: Reject qcow files with data-file attributes  https://review.opendev.org/c/openstack/nova/+/92327315:22
opendevreviewBalazs Gibizer proposed openstack/nova stable/2024.1: Check images with format_inspector for safety  https://review.opendev.org/c/openstack/nova/+/92327415:22
opendevreviewBalazs Gibizer proposed openstack/nova stable/2024.1: Additional qemu safety checking on base images  https://review.opendev.org/c/openstack/nova/+/92327515:22
opendevreviewBalazs Gibizer proposed openstack/nova stable/2024.1: Fix vmdk_allowed_types checking  https://review.opendev.org/c/openstack/nova/+/92327615:22
*** bauzas_ is now known as bauzas15:23
opendevreviewMerged openstack/nova master: Fix vmdk_allowed_types checking  https://review.opendev.org/c/openstack/nova/+/92325815:32
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.2: Reject qcow files with data-file attributes  https://review.opendev.org/c/openstack/nova/+/92328415:33
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.2: Check images with format_inspector for safety  https://review.opendev.org/c/openstack/nova/+/92328515:33
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.2: Additional qemu safety checking on base images  https://review.opendev.org/c/openstack/nova/+/92328615:33
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.2: Fix vmdk_allowed_types checking  https://review.opendev.org/c/openstack/nova/+/92328715:33
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.1: Reject qcow files with data-file attributes  https://review.opendev.org/c/openstack/nova/+/92328815:44
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.1: Check images with format_inspector for safety  https://review.opendev.org/c/openstack/nova/+/92328915:44
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.1: Additional qemu safety checking on base images  https://review.opendev.org/c/openstack/nova/+/92329015:44
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.1: Fix vmdk_allowed_types checking  https://review.opendev.org/c/openstack/nova/+/92329115:44
opendevreviewAndrei Yachmenev proposed openstack/nova master: Fix processing uniqueness of instance host names  https://review.opendev.org/c/openstack/nova/+/92339516:45
fricklertwo failures on one of the 2024.1 cve backports, not sure if someone's still around to check these and also possibly approve the whole stack?17:52
fricklerhttps://review.opendev.org/c/openstack/nova/+/923274/217:52
dansmithfrickler: looks like the instance booted fine to me, so I'd expect that's typical "sometimes we can't ssh to the guest" problems17:55
dansmithwant me to recheck?17:56
fricklerfrickler: either recheck or if you want to approve the check, I can also enqueue into gate directly, the V-1 is ignored then17:56
fricklers/check/stack/17:57
dansmithoh I see it's missing votes17:58
dansmithfrickler: green all the way down on 2024.1 now, I didn't recheck if you want to promote, but left the reason there too18:01
fricklerI won't promote, as that would reset the glance stack currently merging, but just enqueue into gate, which isn't too full right now I'd hope18:05
opendevreviewMohammed Naser proposed openstack/nova master: Fix port group network metadata generation  https://review.opendev.org/c/openstack/nova/+/92353018:11
dansmithI meant s/promote/treat specially/ but yeah, cool18:13
opendevreviewAndrei Yachmenev proposed openstack/nova master: Fix processing uniqueness of instance host names  https://review.opendev.org/c/openstack/nova/+/92339518:22
opendevreviewsean mooney proposed openstack/nova master: [WIP] add iso file format inspector  https://review.opendev.org/c/openstack/nova/+/92353319:11
*** bauzas_ is now known as bauzas19:30
opendevreviewsean mooney proposed openstack/nova master: [WIP] add iso file format inspector  https://review.opendev.org/c/openstack/nova/+/92353320:03
opendevreviewMerged openstack/nova master: port format inspector tests from glance  https://review.opendev.org/c/openstack/nova/+/92350420:51
opendevreviewMerged openstack/nova stable/2024.1: Reject qcow files with data-file attributes  https://review.opendev.org/c/openstack/nova/+/92327321:35
opendevreviewMerged openstack/nova stable/2024.1: Check images with format_inspector for safety  https://review.opendev.org/c/openstack/nova/+/92327421:35
opendevreviewMerged openstack/nova stable/2024.1: Additional qemu safety checking on base images  https://review.opendev.org/c/openstack/nova/+/92327521:35
opendevreviewMerged openstack/nova stable/2024.1: Fix vmdk_allowed_types checking  https://review.opendev.org/c/openstack/nova/+/92327621:36
opendevreviewMerged openstack/nova master: api: Migrate to JSON Schema Draft 2020-12  https://review.opendev.org/c/openstack/nova/+/91584521:36
fungilooks like all the ossa-2024-001 nova patches for master and stable/2024.1 have merged now, changes for older branches are still lacking approvals22:14
fungiglance will be in a similar state as soon as the one change that bounced out earlier merges (i've tossed it back into the gate)22:15
fungicinder's are all merged at this point22:15
opendevreviewMerged openstack/nova master: api: Correct bug in flavors schema  https://review.opendev.org/c/openstack/nova/+/92314423:06
opendevreviewMerged openstack/nova master: api: Add 'removed' decorator  https://review.opendev.org/c/openstack/nova/+/91573623:12
opendevreviewMerged openstack/nova master: api: Don't do version check if nothing required  https://review.opendev.org/c/openstack/nova/+/91573723:12

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!