Thursday, 2024-08-08

opendevreviewmelanie witt proposed openstack/nova master: DNM testing  https://review.opendev.org/c/openstack/nova/+/92563503:14
opendevreviewmelanie witt proposed openstack/nova master: DNM testing  https://review.opendev.org/c/openstack/nova/+/92563503:17
opendevreviewmelanie witt proposed openstack/nova master: DNM testing cont'd  https://review.opendev.org/c/openstack/nova/+/92583805:12
*** bauzas_ is now known as bauzas05:15
*** bauzas_ is now known as bauzas05:37
*** bauzas_ is now known as bauzas07:33
opendevreviewJens Harbott proposed openstack/nova stable/2023.1: Drop Fedora support  https://review.opendev.org/c/openstack/nova/+/92594007:41
*** bauzas- is now known as bauzas09:30
*** bauzas_ is now known as bauzas09:41
opendevreviewsean mooney proposed openstack/nova master: update nova-next to use ubuntu 24.04  https://review.opendev.org/c/openstack/nova/+/92249210:48
*** dmitriis is now known as Guest249610:50
opendevreviewsean mooney proposed openstack/nova master: Test live migration between hosts with differnet cpu_shared_sets  https://review.opendev.org/c/openstack/nova/+/91374411:10
opendevreviewsean mooney proposed openstack/nova master: enable numa live migration in the ceph job  https://review.opendev.org/c/openstack/nova/+/91384211:12
fricklersean-k-mooney: gibi: if you have a moment for fedora cleanup on 2023.1 please check https://review.opendev.org/c/openstack/nova/+/92594011:33
sean-k-mooneyfrickler: +2 on ^11:42
fricklerty11:44
elodillesfrickler: +2+W'd11:52
elodilles(though it was a bit hard to see the change because of the tons of zuul warnings :S i'd appreciate if stable cores would review this patch that eliminates these distracting warnings: https://review.opendev.org/c/openstack/nova/+/925522 & the stable/2023.* versions o:))12:00
sean-k-mooneyelodilles: i was wondering if we had merged that on master when i saw them too12:06
sean-k-mooneybut sure lets get that fixed12:06
fricklersince this is a pure zuul config change, I've taken my stable-release hat to approve. please complain if you feel that that is inappropriate12:15
sean-k-mooneyno i think thats fine. i considered single core approving anyway since the patch is proposed by another stable core12:16
sean-k-mooneywe do technially allow that it just does not come up often, if elodilles: pinged again next week and no one else had reviewed i proably would have elevated to +w12:17
sean-k-mooneywe dont techinally have a required delay i just prefer to wait 7-30 days before using the single core approval excptions unless its urgent12:18
elodillessean-k-mooney frickler : thanks o:)12:25
elodillesfrickler: yepp, it's pure zuul config change so your review is welcome \o/12:26
sean-k-mooneyonce that merged ill try and swing back to the older backprots but it would be nice to make progress on that12:29
elodillesthanks in advance o/12:30
*** bauzas- is now known as bauzas12:56
fricklermeh, gate is being nasty again today :(13:57
elodillesyepp :/14:03
opendevreviewDan Smith proposed openstack/nova master: Use format_inspector from oslo  https://review.opendev.org/c/openstack/nova/+/92502514:17
opendevreviewDan Smith proposed openstack/nova master: DNM: Test against oslo.utils  https://review.opendev.org/c/openstack/nova/+/92502614:17
opendevreviewArtom Lifshitz proposed openstack/nova master: POC/DNM: Remove vTPM live migration block  https://review.opendev.org/c/openstack/nova/+/92577114:56
opendevreviewArtom Lifshitz proposed openstack/nova master: POC/DNM: Remove vTPM live migration block  https://review.opendev.org/c/openstack/nova/+/92577114:58
fricklernext gate fail, same job, same test afaict https://zuul.opendev.org/t/openstack/build/f1b55b06740345848421fe00a57e72c815:28
johnsomIf a user or operator wanted to set custom NTP servers for an instance using the cloud-init module [1], how would they do that via nova? Is that something that can go in a flavor?16:37
johnsom[1] https://cloudinit.readthedocs.io/en/latest/reference/modules.html#ntp16:37
*** bauzas_ is now known as bauzas16:39
dansmithjohnsom: not sure, but I guess that cloud config yaml goes in vendor data: https://cloudinit.readthedocs.io/en/latest/reference/datasources/openstack.html#vendor-data16:40
sean-k-mooneyyou might be able to set it on the neutron network16:41
sean-k-mooneyvia dhcp options?16:41
sean-k-mooneyif a user wnated to do ti then ya user-data and cloud init would be the way to do it via nova16:42
sean-k-mooneyfor an operator16:42
dansmithoh or I guess you can put the cloud config in userdata too?16:42
sean-k-mooneyyou might be able to do that with vendor data16:42
johnsomI don't think so, cloud-init usually takes precedence over DHCP options. Via DHCP is usually disabled by default.16:42
sean-k-mooneyjohnsom: right but i woudl not expect cloud-init to configure this by defualt16:42
sean-k-mooneyso if its set in dhcp options on the neutron network16:43
sean-k-mooneythen that shoudl take precidence of the defualt behavior of cloud-init which should be do nothign16:43
dansmithsean-k-mooney: the example he's asking about is _how_ to set it with cloud-init16:43
johnsomI can look in RHEL, but I'm pretty sure it defaults to no using the DHCP options unless you enable it16:43
sean-k-mooneyok well clodu init can executat arbitary bash via user-data or you woudl ue there module with cloud config if it exits16:44
dansmithhe linked the module above16:44
dansmiththat's what he's asking about16:44
sean-k-mooneyyep in to personas16:44
sean-k-mooneyas a user you use user-data16:44
johnsomYeah, there is a module. I'm just not sure how to configure nova for it. Ideally on a flavor basis16:44
sean-k-mooneyas a operator you might be able to use static vendro data or dynamic vendor data ot do it16:45
sean-k-mooneydansmith:  the cloud init docs document something we do not support16:45
sean-k-mooneyhttps://cloudinit.readthedocs.io/en/latest/reference/datasources/openstack.html#vendor-data16:45
sean-k-mooneythere was a whole discussion about that a few mounts back16:45
dansmithjohnsom: no way to do it per-flavor that I know of16:45
sean-k-mooneyi provide a way to hack that16:46
sean-k-mooneyto make it work16:46
sean-k-mooneybut we do not offically supprot passing cloud init cloud config vai vendor data today16:46
johnsomBummer, flavor would have been perfect in this case16:46
sean-k-mooneyhttps://github.com/canonical/cloud-init/issues/522116:46
sean-k-mooneyjohnsom: nova should not do networking16:46
sean-k-mooneyor software configuration in guests16:46
sean-k-mooneywhich is why you cant do this in the falvor16:47
johnsomAgree, but I think it should be able to configure cloud-init metadata16:47
sean-k-mooneythat woudl be a new feature and im not sure users woudl agree16:47
dansmithsean-k-mooney: I'm not sure why you say we don't support it via vendordata, but if you've got a link I'd be glad to read it16:47
johnsomAgree, it sounds like it would be a new feature. Bummer16:48
sean-k-mooneydansmith: tldr we require the vendor data to be in a format that is diffent form what cloud in it requries16:48
sean-k-mooneydansmith: the require a key at the top level of the resonce to be "cloud-init"16:48
sean-k-mooneythe top level key we requried is the vendor data provider16:49
sean-k-mooneydansmith: i explain it here https://github.com/canonical/cloud-init/issues/522116:49
dansmithcool, I'll check it out16:50
dansmithshould be fine to use via userdata though, AFAIK16:50
sean-k-mooneyyep usere data will work for a user just no offical way to make it work at the operator level 16:50
johnsomThis seems like a common edge use case, to configure instances via cloud-init for local services like NTP or to point instances to specific endpoints.16:51
sean-k-mooneyhowever when i was explinging this they had already started https://review.opendev.org/c/openstack/nova-specs/+/91710916:51
sean-k-mooneyjohnsom: so the neutron subnet allwos you to configure dns server via dhcp options16:51
sean-k-mooneyi dont see why it could not supprot ntp16:51
dansmithbecause dns is widely accepted and sort of necessary :)16:52
sean-k-mooneywell they aslo supprot static routes16:52
dansmithyeah, not everyone accepts those via dhcp either16:52
sean-k-mooneyim just saying there are other dhcp options and neutron could have a facility to allow you to specify them for the network16:52
sean-k-mooneysure just providing another way to do the same usecase16:52
johnsomAnother quick (?) question, is there a way to set the hw_vif_model setting other than a property on the image? Like at instance creation time?16:53
dansmiththis seems well in scope for a cloud-init thing to me16:53
sean-k-mooneyi was thinkign of the pxe boot usecase peopel had in the past16:53
sean-k-mooneyhttps://docs.openstack.org/api-ref/network/v2/index.html#id31516:53
johnsomYeah, the problem with the DHCP options isn't necessarily neutron, but the distributions not enabling them16:53
sean-k-mooneyjohnsom: the problem with the flavor is the image might not have cloud-init16:54
johnsomhw_vif_model question is around using the igb driver for SR-IOV testing in nodepool16:54
sean-k-mooneyso it was on my list of things to enable and i just have not got ot it16:55
sean-k-mooneybut i too want ot add that16:55
johnsomWell, in our world they have cloud-init16:55
sean-k-mooneyour being? its not alwasy there for openstack workloads in general16:55
sean-k-mooneythink workload like core os or talos linux16:56
sean-k-mooneyor windows if they dont have the cloud base init fork16:56
johnsomour being Octavia amphora images.16:56
sean-k-mooneyah16:56
sean-k-mooneywell for octavia since your creating the instnaces you can simply pass user-data with your cloud config settings16:56
sean-k-mooneyjohnsom: if you think nova should supprot this vai vendor data you should read and comment on https://review.opendev.org/c/openstack/nova-specs/+/917109/6/specs/2024.2/approved/dynamicjson-vendordata-cloud-config.rst16:57
sean-k-mooneyi feel like i put that on the ptg adjenda for the last one16:58
sean-k-mooneybut i dont recall if we had time to disucss it16:58
johnsomThat is less than ideal in this customer use case. They as the operator wants to configure it in a way they can point at different endpoints based on the flavor used.16:59
johnsomBut, yes, looking at the spirit of dynamic vendor data, it could be a solution (assuming it works at some point).16:59
johnsomI think the current answer is, cannot be done.17:00
sean-k-mooneyit can by abusing the json standard17:00
johnsomlol17:00
dansmithyep, seems like the perfect way to handle this, any sort of per-site compute cloud-init stuff being a dynamic vendordata thing that coughs up a blob of config17:00
johnsom+117:00
sean-k-mooneyi help the person that was tryign to get this working make it work by telling them how to do that17:00
sean-k-mooneythe reason for the spec was if we wanted to acutly do this we woudl need to commit to officaly supproting tha tuse case, adding tests and not breaking it17:01
sean-k-mooneyjohnsom: this is how to do it today with nova without code changes https://review.opendev.org/c/openstack/nova-specs/+/917109/6/specs/2024.2/approved/dynamicjson-vendordata-cloud-config.rst17:02
johnsomThough, it would be nice if the flavor ID was passed to the dynamic vendor data service too.17:02
sean-k-mooneywe pass some infor to the vender data like the instance uuid17:02
sean-k-mooneyim not sure what we pass exactly17:03
johnsomhttps://docs.openstack.org/nova/latest/admin/vendordata.html#dynamicjson17:03
sean-k-mooneybut we pass the instance uuid so you can make desions per instance if you want too17:03
dansmithimage but not flavor17:03
dansmithflavor should be in there too I would think17:03
sean-k-mooneyah yes its in the docs17:03
johnsomI guess that service can just make another GET call17:03
sean-k-mooneyso this is all old code form rackspace era17:03
sean-k-mooneythat has kind of bitrotted17:04
johnsomSigh17:04
sean-k-mooneyso it supprots what they needed at the time17:04
sean-k-mooneybut again if peropel want to enhance this we could17:04
sean-k-mooneyjust need a spec to desicbe it and people to do the work17:04
johnsomWell, we are pretty far out of "officially supported" at this point, the immediate answer is going to be "create custom images".17:05
dansmithpretty sure dynamic vendor data is way after rax17:05
sean-k-mooneydansmith: i think it was done by michael still17:06
dansmithit was, but in 201717:06
sean-k-mooneyoh i didn mean as part of the inital code dump17:06
sean-k-mooneyi ment it was implemed by them for the requirement they had17:06
dansmithI know :)17:06
sean-k-mooneyjohnsom: so right now we also dont provide the flavor extra specs adn addign those would be problematic unless we passed them in the post body17:07
sean-k-mooneyso im not really sure how you imagine this being encoded in the flavor17:08
sean-k-mooneyor where you hoping that could be done via custom integrations fo some kind by the opertor using custom extra specs17:08
johnsomI just knew cloud-init had the module and wondered if it could be used via nova. I didn't have a design in mind. Just making sure I wasn't missing some way to do it.17:10
sean-k-mooneyother then what we have discussed the only othe way would be perhaps with a custom network template17:11
sean-k-mooneyhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.injected_network_template17:11
elinuxanyone online yet ?17:12
sean-k-mooneywhich is https://github.com/openstack/nova/blob/master/nova/virt/interfaces.template17:12
elinuxsean-k-mooney: i need a small help regarding scheduler. can you help me please17:13
sean-k-mooneyjohnsom: if you can do it via /etc/network/interfaces you can do it as an admin via that17:13
sean-k-mooneyelinux: perhaps17:13
sean-k-mooneyelinux: what problem are you having17:13
elinuxsean-k-mooney: I am writing a custom filter for scheduler,  so in the process have to access the req object's metadata value, which is not passed in the code by default to the scheduler filter test of host_passes. so I have passed it from build_request object  at the function 'def schedule_and_build_instances' in conductor/manage.py file. I did this by simply doing 'request_specs[0].metadata=build_requests[0].instance.metadata' 17:19
elinuxsean-k-mooney: but when it reached the scheduler manager.py thru the rabbitmq, the spec_obj is loosing the metadata object17:20
elinuxsean-k-mooney: so how to pass this value to spec_obj that it retains for checking it in the filter host_pass ?17:20
sean-k-mooneyyou dont17:21
sean-k-mooneywhile custom out of tree filters can be written17:21
sean-k-mooneythey can only use the contet of the host_state object adn request spec17:21
elinuxsean-k-mooney: why cant we pass it like I suggested ? 17:22
sean-k-mooneyyou can in your fork but its not somehting that woudl be supproted by any disto or upstream17:22
elinuxsean-k-mooney: what is stripping it when it reaches the scheduler ?17:22
elinuxsean-k-mooney: not concerned with the support now. I want it to just make it work for our requirement17:23
elinuxsean-k-mooney: any ideas ?17:23
elinuxsean-k-mooney: how to make object assigments to a class object persistent across functions ?17:24
sean-k-mooneyyes but im not sure i should share them. your asking upstream to help you do somethign we dont supprot :)17:24
sean-k-mooneyso this is the request spec object https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L4617:24
sean-k-mooneywe provide access to the schduler hint and the instance uuid https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L100-L10117:25
sean-k-mooneybut not instance metadata 17:25
sean-k-mooneyso normlaly i woudl ways your filter should use a scheduler hint, flavor extra spec or image property insted17:25
sean-k-mooneyif it must be the server metadata 17:26
sean-k-mooneythe only way to do it form a filter today woudl to abuse pythons dynmic types17:28
elinuxsean-k-mooney: so how about specifying image extra specs and comapring them in the filter ? is that feasible ?17:28
sean-k-mooneybasilly implemnt the singelton patther adn do a db lookup in the filter once and asign the metadta into a dynimcaly created filed in the request spec object17:28
sean-k-mooneyelinux: yep the request spec has a fully copy of the flavor and image17:29
sean-k-mooneyincluding the extra specs17:29
sean-k-mooneyso you can look at either today17:29
sean-k-mooneywe just dont provided instance metadata because per instance schduling filter are ment to use scheuler hints17:30
sean-k-mooneyso that they will be read only once created17:30
sean-k-mooneyelinux: https://docs.openstack.org/nova/latest/reference/scheduler-hints-vs-flavor-extra-specs.html might be useful to read over17:30
elinuxsean-k-mooney: can you explain this a bit further "basilly implemnt the singelton patther adn do a db lookup in the filter once and asign the metadta into a dynimcaly created filed in the request spec object" ?17:30
elinuxsean-k-mooney: but I still the request's metadata information for testing it in the filter, so that I can take a decision based on its value17:34
elinux*but I still need17:34
sean-k-mooneyhttps://paste.opendev.org/show/825009/17:37
sean-k-mooneythats a horbile hack but on the first execution of the filter for a given request spec object you can abuse the fact that python will allow you to assign to filed that dont exist at any time to do the lookup form the buildRequest onece and then pass the same data to all other hosts17:38
sean-k-mooneyfor everyone else watching done ever do that in a out of tree filters that just asking for pain17:40
sean-k-mooneys/done/don't/17:41
opendevreviewMerged openstack/nova stable/2023.1: Drop Fedora support  https://review.opendev.org/c/openstack/nova/+/92594018:20
*** ministry is now known as __ministry18:27
opendevreviewMerged openstack/nova master: libvirt: Remove node device XML validate flags  https://review.opendev.org/c/openstack/nova/+/92582618:32
*** bauzas_ is now known as bauzas19:32
opendevreviewMerged openstack/nova stable/2024.1: [CI] Replace deprecated regex  https://review.opendev.org/c/openstack/nova/+/92552220:38
opendevreviewGoutham Pacha Ravi proposed openstack/nova master: DNM: test dependency on devstack-plugin-ceph changes  https://review.opendev.org/c/openstack/nova/+/91895723:45

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!