*** bauzas_ is now known as bauzas | 05:42 | |
*** bauzas_ is now known as bauzas | 07:08 | |
opendevreview | Tobias Urdin proposed openstack/nova master: Fix retried resize operation failing with FileNotFound https://review.opendev.org/c/openstack/nova/+/926251 | 07:16 |
---|---|---|
opendevreview | Tobias Urdin proposed openstack/nova master: libvirt: Fix retried resize operation failing with FileNotFound https://review.opendev.org/c/openstack/nova/+/926251 | 07:29 |
*** jcosmao is now known as Guest425 | 08:13 | |
opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | 13:10 |
*** bauzas_ is now known as bauzas | 15:01 | |
*** ykarel is now known as ykarel|away | 15:16 | |
opendevreview | Viktor Křivák proposed openstack/nova master: Ensure claims to placement are freed after evacuate complete Improve resource_tracker delete_allocation_for_evacuated_instance to handle non-cached compute hosts Add test to prevent regression https://review.opendev.org/c/openstack/nova/+/926292 | 15:39 |
opendevreview | Markus Hentsch proposed openstack/nova master: Use os-brick for volume attachment passphrases https://review.opendev.org/c/openstack/nova/+/926326 | 16:07 |
opendevreview | Elod Illes proposed openstack/python-novaclient master: DNM: gate health test https://review.opendev.org/c/openstack/python-novaclient/+/926334 | 16:09 |
sean-k-mooney | gibi: i think responding to https://review.opendev.org/c/openstack/nova/+/710848 ate what little brain power i had for today but i tried to find where the save was happeing im just not sure which path it is | 17:02 |
sean-k-mooney | i think its the call to the conductor that trigering the save with the refeshed content | 17:03 |
sean-k-mooney | artom: fyi ^ | 17:03 |
sean-k-mooney | we could try moving the refresh to here https://review.opendev.org/c/openstack/nova/+/710848/6/nova/compute/manager.py#2371 | 17:04 |
sean-k-mooney | which i think would result in it being saved here instead https://review.opendev.org/c/openstack/nova/+/710848/6/nova/compute/manager.py#2260 | 17:04 |
sean-k-mooney | which would be better i think | 17:05 |
sean-k-mooney | can you try that locally | 17:05 |
artom | sean-k-mooney, I saw the comments but since I didn't write the actual patch I have to start from scratch to figure out what's going on | 17:05 |
sean-k-mooney | ok im going to finish in 5 mins but ill try to just move that locally and see if it passes your test case | 17:06 |
sean-k-mooney | ... we have a seperate sqlalchemy 2.0 issue | 17:37 |
opendevreview | sean mooney proposed openstack/nova master: test fixing this when allocation fails. https://review.opendev.org/c/openstack/nova/+/926350 | 17:44 |
sean-k-mooney | artom: ^ passes locally if i run the funciontal tests | 17:44 |
sean-k-mooney | but the serise also need a rebase | 17:44 |
sean-k-mooney | ... | 17:45 |
sean-k-mooney | or you know i could not do that on patchset 6... | 17:45 |
artom | Yeah, that relation chain is... special :) | 17:45 |
opendevreview | sean mooney proposed openstack/nova master: test fixing this when allocation fails. https://review.opendev.org/c/openstack/nova/+/926350 | 17:48 |
sean-k-mooney | ok that should be better | 17:49 |
sean-k-mooney | gibi: ^ i think that is a better fix | 17:50 |
sean-k-mooney | ... or it would be if it didnt fail | 17:50 |
sean-k-mooney | ok im not sure why that didnt work but it did not so im just not goign to look at that today | 17:53 |
opendevreview | Merged openstack/nova master: Skip new image format tests https://review.opendev.org/c/openstack/nova/+/926215 | 17:54 |
sean-k-mooney | oh actully i think i do no | 17:55 |
sean-k-mooney | that not where the excption is being raised | 17:55 |
opendevreview | sean mooney proposed openstack/nova master: test fixing this when allocation fails. https://review.opendev.org/c/openstack/nova/+/926350 | 17:59 |
sean-k-mooney | ^ actully passes locally | 17:59 |
sean-k-mooney | artom: gibi i have left some comments to explain why i think this also work and is cleaner but also why the patch i have is still not ideal | 18:06 |
*** bauzas_ is now known as bauzas | 19:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!