Wednesday, 2024-08-14

*** bauzas_ is now known as bauzas05:42
*** bauzas_ is now known as bauzas07:08
opendevreviewTobias Urdin proposed openstack/nova master: Fix retried resize operation failing with FileNotFound  https://review.opendev.org/c/openstack/nova/+/92625107:16
opendevreviewTobias Urdin proposed openstack/nova master: libvirt: Fix retried resize operation failing with FileNotFound  https://review.opendev.org/c/openstack/nova/+/92625107:29
*** jcosmao is now known as Guest42508:13
opendevreviewTakashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption  https://review.opendev.org/c/openstack/nova/+/92610613:10
*** bauzas_ is now known as bauzas15:01
*** ykarel is now known as ykarel|away15:16
opendevreviewViktor Křivák proposed openstack/nova master: Ensure claims to placement are freed after evacuate complete Improve resource_tracker delete_allocation_for_evacuated_instance to handle non-cached compute hosts Add test to prevent regression  https://review.opendev.org/c/openstack/nova/+/92629215:39
opendevreviewMarkus Hentsch proposed openstack/nova master: Use os-brick for volume attachment passphrases  https://review.opendev.org/c/openstack/nova/+/92632616:07
opendevreviewElod Illes proposed openstack/python-novaclient master: DNM: gate health test  https://review.opendev.org/c/openstack/python-novaclient/+/92633416:09
sean-k-mooneygibi: i think responding to https://review.opendev.org/c/openstack/nova/+/710848 ate what little brain power i had for today but i tried to find where the save was happeing im just not sure which path it is17:02
sean-k-mooneyi think its the call to the conductor that trigering the save with the refeshed content17:03
sean-k-mooneyartom: fyi ^17:03
sean-k-mooneywe could try moving the refresh to here https://review.opendev.org/c/openstack/nova/+/710848/6/nova/compute/manager.py#2371 17:04
sean-k-mooneywhich i think would result in it being saved here instead https://review.opendev.org/c/openstack/nova/+/710848/6/nova/compute/manager.py#226017:04
sean-k-mooneywhich would be better i think17:05
sean-k-mooneycan you try that locally 17:05
artomsean-k-mooney, I saw the comments but since I didn't write the actual patch I have to start from scratch to figure out what's going on17:05
sean-k-mooneyok im going to finish in 5 mins but ill try to just move that locally and see if it passes your test case17:06
sean-k-mooney... we have a seperate sqlalchemy 2.0 issue17:37
opendevreviewsean mooney proposed openstack/nova master: test fixing this when allocation fails.  https://review.opendev.org/c/openstack/nova/+/92635017:44
sean-k-mooneyartom: ^ passes locally if i run the funciontal tests17:44
sean-k-mooneybut the serise also need a rebase17:44
sean-k-mooney...17:45
sean-k-mooneyor you know i could not do that on patchset 6...17:45
artomYeah, that relation chain is... special :)17:45
opendevreviewsean mooney proposed openstack/nova master: test fixing this when allocation fails.  https://review.opendev.org/c/openstack/nova/+/92635017:48
sean-k-mooneyok that should be better17:49
sean-k-mooneygibi: ^ i think that is a better fix17:50
sean-k-mooney... or it would be if it didnt fail17:50
sean-k-mooneyok im not sure why that didnt work but it did not so im just not goign to look at that today17:53
opendevreviewMerged openstack/nova master: Skip new image format tests  https://review.opendev.org/c/openstack/nova/+/92621517:54
sean-k-mooneyoh actully i think i do no17:55
sean-k-mooneythat not where the excption is being raised17:55
opendevreviewsean mooney proposed openstack/nova master: test fixing this when allocation fails.  https://review.opendev.org/c/openstack/nova/+/92635017:59
sean-k-mooney^ actully passes locally17:59
sean-k-mooneyartom: gibi i have left some comments to explain why i think this also work and is cleaner but also why the patch i have is still not ideal18:06
*** bauzas_ is now known as bauzas19:06

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!