| opendevreview | melanie witt proposed openstack/nova master: docs: Show the recommended way to PXE boot an instance https://review.opendev.org/c/openstack/nova/+/928309 | 00:27 |
|---|---|---|
| *** bauzas_ is now known as bauzas | 01:17 | |
| *** bauzas_ is now known as bauzas | 01:37 | |
| *** __ministry is now known as Guest2658 | 01:41 | |
| *** dtantsur_ is now known as dtantsur | 01:57 | |
| *** bauzas_ is now known as bauzas | 02:06 | |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] Add functional repoducer for ephemeral disks https://review.opendev.org/c/openstack/nova/+/928310 | 02:11 |
| *** bauzas_ is now known as bauzas | 02:35 | |
| *** bauzas_ is now known as bauzas | 02:51 | |
| *** bauzas_ is now known as bauzas | 02:59 | |
| *** bauzas_ is now known as bauzas | 03:12 | |
| *** bauzas_ is now known as bauzas | 03:20 | |
| *** bauzas_ is now known as bauzas | 04:50 | |
| *** bauzas_ is now known as bauzas | 05:55 | |
| *** chuanm2 is now known as chuanm | 06:24 | |
| *** bauzas_ is now known as bauzas | 07:17 | |
| *** bauzas_ is now known as bauzas | 07:30 | |
| *** chuanm2 is now known as chuanm | 08:04 | |
| elodilles | melwitt: sean-k-mooney explained perfectly o:) thanks sean-k-mooney o/ | 08:10 |
| *** bauzas- is now known as bauzas | 08:40 | |
| *** bauzas_ is now known as bauzas | 09:09 | |
| *** bauzas_ is now known as bauzas | 09:49 | |
| *** bauzas_ is now known as bauzas | 09:57 | |
| *** bauzas_ is now known as bauzas | 10:27 | |
| *** bauzas_ is now known as bauzas | 10:43 | |
| opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | 11:07 |
| *** bauzas_ is now known as bauzas | 11:49 | |
| *** bauzas_ is now known as bauzas | 12:09 | |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/os-vif/+/928353 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/os-vif/+/928355 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/os-vif/+/928356 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/osc-placement/+/928358 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/osc-placement/+/928359 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/osc-placement/+/928360 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/python-novaclient/+/928363 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/python-novaclient/+/928364 | 13:08 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/python-novaclient/+/928366 | 13:08 |
| sean-k-mooney | dansmith: so i tought i had a fix for https://review.opendev.org/c/openstack/nova/+/928310/1/nova/tests/functional/regressions/test_bug_backing_file_partion_tables.py | 13:38 |
| sean-k-mooney | and then whe i treid it i reasised that its more complex then i hoped | 13:39 |
| sean-k-mooney | tl;dr is the mbr/gpt inspector is not only looking for a gpt partion table to exist its also looking for a os partion | 13:39 |
| sean-k-mooney | for epmeral and swap disk that is not really a valid expecatoin | 13:40 |
| sean-k-mooney | so just addign a gpt tabel and vfat partion is not enough to pass the safty check | 13:40 |
| dansmith | It's not looking at the gpt part at all, | 13:42 |
| dansmith | it's looking at the PMBR to make sure you have the right single entry | 13:42 |
| sean-k-mooney | yes its looking at the mbr part | 13:42 |
| dansmith | the mbr needs to have at least one partition that is not type EE, or a single type EE starting at the first sector | 13:44 |
| sean-k-mooney | i likely can make that happen | 13:44 |
| sean-k-mooney | but using our existign create partion tbale and create partion functions didnt seam to be enough | 13:45 |
| dansmith | can you show me fdisk -l of what we create? | 13:45 |
| sean-k-mooney | sure ill need to recreate the image but ill chuck taht in termbin in a sec | 13:46 |
| sean-k-mooney | https://termbin.com/86m6 | 13:49 |
| sean-k-mooney | i can get it to pass the first test_create_file but not test_cache_file | 13:49 |
| opendevreview | Merged openstack/os-vif master: Update master for stable/2024.2 https://review.opendev.org/c/openstack/os-vif/+/928356 | 13:49 |
| dansmith | okay that doesn't show the mbr part because it skips right over, but must have a real pmbr | 13:50 |
| dansmith | can you grab just the first like 4k of that and post it for me somewhere? | 13:50 |
| dansmith | (if it's easy) | 13:50 |
| sean-k-mooney | sure i have this running in a debugger adn im stop right after we hcage created the image but before we call mkfs on it | 13:51 |
| sean-k-mooney | im wonder fi that will alter the output but ill grab the first 4k first and then proceed | 13:51 |
| dansmith | hmm, how is mkfs going to run on just the partition of a file? | 13:52 |
| dansmith | ...without kpartx or something | 13:52 |
| sean-k-mooney | im actully expecting it to recreate teh gpt and partion table | 13:52 |
| dansmith | mkfs will definitely not do that | 13:52 |
| sean-k-mooney | ok then we might need to actuly loop mount it | 13:53 |
| dansmith | if you run mkfs on a file it will create a filesystem starting at byte/sector 0 in the file, wiping the table | 13:53 |
| sean-k-mooney | the current code calls mkfs direcly on the file | 13:53 |
| dansmith | okay so maybe we're creating a partition table for the unformatted case, but if we format with a filesystem, we immediately blow that away and then hand the guest a whole-disk filesystem with no partition table? | 13:54 |
| sean-k-mooney | ya so that might be the problem im coing to quickly copy that file and leave mkfs run | 13:54 |
| dansmith | and to be clear, changing that is not easy | 13:54 |
| sean-k-mooney | dansmith: so creating the partition tabel and partion was what i added to try and "fix" this | 13:54 |
| sean-k-mooney | the exisign code just ran mkfs on the file | 13:54 |
| dansmith | oh okay | 13:54 |
| sean-k-mooney | or block device depending on the code path | 13:55 |
| dansmith | but we were creating a fs in the file and that was being detected as GPT? | 13:55 |
| sean-k-mooney | i can comment out my changes and verify i think it was detecated as a flatfile before but when used as a backinf file we expected something differnt | 13:56 |
| sean-k-mooney | its proably better if i copy the files to a file share so you can look at it and also comment out the code i added to see the behavior before and after | 13:56 |
| dansmith | and was this with vfat? because apparently vfat looks a lot like an MBR (unsurprisingly) | 13:57 |
| dansmith | so maybe that inspector needs to look for something specific to not think fat is an MBR | 13:57 |
| sean-k-mooney | ya so i chose vfat for the repoducer beacuse it is what we use if you dont specify a a format in the config and os_type is not set in the galnce image | 13:58 |
| sean-k-mooney | if ostype is set in the glance iamge we will either use ntfs or ext4 but you have everal options for the config option | 13:58 |
| dansmith | lol yep, vfat has a boot record and the same signature as an MBR in the first sector | 13:59 |
| dansmith | thanks a lot 1980s MSFT | 13:59 |
| sean-k-mooney | ok that might be the issue | 14:00 |
| dansmith | "boot record" meaning 16-bit real-mode x86 executable code to show the message "this is not a bootable disk" :D | 14:00 |
| dansmith | I have to run do something but when I get back I'll see what I can do to not be fooled into thinking a vfat is an MBR, but we'll see | 14:00 |
| dansmith | still seems like we should be able to skip the backing file and skip the safety check on blank disks we create ourselves | 14:01 |
| sean-k-mooney | well we have a few options but ya lets talk about it later | 14:01 |
| dansmith | brb | 14:01 |
| sean-k-mooney | yep i was also goign to explore that route by adding a flag to the image backend create_image to say if we should safty check it | 14:02 |
| sean-k-mooney | but before doing that i wanted to see if i could avoid chaning the interface | 14:02 |
| sean-k-mooney | https://fileshare.seanmooney.info/ephemeral_before_mkfs.img and https://fileshare.seanmooney.info/ephemeral_after_mkfs.img are teh relevent images, so the mkfs call undid what i was trying to do so that what nova produces today | 14:04 |
| sean-k-mooney | this is the fdisk output https://termbin.com/bvvp | 14:05 |
| sean-k-mooney | i renamed the files to .img and fixed the hardcoded extion im doing localy so ignore the fact it refecnce .qcow in the output | 14:06 |
| sean-k-mooney | we alway use raw backing files for epmeral disks | 14:06 |
| sean-k-mooney | well or ploop for openvz but we can ignore that | 14:07 |
| sean-k-mooney | that proably broken too now but i dont think we care as much | 14:07 |
| sean-k-mooney | we have not had any testing of openvz/Virtuozzo supprort for years so its unlikely that even still works without this | 14:08 |
| dansmith | yeah, mkfs will definitely overwrite the partition table bits, the problem is vfat creates one again itself and adds a boot record (because it's actually a partition within a partition) | 14:20 |
| dansmith | so this should not fail if you choose extN right? | 14:20 |
| sean-k-mooney | ill check but i dont expect it to no, im just tryin gto figure out how to confirm that since the funcitonl test sute is complaining about privespe when i change the default | 14:24 |
| sean-k-mooney | oh | 14:24 |
| sean-k-mooney | no thats ok | 14:24 |
| sean-k-mooney | it failed after the safty check | 14:24 |
| sean-k-mooney | we call _update_utime_ignore_eacces(base) after the safty checks | 14:25 |
| sean-k-mooney | so ya the inspecotr for ext4 returns RawFileInspecotr instead of the mbr/gpt one | 14:26 |
| sean-k-mooney | dansmith: so i had a proposal to change our default to not format ephmeral disk | 14:27 |
| sean-k-mooney | if i was to quickly implemnte that and wrap the mkfs call in an if then that woudl work for the default case | 14:28 |
| sean-k-mooney | althernitivly i guess we coudl add a vfat inspector? or special case that in the mbr/gpt one | 14:28 |
| dansmith | it's not that we need a vfat inspector, it's that we'd need the gpt one to not detect the vfat VBR as an MBR, or not obsess over the lack of partitions | 14:30 |
| dansmith | or ideally, just not if it thinks it's a VBR instead of an MBR | 14:30 |
| sean-k-mooney | i would prefer not to need to update oslo for this if we can avoid it but there are workaroudn that we can suggest to people in the interim | 14:30 |
| dansmith | I'm looking into options | 14:30 |
| dansmith | well, again, we shouldn't need to be inspecting blank images we're creating at all | 14:30 |
| dansmith | so that's the non-oslo fix | 14:30 |
| sean-k-mooney | right so i can implemant that with a new parmater to create_image in the image backend and default inspect_backingfile to true | 14:31 |
| sean-k-mooney | then explcitly set it to false for epmeral disks | 14:31 |
| sean-k-mooney | or ephmeral but only when vfat | 14:32 |
| dansmith | all ephemeral should be fine I think | 14:32 |
| sean-k-mooney | if we are ok with that approch ill stop trying ot make it pass and just swap to tuning it off for now when we are creating blank images | 14:32 |
| dansmith | but yeah, that's really what we want to do I think and I'll work in parallel to stop the detection just in case anyone uses a raw vfat in a glance parition | 14:33 |
| dansmith | *image | 14:33 |
| sean-k-mooney | dansmith: are you ok with defering stoping creatin backing files for epmereal disks to the larger image backend refactor | 14:33 |
| dansmith | certainly deferring it past the targeted fix for this | 14:34 |
| sean-k-mooney | ack | 14:34 |
| dansmith | and yeah, I think continuing to slice the current backend is just asking for trouble, even for something smallish like not using backing files I think | 14:34 |
| sean-k-mooney | i feel like while i coudl make it work it woudl be more error prone espcialy when it compes to move ops and upgrade behavior | 14:35 |
| dansmith | yeah | 14:36 |
| dansmith | sean-k-mooney: are you okay with excluding images of floppy disks? | 14:43 |
| dansmith | I don't mean a fake image you created to boot from floppy, but like an actual dd image of a floppy created on MS-DOS 6 or something | 14:43 |
| sean-k-mooney | yes im also happy with droping floopy drive supprot form hw_disk_bus if we have not already | 14:43 |
| dansmith | AFAIK, qemu dropped floppy support a while back anyway right? | 14:44 |
| sean-k-mooney | it did in q35 | 14:44 |
| dansmith | ah okay | 14:44 |
| sean-k-mooney | and i think we did downstream | 14:44 |
| sean-k-mooney | btu not sure about upstream with pc | 14:44 |
| dansmith | well, we could check a range, but I think it's easier if we just check for the descriptor that says "this was created on a hard disk" | 14:44 |
| dansmith | sean-k-mooney: https://review.opendev.org/c/openstack/oslo.utils/+/928448 | 14:53 |
| dansmith | I will get a test image up too | 14:54 |
| sean-k-mooney | im using oslo.utils form a local git repo so i can apply that and test it in my funcitonal test | 14:56 |
| *** bauzas_ is now known as bauzas | 14:57 | |
| dansmith | cool | 14:57 |
| sean-k-mooney | Switched to branch "review/dan_smith/cut-the-fat" :) | 15:01 |
| dansmith | you're welcome :) | 15:01 |
| gibi | lol | 15:02 |
| opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with FAT image https://review.opendev.org/c/openstack/nova/+/928451 | 15:11 |
| dansmith | sean-k-mooney: we'll make sure this ^ fails the same way you're seeing with ephemeral and then add in the oslo change to see that it cures | 15:11 |
| sean-k-mooney | dansmith: sorry was on a call, so if i include your oslo fix and revert back to vfat it seams to be working. its failing at the same point where it tries to use privesep post the safty check | 16:25 |
| sean-k-mooney | ill look a little closer now and confirm | 16:25 |
| sean-k-mooney | ok so ya the inspector is now RawFileinspector when using vfat | 16:27 |
| dansmith | cool | 16:28 |
| dansmith | sean-k-mooney: if you could file a bug with the fail/trace it would be good to get that attached to the oslo fix when we ask for the merge/release | 16:29 |
| dansmith | unless.. is it in the zuul results from your repro change? | 16:29 |
| dansmith | ah, I got it | 16:30 |
| dansmith | I can file the bug then | 16:30 |
| sean-k-mooney | ok i was going to try and do it before i finsih for today but eys its in the zuul change | 16:30 |
| dansmith | I got it, you should weekend | 16:30 |
| sean-k-mooney | one thing we could try is we could update the dnm patch to depned on the oslo one and try and run the expermintal job | 16:31 |
| sean-k-mooney | im not sure that will work but i planned to do that when working on the nova change to not run the inspection on ephmeral disks | 16:31 |
| dansmith | I will after it fails, | 16:31 |
| dansmith | I wanted one run repro'ing the problem with the dedicated test image | 16:32 |
| sean-k-mooney | ack, we might need other zuul config to make depens on to oslo.utils work and at present the job cant run form oslo.utils on nova but we can figure all that out next week | 16:33 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add igb value to hw_vif_model image property https://review.opendev.org/c/openstack/nova/+/928456 | 16:33 |
| dansmith | required_projects should just work | 16:33 |
| *** bauzas_ is now known as bauzas | 16:35 | |
| sean-k-mooney | gibi: :) as an fyi we shoudl also add a trait here https://github.com/openstack/os-traits/blob/master/os_traits/compute/net.py#L26-L38 | 16:35 |
| dansmith | tempest.api.image.v2.test_images_formats.ImagesFormatTest.test_compute_rejects_invalid(fat-vbr) [19.473212s] ... FAILED | 16:35 |
| dansmith | as expected ^ | 16:35 |
| gibi | sean-k-mooney: yeah there is a bunch of TODOs | 16:35 |
| gibi | but good point I missed that so far | 16:36 |
| sean-k-mooney | gibi: it wont break without it but it needed to make the image metadata prefileter be able to select host with igb support | 17:06 |
| sean-k-mooney | gibi: if i recall correctly when we try to generate requried traits we check if its a knwo valide trait ad drop the request if we dont find a match | 17:07 |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] adapt to vfat support in oslo.utils https://review.opendev.org/c/openstack/nova/+/928462 | 17:17 |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] Add functional repoducer for ephemeral disks https://review.opendev.org/c/openstack/nova/+/928310 | 17:19 |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] adapt to vfat support in oslo.utils https://review.opendev.org/c/openstack/nova/+/928462 | 17:19 |
| opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with FAT image https://review.opendev.org/c/openstack/nova/+/928451 | 17:25 |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] Add functional repoducer for ephemeral disks https://review.opendev.org/c/openstack/nova/+/928310 | 17:26 |
| opendevreview | sean mooney proposed openstack/nova master: [WIP] adapt to vfat support in oslo.utils https://review.opendev.org/c/openstack/nova/+/928462 | 17:26 |
| sean-k-mooney | ill take a look on monday at actuly doing what we said to not need th oslo release but https://review.opendev.org/c/openstack/nova/+/928462 will at least try and test test with your oslo patch | 17:26 |
| sean-k-mooney | i added dosfstools to bindep for now as a test requirement so hopefully that will fix the functional job an allow the test to pass | 17:27 |
| *** bauzas_ is now known as bauzas | 17:28 | |
| sean-k-mooney | anyway enjoy your weekend folks o/ | 17:28 |
| dansmith | sean-k-mooney: cool thanks see you monday | 17:31 |
| *** bauzas_ is now known as bauzas | 17:36 | |
| opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with FAT image https://review.opendev.org/c/openstack/nova/+/928451 | 17:37 |
| *** bauzas_ is now known as bauzas | 17:56 | |
| * artom tries really hard to propose a "DNM: Test with SKINNY image" patch | 18:21 | |
| artom | *to avoid proposing | 18:21 |
| dansmith | artom: yeah, all manner of puns ahead | 19:10 |
| JayF | You know, when I saw that comment, my thought was "oh god there's another image type?!" and completely missed the joke :D | 19:17 |
| dansmith | JayF: does ironic support any naked vfat images for anything? | 19:18 |
| JayF | no | 19:18 |
| JayF | I saw your commit in oslo utils, I don't think it'd impact ironic | 19:18 |
| dansmith | it certainly won't yet because you're using the earlier stuff which doesn't detect MBRs, but yeah I was just wondering if you might have any false positives from some case you do support | 19:19 |
| dansmith | it's really silly that we format ephemerals at all, but especially silly that we will format them as FAT32 just so windows guests would have something to see, even though it's totally useless to them | 19:19 |
| *** bauzas_ is now known as bauzas | 20:04 | |
| *** bauzas_ is now known as bauzas | 20:16 | |
| opendevreview | Merged openstack/nova stable/2023.2: hardware: Correct log https://review.opendev.org/c/openstack/nova/+/927473 | 21:06 |
| zigo | Howdy here! New fun OpenStack cli tool: https://salsa.debian.org/openstack-team/clients/oscs | 21:16 |
| *** bauzas_ is now known as bauzas | 22:26 | |
| *** bauzas_ is now known as bauzas | 22:42 | |
| opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | 23:10 |
| *** bauzas_ is now known as bauzas | 23:32 | |
| *** bauzas_ is now known as bauzas | 23:40 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!