| opendevreview | Takashi Kajinami proposed openstack/placement master: Drop db migration tool https://review.opendev.org/c/openstack/placement/+/932324 | 01:40 |
|---|---|---|
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2024.2: Revert "Test live migration between hosts with differnet cpu_shared_sets" https://review.opendev.org/c/openstack/nova/+/932379 | 07:02 |
| gibi | sean-k-mooney[m]: melwitt: I skimmed the discussion above above about the threading in scatter gather. Yes, my comment about the timer was only about the proposed native thread based code. | 07:17 |
| gibi | also please note in native threading there is no such thing that having a timer in an existing thread. The timer itself is always a seperate thread (with basically a sleep and a callback). So if we want a threading.timer based solution to signal an existing thread we need a communication channel between the timer thread that runs our callback on timeout and the existing thread that needs the timer | 07:19 |
| gibi | signal. The most simple thing is to share an Event between the two threads. All the solution needs the existing thread to monitor some channel (e.g. the Event) periodically. | 07:19 |
| sean-k-mooney[m] | an event wont work as far as im aware since the event wont raise an excpetion unless we check it | 07:31 |
| sean-k-mooney[m] | also isint the time just a syscall to the OS to have the OS signal the thread after a timer interupt fires | 07:31 |
| sean-k-mooney[m] | hum, maybe a https://docs.python.org/3/library/threading.html#threading.Barrier is closer to what we want | 07:36 |
| sean-k-mooney[m] | the main issue is we dont really have a concpet of a frestandign cancelable task | 07:36 |
| sean-k-mooney[m] | that what we really want | 07:36 |
| opendevreview | Michael Still proposed openstack/nova-specs master: Repropose spice-direct console support. https://review.opendev.org/c/openstack/nova-specs/+/932387 | 07:45 |
| sean-k-mooney[m] | gibi: the first example here https://www.geeksforgeeks.org/python-different-ways-to-kill-a-thread/ could be adapted for our use | 07:46 |
| sean-k-mooney[m] | we can wrap the function into a calss with an overloaded call operator and add a function to raise the excption | 07:47 |
| sean-k-mooney[m] | then we can use the current timeout code to invoke that function if it expires | 07:47 |
| sean-k-mooney[m] | ill see if i can come up with a restandign example of that and we can see what we think of the approch | 07:54 |
| gibi | sean-k-mooney[m]: threading.Timer is a thread not an OS signal based construct https://github.com/python/cpython/blob/546dddca43a2a69dbe33d230e9e540636b403270/Lib/threading.py#L1318-L1343 | 09:29 |
| sean-k-mooney | gibi: ya i read the docs on it after | 09:30 |
| sean-k-mooney | its a subclass of thread | 09:30 |
| gibi | sean-k-mooney[m]: python has signal handling if we want but that require special care as signal handlers can only run in the main thread and can be tricky to write them properly | 09:30 |
| sean-k-mooney | no im in two minds | 09:30 |
| gibi | https://docs.python.org/3/library/signal.html#signal.SIGALRM | 09:31 |
| sean-k-mooney | part of me wonders if the current approch is corect | 09:31 |
| sean-k-mooney | i.e. are we trying to handle this in too generic a way | 09:31 |
| sean-k-mooney | the only reason this timeout exist sis to timeout the db query to the cell db | 09:31 |
| sean-k-mooney | so im partly wonderign if sqlachemy has a native way to do that | 09:31 |
| gibi | yeah, we can step back and look at the current use case to see if we can reformulate it | 09:32 |
| sean-k-mooney | on the other hand if we dont and we want a generic killable way to execute a task a process is better for that | 09:32 |
| gibi | what we want is a to limit the API response time which a) is limited by the web server (haproxy) already I guess and b) avoid stuck threads waiting for a result that never arrives. | 09:33 |
| sean-k-mooney | yep we have a few options, create a task obejct that will execute an arbitry funciton but kill itself after a timeout, run the function in a process and kill it outselves, convert it to a asyncio corutine and cancel it after a timeout or use somethign in sqlacment to kill it after a timeout at the low level | 09:35 |
| gibi | Do we know how many places in nova we rely on the eventlet in process timer? If it is just 2-3 places then it make sense to do a specific solution for each, if it is more than 5 then I would vote for a creation of a cancellable task primitive and use that everywhere | 09:39 |
| sean-k-mooney | thats a good question. This query_wrapper function is only used in one place i belive | 09:40 |
| sean-k-mooney | im not sure if we have this patterin in ohter however | 09:40 |
| sean-k-mooney | im currently trying to play with creating a BoundTask class to do that | 09:41 |
| sean-k-mooney | maybe TimerTask naming is hard | 09:41 |
| gibi | I guess we have timers in the compute for e.g. vif_plug events | 09:41 |
| sean-k-mooney | yes but it depend on how they are used | 09:42 |
| sean-k-mooney | what i want to do and other can disagree | 09:42 |
| sean-k-mooney | is have our main loop handel pooling for RPC messages | 09:42 |
| sean-k-mooney | but dispatch the message handler to a worker thread pool | 09:43 |
| sean-k-mooney | so basiclaly each RPC handlelr woudl be spawned into its own thread which it can freely block on | 09:43 |
| gibi | I'm not sure how oslo.messaging works in threading mode, I assumed it already does the dispatch of messages to separate threads (from a pool) | 09:43 |
| sean-k-mooney | ya im kind fo hoping it does but not sure either | 09:44 |
| sean-k-mooney | basicaly i want use to be able to safly dispatch connurent work to a seprate io_thread_pool in our functions and block on the returned future | 09:45 |
| gibi | https://docs.openstack.org/oslo.messaging/latest/reference/executors.html#threading | 09:45 |
| gibi | Executor that uses a thread pool to execute calls asynchronously. | 09:45 |
| sean-k-mooney | yes bvut im not sure if that is just submiting it to rabbit | 09:45 |
| sean-k-mooney | i.e. the read/write calls | 09:46 |
| gibi | I think that is the receiving side | 09:46 |
| gibi | the sending side is simply blocking for cast until rabbit takes the message, and blocking for call until the response arrives | 09:47 |
| sean-k-mooney | so if we get this fro free then cool, this may also be externalise in oslo.service | 09:47 |
| sean-k-mooney | this was on my todo list to look at after the removel of our explict use of eventlet.tpool | 09:48 |
| gibi | yepp executors are for receving messages https://github.com/openstack/oslo.messaging/blob/930d97599c0048e84f7c47dca0d62d2cc0562166/doc/source/reference/executors.rst#L12 | 09:49 |
| sean-k-mooney | https://github.com/openstack/oslo.messaging/blob/930d97599c0048e84f7c47dca0d62d2cc0562166/oslo_messaging/server.py#L368 | 09:49 |
| sean-k-mooney | so ok _on_incomming is just submitting the callback to the executor which in threading mode is a threadpool executor form oslo messaging | 09:50 |
| sean-k-mooney | so this is already done for us | 09:50 |
| gibi | yepp it seems so | 09:50 |
| sean-k-mooney | that is what i was hoping for but as i siad i had not confirmed that till now | 09:50 |
| gibi | btw, as you are around, could you do a review round on the igb series https://review.opendev.org/q/topic:%22bp/igb-vif-model%22 the os-traits part is landed released an bumped into both global and nova reqs. | 09:52 |
| gibi | so the nova series is ready to go | 09:52 |
| sean-k-mooney | oh i was not aware we had approved the bluepirnt yet | 10:51 |
| sean-k-mooney | sure i stood up a devstack yesterday so i can pull it in an try it out and give it a test | 10:51 |
| sean-k-mooney | ill see if i can do that later today | 10:52 |
| gibi | thanks. Yes the bp was approved couple of weeks ago | 10:52 |
| sean-k-mooney | ack i vagule remember that but it didnt click that it was ready for review again | 10:52 |
| sean-k-mooney | for some reasoin i tought we were waiting for the ptg but i was proably thinking about somethign else | 10:53 |
| WJeffs1 | Hey, So I was sure I saw an option once, to run a script locally on the HV after a VM is created and the same for deletion? As I'm being overly hopeful or is this actually an option? | 11:14 |
| sean-k-mooney | not in nova but it is in libvirt | 11:14 |
| sean-k-mooney | libvirt has hooks | 11:14 |
| sean-k-mooney | we dont supprot that but it would allow you to do that | 11:14 |
| WJeffs1 | ahh that was probably where I saw it :) I'll dig there thanks! | 11:14 |
| opendevreview | Stephen Finucane proposed openstack/placement master: requirements: Remove setuptools https://review.opendev.org/c/openstack/placement/+/932398 | 11:50 |
| opendevreview | Stephen Finucane proposed openstack/placement master: Add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/placement/+/932399 | 11:50 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | 12:56 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Drop dependency on netifaces https://review.opendev.org/c/openstack/nova/+/931582 | 13:10 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | 13:11 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Drop dependency on netifaces https://review.opendev.org/c/openstack/nova/+/931582 | 13:11 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Drop dependency on netifaces https://review.opendev.org/c/openstack/nova/+/931582 | 13:44 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | 13:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | 13:45 |
| *** bauzas_ is now known as bauzas | 15:24 | |
| bauzas | doh | 16:02 |
| bauzas | I was using the wrong chan (-tc) | 16:02 |
| bauzas | #startmeeting nova | 16:03 |
| opendevmeet | Meeting started Tue Oct 15 16:03:01 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:03 |
| opendevmeet | The meeting name has been set to 'nova' | 16:03 |
| tkajinam | :-) | 16:03 |
| bauzas | hey folks, this time I'm on the right channel :) | 16:03 |
| tkajinam | o/ | 16:03 |
| elodilles | o/ | 16:03 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:03 |
| bauzas | I was wondering why I was getting crickets :) | 16:03 |
| bauzas | so, who's around ? | 16:04 |
| Uggla | o/ | 16:04 |
| bauzas | okay, we can softly start | 16:05 |
| bauzas | #topic Bugs (stuck/critical) | 16:05 |
| bauzas | #info One Critical bug | 16:05 |
| bauzas | #link https://bugs.launchpad.net/nova/+bug/2083518 | 16:05 |
| fwiesel | o/ | 16:05 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:05 |
| bauzas | I'm considering to change the priority of the critical bug to High | 16:05 |
| tkajinam | I downgraded the importance of it as I learned that distutils may be available via setuptools (IIUC) | 16:06 |
| bauzas | oh thanks, all good then | 16:06 |
| tkajinam | However as it is deprecated we definitely need an alternative. As recent python more actively drops things | 16:06 |
| bauzas | we'll have py312 jobs that should see that | 16:06 |
| tkajinam | I started adding something to oslo.utils to replace distutils now and may ping you once that becomes available | 16:06 |
| tkajinam | yeah | 16:06 |
| tkajinam | the tricky thing is that it may not appear as long as we use virtualenv | 16:07 |
| tkajinam | but it appears if you do python -m venv | 16:07 |
| tkajinam | iiuc | 16:07 |
| bauzas | oh, okay, so tox wouldn't see it | 16:07 |
| tkajinam | yup | 16:07 |
| bauzas | and our jobs too, hence why this is not failing in the jobs | 16:07 |
| bauzas | because I guess the tox embedded python version has distutils ? | 16:07 |
| bauzas | s/tox/venv | 16:08 |
| sean-k-mooney | distutils is installable | 16:08 |
| sean-k-mooney | on py312 | 16:08 |
| sean-k-mooney | as a sperate package | 16:08 |
| tkajinam | no but it installs setuptools which brings distutils and pkg_resources | 16:08 |
| tkajinam | but these were kicked out from core python in 3.12 | 16:08 |
| sean-k-mooney | but i belive that is not the case on 3.13 | 16:08 |
| tkajinam | +1 | 16:09 |
| bauzas | so we need to remove that dep from our code | 16:10 |
| bauzas | I'm just sad we don't have any canary in the coal mine | 16:10 |
| sean-k-mooney | https://packages.ubuntu.com/noble/python3-distutils-extra | 16:10 |
| sean-k-mooney | yes eventualy | 16:10 |
| sean-k-mooney | sooner rather then later which is why tkajinam started on it | 16:10 |
| tkajinam | yes :-) | 16:10 |
| sean-k-mooney | our acutal deps on it are somewhat limisted | 16:11 |
| sean-k-mooney | but that is not the same as 0 | 16:11 |
| bauzas | okay, I think this is important to keep that bug report in mind | 16:12 |
| bauzas | I just added the bug report in the 2025.1 status etherpad | 16:13 |
| bauzas | I guess we can move on | 16:13 |
| bauzas | unless someone wants to discuss about another bug report | 16:13 |
| bauzas | okay, moving on | 16:14 |
| bauzas | #topic Gate status | 16:14 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:14 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:14 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:14 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:14 |
| bauzas | #info Please try to provide meaningful comment when you recheck | 16:14 |
| bauzas | the periodics were fine, that's cool | 16:15 |
| bauzas | except placement in stable/yoga but that should be EOM, right? | 16:16 |
| bauzas | elodilles: ^ | 16:16 |
| elodilles | yepp | 16:16 |
| elodilles | hmmm | 16:16 |
| elodilles | i'll add it to my TODO to check what's going on | 16:17 |
| bauzas | thanks | 16:17 |
| bauzas | but is there any reason why we keep CI checking that stable branch ? | 16:17 |
| elodilles | you mean the unmaintained? | 16:18 |
| bauzas | nevermind, my mind blipped | 16:18 |
| bauzas | unmaintained != EOL | 16:18 |
| elodilles | i've proposed some patches that removes periodics from unmaintained/* | 16:19 |
| bauzas | but still the question remains : should we care of the state of unmaintained branches ? | 16:19 |
| bauzas | ack | 16:19 |
| bauzas | moving on then | 16:19 |
| elodilles | so yepp, it's not a general concern | 16:19 |
| bauzas | #topic Release Planning | 16:19 |
| bauzas | #link https://releases.openstack.org/epoxy/schedule.html | 16:19 |
| bauzas | as a reminder, we'll discuss the epoxy nova deadlines next week | 16:20 |
| bauzas | nothing further to say | 16:20 |
| bauzas | #topic Review priorities | 16:20 |
| bauzas | #link https://etherpad.opendev.org/p/nova-2025.1-status | 16:20 |
| bauzas | I did some cleanup in the etherpad and added the recent approved blueprints | 16:20 |
| bauzas | a round of reviews is strongly encouraged | 16:20 |
| bauzas | #topic PTG planning | 16:21 |
| bauzas | #info as a reminder, we'll meet (virtually) at the PTG on Oct 21-25 2024 | 16:21 |
| bauzas | ... which is next week :-) | 16:21 |
| bauzas | # info Please register yourself to the virtual PTG | 16:21 |
| bauzas | #info Please register yourself to the virtual PTG | 16:22 |
| bauzas | #link https://etherpad.opendev.org/p/nova-2025.1-ptg | 16:22 |
| bauzas | feel free to add more topics in the above etherpad | 16:22 |
| bauzas | also, we'll have a x-p session between Horizon and Nova | 16:24 |
| bauzas | feel free to add items for that session | 16:25 |
| bauzas | which will happen on Wed 1600UTC | 16:25 |
| tkajinam | iirc we have a few slots in tc PTG to discuss eventlet removal, so we may want to decide the plan for it and nova specific one. | 16:25 |
| bauzas | yeah I heard it | 16:25 |
| tkajinam | my current preference is to have global discussion first and then nova one but I'm open for different opinions | 16:25 |
| bauzas | when would those topics happen ? | 16:25 |
| bauzas | ditto | 16:26 |
| tkajinam | I think we have a slot on Monday and the other on Wednesday | 16:26 |
| bauzas | I hope the eventlet talks would happen on Monday or Tuesday to leave other projects time for discussing that again | 16:26 |
| sean-k-mooney | there is a sperate etherpad for an overall session | 16:26 |
| tkajinam | https://etherpad.opendev.org/p/oct2024-ptg-os-tc | 16:26 |
| tkajinam | ok it seems they canceled the slots on Wednesday | 16:27 |
| sean-k-mooney | not that oen this https://etherpad.opendev.org/p/oct2024-ptg-eventlet-removal | 16:27 |
| tkajinam | ah, ok | 16:27 |
| bauzas | okay, I'll mention that etherpad in our own Nova etherpad | 16:27 |
| sean-k-mooney | but yes curerntly a monday and wednesday slot but no adjenda | 16:27 |
| bauzas | I need to write the agenda, I'll refer to that session | 16:27 |
| tkajinam | sean-k-mooney, ok. thanks for the info. | 16:28 |
| bauzas | cool, ditto | 16:30 |
| bauzas | moving on then | 16:30 |
| bauzas | there will also be an i18n discussion I'll attend | 16:30 |
| bauzas | I'll refer to it too with possibly follow-up discussions during nova sessions | 16:31 |
| bauzas | #topic Stable Branches | 16:31 |
| bauzas | elodilles: floor is yours | 16:31 |
| elodilles | ack | 16:31 |
| elodilles | #info stable/202*.* gates seem to be OK | 16:31 |
| elodilles | #info final 2023.1 Antelope nova release before the branch transitions to 'unmaintained': https://review.opendev.org/c/openstack/releases/+/932406 | 16:32 |
| elodilles | does anyone have any bug fix that should be part of the final antelope release? | 16:32 |
| elodilles | open & merged patches on stable/2023.1: https://etherpad.opendev.org/p/nova-stable-2023.1-eom | 16:32 |
| elodilles | there are some patches that wait for a 2nd +2, but otherwise i don't know if anything would be important | 16:32 |
| elodilles | and that's all from me | 16:33 |
| tkajinam | maybe we should check if all follow-up fixes for image inspector have been backported | 16:33 |
| elodilles | tkajinam: good point. afair, we had quite many of that backported, | 16:34 |
| elodilles | though i don't know if that were all | 16:34 |
| bauzas | well, there are a bunch of them | 16:35 |
| sean-k-mooney | i think for the issues that are already fix the answer is yes | 16:35 |
| bauzas | if you speak of the CVE fixes, yeah | 16:35 |
| tkajinam | ah, ok | 16:35 |
| sean-k-mooney | we also backported the fix for the aws and iso regressions on stable | 16:35 |
| elodilles | https://review.opendev.org/q/topic:%22format-inspector%22+branch:stable/2023.1 | 16:35 |
| bauzas | if that's about the 'improvements' (like raw means raw), then I'm unsure | 16:35 |
| elodilles | these are the ones that i'm aware of, at least (plus the bug fixes) | 16:36 |
| bauzas | those are the CVE fixes | 16:36 |
| tkajinam | My thought was mostly about regression fixes, not improvements. but I think we are ok about the known issues. | 16:37 |
| elodilles | ACK | 16:37 |
| bauzas | yeah so I checked | 16:38 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/926144 is more a signal patch, like 'dude, you shouldn't be doing that' | 16:38 |
| bauzas | and this was following https://review.opendev.org/c/openstack/nova/+/924866 which was backported | 16:39 |
| tkajinam | lgtm | 16:39 |
| bauzas | we recently merged https://review.opendev.org/c/openstack/nova/+/930754 but I don't see any interest in backporting it down | 16:40 |
| bauzas | and there is a dep on glance | 16:40 |
| bauzas | so I think we can't use the glance safebelt | 16:41 |
| bauzas | hence the non-backport | 16:41 |
| bauzas | so I guess we're cool | 16:41 |
| bauzas | moving on ten | 16:42 |
| bauzas | then* | 16:42 |
| elodilles | ++ | 16:42 |
| bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:42 |
| bauzas | fwiesel: anything to mention ? | 16:42 |
| fwiesel | No, nothing from my side. | 16:42 |
| fwiesel | Sorry for the lack of progress. | 16:42 |
| bauzas | no worries, we're all busy | 16:43 |
| bauzas | particularly me. | 16:43 |
| bauzas | #topic Open discussion | 16:43 |
| bauzas | (tkajinam): Removing db migration tool from nova_placement to placement: https://review.opendev.org/c/openstack/placement/+/932324 | 16:43 |
| bauzas | shoot | 16:43 |
| tkajinam | I discussed this already with sean-k-mooney and gibi but I think it may make sense to bring the topic here to get any additional feedback | 16:44 |
| tkajinam | placement repository has carried the migration tool which pulls placement db from nova db. This was required in upgrade from Stein to Train and I'm wondering if we can directly drop it now because I don't think anyone may use it from master nowadays | 16:45 |
| bauzas | this is old code | 16:45 |
| bauzas | I don't see any controversy in removing it | 16:45 |
| tkajinam | :-) | 16:46 |
| bauzas | and people wanting to use it could just pip install in a venv an older release of placement | 16:46 |
| bauzas | and use that tool | 16:46 |
| gibi | yeah, drop it. | 16:46 |
| tkajinam | A quick question I still have is whether we should keep the upgrade note which is almost empty https://8f5091142d0d93e54bb3-66f76d6fb4c84b410723fddf17d0dbe7.ssl.cf5.rackcdn.com/932324/2/check/openstack-tox-docs/93314e0/docs/admin/upgrade-notes.html or keep it (and the administrator guide section) as a placeholder | 16:46 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Update Nova bdm with updated swap info https://review.opendev.org/c/openstack/nova/+/929858 | 16:47 |
| bauzas | from a procedural perspective, I litterally see zero paperwork to fill | 16:47 |
| bauzas | tkajinam: keep that | 16:48 |
| gibi | tkajinam: that upgrade-notes seem still relevant | 16:48 |
| bauzas | running a status check pre-flight is important | 16:48 |
| tkajinam | yes | 16:48 |
| bauzas | anyway, I think we're done with that item, we'll review it | 16:49 |
| tkajinam | ok then https://review.opendev.org/c/openstack/placement/+/932324 is ready. I had to wipe previous +2 to fix doc issues | 16:49 |
| tkajinam | thanks ! | 16:49 |
| bauzas | tkajinam: feel free to add your patch into the status etherpad | 16:49 |
| tkajinam | will do | 16:49 |
| bauzas | ++ | 16:49 |
| bauzas | another item, less easy to answer | 16:50 |
| bauzas | (tkajinam): Can we remove (or at least deprecate) WIndows OS support ? | 16:50 |
| bauzas | any good reason for doing it ? | 16:50 |
| bauzas | oh, the hypervisor bits | 16:50 |
| tkajinam | So as you know WinStackers project has been retired and now OpenStack on Windows is no longer maintained | 16:51 |
| bauzas | for a second, I thought it was about the image type and the instances :) | 16:51 |
| tkajinam | I've seen some issues with cross platform support when working on replacing unmaintained libs (eg netifaces) | 16:51 |
| tkajinam | I wonder if we can completely drop the windows support if it's not really tested/maintained or at least deprecate it so that we can get rid of it when something is completely broken | 16:52 |
| bauzas | if that's removing tech debt on things that we removed but left remains, sure I second your work | 16:52 |
| bauzas | anyone having any concerns about that ? | 16:53 |
| bauzas | I checked and apparently you can install a libvirt client on windows | 16:54 |
| bauzas | it would require your hypervisor to be remote tho, which is something we don't support | 16:54 |
| tkajinam | yes | 16:54 |
| tkajinam | as we don't support hyper-v via libvirt | 16:54 |
| tkajinam | I personally prefer direct removal given the fact hyper-v driver was already removed, but if we want to do it safe then we can deprecate it this cycle. We can discuss the strategy in the review https://review.opendev.org/c/openstack/nova/+/932407 | 16:55 |
| sean-k-mooney | ya so hyperv via libvirt ws never supported | 16:55 |
| bauzas | I just think we can process with reviewing your patch | 16:55 |
| bauzas | nothing controversial so far | 16:55 |
| tkajinam | thanks | 16:55 |
| bauzas | anything else before we wrap up ? | 16:56 |
| tkajinam | just fyi. I've added a few bugs (and their fixes) to the bottom of status etherpad https://etherpad.opendev.org/p/nova-2025.1-status (L87-91) | 16:56 |
| sean-k-mooney | tkajinam: we have some windows supprot we can delete in os-vif too by the way | 16:57 |
| tkajinam | these replaces the deprecated/unmaintained libs so I appreciate reviews for these. | 16:57 |
| tkajinam | sean-k-mooney, yeah I remember I did deprecate these in the past cycle | 16:57 |
| bauzas | tkajinam: ack | 16:58 |
| tkajinam | so it maybe time to drop it, as we usually use eventlet patch differently for windows removing the logic may help removing eventlet. | 16:58 |
| gmann | tkajinam: what exactly left to remove window support? | 16:58 |
| tkajinam | gmann, tons of os.name == 'nt' checks | 16:58 |
| bauzas | gmann: see above, there is a cleanup patch | 16:58 |
| tkajinam | maybe not 'tons' but 'numbers' | 16:58 |
| gmann | ohk, just cleanup things. got it | 16:59 |
| gmann | but we have already declared the winbdow support removal during hyper-V removal | 16:59 |
| tkajinam | yes | 16:59 |
| tkajinam | that's all from me today | 17:00 |
| bauzas | cool and we're at time | 17:00 |
| bauzas | thanks all | 17:00 |
| bauzas | #endmeeting | 17:01 |
| opendevmeet | Meeting ended Tue Oct 15 17:01:02 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.html | 17:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.txt | 17:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.log.html | 17:01 |
| elodilles | thanks o/ | 17:02 |
| tkajinam | thank you ! | 17:03 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Clean up the remaining logic for Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | 17:09 |
| opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | 17:23 |
| gmann | tkajinam: I changed my -1 to +2 on the py3.8 drop changes for python_requires flag. let me know if I missed any and that is blocking them to merge. | 17:36 |
| opendevreview | Merged openstack/nova stable/2023.1: add functional repoducer for bug 2065927 https://review.opendev.org/c/openstack/nova/+/922987 | 17:37 |
| sean-k-mooney | gibi: i really dont know why this does not work https://paste.opendev.org/show/bv7MnOwOylKgvUiBOube/ | 17:40 |
| sean-k-mooney | it never print LOG.info(f"Finished after {end_time - start_time} seconds") | 17:40 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Remove Python 3.8 support https://review.opendev.org/c/openstack/placement/+/925648 | 17:41 |
| sean-k-mooney | maybe im not emulating this well and iw was working ill try soemthign other then sleep as teh worker function | 17:46 |
| sean-k-mooney | oh there first example in https://www.geeksforgeeks.org/python-different-ways-to-kill-a-thread/ does not actlly work | 18:12 |
| sean-k-mooney | ok i have it workign now but im not sure i like it | 18:19 |
| sean-k-mooney | https://paste.opendev.org/show/bl8yqiKsPC6fv8iMA1tG/ | 18:25 |
| sean-k-mooney | that works with eventlet too https://paste.opendev.org/show/bsbrV4lpmgzIBj5WOB2M/ | 18:26 |
| sean-k-mooney | any the behavior is differnt if i eventlet monkeypathc or not | 18:30 |
| sean-k-mooney | ok so this will work for native threads which is what we want it for but not nessiarly for eventlet greenthreads | 18:31 |
| opendevreview | Merged openstack/nova stable/2023.1: retry write_sys call on device busy https://review.opendev.org/c/openstack/nova/+/922988 | 18:31 |
| opendevreview | Merged openstack/nova stable/2023.1: testing: Fix and robustify archive_deleted_rows test https://review.opendev.org/c/openstack/nova/+/887978 | 18:31 |
| opendevreview | Merged openstack/python-novaclient master: Remove Python 3.8 support https://review.opendev.org/c/openstack/python-novaclient/+/931477 | 19:33 |
| *** elodilles is now known as elodilles_pto | 19:41 | |
| *** bauzas_ is now known as bauzas | 21:51 | |
| opendevreview | Merged openstack/nova stable/2023.1: database: Archive parent and child rows "trees" one at a time https://review.opendev.org/c/openstack/nova/+/887979 | 21:58 |
| *** bauzas- is now known as bauzas | 22:04 | |
| *** bauzas- is now known as bauzas | 22:12 | |
| opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Move cache filename generation to imagebackend https://review.opendev.org/c/openstack/nova/+/930961 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add base image format tracking with file extensions https://review.opendev.org/c/openstack/nova/+/930962 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: db: Add image_type to block_device_mapping table https://review.opendev.org/c/openstack/nova/+/930964 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: objects: Add image_type to BlockDeviceMapping object https://review.opendev.org/c/openstack/nova/+/930965 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: virt: Add image_type to relevant DriverBlockDevice https://review.opendev.org/c/openstack/nova/+/930966 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | 22:18 |
| opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | 22:34 |
| *** bauzas_ is now known as bauzas | 23:33 | |
| *** bauzas_ is now known as bauzas | 23:44 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!