Thursday, 2024-11-28

*** __ministry is now known as Guest130301:06
*** __ministry is now known as Guest132004:10
opendevreviewNisha Brahmankar proposed openstack/nova master: Retain port binding profile after live migration  https://review.opendev.org/c/openstack/nova/+/93633804:28
opendevreviewStephen Finucane proposed openstack/nova master: api: Add new, simpler api_version decorator  https://review.opendev.org/c/openstack/nova/+/93636710:24
opendevreviewStephen Finucane proposed openstack/nova master: api: Only run format checks on strings  https://review.opendev.org/c/openstack/nova/+/93636810:24
opendevreviewStephen Finucane proposed openstack/nova master: api: Simplify parameter types  https://review.opendev.org/c/openstack/nova/+/93636910:24
opendevreviewStephen Finucane proposed openstack/nova master: tests: Ensure all APIs have a response body schema  https://review.opendev.org/c/openstack/nova/+/92459810:24
zigodansmith: Hi there! Got a question for you. I'm testing db upgrades, and populate_instance_compute_id is taking like forever.11:17
zigoI wonder, what is this about? Your commit header says it's for "deleted, shelved, never scheduled or otherwise on a compute host that isn't updatating it", I don't really get it.11:17
zigoAlso, I have many warnings about: "Unable to migrate instance because host None with node None not found: nova.exception.ComputeHostNotFound: Compute host None could not be found.". Should I be worried?11:17
zigo(of course, I'm not expecting a reply before you wake up ... :P )11:23
opendevreviewMerged openstack/nova master: Add share_info parameter to reboot method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/85482313:28
opendevreviewMerged openstack/nova master: Support rebooting an instance with shares (compute manager part)  https://review.opendev.org/c/openstack/nova/+/85482413:37
opendevreviewMerged openstack/nova master: Add share_info parameter to resume method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/86028413:50
ishanwarHi team, 14:24
ishanwarI wanted to ask what is a good entry point, to start understanding the nova implementation in the codebase. I could not find much resources about the implementations on the openstack website 14:25
ishanwarKindly suggest @Sean-k-mooney and @bauzas ? 14:26
sean-k-mooneythe nova codebase is quite large btu we have alot of contibutor adn refence docs decibing the archetecture and subssytems14:33
sean-k-mooneyishanwar: the main entry point to our docs is https://docs.openstack.org/nova/latest/14:34
sean-k-mooneyi woudl first start with https://docs.openstack.org/nova/latest/admin/architecture.html14:34
sean-k-mooneyoru contibutor docs are here https://docs.openstack.org/nova/latest/contributor/index.html and tecnial refence docs are here https://docs.openstack.org/nova/latest/reference/index.html14:35
sean-k-mooneybeyond that there are a number of youtube videos form previosu summits on specific topics14:36
sean-k-mooneyzigo: dansmith is on PTO until the end of the year more or less so expect a delay on any pings :)14:38
sean-k-mooneyzigo: if the instance has host and node none and is not deleted or in cell0 then that is only valid if its shelved14:39
sean-k-mooneyspeicifclly shelve_offoloaded14:39
sean-k-mooneyif you have an isntnace that is not shelve_offloaded and has host or node None then you have db currption14:40
ishanwarsean-k-mooney: thanks for the docs, I had a look at the architecture, I was wondering if there is any specific command to start the apis for testing locally in the codebase 14:51
ishanwarAlso, @Sean-k-mooney @bauzas, it would be great if you could point me to any low hanging bugs to solve like good-first-issues in the codebase 14:56
sean-k-mooneyishanwar: you can techinally do that but its not hwo developemnt is normally done. nova is a distirbute system with several external depencies15:09
sean-k-mooneyso the normall approch is to use devstack https://github.com/openstack/devstack to create a devleopment enviornment in a vam15:09
sean-k-mooney*vm15:09
zigosean-k-mooney: My db is comming from another cluster, just testing db upgrades and online_data_migrations. Could that be the reason?15:18
zigoFYI, that's form Antelope to Caracal.15:19
zigofrom15:19
sean-k-mooneypopulate_instance_compute_id should be using data form within the cell db15:28
sean-k-mooneyso if your doign this on a local backup ectra then it should not cause issues that im aware of15:29
sean-k-mooneythis is what its actully doing https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L1357-L137715:30
sean-k-mooneyfor each instance we get the node and host values and lookup the compute node id then set that in teh instance compute_id column15:31
sean-k-mooneyso that shoudl be relitivly quick although if you have a lot of instnaces then it will take a while15:32
zigoThat cluster has ~8k VM, though many deleted, I guess.15:33
zigoIt's rather fast, what I'm worried about, is the None thingy, plus compute nodes that we decomitionned.15:33
sean-k-mooneywe are reading deleted isntanfe too15:33
zigoYeah, and I don't understand why.15:34
sean-k-mooneyits backpopulating deleted but not archived isntances15:34
sean-k-mooneyto keep it consitent15:34
zigoOh, maybe I should just archive them then ...15:34
sean-k-mooneyso if the compute node is delete then this will skip them15:35
sean-k-mooneybut if your rungin this in a loop it will never fully complete15:35
zigoHum... I do have the ::nova::cron::archive_deleted_rows thingy ... :P15:37
sean-k-mooneyin theory if you are deleting a compute node shoudl shoudl also be deleting any instance that are on it or move them to a diffent host first15:37
sean-k-mooneybut there are bugs that can lead to instanfce beign in a wereid state sometimes15:37
sean-k-mooneybauzas: as an fyi you have not created the 2025.1 series in https://launchpad.net/nova yet or set it as the active developemnt release, it still says 2024.216:09
sean-k-mooneybauzas: proably needs to be done on the other delvierables too16:09
bauzashmmm, no, we already have blueprints for 2025.116:10
bauzasbut indeed, maybe the active release is still 2024.216:10
bauzassean-k-mooney: okay, now fixed16:13
bauzashttps://launchpad.net/nova/+series16:13
sean-k-mooneycool16:15
sean-k-mooneyim just looking at fixing watchers trackign and im using novas config as a refence16:15
sean-k-mooneyso i just noticed that when comparing16:15
opendevreviewMerged openstack/nova master: Revert "[libvirt] Live migration fails when config_drive_format=iso9660"  https://review.opendev.org/c/openstack/nova/+/90912216:40
sean-k-mooneywoot now to backport that...16:56
opendevreviewsean mooney proposed openstack/nova stable/2024.2: Revert "[libvirt] Live migration fails when config_drive_format=iso9660"  https://review.opendev.org/c/openstack/nova/+/93664516:56
opendevreviewribaudr proposed openstack/nova master: Refactor response schemas for share API  https://review.opendev.org/c/openstack/nova/+/93665618:26
opendevreviewBalazs Gibizer proposed openstack/placement master: WIP: Test mitigations for candidate explosion  https://review.opendev.org/c/openstack/placement/+/93665819:23
opendevreviewMerged openstack/nova master: Support resuming an instance with shares (compute manager part)  https://review.opendev.org/c/openstack/nova/+/86028521:41

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!