Monday, 2024-12-09

opendevreviewMerged openstack/nova master: Add shares to InstancePayload  https://review.opendev.org/c/openstack/nova/+/85102900:38
*** __ministry is now known as Guest250607:24
*** ralonsoh_ is now known as ralonsoh09:21
*** __ministry is now known as Guest252210:42
opendevreviewStephen Finucane proposed openstack/nova master: api-ref: Update note on flavor disabled property  https://review.opendev.org/c/openstack/nova/+/93735612:15
opendevreviewbenlei proposed openstack/nova master: Avoid duplication instances when nova compute servcie restart  https://review.opendev.org/c/openstack/nova/+/93735712:17
opendevreviewbenlei proposed openstack/nova master: Avoid duplication instances when nova compute servcie restart  https://review.opendev.org/c/openstack/nova/+/93735712:21
opendevreviewBalazs Gibizer proposed openstack/nova master: DNM: test with placement ac breadth-first  https://review.opendev.org/c/openstack/nova/+/93727512:27
opendevreviewKaloyan Kotlarski proposed openstack/nova master: libvirt: Fetch the available vCPUs from the respective cgroup  https://review.opendev.org/c/openstack/nova/+/92747413:32
opendevreviewBalazs Gibizer proposed openstack/placement master: Add a global limit on the number of allocation candidates  https://review.opendev.org/c/openstack/placement/+/93665813:40
opendevreviewBalazs Gibizer proposed openstack/placement master: Factor out allocation candidate generation strategy  https://review.opendev.org/c/openstack/placement/+/93727313:40
opendevreviewBalazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy  https://review.opendev.org/c/openstack/placement/+/93683213:40
opendevreviewBalazs Gibizer proposed openstack/placement master: DNM: test with breadth-first in tempest  https://review.opendev.org/c/openstack/placement/+/93727413:40
opendevreviewMerged openstack/nova master: api: Add response body schemas for bare metal node APIs  https://review.opendev.org/c/openstack/nova/+/92459115:21
gibimelwitt: the whole https://review.opendev.org/q/topic:%22bug/2070257%22 is ready for review now15:23
opendevreviewStephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact  https://review.opendev.org/c/openstack/nova/+/93737715:34
sean-k-mooneygibi: you have 3 actual patches adn two DNMs to test this in ci with the new order if im readign that right?15:36
sean-k-mooneyis the plan to enabel the breadth-first appochec in nova-next or similar?15:37
sean-k-mooneyi assume we woudl like to have both tested between the set of jobs we have15:38
sean-k-mooneygiven the limited useage of nested resouce providers in the upstream gate i doubt we woudl see an observable diffence15:38
sean-k-mooneyalthough i coudl see use eventually chanigng the default fo the placement config option in a future release so setting it in nova-next i think woudl make sesne15:39
sean-k-mooneygibi: if you would like me to be a second review on that i can try and do so next year but i wont have time to do that this week15:40
sean-k-mooneyif others feel like they have a better grasp on placmenet that fine too15:41
sean-k-mooneyi was hopign melwitt would be one of the reviewer on thsi but i dont know who is next best positioned to review15:41
gibisean-k-mooney: 3 actual placement patch yes, the DNMs are just running tempest with the fix 15:58
gibisean-k-mooney: I feel this patch will wait for review until the new year, so you will have a chance to look at it 15:59
gibimelwitt is already signalled interest15:59
gibiI'm OK to enable this config in nova-next, I think it is pretty safe. But as you noted we don't have much nested coverage in upstream CE16:00
gibiCI16:00
auniyalsean-k-mooney, please have a look at  https://review.opendev.org/c/openstack/nova/+/929858  for review17:23
sean-k-mooneysure17:24
auniyalthanks :) 17:25
opendevreviewStephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact  https://review.opendev.org/c/openstack/nova/+/93737717:44
sean-k-mooneyauniyal: +1.5 comments inline17:50
opendevreviewDouglas Viroel proposed openstack/nova-specs master: Add spec for show scheduler hints in server details  https://review.opendev.org/c/openstack/nova-specs/+/93614018:03
sean-k-mooneydviroel: ^ i have +2'd the spec but also left some nits that coudl be improved. i am proably +1.6 which is why i rounded up to a +2 instead of down to a +1 but im happy with the over all direction of this 18:29
dviroelthanks sean-k-mooney. yeah, there are some implementation/testing details missing in the spec, but mainly because I am not familiar with all nova doc/test details. But for sure I will follow previous implemented API microversions to check all required changes. 18:41
sean-k-mooneyyep if other are happy with the implict understandign that all standard testing will be added at implemeation time im happy to just review for that when reviewing the code change18:42
opendevreviewMerged openstack/nova master: api: Add response body schemas for console auth token APIs  https://review.opendev.org/c/openstack/nova/+/92459218:49
opendevreviewMerged openstack/nova master: Add instance.share_attach_error notification  https://review.opendev.org/c/openstack/nova/+/86028219:35
sean-k-mooneyartom: -1 on https://review.opendev.org/c/openstack/nova-specs/+/936775 but i think its mostly ok19:51
artomYou wrote me a freaking novel :P19:52
artomThanks for reading, I'll need to some to ingest all of that19:52
artom*some time19:52
sean-k-mooneymain things are we shoudl not use nova in the image property value we shoudl use `compute` and the opt in path for exising instnace does not really work19:53
sean-k-mooneya user can resize to opt in but thats about it19:53
artomAck on "compute"19:53
sean-k-mooneythey could update an image the uploaded and rebuild to it but that lesses data19:54
sean-k-mooney*looses19:54
artomRight - so how do new image properties currently get "synced"? Is the answer "they don't"?19:54
sean-k-mooneyi think what you propsoe can be extedned to encypted cidner voluems so if we say we plan to do that in a sepete spec later that fine19:54
sean-k-mooneyartom: they dont by design19:55
artomOK, I need to rethink that bit then.19:55
sean-k-mooneywe take a snap shot of them and stor them in the instace_system_metadata table wit a img_ prefix19:55
sean-k-mooneyi think you can just say the only way to apply this to existing instnace is resize or the nova manage command with the user triggering a hard reboot or simialr19:56
artomAck19:56
sean-k-mooneythe -1 is mainly the nova vs compute thing19:57
melwittgibi: ack, will look19:57
sean-k-mooneybut please read the rest when you have time19:57
artomYeah19:57
artomYep19:57
sean-k-mooneyi might have time before i go on pto to do another pass but if other are ok with the desgin then you dont strictly need to wait for me to re reivew19:58
sean-k-mooneyif its still open when im back ill take another pass early january19:59
artomI don't think anyone's expecting it to merge in 2024. We wanted to at least get a couple of review passes, with maybe a +1 or +2.20:06
abishophi, cinder guy here who is looking for a "feature liaison" to help me with a feature I'd like to work on for epoxy20:09
abishopin the 2025.1 PTG our teams discussed a possible enhancement to the "Update a volume attachment" API to support cinder's driver assisted volume migration20:09
abishopthat turns out to not be feasible for several (cinder) reasons, and so I'm now pursuing an alterntive approach to improving the user experience20:09
abishopit would entail a small enhancement to the "Show a detail of a volume attachment" but that would still require a microversion which means a spec20:09
abishopI have a few liaison questions, starting with what's the epoxy deadline for specs?20:09
artomabishop, you don't necessarily need a feature liaison right off the bat, you could pick up one during spec review. Official deadline is E-2, so Jan 10, but we're trying to get specs posted ASAP and at least looked at before the end of 2024, because otherwise the time because real short.20:27
abishopartom phew, Jan 10 is great news to me and I can post something by mid next week20:29
artomabishop, I don't think bauzas ever posted our "unofficial" timeline, but yeah, get something up ASAP20:29
artom(posted on the ML)20:30
abishopon the ML? I though it would be submitted for review to nova-specs20:30
abishopthough I don't know how nova specs transition from proposed to the "approved" directory20:32
artomNo no, I was completing my previous sentence: "ever posted on the ML"20:37
artomabishop, they don't, you write them directly under the approved directory. They become approved when they merge.20:38
abishopah, that makes sense20:38
opendevreviewMerged openstack/nova master: Rephrase the help message  https://review.opendev.org/c/openstack/nova/+/92520721:28
sean-k-mooneyabishop: the unoffical deadlien for specs is thusrday of r-16 december 12th i.e this thursday but that really just because most nova folks will be on pto starting sometime this/next week.23:34
sean-k-mooneyhttps://etherpad.opendev.org/p/r.4f297ee4698e02c16c4007f7ee76b7c1#L20423:35
sean-k-mooneyso in theory tomorow is a spec review day, thrusday is the soft freeze and the actul freeze is january 9th23:36
sean-k-mooneyi.e. epoxy milestone two https://releases.openstack.org/epoxy/schedule.html#e-223:36
sean-k-mooneyabishop: by the way we are still waitign on  cinder folks to weigh in on https://review.opendev.org/c/openstack/nova-specs/+/93265323:42
sean-k-mooneywe dont nessiarly have concerns with adding new volume frontend qos types provide the cinder side of it is done first23:43
abishopsean-k-mooney: thank you for the additional details; I'll try to post the spec ASAP (I'm also out for the rest of the year starting next Thu). I don't have any info on the other qos spec, but will see what I can find23:55
sean-k-mooneyabishop: as far as im aware the burts qos value are not standardised in cinder so i think they need a cinder spec first to add those23:56
sean-k-mooneyim not sure if they have create one since23:56
sean-k-mooneythat seams to be the only review the author has so proably now23:56
sean-k-mooney*not23:56

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!