| masanori | Hello. I have created this bug fix: https://review.opendev.org/c/openstack/nova/+/936910 Could you please review it when you have time. > gibi, stephenfin or anyone :) This fixes the process to get the image's metadata from instance.image_meta instead of request_spec.image during resize. | 06:48 |
|---|---|---|
| *** tosky_ is now known as tosky | 08:53 | |
| stephenfin | sean-k-mooney: Would you be able to take a look at https://review.opendev.org/c/openstack/nova/+/937377/ today? | 10:11 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Allow min/max_version arguments to expected_errors https://review.opendev.org/c/openstack/nova/+/936363 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Allow min/max_version arguments to response https://review.opendev.org/c/openstack/nova/+/936364 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Adjust validation helpers for a single-method future https://review.opendev.org/c/openstack/nova/+/936365 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Stop using wsgi.Controller.api_version to switch between API versions https://review.opendev.org/c/openstack/nova/+/936366 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add new, simpler api_version decorator https://review.opendev.org/c/openstack/nova/+/936367 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Only run format checks on strings https://review.opendev.org/c/openstack/nova/+/936368 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify parameter types https://review.opendev.org/c/openstack/nova/+/936369 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Ensure all APIs have a response body schema https://review.opendev.org/c/openstack/nova/+/924598 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: doc: Add missing API samples https://review.opendev.org/c/openstack/nova/+/937012 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Use UUIDs in TestOpenStackClient https://review.opendev.org/c/openstack/nova/+/937013 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hosts APIs https://review.opendev.org/c/openstack/nova/+/937047 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for instance actions https://review.opendev.org/c/openstack/nova/+/937048 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (1/3) https://review.opendev.org/c/openstack/nova/+/937245 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (2/3) https://review.opendev.org/c/openstack/nova/+/937246 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (3/3) https://review.opendev.org/c/openstack/nova/+/937247 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server IPs APIs https://review.opendev.org/c/openstack/nova/+/937608 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for remote consoles https://review.opendev.org/c/openstack/nova/+/940114 | 10:18 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115 | 10:18 |
| *** tosky is now known as Guest6863 | 13:19 | |
| *** tosky_ is now known as tosky | 13:19 | |
| bauzas | sean-k-mooney: reading your whiteboard comment on https://blueprints.launchpad.net/nova/+spec/image-metadata-props-weigher | 14:24 |
| bauzas | sean-k-mooney: are we clear that I *need* to create those sets , | 14:24 |
| bauzas | ? | 14:24 |
| sean-k-mooney | can you repahse that | 14:29 |
| sean-k-mooney | they dont already exist but they are trivial to construct from the data you have | 14:29 |
| sean-k-mooney | i was trying to descibe the algorithum i would use and its the one i would have documented in a spec if we were to have had a spec | 14:29 |
| sean-k-mooney | are you askign are free to come up with an entirly diffent design? from my perspecitve i was agreeing to treat this treat it as a specless blueprint on the understadign that you would implemnt the design in the whiteboard but if you ahve a diffent approch i can review it | 14:31 |
| sean-k-mooney | bauzas: if ^ is not what you were asking can you restate the question | 14:33 |
| bauzas | nevermind, your answers are fine | 14:33 |
| bauzas | sean-k-mooney: your whiteboard description looked confusing to me | 14:33 |
| bauzas | but OK, fair enough, your response helped me | 14:33 |
| sean-k-mooney | well the clip notes version is score = common_props / total_props | 14:34 |
| sean-k-mooney | the rest was just defining how to count the common and total sets | 14:34 |
| bauzas | so, yeah, I'll lookup the instances flavor field for generating the sets and as as we discussed https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-07-16.01.log.html#l-86 we avoid a DB lookup call | 14:34 |
| bauzas | okay, I see, you provided some high level algorithm for calculating the weigh by intersecting sets | 14:35 |
| sean-k-mooney | ya so if you not adding db calls, but decisde to use a dict or caluate the value with omething other then a set that is ok | 14:35 |
| bauzas | sets are interesting because they come with batteries for calculating the intersects or the joined elemenbts | 14:36 |
| sean-k-mooney | the set approch should be fast yes and that^ | 14:36 |
| bauzas | so your idea sounds good to me | 14:36 |
| bauzas | ok, now I better understand, thanks | 14:36 |
| bauzas | and thanks for the idea | 14:36 |
| sean-k-mooney | no worries. i likely wont get to it today but if you have a poc that you want me to look at ping me when its pushed | 14:37 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Add managed='no' flag to a guest xml definition https://review.opendev.org/c/openstack/nova/+/940135 | 14:38 |
| sean-k-mooney | am ... | 14:38 |
| sean-k-mooney | oh that is seprate form the pci thing | 14:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115 | 14:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!