| opendevreview | Merged openstack/nova master: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/883411 | 00:31 |
|---|---|---|
| opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | 01:06 |
| *** ykarel_ is now known as ykarel | 06:01 | |
| opendevreview | Amit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage https://review.opendev.org/c/openstack/nova/+/940304 | 06:07 |
| *** elodilles_pto is now known as elodilles | 08:13 | |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | 08:17 |
| ierdem | Hi, how can I live migrate VMs between two different containers? I have environment deployed by using kolla-ansible and some of my compute nodes have rocky containers, some of them have ubuntu. I want to live migrate VMs from Rocky (has higher qemu version and different machine type *_rhel-*) to Ubuntu. Is there any hackish and easy method to do this? (on production) | 08:48 |
| mnasiadka | ierdem: I know people just run rocky version of libvirt container on Ubuntu - but that’s not the solution you are asking for :) | 08:59 |
| ierdem | mnasiadka, yes :) actually we run all containers on Ubuntu too but the problem is difference between nova containers OS releases | 09:04 |
| mikal | sean-k-mooney: I'm still working on the sound traits changes, I haven't even attempted the equivalent changes for the USB controller yet. So I think that os-traits patch is simple and could do with some feedback if possible. When I give up for the day today I'll upload the sound patch so you can decide if I am even on the right track... | 09:15 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 10:10 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 10:10 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 10:10 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | 10:10 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | 10:10 |
| opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add flavor-search-by-name spec https://review.opendev.org/c/openstack/nova-specs/+/940440 | 12:07 |
| ganso | Hi folks. Given nvidia has dropped support for mdev in their v535+ drivers, what one would have to do to transition from an mdev configuration to a vfio configuration? I've been using mdev and working fine but now with the driver update nothing works anymore. I have installed libvirt 10 but that alone doesn't fix the problem. Does Nova SRIOV support running VGPUs in this mode? What config is necessary to change? I don't see | 17:29 |
| ganso | mention of "vfio" in the nova docs for attaching GPU to guests | 17:29 |
| melwitt | ganso: I don't think yet but there is vfio work in progress toward supporting it https://specs.openstack.org/openstack/nova-specs/specs/2025.1/index.html | 18:10 |
| ganso | melwitt: I saw that spec but I thought it was specific to "variant drivers" (I am not familiar with that). If not, then basically the new nvidia drivers rendered the GPUs completely incompatible with OpenStack Nova until that spec is implemented? | 18:15 |
| melwitt | ganso: I'm not familiar with it either (and not an expert in vgpu) but IIUC that work is needed as a prereq toward supporting sriov vgpu. bauzas would know for sure | 18:19 |
| ganso | melwitt: thanks! let's wait for bauzas to respond | 18:57 |
| mikal | sean-k-mooney: you around today? | 19:14 |
| sean-k-mooney | mikal: sorry sort of. ill be aroudn for a bit longer but them im off until tuesday (pto tomorrow because of public holiday on monday) | 19:29 |
| mikal | sean-k-mooney: ahhh fair enough. I sent an os-traits patch, which I _think_ is correct. I'm arguing with the nova sound patch to integrate it, but I've never done one of these before so I think I'll have missed stuff. I'll move on to the USB one after that. | 19:30 |
| mikal | sean-k-mooney: worst case you'll have some patches to laugh at on Tuesday. | 19:30 |
| sean-k-mooney | i can take a look now | 19:31 |
| sean-k-mooney | im not sure if Uggla has cut the new release yet or not | 19:31 |
| sean-k-mooney | we wanted to do one this week | 19:32 |
| sean-k-mooney | we can always do another one next week if needed | 19:32 |
| sean-k-mooney | so https://review.opendev.org/c/openstack/os-traits/+/940418 | 19:32 |
| mikal | Yep, that's it. | 19:33 |
| mikal | I assume I need that released before CI for the nova patch will pass? (Its failing for other reasons now, but presumably that will eventually block me). | 19:33 |
| sean-k-mooney | it will pass in tempest but not unit tests with depends on | 19:33 |
| sean-k-mooney | you could put the traits stuff at the end | 19:34 |
| mikal | Oh, I've been doing the sound one in the sound patch, not in a separate one. | 19:34 |
| mikal | I could separate them if I need to I suppose. | 19:34 |
| sean-k-mooney | mikal: so the patch looks correct to me ill eave a copule of comments to that effect | 19:34 |
| mikal | Thanks. | 19:35 |
| sean-k-mooney | it can be in one pathc it normlaly is | 19:35 |
| mikal | Ok | 19:35 |
| sean-k-mooney | just the unit test will complain ectra if you try and import the constnat | 19:35 |
| mikal | Even with a depends-on? | 19:35 |
| sean-k-mooney | thre are ways to make ti work in unit test but its complex, ya we would have to properly hook up tox siblings and some other stuff | 19:36 |
| sean-k-mooney | bacislly the unit test alwasy pull the libs form pypi | 19:36 |
| mikal | Yeah, that doesn't sound like a good use of time. | 19:36 |
| sean-k-mooney | we woudl need to make the job install them form souce | 19:36 |
| sean-k-mooney | devstack has explcit supprot for this | 19:36 |
| mikal | I am a big concerned about the feature freeze deadline, but not concerned enough to do something like that quite yet. | 19:37 |
| sean-k-mooney | well even if we made it pass we still cant merge it for two reaons one we need to have a release or if anyone tries to use it for real it would break | 19:39 |
| sean-k-mooney | second the depend on will prevent it form merging until the other patch is merged | 19:39 |
| sean-k-mooney | so mechanically it would not speed anything up really | 19:40 |
| sean-k-mooney | maybe slighlty | 19:40 |
| sean-k-mooney | but only by the tiem ti takes to cut a release | 19:40 |
| mikal | Yeah cool. I'll keep working on traits for sound and usb then and hope a release happens in the mean time. | 19:40 |
| mikal | If you've got time for a quick scan of my traits attempt in https://review.opendev.org/c/openstack/nova/+/926126/12 that would be cool, but if you don't that's also fine. | 19:41 |
| sean-k-mooney | i have +2'd the triats patch melwitt if your about care to take a look https://review.opendev.org/c/openstack/os-traits/+/940418 | 19:42 |
| sean-k-mooney | mikal: ah https://review.opendev.org/c/openstack/releases/+/940363 merged 6 hours ago | 19:43 |
| mikal | How often do they do those releases? On demand? | 19:44 |
| sean-k-mooney | bauzas: ^ we shoudl plan an os-traits 3.4.0 once we merge mikal's patch | 19:44 |
| sean-k-mooney | mikal: yes on demand | 19:44 |
| melwitt | sean-k-mooney: not sure I can do a useful review. what are the sources for the list enums? i.e. where do they come from | 19:44 |
| sean-k-mooney | libvirt models. i was debating if we shoudl add the links | 19:45 |
| sean-k-mooney | i decied nto to bring that up but since you asked | 19:45 |
| mikal | Links to the domain XML docs? | 19:45 |
| sean-k-mooney | https://libvirt.org/formatdomain.html#sound-devices | 19:45 |
| sean-k-mooney | mikal: ya we sometime link to the libvirt docs or other refences | 19:45 |
| mikal | I can do that if you want me to. | 19:46 |
| sean-k-mooney | so for the nic models https://github.com/openstack/os-traits/blob/master/os_traits/compute/net.py#L25 | 19:46 |
| sean-k-mooney | we lined to the def in nova | 19:46 |
| sean-k-mooney | in other case we link to specs https://github.com/openstack/os-traits/blob/master/os_traits/compute/security.py#L32 | 19:47 |
| sean-k-mooney | we dont require it but it can be useful, these are just comment for future us | 19:48 |
| mikal | Please hold. | 19:48 |
| sean-k-mooney | so like the link to wiki pages for all the cpu feature flags in https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/__init__.py | 19:49 |
| opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | 19:49 |
| melwitt | sean-k-mooney: yeah I mean, otherwise I'm just like reviewing "hm yes, these look like all caps names in a list" 🙂 | 19:51 |
| melwitt | ✅ | 19:51 |
| mikal | Well in all fairness, it is a list of all caps names. | 19:51 |
| sean-k-mooney | melwitt: no worries its a good callout | 19:52 |
| sean-k-mooney | future it will help future us anyway | 19:53 |
| mikal | So yeah, I think I've done that thing. | 20:04 |
| melwitt | sean-k-mooney: commented on the review with a couple of questions with the main one being about if should have MODEL_NONE in this case | 20:23 |
| sean-k-mooney | am, do we need ot report the ablity to not do somehitng | 20:28 |
| sean-k-mooney | COMPUTE_USB_MODEL_NONE woudl mean the ablity to do emulation without any usb contoler | 20:29 |
| sean-k-mooney | it is part of the grapics triats because when usign vgpus we wanted a way to say dont add an emulated grapics card | 20:30 |
| melwitt | I dunno but we have it as a trait for hw_video_model | 20:30 |
| sean-k-mooney | i guess we coudl add it for completeness | 20:30 |
| melwitt | I'm ok with not having it (obviously I don't know this stuff) but wanted to bring it up in case it needs to be a thing | 20:31 |
| sean-k-mooney | or well for video models we have a usecase to reqeust None because you get one by default if the host is set up for vnc or spice | 20:31 |
| sean-k-mooney | so we added hw_graphic_model=none to opt out of that behavior | 20:32 |
| melwitt | ah ok. and usb is not something that is enabled by default | 20:32 |
| sean-k-mooney | it actully is | 20:32 |
| sean-k-mooney | so im thinking your right | 20:32 |
| sean-k-mooney | melwitt: you can configure the default pointer model to ps2 or usb | 20:32 |
| melwitt | not sure if there is a use case for wanting to explicitly disable it | 20:32 |
| sean-k-mooney | the use case to still use ps2 is lower overhead for realtime guest | 20:33 |
| sean-k-mooney | which is whey they prefer serial console or no console over spice/vnc | 20:33 |
| sean-k-mooney | less overhead to the vm due to interupts | 20:33 |
| melwitt | oh... now that you say that it sounds vaguely familiar | 20:33 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.pointer_model | 20:34 |
| sean-k-mooney | the thing is i dont know if none is a valid libvirt value or if you just dont create the device xml | 20:34 |
| melwitt | ah, good ol usbtablet | 20:35 |
| sean-k-mooney | so for sound modle https://libvirt.org/formatdomain.html#sound-devices it looks like you jsut dont create it but i also know that you can get a sound card added becasule fo q35 i think | 20:35 |
| melwitt | oh, I got the idea from the libvirt doc. it says "Additionally, since 0.10.0, if the USB bus needs to be explicitly disabled for the guest, model='none' may be used." https://libvirt.org/formatdomain.html#controllers | 20:36 |
| sean-k-mooney | for usb contooler i think you just dont add one | 20:36 |
| melwitt | so that's why I asked | 20:36 |
| sean-k-mooney | oh i missed htat | 20:36 |
| sean-k-mooney | so we could supprot it but that would need more work to chnage the pointer model if the config would use usb | 20:37 |
| sean-k-mooney | melwitt: your raisign very reasonable points to which i dont have a simple answer | 20:37 |
| melwitt | hm ok | 20:37 |
| sean-k-mooney | my my concern is delaying the spice direct feature again for this. im wondering if we could add none later if we needed it? | 20:38 |
| sean-k-mooney | basiclly not to expand the scope more | 20:39 |
| melwitt | yeah.. I'm assuming we can punt that to later. this was just in case you already knew it's a thing we need we could add it | 20:39 |
| sean-k-mooney | we didn tactully dicsus traits in the spec https://specs.openstack.org/openstack/nova-specs/specs/2025.1/approved/libvirt-spice-direct-consoles.html | 20:40 |
| sean-k-mooney | we proably should have | 20:40 |
| sean-k-mooney | but we also didnt dicsu opting out | 20:40 |
| melwitt | yeah. I was surprised to see the traits patch bc I didn't realize it would have traits | 20:40 |
| sean-k-mooney | it can merge without it. the traits will allow for schdulign using the image properies filter | 20:41 |
| sean-k-mooney | sorry | 20:41 |
| sean-k-mooney | the image metadata pre filter | 20:41 |
| melwitt | gotcha | 20:41 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L199-L239 | 20:42 |
| sean-k-mooney | so that is just a nice to have for schduling | 20:42 |
| sean-k-mooney | i suggested addign it because the virtio sound model is the only one not supported by our min libvirt/qemu version | 20:42 |
| sean-k-mooney | for usb that not a problem | 20:42 |
| melwitt | oh ok, so we would add hw_sound_model and hw_usb_model into that prefix map | 20:43 |
| sean-k-mooney | yep and if you requst either in the image it will add the reqiured trait to land you on a host that supprot it | 20:43 |
| sean-k-mooney | mikal: so to be clear the traits are optional, certently nice to have but can be done next cycle | 20:44 |
| sean-k-mooney | the compute service bump adn min version check are needed so that we ensure we never boot on a host hat does not supprot it | 20:44 |
| sean-k-mooney | without that you can request a usb devices and because old nova does not no about it it will boot without them | 20:45 |
| sean-k-mooney | mikal: that is protected agaist by a compute service bump for each fo the usb and audio emulation patches and a min version check for server create and rebuild. | 20:47 |
| melwitt | to be clear, I'm not opposed to the traits ... I was just trying to understand what I'm reviewing | 20:47 |
| sean-k-mooney | ack, no worries | 20:47 |
| mikal | Sorry, got distracted and missed this... | 20:48 |
| sean-k-mooney | melwitt: my understanding is the first 3 patches up to here https://review.opendev.org/c/openstack/nova/+/924844/26 is the mvp for spice direct | 20:49 |
| mikal | So, I think my take is that if the traits thing isn't too hard to do we should just do it. | 20:49 |
| mikal | However you're right, I will be disappointed if I have to do this game for a third time next release so I don't want to put that at risk if I can avoid it. | 20:49 |
| sean-k-mooney | melwitt: the folowing 2 patches enable the usecase request in https://review.opendev.org/c/openstack/nova-specs/+/920687 and make the spice direct feature more useful in general | 20:49 |
| mikal | I guess my problem is that having never done a trait before I don't really know how far https://review.opendev.org/c/openstack/nova/+/926126/12 is from being a working implementation. | 20:50 |
| sean-k-mooney | mikal: reviesion 23 is much close then 12 :) | 20:51 |
| mikal | Honestly for VDI to be a thing people will actually want to use you do need sound and USB. | 20:51 |
| sean-k-mooney | mikal: so https://review.opendev.org/c/openstack/nova/+/926126/23/nova/virt/libvirt/driver.py should work as is | 20:51 |
| mikal | Think desktop replacement with a thin terminal on someone's desk -- they'd want sound for notifications etc and USB for smartcard / yubikey / local printer or scanner / etc. | 20:52 |
| sean-k-mooney | mikal: instead of hardcodign them we normally get cleaver and constcut them form the ovo filed defnitions | 20:53 |
| sean-k-mooney | or use the os-traits constants but the hardcode string will work | 20:53 |
| mikal | So I really wanted to do it like the video models, that is obtain it from getDomainCapabilities(), but that doesn't report the sound models. | 20:54 |
| sean-k-mooney | ya we got them to add the video models | 20:54 |
| sean-k-mooney | among other things a while back to avoid matching on version | 20:55 |
| sean-k-mooney | but we did version matches before that | 20:55 |
| melwitt | ok, so IIUC the traits aren't required until the latter two patches. and os-traits release freeze is what, Feb 21 | 20:55 |
| mikal | We could do that here, but I would assume that landing something in libvirt, waiting for it to be covered by our minimum version, and then rewriting that code would likely take literally years. | 20:55 |
| sean-k-mooney | melwitt: ya only the last too | 20:55 |
| sean-k-mooney | and ya its the non clinet lib feeze so about the 21st | 20:56 |
| mikal | That's another thing... There are a few client patches for this stuff as well, but those are sitting queued up waiting for the nova support to land first. I was intending to propose those next release at this rate. | 20:56 |
| sean-k-mooney | mikal: ya so next time we wrap around the alpahpbet we can revisit it but what you ahve now is fine : | 20:56 |
| sean-k-mooney | :) | 20:57 |
| sean-k-mooney | the client patches are only for the new console type right | 20:57 |
| mikal | We are getting dangerously close to me having coworkers who are younger than openstack as it is... I am not sure I'll be around in another alphabet. | 20:57 |
| mikal | sean-k-mooney: yeah. | 20:57 |
| mikal | Its been a while since I looked at them, let me double check that. | 20:57 |
| sean-k-mooney | so honetly i would push the two patches for the sdk and osc and just add a depend on on the third patch that adds the api supprot | 20:58 |
| mikal | Yeah, I am carrying client patches for openstacksdk, python-novaclient, and python-openstackclient. | 20:59 |
| sean-k-mooney | i think you jst need to extend https://github.com/openstack/openstacksdk/blob/master/openstack/compute/v2/server_remote_console.py#L16-L23 | 20:59 |
| sean-k-mooney | but ya if you have workign patches i would post them for review | 20:59 |
| mikal | https://github.com/shakenfist/kerbside-patches/blob/develop/openstacksdk/patch006-openstacksdk-expose-spice-direct-consoles.patch is what I have right now for openstacksdk. | 21:00 |
| mikal | The microversion in that is wrong, I should update that. | 21:01 |
| mikal | Do we still add new things to python-novaclient, or is that one a red herring? | 21:01 |
| sean-k-mooney | you do not need to modify python-novaclient | 21:01 |
| sean-k-mooney | we froze the shell and python biding | 21:02 |
| mikal | Ahhh, ok. Cool. | 21:02 |
| sean-k-mooney | so jsut osc | 21:02 |
| mikal | So that would be openstacksdk and python-openstackclient. | 21:02 |
| sean-k-mooney | mikal: we have to supprot python-novaclient until heat/neutron ectra swap to the sdk | 21:03 |
| sean-k-mooney | yep just those | 21:03 |
| mikal | I will double check those and upload them today, with a depends-on for the third patch. | 21:03 |
| mikal | Similarly I have Kolla / Kolla-Ansible deployment patches, but again I am assuming those need to wait until Flamingo to be proposed. | 21:03 |
| mikal | (And I suspect the K/A one needs some HA love, I developed it on an all-in-one so its a bit under baked there). | 21:04 |
| sean-k-mooney | no you can do it in paralle | 21:05 |
| sean-k-mooney | they jsut wont merge it until it lands in nova | 21:05 |
| mikal | They trail by one release don't they? | 21:05 |
| mikal | Honestly, I haven' | 21:05 |
| mikal | t had much luck in getting the Kolla people to answer messages. | 21:05 |
| sean-k-mooney | no | 21:06 |
| sean-k-mooney | they are release trailing but not by one cycle master there is actuall master for epoxy | 21:06 |
| mikal | Le huh. | 21:06 |
| sean-k-mooney | they normlaly release a few weeks after the offical upstream release | 21:06 |
| mikal | Well, I will take a swing at that, but I am going to deal with nova and client patches first. | 21:06 |
| sean-k-mooney | mikal: fyi you have some line length issues in one of the patches | 21:10 |
| mikal | Client patches you mean? | 21:11 |
| sean-k-mooney | the sound device one | 21:11 |
| sean-k-mooney | the pep8 line limiet is actully 79 not 80 | 21:11 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/926126/23/nova/virt/libvirt/driver.py#13354 | 21:12 |
| mikal | Oh right. I can fix that. I have tests that run on the patch stack locally, but because there are so many queued up nova patches right now it takes a couple of hours to run and I haven't looked at the output yet today. I'll deal with that today. | 21:12 |
| sean-k-mooney | no rush. i think we(reviews) shoudl focus on the first 3 patches | 21:12 |
| sean-k-mooney | it woudl be ideally to merge all of them buti think the first 3 are pretty close | 21:13 |
| mikal | That would be great. Rebasing the microversion and object version changes is getting a bit old at this point, so landing those first three is actually a pretty big quality of life improvement for me. | 21:13 |
| sean-k-mooney | ya we have 3 patches compiting for the same ones | 21:14 |
| sean-k-mooney | i was hoping your would get 2.98 | 21:14 |
| mikal | (Joking!) The others should respect their elders! | 21:14 |
| sean-k-mooney | but we have the image propeties show and scheudler hits ones too | 21:14 |
| sean-k-mooney | ok im going to call it there o/ | 21:17 |
| mikal | Have a good long weekend. Thanks again for your help. | 21:18 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 21:24 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 21:24 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 21:24 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | 21:24 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | 21:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!