| opendevreview | suiong ng proposed openstack/nova master: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/939411 | 02:18 |
|---|---|---|
| opendevreview | suiong ng proposed openstack/nova master: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/939411 | 05:33 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | 08:29 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 08:35 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 08:35 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 08:35 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | 08:35 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | 08:35 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 09:15 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 09:15 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 09:15 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | 09:15 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | 09:15 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/nova/+/940619 | 13:02 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug/2097359 https://review.opendev.org/c/openstack/nova/+/940603 | 13:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | 13:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug/2097360 https://review.opendev.org/c/openstack/nova/+/940640 | 13:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Migrate InstanceNUMATopology received from old compute https://review.opendev.org/c/openstack/nova/+/940641 | 13:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | 13:57 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug/2097360 https://review.opendev.org/c/openstack/nova/+/940640 | 13:57 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Migrate InstanceNUMATopology received from old compute https://review.opendev.org/c/openstack/nova/+/940641 | 13:57 |
| *** ykarel_ is now known as ykarel | 14:28 | |
| opendevreview | Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | 15:07 |
| bauzas | #startmeeting nova | 16:03 |
| opendevmeet | Meeting started Tue Feb 4 16:03:18 2025 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:03 |
| opendevmeet | The meeting name has been set to 'nova' | 16:03 |
| bauzas | sorry I was on a meeting | 16:03 |
| sean-k-mooney | o/ | 16:03 |
| r-taketn | o/ | 16:03 |
| masahito | o/ | 16:03 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:03 |
| gibi | o/ | 16:04 |
| elodilles | o/ | 16:04 |
| sean-k-mooney | while we get started i have one item for open discuss, specificaly corrdinating patches and microversion for the 3 api feature we have in flight. i would like to propose spice 2.98 schduler hitns 2.99 and image properties 2.100 | 16:05 |
| sean-k-mooney | we can loop back to that later in the meeting | 16:05 |
| bauzas | sean-k-mooney: sure, that's a good ask | 16:06 |
| bauzas | we'll discuss that in open discussion | 16:06 |
| bauzas | let's start | 16:06 |
| bauzas | #topic Bugs (stuck/critical) | 16:06 |
| bauzas | #info One Critical bug | 16:06 |
| bauzas | #link https://bugs.launchpad.net/nova/+bug/2070501 | 16:06 |
| bauzas | I don't know why the bug state changed, that one looks to be fixed | 16:07 |
| dansmith | o/ | 16:07 |
| Uggla | o/ | 16:07 |
| bauzas | unless people argue, I'll set again the bug state to Invalid | 16:08 |
| sean-k-mooney | it look like it was triage by someone | 16:08 |
| bauzas | yup | 16:08 |
| sean-k-mooney | i think revert back to invalid is correct | 16:08 |
| bauzas | moving it back to Invalid | 16:08 |
| bauzas | moving on then | 16:08 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:09 |
| bauzas | #topic Gate status | 16:09 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:09 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:09 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status | 16:09 |
| bauzas | I clicked on that page 30 mins before and I'm still awaiting the result | 16:09 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:10 |
| bauzas | #info Please try to provide meaningful comment when you recheck | 16:10 |
| bauzas | okay, I won't wait too much, moving on | 16:11 |
| bauzas | anything about the gate state ? | 16:11 |
| bauzas | fwiw, I started back to look at upstream and AFAIK, nothing new | 16:11 |
| bauzas | okay, crickets | 16:12 |
| bauzas | I guess it's time to go to the next topic | 16:12 |
| bauzas | #topic Release Planning | 16:12 |
| bauzas | #link https://releases.openstack.org/epoxy/schedule.html | 16:12 |
| bauzas | #info Nova deadlines are set in the above schedule | 16:12 |
| bauzas | #info 3 weeks before Feature Freeze | 16:12 |
| bauzas | #link https://review.opendev.org/c/openstack/releases/+/940363 os-traits was released this week | 16:12 |
| bauzas | time is flying | 16:13 |
| sean-k-mooney | we may want to do another release of os-traits | 16:13 |
| bauzas | that was planned in my mind | 16:13 |
| sean-k-mooney | there are some nice to have triats for the spice-direct supprot | 16:13 |
| bauzas | I definitely want to go back reviewing this week | 16:13 |
| sean-k-mooney | so if we proceed with merging those we shoudl ideally do another one this week | 16:14 |
| bauzas | so I'll probably figure out when to release traits | 16:14 |
| bauzas | sean-k-mooney: cool | 16:14 |
| bauzas | moving on the status, because we could disucss that there | 16:14 |
| bauzas | #topic Review priorities | 16:14 |
| fwiesel | o/ | 16:14 |
| bauzas | #link https://etherpad.opendev.org/p/nova-2025.1-status | 16:14 |
| bauzas | the etherpad is stale but I'll update it tomorrow | 16:14 |
| bauzas | for traits, I could also look at the existing series and try to organize a list of traits changes to review | 16:15 |
| bauzas | those things are small | 16:15 |
| bauzas | sean-k-mooney: for the question you asked at the beginning, that's probably the right time to talk about it | 16:16 |
| bauzas | sean-k-mooney: so you wanna want to prioritize all the API changes by a list ? I'm like fine with that, we did this previously IIRC | 16:16 |
| sean-k-mooney | yes so we have 3 api changes competing for 2.98 | 16:16 |
| sean-k-mooney | i woudl like to merge the speic direct patches with that since it was there first effectivly | 16:17 |
| sean-k-mooney | the other two serise are the two to add schduler hints to server show and image properties | 16:17 |
| sean-k-mooney | im not sure about the sate of the later two series in terms fo which can merge first | 16:18 |
| gibi | does the spice series close to land? | 16:18 |
| sean-k-mooney | i am +2 on the first 3 patches which is up to the api change | 16:18 |
| bauzas | I basically have no clear view on the mergeable state of those 3 series :( | 16:19 |
| sean-k-mooney | the final too add sound devices and usb to spice | 16:19 |
| bauzas | but we can try something | 16:19 |
| sean-k-mooney | so those are optional and can merge later | 16:19 |
| sean-k-mooney | gibi: so up to here https://review.opendev.org/c/openstack/nova/+/924844/29 yes | 16:19 |
| bauzas | what we can do for THIS week is to try to merge spice-direct API microversion | 16:19 |
| sean-k-mooney | thats the mvp for that feature | 16:19 |
| gibi | ack | 16:19 |
| bauzas | if we're not able to merge it, then we can discuss whether one of the two other API patches can merge before that one | 16:20 |
| bauzas | let's say during the nova meeting | 16:20 |
| bauzas | call it sprint, call it runway, I don't care | 16:20 |
| sean-k-mooney | does anyone know the state of the other two api series? | 16:20 |
| bauzas | but let's try to merge spice-direct first | 16:20 |
| sean-k-mooney | im hopign to take a pass over both thise week but have not been following them closely | 16:21 |
| gibi | sean-k-mooney: I have a one week old context on the image properties | 16:21 |
| ratailor | sean-k-mooney, functional tests are failing on my series. | 16:21 |
| gibi | there we needed extend the series for the rebuild response | 16:21 |
| gibi | I think the same requirement is true for the scheduler hints | 16:21 |
| sean-k-mooney | ack i think doug is working on that currently but i dont know the eta | 16:22 |
| sean-k-mooney | so soudn like either of those could be 2.99 and the other will get 2.100 | 16:22 |
| gibi | yepp | 16:22 |
| ratailor | sean-k-mooney, for this https://review.opendev.org/c/openstack/nova/+/939649 I am also not sure how to correctly write rebulid schema validation. | 16:22 |
| sean-k-mooney | it shoudl be identical to the server show repsponce schema | 16:23 |
| gibi | sean-k-mooney: there is no server show response schema yet in tree :) | 16:23 |
| bauzas | is anyone merging 2.100 getting a perk ? :) | 16:23 |
| sean-k-mooney | there is | 16:23 |
| gibi | rebuild has it, it needs to be extended | 16:23 |
| ratailor | sean-k-mooney, there is no server show response schema here https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/schemas/servers.py | 16:24 |
| sean-k-mooney | i tough ti linked to the chagne where it was added | 16:24 |
| sean-k-mooney | maybe show is using the rebuild schdmea but i tought this was merrged in novmber | 16:24 |
| ratailor | gibi, but the catch here is that we are adding 'image_properties' in 'properties' subkey and 'properties' has special meaning in schema validation, so we might need to change it to 'image_properties' in response. | 16:24 |
| sean-k-mooney | we can follow up after the metting | 16:24 |
| bauzas | are we then clear with what I proposed ? | 16:25 |
| ratailor | sean-k-mooney, sure. | 16:25 |
| sean-k-mooney | oh ok stephn responded so rebuild is there btu show is still pending | 16:25 |
| gibi | sean-k-mooney: yep that is my view | 16:25 |
| gibi | ratailor: even if properties is a keyword for jsonschema we should have a way to have a schema that matches a field called properties :) but I have to load context and dig | 16:26 |
| sean-k-mooney | ok ya looking at https://review.opendev.org/c/openstack/nova/+/915743/8/nova/api/openstack/compute/schemas/servers.py that correct. | 16:26 |
| sean-k-mooney | gibi: oh does it not like having a feild in the repsonce called properties | 16:27 |
| ratailor | gibi, sure. Thanks! that would be helpful. | 16:27 |
| bauzas | can we move on folks ? | 16:29 |
| sean-k-mooney | yep | 16:29 |
| bauzas | I think we agreed on the plan | 16:29 |
| sean-k-mooney | we can pick this up on gerrit or after the meeting | 16:29 |
| bauzas | we'll look where we are next week | 16:29 |
| bauzas | cool | 16:29 |
| bauzas | #topic Stable Branches | 16:29 |
| bauzas | elodilles: welcome back | 16:29 |
| elodilles | o/ | 16:30 |
| elodilles | #info nothing to report, stable gates seem to be healthy | 16:30 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:30 |
| elodilles | that's all i got | 16:30 |
| bauzas | thanks | 16:32 |
| bauzas | moving on | 16:32 |
| bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:32 |
| bauzas | fwiesel: hello | 16:32 |
| bauzas | any news so far ? | 16:33 |
| fwiesel | So, I fixed the "regression". As it turns out, I didn't clean properly up after each run in the network department, which eventually became too much. | 16:33 |
| fwiesel | Looking at the past test runs, it looks fairly stable with the one know broken test. | 16:33 |
| bauzas | bravo then | 16:33 |
| fwiesel | That's from my side. | 16:33 |
| bauzas | excellent news and thanks for the hard work on investigating the root cause and fixing it | 16:34 |
| bauzas | #topic Open discussion | 16:34 |
| bauzas | I have one topic | 16:34 |
| r-taketn | bauzas: I want to add one topic (request) , is it ok? | 16:35 |
| bauzas | r-taketn: sure, I'm just grabbing some email link, sec | 16:36 |
| r-taketn | I have another topic to mention from last week.. | 16:36 |
| bauzas | there we go | 16:37 |
| bauzas | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/3DBNNHXAPGVUX44NHH43WTDFMIDJ3X5U/ | 16:37 |
| bauzas | disabling the instance info caching | 16:37 |
| bauzas | sean-k-mooney: I guess we can move forward and propose the patch, then ? | 16:37 |
| bauzas | we said to look at the results this week | 16:38 |
| bauzas | and the only person who replied was very happy with it | 16:38 |
| bauzas | sean-k-mooney: so I guess you'll propose the instance info cache disabling patch | 16:38 |
| sean-k-mooney | ah well the patch is already up | 16:38 |
| sean-k-mooney | so we can proceed with the review | 16:39 |
| bauzas | oh my bad you're right | 16:39 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/939476 | 16:39 |
| bauzas | I'll then proceed with the review | 16:39 |
| sean-k-mooney | i have at least one typo to correct so ill respin it this evnnign or tomorrow | 16:40 |
| bauzas | ++ | 16:40 |
| bauzas | cool | 16:40 |
| sean-k-mooney | so if there are other comments ill try and adress those too | 16:40 |
| bauzas | r-taketn: your turn then | 16:40 |
| r-taketn | ok, i just added topic today's agenda. | 16:40 |
| r-taketn | Request for replies on the following - About RDT/MPAM feature | 16:40 |
| r-taketn | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/HIKLBMNMTJR6GFPKFKODECMR56SYPT5J/ | 16:41 |
| bauzas | oh sorry | 16:41 |
| bauzas | I removed it because I was thinking it was the topic we discussed last week | 16:41 |
| bauzas | but indeed, this is different | 16:41 |
| * bauzas clicks on the email | 16:41 | |
| r-taketn | Yes. I have another topic to mention from last week. | 16:42 |
| r-taketn | I'm considering the feasibility of MPAM/RDT feature within OpenStack to solve noisy neighbor problems on VM clouds. | 16:42 |
| sean-k-mooney | r-taketn: the best way to move forward with that is to start a spec and bring it up to dicuss in the ptg | 16:42 |
| sean-k-mooney | r-taketn: depending on how its mature it may be something that can be supproted | 16:42 |
| bauzas | agreed | 16:42 |
| sean-k-mooney | its a very invasive change | 16:42 |
| sean-k-mooney | which is partly why the previous efforts were abandonded | 16:43 |
| bauzas | r-taketn: the PTG dates are now known | 16:44 |
| r-taketn | I intended to discuss the feasibility of this before submitting spec because its implementation will not be simple | 16:44 |
| bauzas | r-taketn: would you be able to join us remotely ? | 16:44 |
| r-taketn | sure. | 16:45 |
| bauzas | cool thanks | 16:45 |
| bauzas | then let's discuss this at the PTG | 16:45 |
| bauzas | I need to create an etherpad for tracking those topics | 16:45 |
| sean-k-mooney | r-taketn i was off on firday and yesterday so i have not fully read your latest post on this topic | 16:45 |
| sean-k-mooney | ill see if i can do that later today | 16:45 |
| r-taketn | sean-k-mooney: Thanks | 16:46 |
| r-taketn | It's for confirming. Should I submit a spec before the PTG? | 16:46 |
| bauzas | it would be nice | 16:47 |
| bauzas | fwiw, I just created a PTG etherpad | 16:47 |
| sean-k-mooney | it does not hurt to do so, it give use somethign concrete to dicuss | 16:47 |
| bauzas | #link https://etherpad.opendev.org/p/nova-2025.2-ptg | 16:47 |
| bauzas | r-taketn: could you please add your two topics at the bottom of that etherpad ? | 16:47 |
| r-taketn | ok, i'll prepare | 16:47 |
| r-taketn | bauzas: ok i'll add | 16:47 |
| bauzas | the one we discuss last week and the other one from this week | 16:48 |
| bauzas | r-taketn: thanks | 16:48 |
| bauzas | I'll also add a couple of topics too | 16:48 |
| bauzas | and I'll tell about the PTG etherpad next week | 16:48 |
| bauzas | are we done for today? | 16:49 |
| masahito | is it okay to start adding some topics on the etherpad? | 16:49 |
| MengyangZhang[m] | I have a question. I was wondering if it is still possible to request an exception to add this bp https://blueprints.launchpad.net/openstack/?searchtext=add-burst-length-support to Eproxy. The code change is minor and is ready for review https://review.opendev.org/c/openstack/nova/+/939490 | 16:49 |
| masahito | it's quick question. | 16:49 |
| sean-k-mooney | r-taketn: https://review.opendev.org/c/openstack/nova-specs/+/662264 was the spec i wrote for RDT 5 years ago just an fyi. | 16:49 |
| bauzas | masahito: yes indeed, you can add topics | 16:50 |
| sean-k-mooney | MengyangZhang[m]: its very very late to do that | 16:50 |
| masahito | thanks. | 16:50 |
| bauzas | MengyangZhang[m]: yeah unfortunately, we're past approval freeze from 3 weeks now | 16:50 |
| bauzas | and feature freeze is in 3 weeks too | 16:50 |
| bauzas | the main reason why we have that approval freeze is for making sure we have enough capacity to review all the already approved ones | 16:51 |
| MengyangZhang[m] | understood sorry i was away for two weeks, so i will need to resubmit it for 2025-02? | 16:51 |
| bauzas | that wouldn't be fair to unprioritize some reviews by looking at some other patch, whatever big it is | 16:51 |
| r-taketn | sean-k-mooney: thanks, and sorry, i have not checked it. | 16:52 |
| bauzas | MengyangZhang[m]: unfortunately yes | 16:52 |
| MengyangZhang[m] | okk will do | 16:52 |
| bauzas | thanks | 16:53 |
| bauzas | I guess we're done then | 16:53 |
| bauzas | thanks all | 16:53 |
| sean-k-mooney | MengyangZhang[m]: the folder is already created and the specs for next cycle are open for review, so this could be done early next cycle | 16:53 |
| MengyangZhang[m] | do i need to re-attend nova meeting once that's updated? | 16:53 |
| sean-k-mooney | not nessisarly we can just review it once its posted | 16:53 |
| MengyangZhang[m] | okk thanks! | 16:54 |
| bauzas | MengyangZhang[m]: you don't need to attend the meeting in person, but please add it in our agenda for asking for a specless blueprint when you want | 16:54 |
| MengyangZhang[m] | ok do you have a link to the agenda? | 16:55 |
| bauzas | https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:55 |
| MengyangZhang[m] | thanks! | 16:55 |
| bauzas | just add it in the open discussion and request for a specless blueprint approval | 16:55 |
| bauzas | see the documentation here for trivial features approval https://specs.openstack.org/openstack/nova-specs/readme.html#trivial-specifications | 16:56 |
| bauzas | or ping me whenever you want | 16:57 |
| bauzas | anyway, we're almost at time | 16:57 |
| MengyangZhang[m] | thanks! | 16:57 |
| bauzas | anything anyone ? | 16:57 |
| bauzas | then thanks all | 16:58 |
| bauzas | #endmeeting | 16:58 |
| opendevmeet | Meeting ended Tue Feb 4 16:58:12 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:58 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2025/nova.2025-02-04-16.03.html | 16:58 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-02-04-16.03.txt | 16:58 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2025/nova.2025-02-04-16.03.log.html | 16:58 |
| r-taketn | Thank you for discussing. | 16:58 |
| elodilles | thanks o/ | 16:58 |
| gibi | thanks forlks | 16:58 |
| gibi | and folks even :) | 16:58 |
| fwiesel | Thanks | 16:58 |
| masahito | thanks everyone | 16:58 |
| sean-k-mooney | MengyangZhang[m]: i suspect the current impletion is missing some fucntionatliy to ensure the compute node supprot the feature when we have a mix os openstack version on different compute nodes by the way | 17:00 |
| sean-k-mooney | MengyangZhang[m]:the existin spec does not cover that properlys. | 17:00 |
| sean-k-mooney | ill leave a comment to that effect on teh current one. | 17:00 |
| ratailor | sean-k-mooney, gibi I have to leave now, its too late for me. I will update the patch tomorrow and we can discuss then. | 17:02 |
| masahito | gibi sean-k-mooney: if you have time, please review this bug fix again. The new patchset returns null at list API in both no pinned az case and no request spec case. https://review.opendev.org/c/openstack/nova/+/939658 | 17:02 |
| gibi | ratailor: sure. I also don't have time right now to load context there | 17:02 |
| ratailor | gibi, sean-k-mooney ack. Thanks! | 17:02 |
| sean-k-mooney | gibi: ratailor i suggested just adding additional_properties=True | 17:02 |
| gibi | sean-k-mooney: I think stephenfin was against that | 17:03 |
| sean-k-mooney | if we cna restrict that only a filed called properties in the image object then that woudl be better | 17:03 |
| gibi | and I also would like to be at least specific on the level of string keys, with length check | 17:03 |
| gibi | and charset check | 17:03 |
| sean-k-mooney | we could do that | 17:04 |
| sean-k-mooney | what i want to avoid is listing the speicic image properties | 17:04 |
| sean-k-mooney | specicicly becasue adding a new image property is not an api change today so we should not encode the set of options in the respocne schema | 17:04 |
| sean-k-mooney | but im ok with encodeign some general restrictions. image properties are not free from so its less problatic then other files but we can still do some level fo validation | 17:06 |
| gibi | yeah, lets try to be strict about having a field "properties" and that it is an object with string key values with some length and charset requirements | 17:06 |
| gibi | I think we have example of such schema pieces already | 17:07 |
| sean-k-mooney | ack probaly server metadata? | 17:07 |
| gibi | yeah that is a good candidate | 17:09 |
| sean-k-mooney | im not sure if the schema for that has merged or not but its the clsoet i can think of. the server tags api is not key:value if i recall, aggreate metadata woudl be another option to look at too | 17:10 |
| gibi | jsonschema is OK with a field called properties https://paste.opendev.org/show/b8Vs43sf3PThcDuMbjIn/ | 17:14 |
| gibi | I will link this to the patch as ratailor is offline... | 17:14 |
| sean-k-mooney | cool, i agree with the restirction you were proposing so can you capture that in your comment also | 17:15 |
| sean-k-mooney | i.e. lenght/charset enforcement | 17:15 |
| gibi | done :) | 17:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug/2097359 https://review.opendev.org/c/openstack/nova/+/940603 | 17:20 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | 17:20 |
| opendevreview | Fabian Wiesel proposed openstack/nova master: Re-raise exception for failed reboot for error reporting. https://review.opendev.org/c/openstack/nova/+/940725 | 17:24 |
| gibi | Salah Hazaa: I see that you updated my review in https://review.opendev.org/c/openstack/nova/+/937275 was there any particular reason to do so? I will going to restore my version of that review now... | 17:55 |
| sean-k-mooney | gibi: im kind of confused by there coment with just a sha or change id | 17:59 |
| sean-k-mooney | its not the first time i have seen someone do that recently | 17:59 |
| sean-k-mooney | it makes me wonder if thsoe are bot comments or similar | 18:00 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [CI][nova-next]test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275 | 18:00 |
| sean-k-mooney | same thing here https://review.opendev.org/c/openstack/requirements/+/940448/comments/53acb822_bf3e4455 | 18:01 |
| gibi | I think the person tried to resolve my review in merge conflict but failed | 18:01 |
| sean-k-mooney | maybe but that does not explian the same behaivor on the requirements patch | 18:01 |
| gibi | yeah | 18:02 |
| sean-k-mooney | and here https://review.opendev.org/c/openstack/releases/+/931314 | 18:02 |
| sean-k-mooney | to me its sus that they comemnted the same tyep of hash comment on releas eand reqiuremnts patches in 19 seconds appart, | 18:04 |
| sean-k-mooney | the comment on your patch was a few hours later | 18:05 |
| gibi | we can try to reach out to the email the account has on file in gerrit | 18:05 |
| sean-k-mooney | perhaps, frickler also asked about thi son a diffetn review if i recall | 18:06 |
| gibi | anyhow I'm done for today. See you tomorrow o/ | 18:07 |
| sean-k-mooney | frickler: it seams to be a recurring pattern where all there comments are a sha or review link of some kind https://review.opendev.org/dashboard/37702 | 18:12 |
| sean-k-mooney | often the comment is just the change id or gerrit query url with the change id | 18:15 |
| bauzas | gmann: I counted 23 jobs running on check pipeline for nova | 18:49 |
| bauzas | gmann: I forgot context but I guess we still need to run the two jobs for the old rbacs and the new default policies ? | 18:50 |
| gmann | bauzas: I think we can do only old rbac, I kept new rbac because of cinder still not default to new RBAC but that we can in tempest gate and that should be enough | 18:52 |
| gmann | I will cleanup that today | 18:52 |
| gmann | bauzas: Also, we can run old rbac as periodic. As we are checking periodic jobs in weekly meeting, that should be enough. what you say? | 18:53 |
| *** iurygregory_ is now known as iurygregory | 18:55 | |
| bauzas | gmann: yeah I guess we can run old rbac in periodic, provided we get the list of periodics :) | 18:57 |
| bauzas | this time, I wasn't able to get that list :) | 18:57 |
| gmann | ack, will propose change today | 19:00 |
| mikal | sean-k-mooney: good morning. I _think_ that CI should pass on https://review.opendev.org/c/openstack/nova/+/926126/12 once the trait merges. The unit tests pass locally for me at least. That said, I haven't done a compute service version bump, is that needed when new hypervisor traits are introduced? | 19:06 |
| sean-k-mooney | ack. its passing for the first 3 patches and the failures do seam to be related to the traits | 19:07 |
| sean-k-mooney | so i agree it shoudl pass when we add the traits | 19:08 |
| sean-k-mooney | and do a release | 19:08 |
| mikal | Any thoughts on if there is anything missing from that sound patch now? If you think its basically complete I'll go spend some time doing the same thing to the USB one. | 19:22 |
| sean-k-mooney | mikal: im going to try and finsih aroudn the top of the hour ill see if i can review it before i do. | 19:24 |
| mikal | sean-k-mooney: cool, thanks. No pressure. If you don't get to it I'll just move onto the USB one anyways and I can always circle back. | 19:24 |
| sean-k-mooney | actully looking at the change files im not seeing a comptue service bump or min version check | 19:24 |
| mikal | Yeah, that's what I was asking above -- I assume I need those, but I haven't done them before. Where are they? | 19:25 |
| sean-k-mooney | if we go the traits route without those we need a addtional change to enforce the trait request. | 19:26 |
| sean-k-mooney | ah am one sec | 19:26 |
| sean-k-mooney | the service version is defiend here https://github.com/openstack/nova/blob/master/nova/objects/service.py#L34 | 19:26 |
| mikal | Hmmm. Bump twice or bump that at the end after the sound and USB traits have both landed? | 19:27 |
| sean-k-mooney | when we add a new feature tha tneed supprot form the compute manger we add a new constant here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L106-L126 | 19:28 |
| sean-k-mooney | and then add a check on the relevent api action i.e spawn and rebuild in yoru case | 19:28 |
| sean-k-mooney | so we tend to define a check funciton like this _check_support_vnic_accelerator https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1054C9-L1054C40 | 19:29 |
| mikal | Hmmm. How do you define support there? Is that any API request that wants USB or sound, or any API request which needs a compute manager with the SPICE direct code? | 19:30 |
| sean-k-mooney | so you are addign a genic feature to add usb device or sound cards | 19:30 |
| mikal | That is, for the SPICE direct console type to work, you cannot be running an ancient compute manager because it would generate the wrong domain XML. | 19:30 |
| sean-k-mooney | so its not spice specific its server creeate which we validate in _validate_and_build_base_options | 19:30 |
| sean-k-mooney | like this https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1151-L1171 | 19:31 |
| sean-k-mooney | and rebuild | 19:31 |
| mikal | Ahhh, ok. And then the API microversion protects the overall SPICE direct feature I suppose. | 19:31 |
| sean-k-mooney | correct | 19:31 |
| mikal | Ok, that makes sense to me. | 19:31 |
| mikal | In that case I'll take a swing at doing that version bump and so forth today before I move onto the USB traits stuff. | 19:32 |
| sean-k-mooney | the min compute service check it just to make sure we dotn try to create the vm on a compute node that does not know about the new image properties | 19:32 |
| sean-k-mooney | ya so there should be 2 bumps one for sound and one for usb | 19:32 |
| mikal | Yep. | 19:32 |
| sean-k-mooney | the sound traits are really just for schduing to a host that supprot virtio since that is the only one that is not supproted by our min libvirt | 19:33 |
| sean-k-mooney | without the trait we woudl jsut get a late build error with the instance in error | 19:33 |
| mikal | How does the API microversion protect against old compute managers though? Is it simply a case that we require operators upgrade hypervisors before the API servers and that protects against compute managers which don't know how to generate that domain XML? | 19:33 |
| sean-k-mooney | no the api does not | 19:34 |
| sean-k-mooney | for one we now supprot n-2 for slup release | 19:34 |
| sean-k-mooney | so we coudl have an epoxy api and caracal compute | 19:34 |
| sean-k-mooney | the microvsion does not help with that | 19:34 |
| sean-k-mooney | that what the min compute service check in the api is for | 19:35 |
| mikal | Yeah, so I'd need a version check in get_console() (or whatever it was called) as well then right? | 19:35 |
| mikal | Not just spawn and rebuild? | 19:35 |
| sean-k-mooney | not in this case | 19:36 |
| sean-k-mooney | get console does not actully create a spice console | 19:36 |
| opendevreview | Ghanshyam proposed openstack/nova master: [Trivial] Fix the typo error https://review.opendev.org/c/openstack/nova/+/937744 | 19:36 |
| opendevreview | Ghanshyam proposed openstack/nova master: Cleanup RBAC jobs in check/gate pipeline https://review.opendev.org/c/openstack/nova/+/940737 | 19:36 |
| mikal | Oh true, it just wires it up. Its already in the domain XML by that point. | 19:36 |
| sean-k-mooney | i need to check your patch but the sound device is only added if you request it right | 19:37 |
| opendevreview | Ghanshyam proposed openstack/nova master: Cleanup RBAC jobs in check/gate pipeline https://review.opendev.org/c/openstack/nova/+/940737 | 19:37 |
| sean-k-mooney | via the image property | 19:37 |
| sean-k-mooney | well or flavor extra spec | 19:37 |
| mikal | sean-k-mooney: that is my recollection, but I'd have to double check too. | 19:37 |
| sean-k-mooney | ok so your supproting extra specs so we also need to account for resize | 19:38 |
| sean-k-mooney | the server create check prevcent new isntnace usign the fature until everything is upgraded and resize/rebuild checks prevent exisitng instnce form using it until the cloud is fully upgraded | 19:38 |
| mikal | Yeah, if you don't specify a sound model then you don't get one in the domain XML according to _add_sound_device() | 19:39 |
| mikal | Ok. | 19:39 |
| sean-k-mooney | ack thats what i was expecting | 19:39 |
| mikal | Yeah, I'm just old and forgetful. This code is probably over six months old now and I forget some of the finer details sometimes. | 19:39 |
| sean-k-mooney | i dont expect perferct recall, i reviewd it 5 days ago and while i tought that what it did i still had to check | 19:40 |
| sean-k-mooney | its sometimes hard to seperate on irc, what does it actully do, vs what woudl i do, without actully looking at the patch | 19:41 |
| mikal | So yeah, I think I have a plan for today at least then. I'll do the sound compute service bumps and checks and hopefully have something for you to take a look at while I'm asleep. | 19:42 |
| mikal | Thanks again for your help. | 19:42 |
| sean-k-mooney | so other then the version check there is only one other thing that is possibel missing | 19:42 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/926126/12/nova/virt/libvirt/driver.py | 19:42 |
| sean-k-mooney | you are not checkign if libvirt suprpot the requested sound device modle for virtio | 19:43 |
| sean-k-mooney | oh | 19:43 |
| sean-k-mooney | never mind that version 12 of 26 | 19:44 |
| sean-k-mooney | ok in the latest veriosn that is still missing | 19:44 |
| mikal | No I think you're still right. I don't think the domain XML generation checks if the hypervisor has virtio sound. | 19:44 |
| mikal | Yeah, I had assumed the trait would protect against incoming requests that couldn't be supported. | 19:44 |
| sean-k-mooney | so the trait can but you missing a addtional change to enforce it | 19:45 |
| sean-k-mooney | oh maybe not | 19:45 |
| mikal | Ok, I can add one there as well. I presume I just raise an exception if I can't support virtio sound there? | 19:46 |
| sean-k-mooney | well you added https://review.opendev.org/c/openstack/nova/+/926126/26/nova/scheduler/request_filter.py | 19:46 |
| sean-k-mooney | mikal: ya i think i suggested one in a previous revision | 19:46 |
| sean-k-mooney | mikal: so looking at https://review.opendev.org/c/openstack/nova/+/926126/26/nova/scheduler/request_filter.py | 19:48 |
| sean-k-mooney | they way you chose to add an uncontintiol prefilter means we coudl skip the min version check | 19:49 |
| sean-k-mooney | as that trait will only be present if the host is upgraded | 19:49 |
| sean-k-mooney | actully not that only covers the virtio cases | 19:49 |
| sean-k-mooney | so we need both | 19:49 |
| sean-k-mooney | it does mean you dont need the check in the xml generation as currently written | 19:50 |
| mikal | All the other sound models have been supported for ages though, so apart from virtio do any of them actually need a check? | 19:50 |
| sean-k-mooney | as you will never get schduled to a host that does not suport virtio | 19:50 |
| sean-k-mooney | no only virtio need to be checked | 19:50 |
| mikal | So doesn't that unconditional prefilter mean I don't need a service bump at all then? | 19:51 |
| sean-k-mooney | we still need the min versin check to protect non upgraded hosts | 19:51 |
| sean-k-mooney | no we need to make sure if you request a diffent model that you land on an upgrade host | 19:51 |
| sean-k-mooney | its almost enouch but not quite | 19:51 |
| mikal | Ok | 19:51 |
| sean-k-mooney | for usb we dont need a prefilter like this since all host that have the correct compute service verion will supprot it | 19:52 |
| sean-k-mooney | mikal: so ya only the comptue service check is missing form the sound change you do not need the xml generation check | 19:53 |
| mikal | So I'm a little confused about why we need USB controller traits at all then? | 19:53 |
| sean-k-mooney | the usb ones are not needed | 19:53 |
| sean-k-mooney | only the virtio one for sound is really required | 19:53 |
| mikal | Yeah, because the others are basically hard coded to true. | 19:53 |
| sean-k-mooney | yep | 19:53 |
| mikal | I guess maybe it matters if another hypervisor wanted to use these extra specs... | 19:54 |
| mikal | That is, I don't think I should remove them from the os-traits patch. | 19:54 |
| sean-k-mooney | technially yes | 19:54 |
| sean-k-mooney | the are ok to keep IMO | 19:55 |
| mikal | I should let you escape. I'll take a swing at the version checks today. | 19:55 |
| sean-k-mooney | ack. i may or may not be back briefly later but if not ill try and review again tomorrow | 19:56 |
| sean-k-mooney | mikal: did you see the nova meeting conversation | 19:56 |
| mikal | About the order of landing the API changes? Yes, that made me happy to be completely honest. | 19:56 |
| sean-k-mooney | cool, ya so hopefully we can get at least the first 3 patches and perhaps all 5 merged this week if others have time to review | 19:57 |
| mikal | I appreciate you handholding me along the way. Thank you. | 19:57 |
| mikal | I think that gaming company probably still want the USB one at least, so it would be nice to get all of them in, but I understand we're starting to run out of time. | 19:57 |
| sean-k-mooney | we still ahve 3 weeks so it think its doabel if we get the first 3 this week | 19:58 |
| mikal | This makes me happy. | 19:58 |
| mikal | Well, I'll let you get on with your life. | 19:58 |
| sean-k-mooney | i think there name was shadow https://shadow.tech/ i think | 19:58 |
| mikal | Yeah, that's them. | 19:59 |
| mikal | Maxime Lubin was commenting on the USB patch at one point, but I haven't seen anything recently. | 20:00 |
| frickler | sean-k-mooney: gibi: fyi we (infra-root) noticed some weird activity by that account earlier and we disabled it yesterday | 20:31 |
| sean-k-mooney | frickler: ack, i was not sure it was the same account but i did see those strange comments | 20:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!