| opendevreview | Masahito Muroi proposed openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | 01:23 |
|---|---|---|
| opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing instance-action finish_time https://review.opendev.org/c/openstack/nova/+/928933 | 11:33 |
| *** iurygregory__ is now known as iurygregory | 11:50 | |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943753 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943754 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943756 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/osc-placement/+/943757 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/osc-placement/+/943758 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/osc-placement/+/943759 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943762 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943763 | 14:36 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943764 | 14:36 |
| *** whoami-rajat_ is now known as whoami-rajat | 15:04 | |
| opendevreview | Merged openstack/os-vif stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943753 | 15:11 |
| opendevreview | Merged openstack/os-vif stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943754 | 15:12 |
| opendevreview | Merged openstack/os-vif master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943756 | 15:12 |
| dansmith | gibi: if I look at the allocations that we have in the resource tracker before we do the local claim stuff, I don't see any for the pci device | 15:42 |
| dansmith | ...but I should right? | 15:42 |
| dansmith | yeah, they're in the actual allocations in placement, they're just not like added to the allocations we pass down to the compute node.. | 15:44 |
| gibi | dansmith: allocation is made in placement, the InstancePCIRequest carries the information about what RPs are fulfilling what request by placement. | 15:54 |
| dansmith | yeah I guess I would just expect those to be in our list of allocations | 15:54 |
| gibi | when you say "allocation" what you mean exactly? | 15:55 |
| gibi | the pci claim only happens on the compute side. so the pci tracker has no information about the allocation until the pci claim happens on the comptue side | 15:57 |
| dansmith | gibi: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L142 | 16:03 |
| dansmith | that allocations variable is a dict of {rp_uuid: {allocation_dict}} | 16:04 |
| dansmith | in this case, it has the local compute node's rp_uuid and allocations for memory, etc, but not the pci allocations | 16:04 |
| dansmith | to me, it should be "all the allocations that have been made for this instance".. or at least, that's what I expect | 16:05 |
| gibi | yeah that should have it | 16:08 |
| gibi | do you have pci_in_placement enable? | 16:08 |
| gibi | https://github.com/openstack/nova/blob/276685b3db6e8f2ad59c33bc254461c255700ff8/nova/compute/manager.py#L2615C1-L2617C40 | 16:09 |
| gibi | we load allocation from placement before the instance_claim call | 16:09 |
| gibi | so if you see the allocation in placement then the same data should be in the allocation dict in the claim call | 16:10 |
| dansmith | yes, the allocations get made in placement, and the pci device has the rp_uuid in the extra_info, it's just never getting merged | 16:10 |
| gibi | I suggest to trace how we read the allocations from placement before the instance_claim call | 16:11 |
| dansmith | the device that we get back from the pci claim also doesn't get the new key in extra_info that I'm putting in device_spec | 16:12 |
| dansmith | gibi: okay I thought those were passed down via rpc and not re-loaded in compute, but I could be wrong | 16:12 |
| dansmith | but yeah I see that get_allocations_for_consumer() call.. it's almost like that's filtering for just our RP or something | 16:13 |
| gibi | dansmith: for the devspec => dev data move you need to extend this https://github.com/openstack/nova/blob/276685b3db6e8f2ad59c33bc254461c255700ff8/nova/pci/devspec.py#L418 | 16:14 |
| dansmith | ah, okay I added the key in the update, like this: https://review.opendev.org/c/openstack/nova/+/942144/4/nova/objects/pci_device.py | 16:15 |
| dansmith | and I see it in the "final resource view" when n-cpu starts, but not when I get it back from the pci claim | 16:15 |
| dansmith | I'll add it there too | 16:15 |
| gibi | I need to drop. It was a long week. I will try to check back later today but more likely only on monday | 16:16 |
| dansmith | no prob, thanks | 16:16 |
| dansmith | yep, that did it | 16:19 |
| gibi | ohh if you see the allocation in placement but not during claim then it must be the allocation healing that creates the allocation in placement and not the scheduler. pci_in_placement flag needs to be true in the config not just report_in_placement | 16:23 |
| dansmith | hmm | 16:32 |
| opendevreview | Merged openstack/python-novaclient master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943764 | 17:15 |
| dansmith | gibi: aha, yep, that does it, thanks | 17:22 |
| opendevreview | Merged openstack/nova stable/2024.2: Reproduce bug/2097359 https://review.opendev.org/c/openstack/nova/+/942085 | 17:36 |
| opendevreview | Merged openstack/nova stable/2024.2: Update InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/942086 | 18:09 |
| opendevreview | sean mooney proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | 18:11 |
| opendevreview | Merged openstack/nova stable/2024.2: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/942087 | 18:13 |
| opendevreview | sean mooney proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | 18:16 |
| sean-k-mooney | gibi: ^ this is a less dramtic rewite tha tavoid round triping the data via the object when we are composing the responce | 18:17 |
| sean-k-mooney | gibi: so it will keep the keys and values matching what we have in the system_metadta_table | 18:17 |
| sean-k-mooney | of couse if we normalised the values before we saved them there is noting we can do at this point | 18:18 |
| opendevreview | sean mooney proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | 18:22 |
| sean-k-mooney | fixed pep8 issue | 18:22 |
| sean-k-mooney | am im going to finish now ish and i assume you already have so no rush with ^ | 18:22 |
| opendevreview | Dan Smith proposed openstack/nova master: WIP: Reserve OTU devices https://review.opendev.org/c/openstack/nova/+/943816 | 18:30 |
| dansmith | shockingly, that seems to work ^ | 18:30 |
| sean-k-mooney | that looks shorter then im expecting | 18:31 |
| dansmith | well, I wasn't thinking it would be huge given it's technically a simple thing to do, | 18:31 |
| sean-k-mooney | oh | 18:32 |
| dansmith | but yeah | 18:32 |
| sean-k-mooney | your doing it in update_provider_tree | 18:32 |
| dansmith | yeah so I'm adding some review comments about why | 18:32 |
| sean-k-mooney | ok | 18:33 |
| sean-k-mooney | we just make sure that that is not only working because of the perodic | 18:33 |
| sean-k-mooney | or we would have a gap where if we spawned and delete right after each other it might not run | 18:33 |
| dansmith | it's not, but obviously tests | 18:34 |
| opendevreview | Merged openstack/nova master: Update manager to allow vfio pci device live migration https://review.opendev.org/c/openstack/nova/+/942145 | 20:17 |
| *** winicius is now known as wncslln | 21:39 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!