| ishanwar[m] | Hi Everyone... (full message at <https://matrix.org/oftc/media/v1/media/download/ATMsTmYRC_O_5NLksmXpDcjurxmdUL5FvXvyOxE41THD5qlnXpbAklDgHgDUmLVge3chX9vGZMMSxjhL6pv2-jxCeW8Xnj2gAG1hdHJpeC5vcmcvcVNBSnNRU2tBaXZkck1PcEJLQVBLYWN6>) | 06:13 |
|---|---|---|
| opendevreview | Ishan Shanware proposed openstack/nova master: [FEAT]: using quota_details to optimize validate networks [FIX]: added error handling for .get() statements [FIX]: pep8 formatting fixed for changes https://review.opendev.org/c/openstack/nova/+/948988 | 06:54 |
| opendevreview | Ishan Shanware proposed openstack/nova master: [FEAT]: using quota_details to optimize validate networks [FIX]: added error handling for .get() statements [FIX]: pep8 formatting fixed for changes https://review.opendev.org/c/openstack/nova/+/945204 | 06:56 |
| ishanwar[m] | <ishanwar[m]> "Hi Everyone..." <- I want to get this merged so need your help | 06:58 |
| sean-k-mooney | ishanwar[m]: the failed indicate taht your missing mocking | 09:25 |
| sean-k-mooney | you added | 09:26 |
| sean-k-mooney | @mock.patch( | 09:26 |
| sean-k-mooney | "nova.network.neutron.API.has_quota_details_extension", | 09:26 |
| sean-k-mooney | new=mock.Mock(return_value=True), | 09:26 |
| sean-k-mooney | ) | 09:26 |
| sean-k-mooney | but you only did that to your test | 09:26 |
| sean-k-mooney | the function you added is called in several other test that do not have the mock in place | 09:26 |
| sean-k-mooney | so for the 5 failing test you also need to mock the call to has_quota_details_extension | 09:27 |
| gibi | sean-k-mooney: dansmith: FYI I noted some memory consumption numbers with the reduced scatter-gather pool size in https://review.opendev.org/c/openstack/nova/+/948450/comments/9ff461df_ec6381b2 It seems we have a good handle on managing memory consumption by managing the pool size. | 12:05 |
| gibi | 40 threads -> 122MB RSS, 5 threads -> 85MB RSS, eventlet based scheduler 56MB RSS | 12:07 |
| sean-k-mooney | cool that looks reasonable. although we are planning to have multiple pools in some cases | 12:14 |
| sean-k-mooney | i guess for conductor api and schduelr we likely will only need the scater gater pool | 12:14 |
| sean-k-mooney | and for the compute we will only need the io one | 12:14 |
| sean-k-mooney | out side of the oslo.messaging one | 12:14 |
| sean-k-mooney | so we are proably fine | 12:15 |
| sean-k-mooney | i belive in my paches i reused the generic io threadpool for ceph but if we are removing that expict usage anyway and leavign the librbd/rados package handel that internally then that fine too | 12:16 |
| gibi | yeah currently I have no data abou the pool in oslo.messaging. But obviously that is changed too as soon as we switched off monkey patching | 12:16 |
| gibi | but we have a config option to limit that pool too (default is 64) | 12:17 |
| sean-k-mooney | i assume that if that is configurable it will be expsoed as an oslo.messaging config option which we will jsut inherit | 12:17 |
| gibi | yepp | 12:17 |
| gibi | it is | 12:17 |
| sean-k-mooney | cool | 12:17 |
| sean-k-mooney | 64 seam a little higher then i woudl expect but we can role with it and see | 12:17 |
| sean-k-mooney | for the conductor or schduler i guess that might be reasonable to have 64 RPCs in flight at once | 12:18 |
| sean-k-mooney | the api and comptue dont really need it that large | 12:18 |
| sean-k-mooney | tooling and admins can tune it however once we gain experince iwth the impact on scaling | 12:19 |
| gibi | yepp | 12:23 |
| gibi | I will include a list of tunables in a new doc | 12:23 |
| *** ralonsoh is now known as ralonsoh_out | 15:15 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Use futurist for _get_default_green_pool() https://review.opendev.org/c/openstack/nova/+/948072 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Print ThreadPool statistics https://review.opendev.org/c/openstack/nova/+/948340 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: WIP: allow service to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | 15:40 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | 15:40 |
| *** __ministry is now known as Guest15360 | 16:06 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Print ThreadPool statistics https://review.opendev.org/c/openstack/nova/+/948340 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: WIP: allow service to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | 19:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | 19:58 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!