| gmaan | stephenfin | 01:07 |
|---|---|---|
| gmaan | stephenfin: when you have time, can you please check these specs https://review.opendev.org/c/openstack/nova-specs/+/937650 https://review.opendev.org/c/openstack/nova-specs/+/951218 | 01:08 |
| stephenfin | gmaan: ack, will do | 10:11 |
| stephenfin | gmaan: let me know if you want to discuss https://review.opendev.org/c/openstack/nova/+/936368 too. I'm *very* surprised there's been so much pushback on that, since it seems a no-brainer and is spec-compliant. I suspect you (and Uggla) might be missing something and that I haven't explained it properly | 10:12 |
| opendevreview | Merged openstack/nova-specs master: Re-propose API policy service role spec https://review.opendev.org/c/openstack/nova-specs/+/951218 | 13:21 |
| gibi | Uggla: thanks for the review on the eventlet-removal series. I replied. I will respin the series based on you comments as there are points that worth to mention in the commit messages / doc tests | 13:54 |
| Uggla | gibi, you're welcome. I have not continue reviewing the serie today, but I will try tomorrow or next week. | 13:55 |
| gibi | cool | 13:56 |
| Uggla | Maybe I should recommend for reviewers to read your latest blog post, before reviewing the first patch. It clarifies the context and the "service worker" bug. | 14:06 |
| gibi | yeah the blog is there to give more context that is hard to give via a single commit message as it is not related to a single commit but a series of commits / events | 14:08 |
| stephenfin | Uggla: Got another one for you to revisit when you have a chance https://review.opendev.org/c/openstack/nova/+/937047 | 14:32 |
| gmaan | stephenfin: thanks for review specs. for 936368, I will ping you top of hr, hope that is not late for u. | 15:10 |
| stephenfin | ack | 15:10 |
| gmaan | stephenfin: I read your reply, let me check some test for non-string as part of jsonschema as whole. I agree not to include those in format-checker tests | 16:43 |
| opendevreview | Pierre Riteau proposed openstack/nova master: doc: Fix Caracal release number https://review.opendev.org/c/openstack/nova/+/951883 | 16:46 |
| gmaan | stephenfin: I am good on 936368, found the testing in controller tests which is what I was looking for | 17:22 |
| gmaan | sean-k-mooney: in case you forgot :), manager role spec is ready https://review.opendev.org/c/openstack/nova-specs/+/937650 | 17:23 |
| sean-k-mooney | ill take a look later this evening | 17:29 |
| sean-k-mooney | ah you renamed the file so i cant just see what chagned between v5 and v9 no worreis | 17:29 |
| gmaan | for v5, yes it is renamed but you can see from ps7-ps9 (your last +1 ) https://review.opendev.org/c/openstack/nova-specs/+/937650/7..9 | 17:46 |
| sean-k-mooney | ack im writing something up which will take me about anouther hour or so. ill try an take a look after that | 18:02 |
| opendevreview | Merged openstack/nova master: Remove contrib/clean-on-delete.py https://review.opendev.org/c/openstack/nova/+/950592 | 20:14 |
| opendevreview | Merged openstack/nova master: doc: Fix Caracal release number https://review.opendev.org/c/openstack/nova/+/951883 | 20:14 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!