| stephenfin | gmaan: When you're around, I think I've addressed your comments (via follow-ups) on the following: https://review.opendev.org/c/openstack/nova/+/937047/ https://review.opendev.org/c/openstack/nova/+/937048/ https://review.opendev.org/c/openstack/nova/+/937246/ | 11:22 |
|---|---|---|
| stephenfin | and sean-k-mooney: you can probably re-add your +2 on https://review.opendev.org/c/openstack/nova/+/937048/ also since I have a follow-up now | 11:23 |
| sean-k-mooney | ack so it was just in the test code | 11:26 |
| sean-k-mooney | and only 5 tests at that | 11:27 |
| sean-k-mooney | stephenfin: done | 11:28 |
| *** elodilles is now known as elodilles_ooo | 12:33 | |
| stephenfin | Uggla: On https://review.opendev.org/c/openstack/nova/+/940114, I had intentionally included since-removed values in the enum ('xvpvnc') since the schemas need to work for all versions of Nova. Does that make sense? | 14:21 |
| stephenfin | IMO, the api-ref should probably list those also since that's unversioned. I removed them I2f7f2379d0cd54e4d0a91008ddb44858cfc5a4cf. Perhaps I should add them back but with a warning that they won't work on modern (>= Ussuri) nova | 14:22 |
| gmaan | stephenfin: ack, could not finish on friday but I will continue on those today. | 15:05 |
| opendevreview | Arnaud Morin proposed openstack/nova master: Fix small documentation issue https://review.opendev.org/c/openstack/nova/+/952151 | 16:15 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!