| opendevreview | Rajesh Tailor proposed openstack/nova-specs master: Show finish_time field in instance action show https://review.opendev.org/c/openstack/nova-specs/+/929780 | 06:10 |
|---|---|---|
| opendevreview | Lajos Katona proposed openstack/os-vif stable/2025.1: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/952567 | 08:57 |
| *** tosky_ is now known as tosky | 09:49 | |
| opendevreview | Merged openstack/nova master: Remove Unicode characters https://review.opendev.org/c/openstack/nova/+/952621 | 11:11 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | 11:23 |
| *** elodilles is now known as elodilles_pto | 12:20 | |
| opendevreview | Merged openstack/nova master: api: Address issues with instance actions API https://review.opendev.org/c/openstack/nova/+/951941 | 15:05 |
| Uggla | Reminder that tomorrow is spec review day. | 16:12 |
| bauzas | Uggla: good point, thanks for the reminder ! | 16:39 |
| Uggla | bauzas, you are welcome. | 16:39 |
| sean-k-mooney | oh ya... i had forgotten about that | 16:39 |
| Uggla | And we have a lot of spec to review. | 16:42 |
| gibi | dansmith: sean-k-mooney: do I see it correctly that the build_and_run_instance does not ever report error and revert task state at failure via these decorators as the implementation immediately calls spawn but never waits for the result so the error is not raised back? https://github.com/openstack/nova/blob/64ca204c9cf497b0dcfff2d3a24b0dd795a57d1d/nova/compute/manager.py#L2341-L2344 | 17:33 |
| gibi | I need to drop but I can read back tomorrow and try to reproduce it as a bug | 17:34 |
| dansmith | looks like it | 17:35 |
| dansmith | maybe those decorators need to be moved to the inner _locked funciton | 17:35 |
| dansmith | the finally in there will mark the instance is error I think, so it might only be the task_state (not important on a new instance you are going to delete) and the event (which might not be noticed either) | 17:36 |
| sean-k-mooney | ya that looks like what is happening dan is likely correct about moving them although we woudl have to look at git blame to see when/how they were orgianlly added | 18:29 |
| sean-k-mooney | it looks like we used to do some network validation https://opendev.org/openstack/nova/commit/1d8eddb2614de8daaddddd64ad1a8de4c215fe7a | 18:32 |
| sean-k-mooney | well no not validation exactly | 18:33 |
| sean-k-mooney | its possibel althogh unlikely that the objects.NetworkRequest.from_tuple(t) calls coudl have raised. | 18:34 |
| sean-k-mooney | _do_build_and_run_instance seams to have the real logic that we need those decorator for. | 18:35 |
| sean-k-mooney | ah https://opendev.org/openstack/nova/commit/437a1e92c11d51fb828d355091cdcdd4694dfed7 that when they were actully added | 18:37 |
| sean-k-mooney | and orgianlly we did not use spawn_n. it is technically possibel for @utils.synchronized(instance.uuid) to raise as well | 18:38 |
| opendevreview | melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628 | 21:32 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | 21:32 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | 21:32 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 21:32 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 21:32 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: update instance request_spec with secret security https://review.opendev.org/c/openstack/nova/+/952630 | 21:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!