| auniyal | hi sean-k-mooney, will you have access to merge this in nova-disgit | 06:36 |
|---|---|---|
| auniyal | https://review.rdoproject.org/r/c/openstack/nova-distgit/+/58076 | 06:36 |
| auniyal | can you please provide review comments | 06:37 |
| auniyal | we have only 1 nova-disgit core - sahid.ferdjaoui@redhat.com | 06:38 |
| auniyal | https://review.rdoproject.org/r/admin/groups/1abd61acb05653e6333e01582fe4b118a7febc8c,members | 06:38 |
| auniyal | sahid ? | 06:38 |
| sean-k-mooney | auniyal: i did until october whne i asked to be removed form the list rdo cores for nova. artom and gibi have core rights | 10:33 |
| sean-k-mooney | currently the only core right i still have in rdo are for cyborg | 10:34 |
| sean-k-mooney | melwitt: commeted on the bug | 10:40 |
| sean-k-mooney | https://review.rdoproject.org/r/admin/groups/1abd61acb05653e6333e01582fe4b118a7febc8c,members | 10:41 |
| sean-k-mooney | that is not the group we use | 10:41 |
| sean-k-mooney | we use https://review.rdoproject.org/r/admin/groups/d90e2cf3a41ddec7e571c67ce63e10aed1b4e363,members but it looks like artom has not updated that yet to add gibi | 10:41 |
| sean-k-mooney | anyway this is more a downstream or rdo converstaion since its not really in the scope fo the nova project | 10:42 |
| auniyal | sean-k-mooney ack, | 12:06 |
| sean-k-mooney | auniyal: there may be a review open ot update the list | 12:06 |
| auniyal | still can you please have a look patch is okay | 12:06 |
| auniyal | I added sahid, hopefully they will look | 12:08 |
| sean-k-mooney | sahid does not work on this anymore | 12:08 |
| sean-k-mooney | they may but its unlikely | 12:08 |
| sean-k-mooney | so the patch shoudl be propsoed againt master first | 12:09 |
| sean-k-mooney | not direclty to andeploe liek this | 12:09 |
| sean-k-mooney | and you will need to backprot it in rdo | 12:09 |
| auniyal | yeah I did that first https://review.rdoproject.org/r/c/openstack/nova-distgit/+/58075 | 12:09 |
| sean-k-mooney | right but you abandoned it | 12:10 |
| auniyal | bust as we need this in 18 (downstream) I thought antelope is correct one | 12:10 |
| sean-k-mooney | so it was not the wrong branch it ned to land there first and then backprot it to antelope | 12:10 |
| auniyal | also I saw this - https://review.rdoproject.org/r/c/openstack/nova-distgit/+/57752 | 12:10 |
| sean-k-mooney | that is diffent | 12:11 |
| auniyal | oh okay, sure will create the backports then | 12:11 |
| sean-k-mooney | althogh it likely shoudl have been done to master first as well | 12:12 |
| sean-k-mooney | the reason its diffent is the depencies are diffent per branch | 12:12 |
| mohsen__ | hello dear friends. Is there anybody here who has ever tested the vCPU vs pCPU performance? | 12:16 |
| mohsen__ | I tried NUMATopologyFilter on nova scheduler along with cpu_dedicated_set config on the nova compute side. The scheduling process works completely fine. | 12:16 |
| mohsen__ | this is my nova compute config: | 12:16 |
| mohsen__ | [compute] | 12:16 |
| mohsen__ | cpu_shared_set = 18-35,54-71 | 12:16 |
| mohsen__ | cpu_dedicated_set = 0-17,36-53 | 12:16 |
| mohsen__ | consider the fact that the cpu_shared_set value is on numa node 0 and cpu_dedicated_set is on numa node 1. | 12:16 |
| mohsen__ | The issue is that after creating instances and benchmarking vCPU and pCPU instances separately, the result was surprising. The performance of vCPU was better than pCPU. | 12:16 |
| mohsen__ | Is there anybody who has experienced the same issue? | 12:16 |
| sean-k-mooney | that likely because of other effect related to the numa toplogy | 12:17 |
| auniyal | sean-k-mooney, do you think other things are alight in patch - like file path and bin prefix like nova-contrib - do you have any comment on that | 12:17 |
| sean-k-mooney | i skimed it and ot look mostly ok but im not sure if you need to set the mode here https://review.rdoproject.org/r/c/openstack/nova-distgit/+/58076/8/openstack-nova.spec#580 | 12:18 |
| sean-k-mooney | it proably should be 755 or 644 but im not sure if that is required | 12:19 |
| mohsen__ | sean-k-mooney: What do you mean by other effect? did you mean the other instances on the same compute node can affect the result of the test? | 12:19 |
| sean-k-mooney | in general this is not somethign i review often so i alwasy have to look up the manpages for install ectra when i do | 12:20 |
| sean-k-mooney | mohsen__: no i mean if the testing your doing is using cinder volume or relys on networking | 12:20 |
| sean-k-mooney | then using numa node 1 may have higher latency then numa 0 | 12:21 |
| auniyal | I know it should be executable - I use 755 because that rest of the bins/script has set | 12:22 |
| sean-k-mooney | im talking about the directory | 12:22 |
| auniyal | install -d --> that mean mkdir -p | 12:22 |
| sean-k-mooney | not the files | 12:22 |
| sean-k-mooney | right which uses the default umask for the current process for the permsions | 12:23 |
| sean-k-mooney | im not sur eyou shoud be relying on that | 12:23 |
| sean-k-mooney | you likel yshoudl follwo the other exampels where teh mode is alwasy explcitly set | 12:23 |
| sean-k-mooney | auniyal: all other usage of `install` in that file has an explcity -m to set the mode | 12:24 |
| sean-k-mooney | so you are deviating form the conventiosn in the file | 12:24 |
| sean-k-mooney | you proably shoudl be doing install -d -m 755 | 12:24 |
| sean-k-mooney | here https://review.rdoproject.org/r/c/openstack/nova-distgit/+/58076/8/openstack-nova.spec#580 | 12:25 |
| auniyal | yeah above all setting permission to dir, | 12:26 |
| auniyal | I only thought of creating it, then setting chmod to file | 12:26 |
| auniyal | thanks Sean | 12:30 |
| mohsen__ | sean-k-mooney: So how is it possible to have pCPUs with better performance than vCPUs, along with using networking and cinder-volume to create instances? | 12:31 |
| mohsen__ | Note that once I changed the cpu_dedicated_set from one numa node to another, and the benchmarking result stayed the same. | 12:31 |
| sean-k-mooney | mohsen__: by the way on an otherwise idel system you are unlikely to see many of the beniftis of pinning. pinning helps performance for 2 reasons., 1 it enfoces a explict numa toplogy so the guest memroy and cpus are allcoated form teh same numa ndoe, (that why you shoudl alwasy set hw:mem_page_size=<some valid value> i.e. small that give about 70% of the performace boost, | 12:31 |
| sean-k-mooney | the rest comes form reducign cache misses and prevent other vms form consdume cpu time. | 12:31 |
| sean-k-mooney | mohsen__: tha tis very stragne because in the perfomnance testing we did in the past it did impove performance. the main reasoin for CPU pinning is not raw trhoughput however, it benifit is in determinisum | 12:33 |
| sean-k-mooney | it shoudl not reduce the performce vs vcpus becasue the emulation of the vcpu is identical | 12:33 |
| sean-k-mooney | all cpu pinnign does is use cgroups/taskset to prevent the kernel form movinv the cpus | 12:34 |
| sean-k-mooney | and on the nova side we prevent other vms form beign schduled to the same cores | 12:34 |
| sean-k-mooney | its why we call it cpu_policy=dedicated | 12:34 |
| sean-k-mooney | you care giveing an entire host cpu to the vm provide you are isolating other host process form those cores | 12:35 |
| sean-k-mooney | regarding newtwokrign and cidner , if your using sriov you can allcoat vfs form the local numa node or you can use a cross numa bond for the stroage network | 12:35 |
| sean-k-mooney | mohsen__: when you swap the numa nodes did you delete and recreate the vms by the way | 12:36 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for using cell-name in cell_v2 commands https://review.opendev.org/c/openstack/nova/+/954460 | 12:48 |
| mohsen__ | sean-k-mooney: Yes. I removed the old instances and after reconfiguration, created new ones. So you mean cpu performance improvement isn't necessarily the benefit of cpu pinning? | 12:50 |
| mohsen__ | having such an expectation isn't always valid? | 12:50 |
| sean-k-mooney | cpu pinning was create to provide predicable perfroamce under load | 13:25 |
| sean-k-mooney | it often provides mroe performce as a side effect of enfoceign numa affintiy between guest cpus ram and pci devices | 13:25 |
| sean-k-mooney | but most of the uplift comes enableing numa affintiy as cpu pinning implictly enables hw:numa_nodes=1 | 13:29 |
| sean-k-mooney | adding hw:numa_nodes=1 hw:mem_page_size=small | 13:30 |
| sean-k-mooney | you will get most of the performace uplift that is expect form cpu pinnin for floating guests | 13:30 |
| opendevreview | Ian Watson proposed openstack/nova master: Add migration conditional for resource tracker https://review.opendev.org/c/openstack/nova/+/955690 | 14:09 |
| sean-k-mooney | stephenfin: also interesting error in the logs https://paste.opendev.org/show/bxMqpRogUlo3jHCe2trb/ that likely related to your volume bug | 14:24 |
| sean-k-mooney | we shoudl be able to catch that and abort starting the agent and let systemd or whatever restart it | 14:24 |
| stephenfin | ooohh, good spot | 14:24 |
| sean-k-mooney | https://0908e5c3034094a51a1a-ddb50bb0d8d4f5453b9288f160ef0a30.ssl.cf5.rackcdn.com/openstack/70be4003a0ae40b4bfaae667688f694c/controller/logs/screen-n-cpu.txt | 14:25 |
| sean-k-mooney | its right in the startup just after the config is printed | 14:25 |
| sean-k-mooney | so it pretyy early | 14:25 |
| sean-k-mooney | but my guess is it never recovers form that if it happens | 14:25 |
| sean-k-mooney | so either we need to abort or retry | 14:25 |
| sean-k-mooney | well or something more indelgent then the 30s tought i have given it | 14:26 |
| sean-k-mooney | can you see if you have the same error in your logs if you have time | 14:26 |
| sean-k-mooney | stephenfin: https://tinyurl.com/yw5ynd7d | 14:28 |
| sean-k-mooney | its happening alot in the usptream jobs | 14:29 |
| stephenfin | yes, I see it in the flamingo VM. I don't see it in the bobcat VM | 14:29 |
| sean-k-mooney | across c9s ubuntu and debian | 14:29 |
| stephenfin | and I've since deleted all the other VMs | 14:29 |
| sean-k-mooney | ack | 14:29 |
| sean-k-mooney | so that likely the problem | 14:29 |
| sean-k-mooney | i dont know what the cause iss but thats a smoking gun | 14:29 |
| sean-k-mooney | i.e. i dont knwo why it does not happen after restarting nova-comptue but apprently it does not always fail | 14:30 |
| stephenfin | sean-k-mooney: dumped it into the bug https://bugs.launchpad.net/nova/+bug/2119114/comments/3 | 14:33 |
| sean-k-mooney | cool i didnt have the link to that | 14:33 |
| * stephenfin wishes they'd add markdown support (or at least code fence support) to LP... | 14:33 | |
| noonedeadpunk | ++ | 15:12 |
| cardoe | sean-k-mooney: so not sure if you saw my follow up on the vlan spec. The issue you pointed out in chat about the id field and that dansmith brought up on gerrit itself isn't something that spec can really fix right now. It's just defining the behavior of nova code today (and the behavior that its been since June 2015). | 15:24 |
| cardoe | So I'm really not sure what to fix cause that spec isn't about changing the behavior of existing "phy" interfaces. It's about including "vlan" interfaces. The "vlan" interface references to "phy" interface its running on. | 15:25 |
| sean-k-mooney | the spec si free to extend or modify the schema and change the data that is stored in specific fileds | 15:26 |
| sean-k-mooney | it is not possibel for nova ot know what the name of the Phy interface will be | 15:26 |
| sean-k-mooney | so the value that are provdie are and alwasy were informational | 15:26 |
| sean-k-mooney | you are ment ot match on things like the mac adress | 15:27 |
| sean-k-mooney | when you are consumign this to identify the phy not the id or name | 15:27 |
| sean-k-mooney | its just an identifyer for the parsing program | 15:27 |
| abhishekk | o/ can I get a review on https://review.opendev.org/c/openstack/nova/+/950623, it has one +2, this will be important change to get rid of show_multiple_locations config option | 15:29 |
| noonedeadpunk | fwiw, I've addressed comments in https://review.opendev.org/c/openstack/nova-specs/+/955783 and I think implementation is also available for preliminary review | 15:38 |
| melwitt | thanks sean-k-mooney | 15:45 |
| sean-k-mooney | abhishekk: does it work this time? :) if i recall we reverted it because there was soem issue on the glance side that needed to be adressed first | 15:47 |
| sean-k-mooney | abhishekk: ah i see dan is already +2 that reverting the revert | 15:47 |
| sean-k-mooney | ill take a look shortly | 15:48 |
| sean-k-mooney | we can always have a revert^3 patch if needed i guess. | 15:48 |
| abhishekk | sean-k-mooney: thank you!!! I have added rechecks 7-8 times on revert patch to ensure that failure does not occur again | 16:48 |
| sean-k-mooney | noonedeadpunk: oh the parallel mgtions | 17:08 |
| sean-k-mooney | we really need to create teh 2026.1 folder in the specs repo | 17:08 |
| sean-k-mooney | so you can propose that to the right pplace | 17:08 |
| sean-k-mooney | noonedeadpunk: ill try and loop back to that but it likely will be next week at this rate | 17:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (1/6) https://review.opendev.org/c/openstack/nova/+/956234 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (2/6) https://review.opendev.org/c/openstack/nova/+/956236 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (3/6) https://review.opendev.org/c/openstack/nova/+/956237 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (4/6) https://review.opendev.org/c/openstack/nova/+/956238 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (5/6) https://review.opendev.org/c/openstack/nova/+/956239 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (6/6) https://review.opendev.org/c/openstack/nova/+/956240 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server shares APIs https://review.opendev.org/c/openstack/nova/+/956266 | 17:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Invert validation check https://review.opendev.org/c/openstack/nova/+/956241 | 17:15 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!