| opendevreview | Merged openstack/nova master: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957757 | 01:00 |
|---|---|---|
| *** mhen_ is now known as mhen | 01:25 | |
| gibi | elodilles: when you are up could you look at https://review.opendev.org/q/topic:%22bug/2112187%22+project:openstack/nova backports. It is important as it is a security hardening bug | 05:38 |
| sean-k-mooney[m] | gibi thanks for updating tempest, is that third test new? i tought ran tempest full - the encyption adn cinder backup tests on friday so im not sure why i didnt see it fail | 07:02 |
| sean-k-mooney[m] | hum no i must not have set the approate tempest config locally and it must have skiped | 07:07 |
| sean-k-mooney[m] | i proably didnt explictly define the multiatch volume type of something along those lines | 07:07 |
| gibi | sean-k-mooney[m]: yeah it is not new | 07:17 |
| opendevreview | Merged openstack/nova stable/2025.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957759 | 09:08 |
| opendevreview | Max proposed openstack/nova master: fix: leftover volume_attachment on instance delete https://review.opendev.org/c/openstack/nova/+/934984 | 09:16 |
| sean-k-mooney | gibi: did you see my comment last week about using RSS instead of adress_sapce for the prlimit for the qemu-img commands by the way? | 12:02 |
| sean-k-mooney | priteau: approved | 12:04 |
| priteau | Thank you sean-k-mooney :) | 12:05 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Switch nova-conductor to use ThreadPoolExecutor https://review.opendev.org/c/openstack/nova/+/957088 | 12:41 |
| gibi | sean-k-mooney: I saw and made a note abuot it | 13:18 |
| gibi | I have to get back to it eventually | 13:18 |
| sean-k-mooney | gibi: i assum you have not pushed a poc patch to bump the limit yet? i could try and push one to swap ti to rss and depend on the DNM ci job revert patch you have | 13:27 |
| gibi | sean-k-mooney: I only pinpointed the address space limit increase we need on master +5MB. And I tried to see how much address space we used before the new ceph but I cannot get that data as i) I cannot roll back the ceph version in ubuntu as the package repo already cleaned ii) the older ubuntu based jobs does not want to run the specific test for me even though I think I set everything. But I had | 13:32 |
| gibi | not time to dig deep into RSS at all | 13:32 |
| gibi | the problem with RSS is similar, we don't know the baseline usage. | 13:33 |
| gibi | so we cannot judge the that the increase is just small and OK, or it is a huge bump from the previous version | 13:34 |
| gibi | if you have time you sure you can play with it to get an RSS number we need on master | 13:34 |
| sean-k-mooney | well i was orginally thinking fo using the same 1G limit to start with but on RSS not adress space | 13:35 |
| sean-k-mooney | and then cosndiering if we need to factor it out to a tuneable config option later | 13:35 |
| sean-k-mooney | the orgianl intent of the limit was to workaroudn some pathological beahivor in old version of qemu-img with untrusted input | 13:36 |
| gibi | I suggest to at least try locally with different volume sizes to see if the RSS is depending on the size of the volume | 13:36 |
| gibi | sean-k-mooney: I affraid we might have a new pathological behavior :) | 13:36 |
| gibi | today the test resizes an 1G volume to a 2G volume | 13:37 |
| sean-k-mooney | well i think sinc ethey are now recfacotring things to use stackless corutiens in the newer version of c++ | 13:37 |
| gibi | so the test is not really realistic. Out there the volumes are lot bigger | 13:37 |
| sean-k-mooney | that the amoutn of adress space has increase but not nessisarly the amount of commit memory | 13:37 |
| gibi | yeah I agree about that ^^ | 13:37 |
| gibi | so RSS is a good direction | 13:37 |
| sean-k-mooney | gibi: in principal this does not matter abot voluems corroct | 13:37 |
| sean-k-mooney | we coudl do some local testign with files of diffent size | 13:37 |
| sean-k-mooney | or do you think the volumes actully play an imporant role | 13:38 |
| sean-k-mooney | oh actully this iss in the rbd code path | 13:38 |
| sean-k-mooney | so we likely do need ceph right? | 13:38 |
| gibi | either the volume, or the fact that it is luksv1 encrypted, or the fact that the test case is resizing plays a role as other test cases does not fail | 13:38 |
| sean-k-mooney | ack so ya we woudl need to test a few diffent ways. | 13:39 |
| gibi | File "/opt/stack/tempest/tempest/api/volume/admin/test_encrypted_volumes_extend.py", line 41, in test_extend_attached_encrypted_volume_luksv1 | 13:39 |
| sean-k-mooney | i wonder fi there is a way to log this info | 13:39 |
| gibi | this is the test case that triggers it | 13:39 |
| sean-k-mooney | we porobaly shoudl park this for now but sinc ehte ceph folks are interested i also dont want to loose too much momentem | 13:39 |
| gibi | we call a bunch of qemu-img info during tempest, but only this test trigger the out of memory for qemu-img info | 13:40 |
| sean-k-mooney | ya so dans comment that the encyption may impact it seams valid | 13:40 |
| gibi | yeah I have a bz open on ceph and they are responsive but we don't have a clear non tempest repro for them | 13:40 |
| sean-k-mooney | i was wondering if we coudl create a smaller non openstack repdocuer too | 13:41 |
| sean-k-mooney | that why i was wondering about a file | 13:41 |
| gibi | I copied the volume out of ceph as a file and run the same command it did not failed | 13:41 |
| sean-k-mooney | but we could likely jsut see if we can manually repoduce this with ceph and qemu directly | 13:41 |
| sean-k-mooney | i just dont happen to have a ceph install to hand currently | 13:41 |
| gibi | so rbd is in the picture | 13:41 |
| sean-k-mooney | ack | 13:42 |
| sean-k-mooney | so im wondering is it as simple as create a raw image wiht luks, upload that to ceph as a voluem | 13:42 |
| sean-k-mooney | extend the volume and messure the adress space and rss | 13:42 |
| sean-k-mooney | fo qemu image as you grow it | 13:42 |
| gibi | yeah that can be tried | 13:43 |
| gibi | realistically for me it is not earlier than next week when I can try | 13:43 |
| sean-k-mooney | ya i was goign to say the same | 13:43 |
| sean-k-mooney | post FF | 13:43 |
| sean-k-mooney | i can do the quick RSS hack and push but digging deeper will take more time then ill have before FF or perhaps RC1 is done | 13:44 |
| gibi | ack | 13:45 |
| dansmith | gibi: I wonder if you could look at this conversation: https://review.opendev.org/c/openstack/nova/+/952630/12/nova/conductor/manager.py#322 | 14:07 |
| dansmith | I really hate this idea that we have to do a mini data migration (from instance to reqspec) every time we do a move operation | 14:07 |
| dansmith | it feels fragile to me, like we could end up missing that step in some cases, and/or get other weird rebuild/evac/whatever behavior later, and after hours of debugging, | 14:08 |
| dansmith | realize that one instance worked because it had been migrated once (and thus got the reqspec change) and another failed because it had never been migrated | 14:08 |
| gibi | dansmith: OK, added to my list along with the other place https://review.opendev.org/c/openstack/nova/+/942502/13/nova/scheduler/request_filter.py#477 melwitt ping me about yesterday | 14:09 |
| dansmith | (in this case I mean s/migrated/moved in some way/) | 14:09 |
| dansmith | gibi: ack, thanks | 14:09 |
| dansmith | gibi: that's a similar theme to the question above.. all about how we define, choose, and expose the default policy we choose for new instances when they don't otherwise request one | 14:14 |
| Uggla | Hello, nova meeting in ~1h. | 15:01 |
| jssfr | Uggla, I might not make it, but I'd like to bring https://review.opendev.org/c/openstack/nova/+/955657 to the table -- I managed to (hopefully) bring the patch into shape as discussed two weeks ago and I'd appreciate any reviews or feedback :) | 15:05 |
| jssfr | I'll read up on IRC discussion if I'm pinged here, too (but probably I'm going to be preparing dinner at the meeting time :-X) :) | 15:06 |
| Uggla | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Aug 19 16:00:25 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| gibi | o/ | 16:00 |
| tkajinam | o/ | 16:00 |
| Uggla | Hello everyone | 16:00 |
| gmaan | o/ | 16:00 |
| Uggla | Awaiting a couple of minute so people can join. | 16:01 |
| Uggla | #topic Bugs (stuck/critical) | 16:02 |
| elodilles | o/ | 16:02 |
| Uggla | #info No Critical bug | 16:02 |
| Uggla | #topic Gate status | 16:02 |
| Uggla | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:02 |
| Uggla | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:02 |
| Uggla | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status | 16:02 |
| Uggla | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:02 |
| Uggla | #info Please try to provide a meaningful comment when you recheck | 16:02 |
| Uggla | I checked quickly the report and don't see anything scary. | 16:03 |
| Uggla | #topic tempest-with-latest-microversion job status | 16:04 |
| gibi | we have a security adjacent bug switched to public yesterday. Fix landed on master and stable backports are progressing. https://bugs.launchpad.net/nova/+bug/2112187 | 16:04 |
| Uggla | gmaan, do you want to say anything about it ? | 16:04 |
| gmaan | sorry, nothing from me. | 16:04 |
| Uggla | thanks gmaan | 16:05 |
| Uggla | gibi, sorry I was a bit fast. | 16:05 |
| gibi | I just wanted to raise attention to that bug and the related fixes | 16:05 |
| gibi | we need to do a tempest dance to skip some tests, land the nova fix, then re-enable tests with fixes applied | 16:06 |
| elodilles | regarding the sec bug fix: do we want to do stable releases once those fixes landed? | 16:06 |
| gibi | elodilles: yes we want | 16:06 |
| elodilles | gibi: ACK, then I'll prepare some release patches | 16:06 |
| gibi | thanks | 16:07 |
| elodilles | np | 16:07 |
| Uggla | thx elodilles | 16:07 |
| gibi | Uggla: back to you | 16:07 |
| Uggla | #topic Release Planning | 16:08 |
| Uggla | #link https://releases.openstack.org/flamingo/schedule.html | 16:08 |
| Uggla | #info Nova deadlines are set in the above schedule | 16:09 |
| Uggla | #info Feature freeze is next week. | 16:09 |
| Uggla | #topic Review priorities | 16:09 |
| Uggla | #link https://etherpad.opendev.org/p/nova-2025.2-status | 16:09 |
| Uggla | #link Amd Sev serie (tkajinam) need review https://review.opendev.org/q/topic:%22bp/amd-sev-es-libvirt-support%22 | 16:10 |
| Uggla | #link 955657: Preserve vTPM state between power off and power on | https://review.opendev.org/c/openstack/nova/+/955657 | 16:10 |
| Uggla | Concerning the later one, jssfr woould like reviews or feedbacks. | 16:11 |
| tkajinam | regarding the first one, I've addressed initial feedback by Uggla and appreciate reviews | 16:12 |
| Uggla | tkajinam, I did not manage to spend a lot of time on it. But I'll try to do it before the end of the week. | 16:13 |
| tkajinam | thx | 16:13 |
| tkajinam | I'm concerned that it might be too tricky to be merged in a few days, but any opinion about possibility to get FFE would be also appreciated. | 16:13 |
| Uggla | There are not a lot of patches so maybe it will be possible. | 16:16 |
| Uggla | Anyway we will see. | 16:16 |
| tkajinam | yup | 16:16 |
| Uggla | moving on to next topic | 16:16 |
| Uggla | #topic OpenAPI | 16:16 |
| Uggla | #link: https://review.opendev.org/q/topic:%22openapi%22+(project:openstack/nova+OR+project:openstack/placement)+-status:merged+-status:abandoned | 16:17 |
| Uggla | #info still 32 remaining atm. | 16:17 |
| Uggla | #topic Stable Branches | 16:17 |
| Uggla | elodilles, I give you the mic. | 16:18 |
| elodilles | thanks | 16:18 |
| elodilles | #info stable branches (stable/2025.1 and stable/2024.*) seem to be in OK state | 16:18 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:18 |
| elodilles | and that's all (plus i'm going to prepare the new stable release patches) | 16:19 |
| elodilles | Uggla: back to you | 16:19 |
| Uggla | thx elodilles | 16:19 |
| elodilles | np | 16:20 |
| Uggla | I'm going to skip next topic due to pto. | 16:22 |
| Uggla | #topic Gibi's news about eventlet removal. | 16:22 |
| gibi | o/ | 16:22 |
| Uggla | #link Blog: https://gibizer.github.io/categories/eventlet/ | 16:22 |
| gibi | Both n-sch and n-api and n-metadata API patches landed so these services can be switched to native threading and nova-next is running them that way already on all patches. My large series is now for the unit test fixes but that can wait. | 16:22 |
| gibi | There is a bunch of small patches that I want to promote to land: | 16:22 |
| gibi | https://review.opendev.org/c/openstack/nova/+/957424 Ask for pre-prod testing for native threading | 16:22 |
| gibi | https://review.opendev.org/c/openstack/nova/+/947260 Remove nova.service.process_launcher | 16:23 |
| gibi | https://review.opendev.org/c/openstack/nova/+/950991 Centralize cooperative yield | 16:23 |
| gibi | https://review.opendev.org/c/openstack/nova/+/950992 [hacking] N374 do not use time.sleep(0) to yield | 16:23 |
| gibi | https://review.opendev.org/c/openstack/nova/+/954990 Remove eventlet timer from multi_cell_list | 16:23 |
| Uggla | \o/ | 16:23 |
| gibi | and tomorrow is pulic holiday here so I will not be able to run the weekly eventlet sync call | 16:23 |
| gibi | so feel free to skip it or do it without me | 16:23 |
| gibi | I know Kamil updated the nova-conductor series after my feedback but I had no time to go back to it yet | 16:24 |
| gibi | that is all from me | 16:24 |
| gibi | back to you Uggla | 16:24 |
| Uggla | Cool thanks Gibi ! | 16:24 |
| Uggla | #topic Open discussion | 16:25 |
| Uggla | #info FYI, I'm a volunteer for the next cycle. 957240: Adding René Ribaud candidacy for Nova 2026.1 PTL | https://review.opendev.org/c/openstack/election/+/957240 | 16:26 |
| gibi | thanks Uggla | 16:26 |
| tkajinam | Thanks for stepping up, Uggla++ :-) | 16:26 |
| Uggla | That's all I have | 16:26 |
| Uggla | Does someone have a topic ? | 16:27 |
| tkajinam | no additional topic from me | 16:28 |
| Uggla | ok moving on. | 16:29 |
| Uggla | #topic Bug scrubbing | 16:29 |
| Uggla | #info down to 172, I manage to answer reporters about some invalid or incomplete ones. | 16:30 |
| Uggla | If you don't mind I will skip the scrubbing today, because we are only few today, and my eyes hurt. | 16:32 |
| sean-k-mooney | o/ sorry was distraced down stream | 16:32 |
| Uggla | Hi sean-k-mooney, any last topic you want to bring ? Otherwise I think I will close for todaY. | 16:33 |
| sean-k-mooney | no didnt really have anything | 16:34 |
| sean-k-mooney | was just reading back | 16:34 |
| sean-k-mooney | the main thing is obviously the bug we are currently backporting but htere is nothing actionabl to do on that | 16:34 |
| Uggla | The security one ? | 16:35 |
| sean-k-mooney | ya we are just making our way through the stable branches | 16:35 |
| sean-k-mooney | thanks elodilles for taking a look by the way | 16:35 |
| elodilles | sean-k-mooney: no problem, thanks for fixing it o:) | 16:35 |
| sean-k-mooney | elodilles: on the watcher side we will probly do release fot his and the other pending patches at the end of the week or next week | 16:36 |
| sean-k-mooney | ill prepare patches for those | 16:36 |
| elodilles | sean-k-mooney: ACK, thanks for the notice, i'll try to take an eye on it | 16:36 |
| elodilles | 1st release patch for nova is up btw: https://review.opendev.org/c/openstack/releases/+/957951 | 16:37 |
| elodilles | Uggla: ^^^ fyi o:) | 16:37 |
| sean-k-mooney | Uggla: so ya thats all i had so we can wrap if there are no other topics | 16:37 |
| elodilles | (i'll update 2024.2 dalmatian release patch when the patch gets merged and prepare 2024.1 caracal one too) | 16:38 |
| Uggla | elodilles cool, I'll look at it tomorrow. | 16:39 |
| elodilles | thanks in advance o/ | 16:39 |
| opendevreview | Merged openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | 16:39 |
| Uggla | So I'm gonna close, thanks all. | 16:40 |
| Uggla | #endmeeting | 16:40 |
| opendevmeet | Meeting ended Tue Aug 19 16:40:08 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:40 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2025/nova.2025-08-19-16.00.html | 16:40 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-08-19-16.00.txt | 16:40 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2025/nova.2025-08-19-16.00.log.html | 16:40 |
| elodilles | thanks Uggla o/ | 16:40 |
| tkajinam | thanks | 16:40 |
| opendevreview | sean mooney proposed openstack/nova stable/2025.1: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/957958 | 16:44 |
| sean-k-mooney | ... that has conflicts let me do that form the cli instead... | 16:44 |
| opendevreview | Merged openstack/nova stable/2024.2: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957762 | 17:01 |
| *** sfinucan is now known as stephenfin | 17:02 | |
| gibi | melwitt: dansmith: responded in https://review.opendev.org/c/openstack/nova/+/942502/13#message-cf59c0d4f875b19c85c544c81fa76210786ca184 | 19:28 |
| gibi | unfortunately I had less time today for this than I wanted and I will be away until next Monday. | 19:28 |
| gibi | anyhow I lean towards using the host level default temporarily if possible. I offered some suggestion how. | 19:35 |
| melwitt | thank you gibi. I will read through | 19:36 |
| dansmith | melwitt: I don't have the brain power to think this through completely right now, so let me muse here in semi-persistent land | 19:41 |
| dansmith | something gibi mentioned makes me think... | 19:41 |
| dansmith | we're kinda depending on the scheduler doing the right thing for much of the enforcement of the policy (maybe more than I'd like even, as I noted, but alas) | 19:42 |
| dansmith | maybe the better thing here is to think about the reqspec as the authoritative thing instead of sysmeta | 19:42 |
| dansmith | like maybe we have a default (configurable or just default to host) or we require a policy on the flavor/image for new instances | 19:43 |
| dansmith | and we just stamp it into the sysmeta on the way down | 19:44 |
| dansmith | and handle the migration of existing instances differently.. either: | 19:44 |
| dansmith | 1. stamp them as user and make them resize if they want "out". That's somewhat fitting in that right now the flavor they booted with doesn't have migrate ability, resize to a flavor that does fixes the problem | 19:44 |
| dansmith | 2. make hard reboot pass down a default *or* have some other way for them to stamp a policy (either choice or agree to the default) | 19:45 |
| dansmith | and then just focus on reqspec being the authoritative thing and sysmeta just becomes basically the write-once-read-many record of what was chosen so we know where to find a secret, but never change it (at the compute level) | 19:46 |
| melwitt | I will need to think through these ... and I note that it feels like most of the spec is being rewritten (and the implementation thusly rewritten). not sure if this can realistically make FF :/ | 19:50 |
| dansmith | yeah, I know, I was thinking about this earlier too and wondering if we were to ignore the existing instances if we could even just like merge host+user, no hard reboot fix and push some of the details to the end | 19:52 |
| dansmith | the above where we just require resize if you want out of the current limitation might also mean we need to merge less to hit our goal | 19:52 |
| dansmith | and we could follow up with the hard reboot approve-in-place as an optimization | 19:53 |
| melwitt | that's an interesting idea | 19:53 |
| gibi | 1. feel very tempting at first read | 20:02 |
| gibi | resize being the opt in is acceptable to me | 20:02 |
| gibi | and for the cloud admin asking for a reboot or a resize is not a big difference, it is an ask anyhow | 20:04 |
| gibi | also level=user becomes the default which I like :) | 20:04 |
| melwitt | I agree resize opt in sounds reasonable for the first phase in any case | 20:05 |
| opendevreview | Merged openstack/nova master: [tests] Add printing of sample and template paths https://review.opendev.org/c/openstack/nova/+/944054 | 20:15 |
| dansmith | resize as the opt-in also lets the admin force them to be moved if they don't want to mix user and host, for example. hard reboot does not give that option | 20:15 |
| sean-k-mooney | does resizeing in this context mean selectign a new flavor with a diffent secreate policy to opt in. | 20:44 |
| sean-k-mooney | im jsut wrapping for the day but i will try to read abck tomorrow if i rememeber | 20:45 |
| sean-k-mooney | oh that the option 1 above | 20:45 |
| sean-k-mooney | to do 1 we woudl ahve to update the isntance copy of the falvor as if the extra spec was set similar to how we often do that to fake the image property being set | 20:47 |
| sean-k-mooney | which is proably ok but i think that a littel trickerer just becasue we store it diffently | 20:47 |
| opendevreview | Merged openstack/python-novaclient master: tests: Stop "testing" against Identity v2 API https://review.opendev.org/c/openstack/python-novaclient/+/952984 | 20:47 |
| sean-k-mooney | tirvially so but it woudl be the first tiem to do that with the embeded falvor that i am aware of | 20:48 |
| melwitt | yeah.. I need a moment to regain my bearings 😝 I have spent so much time working on this and implementing the spec. I need some time to re-adjust my mind to this new thing | 20:51 |
| sean-k-mooney | ya i dont have ennoguh sapre brain power to load context and think about this with any depth tonight to say anythign more then "Maybe?" | 20:55 |
| melwitt | heh | 20:56 |
| sean-k-mooney | i vaguly got that dan want to avoid updating the request spec on all move operations which i agree should not be required but i dont knwo why the serisse currenlty is so i cant really comment | 20:56 |
| melwitt | it's because the original design involves setting a default inside sysmeta down in the libvirt driver. so that has to make it to the request spec somehow in order to be honored during scheduling | 20:57 |
| sean-k-mooney | as in fakign that it was selected in the image medata data | 20:58 |
| melwitt | this issue goes away if we require image/flavor for the policy, which is why that's being talked about above | 20:58 |
| sean-k-mooney | so your saying we need to sync the image metadata form teh cell db to the request spec | 20:58 |
| sean-k-mooney | so that move ops fine the right host | 20:58 |
| melwitt | yes pretty much. the entire design in the spec is to put a image_hw_tpm_secret_security into the instance sysmeta regardless of whether it came from an image or not | 20:58 |
| sean-k-mooney | ghat that sound valid and unfortunet because the comptue shoudl nbot need to touch the api db | 20:59 |
| sean-k-mooney | but how do we handel this today? | 20:59 |
| sean-k-mooney | we set a buch fo thing liek that already | 20:59 |
| melwitt | you mean like for AZs? that got brought up in the gerrit review | 21:00 |
| sean-k-mooney | like we set the request for a config drive or the machine tyep when the isntace lands on a comptue node | 21:00 |
| sean-k-mooney | and recored them in instance_system_metadta during spawn | 21:00 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7190-L7200 | 21:02 |
| sean-k-mooney | we do it in other palcees too that just the first palce i found | 21:03 |
| melwitt | yeah that's very similar thing. but I don't find that ever makes it to the request spec | 21:03 |
| sean-k-mooney | there are a bunch of debug lgos when we boot a vm where we recored specific values to make sure they dont change over the lifetime of the vm | 21:04 |
| melwitt | not sure if any of those cases are things that are required for scheduling | 21:04 |
| sean-k-mooney | ya nor am i | 21:06 |
| sean-k-mooney | oh i set config_drive on the instance object not the image meta github.com/openstack/nova/blob/master/nova/compute/manager.py#L2255-L2268 https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2255-L2268 | 21:10 |
| sean-k-mooney | and we do not schduler on that either | 21:10 |
| sean-k-mooney | melwitt: https://paste.opendev.org/show/bGufCv4fBSCZwAP3m6qT/ thos are the log message i ment | 21:19 |
| sean-k-mooney | which is https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2255-L2268 | 21:20 |
| sean-k-mooney | sorry wrong link | 21:20 |
| sean-k-mooney | https://github.com/openstack/nova/blob/d5cfdfd16d7573a83b05dd6c0656b7610e77c4c4/nova/virt/libvirt/driver.py#L993-L1043 | 21:21 |
| sean-k-mooney | we can scheduler on 'hw_video_model', 'hw_vif_model' | 21:21 |
| sean-k-mooney | via a placement prefileter | 21:22 |
| sean-k-mooney | but perhaps that only works fi you ahve it set on the iamge properly | 21:22 |
| melwitt | hm yeah maybe | 21:22 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2255-L2268 | 21:23 |
| sean-k-mooney | wehn i wrote that i was not thinkign fo this other way of populating it | 21:23 |
| sean-k-mooney | ... | 21:23 |
| sean-k-mooney | way is that link stuck in my copy past buffer | 21:23 |
| sean-k-mooney | https://github.com/openstack/nova/blob/d5cfdfd16d7573a83b05dd6c0656b7610e77c4c4/nova/scheduler/request_filter.py#L199 | 21:23 |
| melwitt | it really wants you to talk about that link I guess | 21:24 |
| sean-k-mooney | oh its becasue the url was not updating in my firefox | 21:24 |
| sean-k-mooney | you know the way if you edit the url but then navigate it does not updstea properly i think that is what happend | 21:24 |
| melwitt | yeah that request filter is assuming the image properties are already in the request spec | 21:25 |
| sean-k-mooney | so lee added this registration logic so that we could freely change the defautls without affectin new instnaces | 21:25 |
| sean-k-mooney | but it was never inteded for scheduleing really | 21:26 |
| sean-k-mooney | but i guess that was an oversight in the orignal feature | 21:26 |
| sean-k-mooney | we never provide a way to sync the request spec with those if it was ever needed | 21:26 |
| sean-k-mooney | melwitt: this is were your nova audit proroal woudl have been useful | 21:27 |
| sean-k-mooney | i.e. to do a perodic sync of this info form the cell db to the api db | 21:27 |
| melwitt | nova-janitor | 21:29 |
| opendevreview | Merged openstack/python-novaclient master: Replace keystoneclient with openstacksdk https://review.opendev.org/c/openstack/python-novaclient/+/952986 | 21:31 |
| opendevreview | Merged openstack/nova stable/2024.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957764 | 21:37 |
| opendevreview | Merged openstack/nova stable/2025.1: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/945096 | 23:54 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!