| *** mhen_ is now known as mhen | 02:03 | |
| opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | 07:55 |
|---|---|---|
| opendevreview | Sylvain Bauza proposed openstack/nova master: Change uptime in hypervisor to be provided async using stats https://review.opendev.org/c/openstack/nova/+/959571 | 07:59 |
| opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | 08:47 |
| gibi | bauzas: you are quick. I suprised that we already has impl proposed to the hypervisor uptime bug. I left some comments in the patch https://review.opendev.org/c/openstack/nova/+/959571 | 10:02 |
| opendevreview | Johannes Kulik proposed openstack/nova master: api: Pre-query not deleted members in server groups https://review.opendev.org/c/openstack/nova/+/959696 | 11:12 |
| sean-k-mooney | gibi: so do i | 11:12 |
| sean-k-mooney | gibi: https://review.opendev.org/c/openstack/nova/+/959604 | 11:12 |
| sean-k-mooney | ah you found my version too | 11:13 |
| gibi | ohh wait. I only found your version somehow not bauzas' | 11:16 |
| gibi | so I will look at bauzas' too | 11:16 |
| sean-k-mooney | i added you to mine :) | 11:16 |
| sean-k-mooney | its similar without the test update and no fall back | 11:16 |
| gibi | now I added my feedback to both :) | 11:23 |
| sean-k-mooney | gibi: thanks just read them and i geneally agree with them | 11:29 |
| sean-k-mooney | ill make those changes shortly and ill also update teh api ref to not that this is a driver depenent api respocne and that its cached, in addtion ot the mention in the release note. | 11:30 |
| gibi | cool thanks. Please sean-k-mooney bauzas agree on which patch is the "official" one :) | 11:30 |
| sean-k-mooney | gibi: what did you think of the release note and commit message in general. those were the only thing i got ai to do | 11:30 |
| gibi | I had no problem with those indeed | 11:31 |
| jkulik | as said yesterday, I'd like to get our server-group listing performance improvement patches upstream if possible. I opened https://bugs.launchpad.net/nova/+bug/2122109 for that and already pushed the first one: https://review.opendev.org/c/openstack/nova/+/959696 - feedback appreciated | 11:36 |
| gibi | bauzas: if you have a chance then you can take a look at https://review.opendev.org/q/topic:%22bug/2115905%22 . I respun it to fix sean-k-mooney's comments and sean-k-mooney is +2 on it | 11:37 |
| bauzas | I have another thing to do now | 12:17 |
| bauzas | honestly I don't care, I created my patch first, but if you prefer Sean's one, meh | 12:17 |
| bauzas | I just want it for RC1 | 12:18 |
| gibi | bauzas: I did not expressed preference :) | 12:18 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2025.2: Update .gitreview for stable/2025.2 https://review.opendev.org/c/openstack/os-vif/+/959741 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2025.2: Update TOX_CONSTRAINTS_FILE for stable/2025.2 https://review.opendev.org/c/openstack/os-vif/+/959742 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/os-vif/+/959743 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2025.2: Update .gitreview for stable/2025.2 https://review.opendev.org/c/openstack/osc-placement/+/959744 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2025.2: Update TOX_CONSTRAINTS_FILE for stable/2025.2 https://review.opendev.org/c/openstack/osc-placement/+/959745 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/osc-placement/+/959746 | 12:20 |
| gibi | my only preference is not having two competing patches at the end | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2025.2: Update .gitreview for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959747 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2025.2: Update TOX_CONSTRAINTS_FILE for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959748 | 12:20 |
| opendevreview | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959749 | 12:20 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | 13:05 |
| opendevreview | Merged openstack/nova stable/2025.1: Reproduce that only half of the PCI devs are removed https://review.opendev.org/c/openstack/nova/+/959308 | 13:06 |
| opendevreview | Merged openstack/os-vif stable/2025.2: Update .gitreview for stable/2025.2 https://review.opendev.org/c/openstack/os-vif/+/959741 | 13:10 |
| opendevreview | Merged openstack/python-novaclient stable/2025.2: Update .gitreview for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959747 | 13:14 |
| opendevreview | Merged openstack/python-novaclient stable/2025.2: Update TOX_CONSTRAINTS_FILE for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959748 | 13:14 |
| *** ralonsoh__ is now known as ralonsoh | 13:36 | |
| opendevreview | Merged openstack/os-vif master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/os-vif/+/959743 | 13:55 |
| tkajinam | o/ there is a bug with SEV encrypted instances recently reported. I've proposed a fix for it which was validated by a reporter. Can we merge it before rc (this may not conflict with the feature freeze policy). I'm ok to merge it after rc and then backport it later, though | 14:02 |
| tkajinam | https://review.opendev.org/c/openstack/nova/+/958868 | 14:02 |
| opendevreview | Merged openstack/os-vif stable/2025.2: Update TOX_CONSTRAINTS_FILE for stable/2025.2 https://review.opendev.org/c/openstack/os-vif/+/959742 | 14:04 |
| opendevreview | Takashi Kajinami proposed openstack/os-vif stable/2025.2: Remove remaining job with Ubuntu Jammy (22.04) https://review.opendev.org/c/openstack/os-vif/+/959855 | 14:06 |
| gibi | tkajinam: thanks! it is approved now | 14:15 |
| tkajinam | gibi, thx ! | 14:15 |
| opendevreview | Merged openstack/nova stable/2025.1: Fix pci_tracker.save to delete all removed devs https://review.opendev.org/c/openstack/nova/+/959309 | 14:40 |
| opendevreview | Merged openstack/nova master: Reproduce bug/2115905 https://review.opendev.org/c/openstack/nova/+/954336 | 14:40 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Change uptime in hypervisor to be provided async using stats https://review.opendev.org/c/openstack/nova/+/959571 | 14:47 |
| bauzas | sean-k-mooney: gibi: I offer to use my patch as the fix (as mine was a bit older than sean's one and given I have capacity for that), but I added Sean as co-author to reflect his effort too | 14:49 |
| bauzas | sean-k-mooney: if you prefer having yours as main, fine, tell me and I'll abandon mine | 14:49 |
| bauzas | as I said, my main concern is to make sure we have that by RC1 | 14:49 |
| sean-k-mooney | well i do | 14:50 |
| sean-k-mooney | becuase i said i would work on it before you wrote your patch | 14:50 |
| sean-k-mooney | so i was annoy wen you pushed it while i was fixing uniti tests and docs ectra | 14:50 |
| dansmith | sean-k-mooney: to me it sounded like you'd work on it if you had time, and weren't particularly concerned about getting it any time soon | 14:51 |
| dansmith | so I was glad bauzas just went ahead with it | 14:51 |
| sean-k-mooney | i only did push it early because of the sprint/jira disucssion downstream | 14:52 |
| sean-k-mooney | like i had it open the entire tiem and was workign on it on an doff since i said i would on irc | 14:52 |
| sean-k-mooney | i kept stopping to explian how to fix it to bauzas | 14:52 |
| dansmith | sean-k-mooney: that seems like a rather uncharitable characterization of the conversation as I remember it | 14:53 |
| bauzas | okay, I don't want to create a situation, lemme abandon my change | 14:54 |
| bauzas | this is Friday afternoon for me and I'm done arguing for the week :) | 14:54 |
| sean-k-mooney | if your change is done and has all the test and what gibi asked for i litrally only have one test left ot finsh | 14:54 |
| sean-k-mooney | so i can drop it but i was almost done before my team call earier today | 14:55 |
| bauzas | I don't f... care :) | 14:55 |
| bauzas | if you have time to work on it, do it | 14:55 |
| * dansmith is pretty annoyed | 14:55 | |
| bauzas | anyway, patch abandoned, floor is yours but please make sure that's on a good shape for rc1 | 14:56 |
| bauzas | I can't just argue, again I'm done | 14:56 |
| dansmith | I don't want to go dig up actual quotes, but it surely seemed to me we left the conversation with sean-k-mooney indicating not a lot of time to work on it and bauzas saying he did | 14:56 |
| dansmith | so I reviewed bauzas' immediately and then sean-k-mooney pushed a competing one up after even that first round of reviews | 14:56 |
| bauzas | fwiw, we have a tracker somewhere downstream that also needs to reflect the who does what | 14:56 |
| dansmith | so now I've got to go review the other one? | 14:57 |
| bauzas | so please update it as well | 14:57 |
| bauzas | dansmith: the two are basically identical, except an object modification (which hopefully is just an helper) | 14:57 |
| bauzas | tests diverge a little bit | 14:58 |
| dansmith | so even less necessary to have pushed up a competing patch after the first one was the same solution? | 14:58 |
| bauzas | that's 5pm here on a Friday anyway and I started at 8am, I call it a wrap | 14:58 |
| sean-k-mooney | so i honestly done know what to say | 15:01 |
| sean-k-mooney | bauzas: almost made me rage quite since it feld liek tehy were inteally not reading anythin i wrote on irc | 15:01 |
| bauzas | well, my patch is abandoned, the problem is over | 15:01 |
| sean-k-mooney | so i stop what i was workign on and said i woudl owrk on it | 15:02 |
| sean-k-mooney | i spemnd my evning na dmoning workign on it between interups and while i was waiting for tox runs you pushed a pathc | 15:02 |
| bauzas | that's my point, I had capacity, you didn't had, which is why I offered to push it | 15:03 |
| sean-k-mooney | that patch didnt have hte fallback or tests which i had in my locally so i contineus working on it | 15:03 |
| bauzas | now you say that you have capacity, which is cool, then I abandon mine | 15:03 |
| bauzas | if that sounds a matter of IP, then surely I don't give a single cent about it | 15:04 |
| sean-k-mooney | no i made time to work on it because it felt like you were ignoring me | 15:04 |
| sean-k-mooney | you almost made me rage quite irc yesterday | 15:04 |
| bauzas | the good news is that irc logs are public | 15:05 |
| bauzas | I don't think I had the intent to make you rage, I just expressed one thing about capacity and again I offered a solution | 15:05 |
| bauzas | now, again, fact is that my patch is ABANDONED, so we anyway need to review your patch | 15:06 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix num_instances_weight_multiplier option example https://review.opendev.org/c/openstack/nova/+/959866 | 15:06 |
| sean-k-mooney | bauzas: im currently reviewing your | 15:06 |
| bauzas | please then update yours based on gibi's feedback and then I'll review it | 15:06 |
| sean-k-mooney | to see what the delta is | 15:06 |
| sean-k-mooney | i have, im litrally just workign ont hte unit test to show the case where the rpc is called and hwen it not based on if the stats have uptime | 15:07 |
| sean-k-mooney | that was the only bit of feedback i didnt have completed 2 hours ago | 15:08 |
| bauzas | sean-k-mooney: I really have to drop soon, again, fact is, I had time today to work on a PS3, no other bits than that | 15:12 |
| sean-k-mooney | bauzas: enjoy your weekend sylvain | 15:13 |
| bauzas | I don't have a particular opinion of my contributions fwiw, so again, feel free to update your patch so I can review it | 15:13 |
| sean-k-mooney | and yes ill finish updating it but i feel like we need to reset | 15:14 |
| sean-k-mooney | we really need ot just chil and hang out some time | 15:15 |
| dansmith | I must say, I feel like something pretty uncool has happened here | 15:15 |
| sean-k-mooney | we both obviously were not comunicating well and both feel like we have wated each other time. syvalisn patch does nto have hte optimisation to prevent the slow down for dirver that dont supprot uptime, that the only delta between the two in general at this point | 15:19 |
| dansmith | sean-k-mooney: I had already commented on that on his patch before you even posted yours, so that's not a reason | 15:19 |
| dansmith | sean-k-mooney: also, he marked you as co-author so if you had tweaks you could have pushed them directly there after it was up, or written tests for his patch instead of writing your own and then tests for that | 15:20 |
| dansmith | so it really feels a lot like a snipe to me, sorry to say | 15:20 |
| dansmith | his PoC had also been posted in the middle of the ending part of the conversation, logged here so it's not like it was a surprise that it was posted or anything | 15:21 |
| dansmith | I even asked you if you had a patch or just a solution "in your head" and you confirmed the latter so.. I think it was pretty fair game at that point, especially with the mention of not having time to work on it (or a sense that it was a priority) | 15:22 |
| sean-k-mooney | it very much was to me because i didn even know he has started on it | 15:22 |
| dansmith | sorry, but that feels dishonest to me.. he posted it and pinged you by name | 15:23 |
| dansmith | and you even responded and said yours was different and "partly done" .. to me that sounds like it _wasn't_ different (at least in the grand sense) and also not like ready to submit | 15:24 |
| dansmith | anyway, my skin in the game is minimal since I had just reviewed one that is not abandoned, but from the somewhat independent observer, this feels highly unfair and unconstructive to me | 15:24 |
| sean-k-mooney | partly done was i was fixign the unit test which sylvain skipped | 15:25 |
| sean-k-mooney | if we want to resotre and merge sylvains we can | 15:26 |
| sean-k-mooney | what im annoyed byt most is listrlly soemthin that i had debugs a few weeks ago, planed how to fix and had plan to do after RC1 was made suddenly really urgent | 15:27 |
| sean-k-mooney | and instead of actully takign the tiem to listen to the backward compatibale solution that we can backport it was repwadly suggested we break our api contract or add config drive api behevaior | 15:28 |
| dansmith | that is not a reasonable characterization of the conversation we had *at all* | 15:30 |
| sean-k-mooney | did you actully look at where the converstaion started 3-4 hours before you came on line | 15:34 |
| dansmith | yes | 15:34 |
| opendevreview | Elod Illes proposed openstack/osc-placement master: [CI] Drop unsupported py39 based functional job https://review.opendev.org/c/openstack/osc-placement/+/959873 | 15:35 |
| opendevreview | Merged openstack/nova master: [PCI tracker]Remove non configured devs when freed https://review.opendev.org/c/openstack/nova/+/954613 | 15:36 |
| opendevreview | Elod Illes proposed openstack/osc-placement stable/2025.2: [CI] Drop unsupported py39 based functional job https://review.opendev.org/c/openstack/osc-placement/+/959874 | 15:36 |
| opendevreview | Merged openstack/nova master: [pci]Keep used dev in Placement regardless of dev_spec https://review.opendev.org/c/openstack/nova/+/954149 | 15:36 |
| sean-k-mooney | i lirtally startded workin on it when i said "bauzas: look im just going to go fix this becuase im -2 on just riping it ou8t" jkulik provided me to the link to the bug gibi filed earlier and i checcked out the branch adn started workign on it | 15:38 |
| sean-k-mooney | every time i replied on irc or slack after that yesterdy until i push my patch i was swappign form it to reply | 15:40 |
| bauzas | I just saw it from the logs, I have to say | 15:53 |
| bauzas | after that I said that I'd like to have a consensus about the solution, and then I moved it quickly | 15:54 |
| bauzas | so I understand your concern, but please understand as well that my main point is that I want that fix to be part of RC1 and backportable, now that we have a consensus | 15:54 |
| sean-k-mooney | i think that were we diverged | 15:55 |
| sean-k-mooney | the was part is my unit test is stil failing... | 15:55 |
| bauzas | sean-k-mooney: if you look at the API test, I had to modify some knob given we're directly passing back the object | 15:55 |
| bauzas | you need to delete the stats field before returning the whole dict | 15:56 |
| sean-k-mooney | right os i was tryitng to avoid doing exacty what you did | 15:56 |
| bauzas | (that's the only piece where I used Cursor, in order to understand the root cause but I wrote the code myself) | 15:56 |
| sean-k-mooney | you added https://review.opendev.org/c/openstack/nova/+/959571/3/nova/tests/unit/api/openstack/compute/test_hypervisors.py#80 | 15:57 |
| sean-k-mooney | which woudl work and i coudl od it too | 15:57 |
| bauzas | on the second compute | 15:57 |
| sean-k-mooney | i have been tryign to not change that but fake_compute_node_statistics | 15:57 |
| bauzas | not on the first one | 15:57 |
| bauzas | we have two fake computes, I updated the second one and then I skim the stats field before passing the object back | 15:58 |
| bauzas | anyway, 6pm here on a Friday, /me stops | 15:58 |
| sean-k-mooney | ya so i way trying to avoid that because i dint want to change teh v21 data | 15:58 |
| sean-k-mooney | but i think ill just do what you did instead | 15:58 |
| sean-k-mooney | we are using self.stub_out('nova.db.main.api.compute_node_statistics', | 15:59 |
| sean-k-mooney | fake_compute_node_statistics) | 15:59 |
| sean-k-mooney | and i was try8ign to figure out how to refacto rthat so i coudl update the mock only in one specific test | 15:59 |
| sean-k-mooney | im making it a lot harder for myself by doing that | 16:00 |
| sean-k-mooney | effectily i was tryign to avoid touchign the test setup for the older micoversion but you approch is not matirally changing what they are testegin so ill adopt that instead | 16:01 |
| sean-k-mooney | oh i see your testing show not list. ill do both. and include your test in my version | 16:08 |
| * dansmith fumes | 16:22 | |
| opendevreview | Merged openstack/nova master: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/958868 | 16:32 |
| opendevreview | Merged openstack/nova stable/2024.2: Reproduce that only half of the PCI devs are removed https://review.opendev.org/c/openstack/nova/+/959310 | 16:32 |
| opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | 16:33 |
| opendevreview | Merged openstack/nova stable/2024.2: Fix pci_tracker.save to delete all removed devs https://review.opendev.org/c/openstack/nova/+/959311 | 17:36 |
| opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | 17:50 |
| sean-k-mooney | dan ^ implement the defaulting in the resouce tracker you wnated. i can update it more if needed | 17:52 |
| sean-k-mooney | well technially not in the resouce trracker | 17:53 |
| sean-k-mooney | but in the stats module https://review.opendev.org/c/openstack/nova/+/959604/3/nova/compute/stats.py | 17:54 |
| sean-k-mooney | which will make it work for all driver and now the api can jsut use that as a sentenil | 17:54 |
| sean-k-mooney | actully that not quite right fixing | 17:57 |
| opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | 17:59 |
| opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | 18:04 |
| atmark | Hello, I have volume that got stuck that I dad to run `openstack volume set --state available --detached` but the instance still think it's attached ( volume ID shows up in volumes_attached). How do I get the instance to detach volume? | 19:18 |
| atmark | s/dad/had | 19:18 |
| opendevreview | Merged openstack/nova stable/2024.1: Reproduce that only half of the PCI devs are removed https://review.opendev.org/c/openstack/nova/+/959313 | 20:50 |
| opendevreview | Merged openstack/nova stable/2024.1: Fix pci_tracker.save to delete all removed devs https://review.opendev.org/c/openstack/nova/+/959314 | 21:55 |
| opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.2: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959913 | 22:07 |
| opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959914 | 22:08 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!