| *** mhen_ is now known as mhen | 01:37 | |
| *** mhen_ is now known as mhen | 07:41 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | 08:20 |
|---|---|---|
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | 08:46 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | 09:43 |
| opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | 10:00 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Switch nova-conductor to use global executor https://review.opendev.org/c/openstack/nova/+/962478 | 10:11 |
| opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | 11:12 |
| *** tridde is now known as Trident | 11:26 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | 11:28 |
| gibi | dansmith: fyi we can catch threading slowdowns now with rally https://review.opendev.org/c/openstack/nova/+/960130/30#message-1f12ccedc335aa0e59d469a478012a41d76fd67c | 12:14 |
| gibi | (this was a simulated slowdown by injecting sleep to nova) | 12:14 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Switch nova-conductor to use global executor https://review.opendev.org/c/openstack/nova/+/962478 | 12:40 |
| opendevreview | Merged openstack/nova stable/2025.1: Regression test for ImagePropsWeigher due to missing context https://review.opendev.org/c/openstack/nova/+/961805 | 13:09 |
| dansmith | gibi: nice.. hopefully that will be stable enough to be useful.. even within a single worker performance has varied a lot in the past (due to noisy neighbors) but even if we get a smoke signal that will be good | 13:58 |
| gibi | if the performance of the worker fluctuates in a ~10 mintues window then yeah we will get false postive signals | 14:04 |
| gibi | the window size depends one length of our rally scenarios | 14:05 |
| sean-k-mooney-pto | while we could have noise neighber effects i think its a lease worth trying this for a while and see if it becomes a problem | 14:17 |
| sean-k-mooney-pto | gibi: presumable the rally job wont be voting at least not in the short term | 14:18 |
| gibi | won't be voting for a while | 14:18 |
| sean-k-mooney-pto | so if it a perodic or its non voting | 14:18 |
| sean-k-mooney-pto | i think this ok for now | 14:18 |
| sean-k-mooney-pto | gibi: do you think it need to run in check longterm or would you jsut rung this in weekly perodic? | 14:19 |
| gibi | right now it is a cheap job so I would run it non-voting. But if we add more scenarios (I planning to ) then it might be expensive enough to run it only periodically | 14:23 |
| gibi | or if we move it to a label with many subnodes | 14:23 |
| sean-k-mooney-pto | ack | 14:24 |
| sean-k-mooney-pto | this is the kind fo job where it would be nice if there as a persitent mysql db where we coudl log some data across runs | 14:24 |
| sean-k-mooney-pto | i.e. to track over all trends across time | 14:25 |
| sean-k-mooney-pto | but ya i was thining the same start we non voting and hten move to perodic + experimental if its becomes expensive | 14:26 |
| sean-k-mooney-pto | havign it in experminetal so you can spot check specific changes is ueful if we go the perodic route | 14:27 |
| *** sean-k-mooney-pto is now known as sean-k-mooney | 14:28 | |
| sean-k-mooney | gibi: the last day before i went on pto i spend a little time tryign to see if we could get any better infro form atop or the logs on overall load. i made some progress but the binary format and way that tool works is a littel painful | 14:29 |
| gibi | sean-k-mooney: I actually noticed that when a service is stopped systemd already nicely logs the memory swap high watermark and the cpu time of the service | 14:40 |
| gibi | so I went with that | 14:40 |
| sean-k-mooney | yes i saw that also | 14:40 |
| sean-k-mooney | however we only have the logs form the second run correct | 14:40 |
| sean-k-mooney | unless thats also in the journal dump? | 14:41 |
| gibi | we have journal logs from both runs, and I do an extra service restart now at the end to get the resource usage after the second run as well. Then I pull the data out from the journal into eg https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_eb1/openstack/eb1c16166a9e42b5be0987f5d8ca0d01/results/resource-usage-devstack%40n-sch.service.txt | 14:41 |
| sean-k-mooney | ah cool | 14:43 |
| jssfr | dansmith (and maybe others following https://review.opendev.org/c/openstack/nova/+/955657 ): I'm going to be AFK starting october 1st until november 25th. Is there anything else I need to do before that to get it over the line? | 14:46 |
| dansmith | jssfr: sorry, just been really busy with other stuff.. I think it mostly looks good to me now but I was just going to do some tests locally that I haven't had a chance to do yet | 14:47 |
| dansmith | but others may feel more comfortable just looking at it | 14:47 |
| jssfr | related question: is it possible to take over another person's gerrit patch? | 14:48 |
| jssfr | I might find a substitute who can continue to look into it while I'm away. | 14:48 |
| dansmith | yep, easy and common | 14:48 |
| jssfr | is there anything that needs to be taken into account when doing that? or can another gerrit user just take my patch and run `git review`? | 14:50 |
| opendevreview | Merged openstack/nova stable/2025.1: Add admin context when filling metadata on ImagePropsWeigher https://review.opendev.org/c/openstack/nova/+/961806 | 14:50 |
| dansmith | no, anyone can git review it right now | 14:50 |
| jssfr | thanks | 14:50 |
| clarkb | `git review -d changenumber` make edits then `git review` to push back | 14:51 |
| bauzas | dansmith: given we have yet another issue with the ImageMetaWeigher https://bugs.launchpad.net/nova/+bug/2125935 I wonder why I can't just target a cell context for fill_metadata this way : | 16:48 |
| bauzas | with nova_context.target_cell(ctxt, cell_mapping): | 16:49 |
| bauzas | insts.fill_metadata() | 16:49 |
| bauzas | I guess I need to change the object context itself, right? | 16:49 |
| dansmith | well, that's targeting a context but you're not using it | 16:49 |
| dansmith | all the instances are from the same cell right? If so, you need to target the context, then pass that to InstanceList.__init__() and then fill metadata | 16:49 |
| dansmith | the usage is "with target_cell(...) as child_ctx: " | 16:50 |
| bauzas | yeah, given we look at all the instances from the same host, they are on the same context | 16:52 |
| bauzas | s/context/cell | 16:52 |
| bauzas | gotcha, I got that | 16:52 |
| bauzas | thanks | 16:53 |
| dansmith | cool, yeah then just need to target the one you give to the InstanceList | 16:53 |
| bauzas | with nova_context.target_cell(ctxt, cell_mapping) as cell_ctxt: | 17:00 |
| bauzas | insts = objects.InstanceList(cell_ctxt, | 17:00 |
| bauzas | objects=host_state.instances.values()) | 17:00 |
| bauzas | insts.fill_metadata() | 17:00 |
| bauzas | that thing doesn't give me the metadata yet | 17:00 |
| * bauzas continues | 17:01 | |
| dansmith | do the fake instances have sysmeta set on the object to an empty dict? | 17:14 |
| bauzas | yup | 17:21 |
| bauzas | I'm lost, I need to get some fresh air, ending my long day | 17:27 |
| dansmith | if they do then the fill will just skip them all, so need to drop those from the object to make it work | 17:35 |
| opendevreview | melanie witt proposed openstack/nova master: FUP for vTPM live migration https://review.opendev.org/c/openstack/nova/+/962309 | 19:47 |
| opendevreview | melanie witt proposed openstack/nova master: Opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | 19:47 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 19:47 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!